#metabrainz

alastairp, so how about we put the feature behind a flag for now, disable it and merge the PR?

lucifer: plz!

and just to be checking, but you saw the dump exception email, yes?

yeah, i do not why that happened. i retrired after seeing that mail and it went sucessfully.

*know why

failed successfully. again. lol.

LB dumps are just cursed.

lol

ruaok, which is the latest branch i should look into for metric-writer?

lucifer: yeah, apart from the timeout it seems that it works, right?

yes, right.

let's add in a feature to do the count, and disable the button/view if the count is over a given config value

👍, sounds good to me.

lucifer: PR1 needs to be merged still -- I think that version is in production currently. work off that branch.

👍

alastairp: when you have some time, https://github.com/metabrainz/brainzutils-pytho...

lucifer: ^ dataset counts. so we can definitely keep it low. 10k maximum, even down to 5k if we want. we can double-check how long a ~4-5k dataset takes to dump

nice, +1

bitmap, yvanzo, reosarevok: I got "Internal Server Error: 500" multiple times when submitting a release, it usually works when pressing the button again, are you aware of this issue (it appeared few days ago, likely with last prod release).

I am not, at least

It doesn't seem number of 500s significantly increased over last month though

monkey: ruaok: with lucifer we just had a chat about how we can keep track of PRs a little bit better, including knowing which ones we want to review/merge next and which ones someone wants someone else to look at with a higher priority

this is coming back to my previous comments about how sometimes I don't know what to work on next, or that I intentionally choose something easier rather than the "big" thing that we should merge next

as a trial, we opened a github project at https://github.com/orgs/metabrainz/projects/1, the idea is that we can add PRs to it and order them based on when we want to merge them next

it's an org-level project, so we can add PRs from multiple repos.

All right, I can see this helping indeed

alastairp: should we add a column for high priority, low priority or consider the top to down order as priority?

IDK if this is the correct channel for this question, but does anyone know why I am unable to import my last.fm scrobbles into listenbrainz? Am I just missing something obvious? This box is grayed out for me as seen in this screen cap: https://s.saint.moe/5voh4. Thanks in advanced!

lucifer: I think that the order in the column should be priority

SaintHime: this is indeed the correct place to ask

monkey: bug due to the props update?

SaintHime: yeah, its greyed out for me as well. probably a bug. Thanks for reporting.

Error: No global props element found on the page

TypeError: Cannot read property 'name' of undefined

Thanks for reporting SaintHime, I'll look at it right away

lucifer glad to know it's not just me. Just made an account and it was driving me insane. I thought I was just dumb and missing something obvious LOL

:D

We should look into imporving the error catching in React pages. this didn't show up in sentry.

lucifer: but this is the chicken and egg problem - no global props == no sentry dsn

ah, right! 🤦

I'm not very technically inclined, so I apologize if this is a dumb question. Can I manually import my last.fm scrobbles with an api call?

or something of the sort

SaintHime: in fact, that's all that the lastfm importer does. it uses the lastfm api to get your scrobbles, converts them to the format required by listenbrainz, and then uses the listenbrainz api to add them

however I don't know if we have any standalone demo code which does this

I see... is there any rate limiting that you know of? I have about 100k scrobbles. Even when the webui gets fixed do you think it will take a while to import?

I get this modal floating and am not able to get past it in local dev. Anyone having an idea of what might be causing it

[listenbrainz-server] 14MonkeyDo opened pull request #1495 (03master…monkey-global-props-lastfm-template): Use base-react.html template in LastFM importer page https://github.com/metabrainz/listenbrainz-serv...

^ alastairp and lucifer

ruaok, bitmap, yvanzo: https://tickets.metabrainz.org/browse/MBS-9356 - I'd like to look at this one again soonish, to get it done

MBS-9356: Remove existing editors with no confirmed email and no OAuth tokens/edits/votes

monkey: oh! makes sense now. approved.

Updated the query to add place_rating_raw, not sure any other change requires modifications there? :)

lucifer: ever seen the above dialog?

shivam-kapila, just made an account today and didnt ever see that dialog

shivam-kapila: no, i haven;t. i am bringing up a dev instance to see if i also get that. you are on the latest master, right?

SaintHime: this is happening in local dev only. prod works fine

lucifer: yep

shivam-kapila, how do I switch to production?

oh you mean that pop up you have

sorry I understand what you mean

yeah SaintHime

shivam-kapila: that either looks like the anti-spam request when editing the wiki, or maybe you're trying to access the MB oauth login page and you don't have your key and secret configured

[listenbrainz-server] 14MonkeyDo merged pull request #1495 (03master…monkey-global-props-lastfm-template): Use base-react.html template in LastFM importer page https://github.com/metabrainz/listenbrainz-serv...

lucifer: what's the story with LB redis? should we upgrade it along with ^ this PR?

let me start up the latest version of redis with the copy of the db file that I had. I think that all we'll need to do is 1) take down web, 2) save redis db, 3) take down redis, 4) start up new version of redis

and ideally we should double-check redis configuration because it's possible that 2 isn't even needed (if we can configure it to always serialise db to disk)

[listenbrainz-server] release 03v-2021-06-03.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

[troi-recommendation-playground] 14amCap1712 merged pull request #35 (03main…actions): Add action for running tests https://github.com/metabrainz/troi-recommendati...

welcome to this monkey!

And back

alastairp, there was a netsplit looking at chatlogs now

LB prod containers updated, working on beta now

SaintHime: You should now be able to import your listens from LastFM ! Thanks for your patience

adhawkins: re lb redis, which PR did you mean?

alastairp: ^

lucifer: upgrading the version of redis in docker-server-configs

45 minutes from bug report to deployment. Well done lucifer and alastairp on those testing, build and deployment improvements !

alastairp: yeah, its not necessary to upgrde at the same time of merging the PR but would reduce confusion in future.

[musicbrainz-server] 14reosarevok opened pull request #2126 (03master…MBS-11693): MBS-11693: Give useful message when rejecting Musixmatch /album links https://github.com/metabrainz/musicbrainz-serve...

also, we'll need to take down timescale-writer methinks because it is also writing stats to redis now.

monkey: what???????????????????????????????????????? thats crazy!! thank you!!!! cant believe it took that short.

[listenbrainz-server] 14shivam-kapila opened pull request #1496 (03master…remove-browser-less-compilation): Remove in broswer less compilation https://github.com/metabrainz/listenbrainz-serv...

Well thankfully it was an easy one to fix, and we broke it just yesterday so it's all still fresh in memory.

lucifer: right - although theoretically taking down redis will cause the service to go away in consul so everything should shut down and wait until it comes back

You have no clue how long I spent on trying to get it work

I didnt see any bug reports online so I assumed it was on my end

lmfao

alastairp: right, consul will bring it down and then keep retrying to bring up the service. the only upside to manually taking down is less spam from sentry i guess :p

yes right

lucifer: "1:M 03 Jun 2021 10:23:35.396 * Loading RDB produced by version 5.0.3"

yeah, new redis just happily loads an old version

nice! :D

yep, and then it re-saves it as the new version and when you next load it, it's fine

let me finish that PR, then

ruaok: i have upated https://github.com/metabrainz/metric-writer/pul... , if the changes look fine i'll deploy.

lucifer: https://github.com/metabrainz/docker-server-con... ready

approved

ok, do you want to release?

lucifer: approved.

alastairp: yes sure.