#metabrainz

/

      • jasondk
        Yep
      • 2021-06-14 16527, 2021

      • ruaok heads home before the meeting
      • 2021-06-14 16512, 2021

      • jasondk
        Okay thats all I have :) i'm gonna submit a PR for adding the user_id to delete function today
      • 2021-06-14 16520, 2021

      • jasondk
        thanks ruaok, lucifer !
      • 2021-06-14 16526, 2021

      • lucifer
        ruaok: changes pushed. should i deploy?
      • 2021-06-14 16545, 2021

      • lucifer
        ruaok: lol, i don't know what to say. https://sentry.metabrainz.org/metabrainz/listenbr… this error which has been consistently happening for 2 years seems to have got fixed 2hrs ago when new pika got deployed.
      • 2021-06-14 16558, 2021

      • lucifer
        a bitter sweet upgrade!!
      • 2021-06-14 16533, 2021

      • ruaok
        I'll do it in a bit, the code is still rough.
      • 2021-06-14 16555, 2021

      • ruaok
        well, that sounds pretty good overall!
      • 2021-06-14 16547, 2021

      • Freso
        <BANG>
      • 2021-06-14 16547, 2021

      • Freso
        It’s World Blood Donor Monday!
      • 2021-06-14 16547, 2021

      • Freso
      • 2021-06-14 16547, 2021

      • Freso
        yyoung has sent in a review, so here’s what yyoung has to report for this week:
      • 2021-06-14 16547, 2021

      • Freso
        """
      • 2021-06-14 16547, 2021

      • Freso
        - Last week I enhanced my PR #2128, made some changes according to the reviews, and fixed the tests
      • 2021-06-14 16547, 2021

      • Freso
        - (Hoping to get more suggestions on it so we can make progress)
      • 2021-06-14 16548, 2021

      • Freso
        - Also dug a little bit into the usage of dialogs, and did some edits on MusicBrainz (external links and cover arts)
      • 2021-06-14 16548, 2021

      • Freso
        - That's all, thank you.
      • 2021-06-14 16549, 2021

      • Freso
        """
      • 2021-06-14 16549, 2021

      • Freso
        And next up… reosarevok, go!
      • 2021-06-14 16552, 2021

      • Freso
        Or… bitmap, go!
      • 2021-06-14 16559, 2021

      • bitmap
        hi
      • 2021-06-14 16522, 2021

      • bitmap
        last week I worked on improving https://github.com/metabrainz/musicbrainz-server/… and fixed some bugs, test failures etc., then split some of the commits for easier review
      • 2021-06-14 16544, 2021

      • bitmap
        I implemeted the noscript fallback so that releases with a ton of tracks still work paged without JS
      • 2021-06-14 16549, 2021

      • reosarevok
        Oh. Duh. Sorry. I am around, can go next
      • 2021-06-14 16523, 2021

      • bitmap
        relatedly added some sitemap tests for /release/mbid/disc/n pages which we were sorely lacking, since the logic there is a bit complicated
      • 2021-06-14 16558, 2021

      • bitmap
        also submitted several smaller PRs, mostly to fix tiny bugs and one to significantly improve direct search performance
      • 2021-06-14 16532, 2021

      • bitmap
        the latter was a simple sql query modification I randomly noticed
      • 2021-06-14 16507, 2021

      • bitmap
        the remainder of the week I spent writing a bunch tests and fixing bugs in the artwork-indexer. it has much better automated tests than the caa-indexer at this point
      • 2021-06-14 16534, 2021

      • bitmap
        trying to finish that this week so we can resolve caa-indexer bugs and then proceed with the event art archive.
      • 2021-06-14 16541, 2021

      • bitmap
        fin. reosarevokgo!
      • 2021-06-14 16546, 2021

      • reosarevok
        Hi!
      • 2021-06-14 16500, 2021

      • Freso
        (Others (still) up: alastairp, Freso, monkey, ruaok, zas, lucifer , yvanzo, akshaaatt, jasondk , akashgp09, CatQuest – anyone else who wish to give review, please let me know ASAP!)
      • 2021-06-14 16502, 2021

      • reosarevok
        I mostly fixed more old PRs (we got quite a few merged for this server release)
      • 2021-06-14 16516, 2021

      • reosarevok
        And spent some time reviewing the PR bitmap talked about. Still looking into that (it's a big one)
      • 2021-06-14 16525, 2021

      • reosarevok
        CatQuest: around? If so, go! :)
      • 2021-06-14 16539, 2021

      • CatQuest
        Meow! `😺`
      • 2021-06-14 16546, 2021

      • CatQuest
        o, my wireless router which has been on the fritz for ages *finally* conked out completely
      • 2021-06-14 16546, 2021

      • CatQuest
        well, I got a new one, and now I can access internet on the other machine (a windows machine) which is much more modern and thus I can tag with picard again!
      • 2021-06-14 16502, 2021

      • CatQuest
        it's basically summer here now and things are slowly working towards normal.
      • 2021-06-14 16516, 2021

      • CatQuest
        expect afk from me in the next few weeks as I try to be outside to soak up d-vitamine, exercise, and work up the nerve to be outside with *gasp* people again!
      • 2021-06-14 16536, 2021

      • CatQuest
        I have finished a few "add alias to $instrument" tickets, (huge ones like "strings" require 20+ alias)
      • 2021-06-14 16536, 2021

      • CatQuest
        as well as working on extended locale list. (more on that Soon™)
      • 2021-06-14 16546, 2021

      • CatQuest
      • 2021-06-14 16546, 2021

      • CatQuest
        fin, go monkey
      • 2021-06-14 16551, 2021

      • monkey
        Halo !
      • 2021-06-14 16549, 2021

      • monkey
        Last week I spent a good bit of time hunting a bug with BookBrainz revision diffs. Something's not right presumably with the ORM, but I haven't found a fix yet.
      • 2021-06-14 16518, 2021

      • monkey
        There was also some shenanigans with the new servers, and moving BB from server to server accordignly.
      • 2021-06-14 16549, 2021

      • monkey
        I worked with akashgp09_ on his GSoC project (more clarification of the database schema regarding the new relationship attributes)
      • 2021-06-14 16558, 2021

      • monkey
        And finally reviewed a bunch of PRs !
      • 2021-06-14 16529, 2021

      • monkey
        Today is internation blood donor day so I went to the hospital for a bit this afternoon, slow kind of day.
      • 2021-06-14 16529, 2021

      • ritiek
        Freso: yep, i'm in for review today
      • 2021-06-14 16542, 2021

      • monkey
        Good timing ritiek ! You're next ! :)
      • 2021-06-14 16556, 2021

      • ritiek
        last week i worked on enhancing coverart extraction in muicbrainz_rs, and implemented auto-retries on queries which get rate-limited https://github.com/oknozor/musicbrainz_rs/pulls
      • 2021-06-14 16510, 2021

      • ritiek
        my mentor has been busy since last week but is expected to be around this week
      • 2021-06-14 16524, 2021

      • ritiek
        so these PRs will probably get reviewed this week
      • 2021-06-14 16537, 2021

      • ritiek
        fin
      • 2021-06-14 16515, 2021

      • yvanzo
        !m ritiek and invite someone else for review
      • 2021-06-14 16516, 2021

      • BrainzBot
        You're doing good work, ritiek and invite someone else for review!
      • 2021-06-14 16534, 2021

      • Freso
        Or I’ll just pick one…
      • 2021-06-14 16537, 2021

      • yvanzo
        in Freso's list, above.
      • 2021-06-14 16501, 2021

      • Freso
        alastairp: Go!
      • 2021-06-14 16503, 2021

      • yvanzo
        rkt
      • 2021-06-14 16505, 2021

      • alastairp
        hello
      • 2021-06-14 16509, 2021

      • yvanzo
        ty :)
      • 2021-06-14 16519, 2021

      • Freso
        (Others still up: Freso, ruaok, zas, lucifer, yvanzo, akshaaatt, jasondk, akashgp09 – anyone else who wish to give review, please let me know ASAP!)
      • 2021-06-14 16528, 2021

      • alastairp
        last week as monkey said, we moved some servers around
      • 2021-06-14 16550, 2021

      • alastairp
        I did some reviews, including double-checking jasondk's work - exciting!
      • 2021-06-14 16510, 2021

      • jasondk
        :D
      • 2021-06-14 16519, 2021

      • alastairp
        with lucifer we started digging into AcousticBrainz/MusicBrainz database interaction, which looks fun
      • 2021-06-14 16538, 2021

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, autoeditors with bouncing emails (reo)
      • 2021-06-14 16527, 2021

      • alastairp
        I also continued some work trying to improve the way that we connect to external services in ListenBrainz, and made a test flask app to demonstrange it. I'll be discussing this with ruaok and lucifer this week
      • 2021-06-14 16533, 2021

      • alastairp
        uh, demonstrate
      • 2021-06-14 16544, 2021

      • alastairp
        that's it. Freso next?
      • 2021-06-14 16548, 2021

      • Freso
        o/
      • 2021-06-14 16539, 2021

      • Freso
        Not much from me this week. Been spending a lot of time in the sun though which has been nice and relaxing. Mostly lurking about.
      • 2021-06-14 16543, 2021

      • Freso
        fin.
      • 2021-06-14 16545, 2021

      • Freso
        ruaok: Go!
      • 2021-06-14 16555, 2021

      • ruaok
        aight.
      • 2021-06-14 16511, 2021

      • ruaok
        last week was aforementioned server swapping and various hosting nonsense.
      • 2021-06-14 16534, 2021

      • ruaok
        I was also out on monday, and slow on wednesday (vaccine dopiness)
      • 2021-06-14 16550, 2021

      • ruaok
        on friday I wrote a proposal to YouTube on how we can work better with ISNI.
      • 2021-06-14 16526, 2021

      • ruaok
        and here and there I worked on some PR, in particular for jasondk and moved the mbid-mapping writer along a tiny bit.
      • 2021-06-14 16531, 2021

      • ruaok
        fin. jasondk?
      • 2021-06-14 16544, 2021

      • jasondk
        Hi all,
      • 2021-06-14 16553, 2021

      • jasondk
        Last week I finished submitted a PR to implement database methods for the pinned recording feature https://github.com/metabrainz/listenbrainz-server…
      • 2021-06-14 16503, 2021

      • jasondk
        and started on the matching API routes which I hope to finish this week.
      • 2021-06-14 16518, 2021

      • jasondk
        Also I'm transferring schools in the fall so I spent time filling forms and doing orientation stuff.
      • 2021-06-14 16532, 2021

      • jasondk
        That's it for me.
      • 2021-06-14 16542, 2021

      • Freso
        (Others still up: zas, lucifer, yvanzo, akshaaatt, akashgp09 – anyone else who wish to give review, please let me know ASAP!)
      • 2021-06-14 16546, 2021

      • jasondk
        yvanzo next?
      • 2021-06-14 16552, 2021

      • yvanzo
        hi!
      • 2021-06-14 16502, 2021

      • yvanzo
        Last week I moved RabbitMQ from ‘prince’ to ‘boingo’ then to ‘clash’.
      • 2021-06-14 16520, 2021

      • yvanzo
        I pushed a script to make data move easier for project maintainers.
      • 2021-06-14 16540, 2021

      • yvanzo
        It still requires more doc as each project creates message queues its own way.
      • 2021-06-14 16527, 2021

      • yvanzo
        (For example, SIR must creates its own queues before moving data, do not let shovels create it instead.)
      • 2021-06-14 16537, 2021

      • yvanzo
        Plus I investigated search indexer issues and reviewed PRs,
      • 2021-06-14 16547, 2021

      • yvanzo
        including the large one about error types thanks to yyoung,
      • 2021-06-14 16555, 2021

      • yvanzo
        and a set of older PRs thanks to reosarevok and bitmap.
      • 2021-06-14 16501, 2021

      • yvanzo
        Fin. Go zas!
      • 2021-06-14 16506, 2021

      • zas
        Hey
      • 2021-06-14 16530, 2021

      • zas
        configured new server (clash)
      • 2021-06-14 16559, 2021

      • zas
        Picard code reviews
      • 2021-06-14 16523, 2021

      • zas
        various admin tasks, IP blocking/unblocking, upgrades
      • 2021-06-14 16543, 2021

      • zas
        I upgraded discourse too
      • 2021-06-14 16552, 2021

      • zas
        fin. lucifer?
      • 2021-06-14 16556, 2021

      • lucifer
        hi all!
      • 2021-06-14 16509, 2021

      • kinduff
        monkey, wow uptime in a badge, that's pretty fun
      • 2021-06-14 16559, 2021

      • lucifer
        I helped with configuring LB to new rabbitmq instance. the upgrade exposed some bugs in our code, helped in debugging and fixing those.
      • 2021-06-14 16514, 2021

      • Freso
        (Only akshaaatt[m] and akashgp09_ left on my list! Last call for anyone else who want to give a review!)
      • 2021-06-14 16518, 2021

      • lucifer
        I also worked on upgrading websockets for LB, started looking into implementing MeB Oauth stuff and benchmarking some sql queries in AB.
      • 2021-06-14 16558, 2021

      • lucifer
        Later, i worked on upgrading which was deployed today. Next on my radar is upgrading the our Sentry instance.
      • 2021-06-14 16513, 2021

      • lucifer
        that's it for me. akshaaatt[m]: next?
      • 2021-06-14 16518, 2021

      • akshaaatt[m]
        Hi Everyone!
      • 2021-06-14 16528, 2021

      • lucifer
        (*upgrading pika)
      • 2021-06-14 16546, 2021

      • akshaaatt[m]
        I worked on a massive PR regarding the Tagger in the MB Android App this past week with @lucifer and we will work on finalizing it this week.
      • 2021-06-14 16554, 2021

      • akshaaatt[m]
        Also, I did some research on the future work we can do.
      • 2021-06-14 16511, 2021

      • akshaaatt[m]
        Other than that the weather has been pleasant here for the past few days so I have enjoyed that :)
      • 2021-06-14 16524, 2021

      • akshaaatt[m]
        fin! akashgp09_ you up?
      • 2021-06-14 16530, 2021

      • akashgp09_
        Hi everyone l
      • 2021-06-14 16549, 2021

      • akashgp09_
        Last week i started working on creating delete and revision routes for series entity.
      • 2021-06-14 16501, 2021

      • akashgp09_
        and also finally we are done with the database schema https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-06-14 16511, 2021

      • Freso
        \o/
      • 2021-06-14 16515, 2021

      • akashgp09_
        I worked on Implemeting automatic sorting mechanism for relationships in series and added series entity to search index so that series shows up in the search results
      • 2021-06-14 16526, 2021

      • akashgp09_
        that's all from my side, thank you :)
      • 2021-06-14 16530, 2021

      • BrainzGit
        [bookbrainz-site] release 03v-2021-06-14.0 has been published by 14release-drafter[bot]: https://github.com/bookbrainz/bookbrainz-site/rel…
      • 2021-06-14 16542, 2021

      • monkey
        (Sorry about that)
      • 2021-06-14 16543, 2021

      • Freso
        Alright!
      • 2021-06-14 16557, 2021

      • Freso
        That’s everyone I have down for reviews. Thank you all who gave one. :)
      • 2021-06-14 16512, 2021

      • Freso
        We have one additional item on today’s agenda list:
      • 2021-06-14 16520, 2021

      • Freso
        reo: autoeditors with bouncing emails
      • 2021-06-14 16533, 2021

      • reosarevok
        Hi!
      • 2021-06-14 16546, 2021

      • reosarevok
        So, we talked about this a few years ago, not sure with what result
      • 2021-06-14 16503, 2021

      • reosarevok
        But I'm getting tired of getting bounces from like 6 to 10 autoeditors every time I send election mails
      • 2021-06-14 16525, 2021

      • reosarevok
        I can just remove them from my list, I guess, but should we blank their email or something?
      • 2021-06-14 16538, 2021

      • reosarevok
        I think they're all people who have been inactive for years and years, anyway, but
      • 2021-06-14 16545, 2021

      • Freso
        I’d personally be fine with removing their autoeditor status.
      • 2021-06-14 16555, 2021

      • yvanzo
        bouncing emails because they are invalid?
      • 2021-06-14 16540, 2021

      • Freso
        As you say, they’ve been inactive for eons and not invested enough to keep their e-mail working.
      • 2021-06-14 16505, 2021

      • Freso
        Maybe a vote/discussion in the AE forum?
      • 2021-06-14 16509, 2021

      • reosarevok
        Most are address not found, one is message blocked
      • 2021-06-14 16548, 2021

      • reosarevok
        Someone also complained last election "why am I even getting this, I have deleted my account" (they had not deleted their account, I asked abou tit)
      • 2021-06-14 16501, 2021

      • Freso
        I don’t think we should blank e-mail, in case they come back around and are like "I lost access to my account, my address was XYZ."
      • 2021-06-14 16504, 2021

      • yvanzo
        message blocked ^^
      • 2021-06-14 16504, 2021

      • reosarevok
        There's a more general issue with half of our autoeditors being inactive, but :)
      • 2021-06-14 16505, 2021

      • zas
        btw, I guess we have the same problem with normal editors
      • 2021-06-14 16551, 2021

      • CatQuest
        i say deactivate autoed for them
      • 2021-06-14 16503, 2021

      • zas
        I guess we'll need to set up something to manage bounces (but using gmail doesn't help in this field)
      • 2021-06-14 16531, 2021

      • yvanzo
        +1 CatQuest
      • 2021-06-14 16501, 2021

      • Freso
        OTOH, we may want to blank e-mails if they stop existing. I know someone who in the last few weeks got their Facebook cracked into due to a domain expiring and someone buying up that domain and using that to get a reset password e-mail and from there take over the account.