#metabrainz

[musicbrainz-android] 14amCap1712 merged pull request #76 (03master…listen_addition): WebView Addition to the app https://github.com/metabrainz/musicbrainz-andro...

lucifer: Hola! I'm available rn in case something is to be discussed 😇

hi akshaaatt[m]! cool, 👍

!m lucifer

You're doing good work, lucifer!

i agree with the comments on the login PR but we should do that before releasing

Yup!

On it boss

no hurry :), we release when we're ready.

[musicbrainz-android] 14amCap1712 merged pull request #77 (03master…login_tweaks): Login tweaks https://github.com/metabrainz/musicbrainz-andro...

Yusss

yvanzo: Good afternoon

hi!

I've wrote the tests and opened a thread asking for suggestions: https://community.metabrainz.org/t/a-discussion...

As expected, editors want to keep the UI simple and straightforward.

I agree with them that we should try to eliminate extra clicks, and I think showing a bubble on the right is a good option.

yyoung: is it possible to blur on copy/paste?

yvanzo: I don't think it's possible, what do you think?

yvanzo: What do you think of the bubble option?

is it possible to open the popover when editor paste an URL in input field?

I don't get it. If the link is already in the list, then there's no input field in the editor; if it's a new link, then there's no popover

Meanwhile, isn't that exactly what a bubble does? :)

when an editor paste an URL, they still have to press tab or enter, right?

Yes, or after the input box blurred.

is it possible to detect the paste to add a new URL entry right away?

I guess pasting is the same as entering character by character, they're all key press events, will have a search later

Sorry, it seems I got it wrong :)

Yes, so are you suggesting automatically add the link on paste?

yes

Then what about editing existing links?

That should solve 99% of the extra click issue already.

IIRC adding link didn't introduce extra clicks

And editing existing links requires 2 extra clicks: open the popover, and save

what was the issue with bubble again?

I didn't say there's an issue with bubble :)

I think we decided to go for popover for a reason?

I thought you put up that idea?

Oh you said it would make the list more compace

s/compace/compact

<The bubble is not ideal either: it shows the clean URL only on rollover.>

Well, we can keep the clean URL in the input box instead of raw URL

So there still is an issue with black magic happening to the input field while editor is typing.

I don't think so, see this: https://community.metabrainz.org/t/a-discussion...

When the bubble is shown, the input box is treated like raw URL, the clean URL is in the bubble

It's not the clean URL in this mockup, it's the raw URL.

And when the bubble is closed, i.e. the input box blurred, the raw URL is replaced with clean URL

(in the input field, not the bubble)

then the raw URL is lost

Yes, but it's the same as what we have now

So it might not be a big deal

so if it's the same, let's do nothing ;)

The advantage is you won't be interrupted by cleanup while inputting

yes

I guess that did solve the issue? ;)

no, the raw URL should still be retained.

The main feature is to enable editors to see automatic changes.

Is that suggested in the issue to keep raw URL?

This should also be a first step toward allowing to bypass broken cleanup.

Won't the clean URL shown in the bubble indicates automatic changes?

Oh, that makes sense

> These changes are implicit and difficult to see for editors. It would be nice to have separate display for the URL entered by the editor and the normalized URL.

So we have separate display while inputting, but not after

I guess we can add a option in the bubble to bypass cleanup?

this option is future work as it requires change to edit data too.

As long the input box is focused, the raw URL is kept

s/As long/As long as

yes, it should be kept until form is submitted

So what about keeping the raw URL and switching to it when the input box is focused?

And switch back to clean URL when blurred

yvanzo: Why do you think a popover will compact the list again?

I'm not sure that was about popover vs bubble

I don't know what to think about switching from/to raw/clean URL in the same input field. Would that still allow to compare them?

Yes I guess, the raw URL is in the input box, and clean URL is in bubble

Though raw URL is not shown when blurred, it's the same as the popover

yvanzo: ping

pong

So what do you think?

yyoung: there seems to be a misunderstanding in the thread: the pop-over would be used to edit URLs only, not to add new ones.

Maybe, but editing URL did become more complex

Shall I make a clarification and mention the editors?

Switching content of the input field would probably tend to confuse editors, but it's hard to say for me.

I’m replying already.

OK, thanks

When clicking on the pencil, is it possible to auto-focus the input field? It would remove an extra click at least

Yes I think that's possible

Will have a try later

yyoung: would that solve the extra click problem for good?

yvanzo: I think so, but I haven't try it yet. Going to bed now, see you tomorrow :)

yyoung: Ok, I will reply about the output of our discussion to forums, good night :)

Done, see https://community.metabrainz.org/t/a-discussion...

[bookbrainz-site] 14akashgp09 opened pull request #661 (03series-entity…series-routes-tests): test(series): add tests for main GET routes https://github.com/bookbrainz/bookbrainz-site/p...

Hi Everyone, I have recently summed up some part of our work which we have done on the MusicBrainz App so far at: https://community.metabrainz.org/t/musicbrainz-... Anyone interested can go through this and we would love to hear from you in the community!