#metabrainz

/

      • Lotheric_ joined the channel

        • 2021-07-03 18409, 2021

      • Lotheric has quit

        • 2021-07-03 18414, 2021

      • Lotheric__ joined the channel

        • 2021-07-03 18401, 2021

      • Lotheric_ has quit

        • 2021-07-03 18450, 2021

      • Lotheric__ is now known as Lotheric

        • 2021-07-03 18438, 2021

      • Zastai has quit

        • 2021-07-03 18430, 2021

      • lordie has quit

        • 2021-07-03 18417, 2021

      • akashgp09 joined the channel

        • 2021-07-03 18450, 2021

      • lordie joined the channel

        • 2021-07-03 18404, 2021

      • lordie has quit

        • 2021-07-03 18429, 2021

      • BrainzGit
        [musicbrainz-android] 14amCap1712 merged pull request #76 (03master…listen_addition): WebView Addition to the app https://github.com/metabrainz/musicbrainz-android…

        • 2021-07-03 18408, 2021

      • akshaaatt[m]
        lucifer: Hola! I'm available rn in case something is to be discussed 😇

        • 2021-07-03 18416, 2021

      • Toasty joined the channel

        • 2021-07-03 18420, 2021

      • lucifer
        hi akshaaatt[m]! cool, 👍

        • 2021-07-03 18432, 2021

      • akshaaatt[m]
        !m lucifer

        • 2021-07-03 18433, 2021

      • BrainzBot
        You're doing good work, lucifer!

        • 2021-07-03 18449, 2021

      • lucifer
        i agree with the comments on the login PR but we should do that before releasing

        • 2021-07-03 18403, 2021

      • akshaaatt[m]
        Yup!

        • 2021-07-03 18405, 2021

      • akshaaatt[m]
        On it boss

        • 2021-07-03 18439, 2021

      • lucifer
        no hurry :), we release when we're ready.

        • 2021-07-03 18450, 2021

      • BrainzGit
        [musicbrainz-android] 14amCap1712 merged pull request #77 (03master…login_tweaks): Login tweaks https://github.com/metabrainz/musicbrainz-android…

        • 2021-07-03 18451, 2021

      • akshaaatt[m]
        Yusss

        • 2021-07-03 18448, 2021

      • yyoung
        yvanzo: Good afternoon

        • 2021-07-03 18414, 2021

      • yvanzo
        hi!

        • 2021-07-03 18409, 2021

      • yyoung
        I've wrote the tests and opened a thread asking for suggestions: https://community.metabrainz.org/t/a-discussion-o…

        • 2021-07-03 18413, 2021

      • yyoung
        As expected, editors want to keep the UI simple and straightforward.

        • 2021-07-03 18423, 2021

      • yyoung
        I agree with them that we should try to eliminate extra clicks, and I think showing a bubble on the right is a good option.

        • 2021-07-03 18452, 2021

      • yvanzo
        yyoung: is it possible to blur on copy/paste?

        • 2021-07-03 18453, 2021

      • yyoung
        yvanzo: I don't think it's possible, what do you think?

        • 2021-07-03 18425, 2021

      • yyoung
        Also having to open a popover before editing is kind of redundant

        • 2021-07-03 18431, 2021

      • yyoung
        yvanzo: What do you think of the bubble option?

        • 2021-07-03 18415, 2021

      • yvanzo
        is it possible to open the popover when editor paste an URL in input field?

        • 2021-07-03 18453, 2021

      • yyoung
        I don't get it. If the link is already in the list, then there's no input field in the editor; if it's a new link, then there's no popover

        • 2021-07-03 18449, 2021

      • yyoung
        Meanwhile, isn't that exactly what a bubble does? :)

        • 2021-07-03 18453, 2021

      • yvanzo
        when an editor paste an URL, they still have to press tab or enter, right?

        • 2021-07-03 18409, 2021

      • yyoung
        Yes, or after the input box blurred.

        • 2021-07-03 18441, 2021

      • yvanzo
        is it possible to detect the paste to add a new URL entry right away?

        • 2021-07-03 18426, 2021

      • yyoung
        I guess pasting is the same as entering character by character, they're all key press events, will have a search later

        • 2021-07-03 18449, 2021

      • yyoung
        Sorry, it seems I got it wrong :)

        • 2021-07-03 18446, 2021

      • yyoung
        Yes, so are you suggesting automatically add the link on paste?

        • 2021-07-03 18449, 2021

      • yvanzo
        yes

        • 2021-07-03 18439, 2021

      • yyoung
        Then what about editing existing links?

        • 2021-07-03 18446, 2021

      • yvanzo
        That should solve 99% of the extra click issue already.

        • 2021-07-03 18438, 2021

      • yyoung
        IIRC adding link didn't introduce extra clicks

        • 2021-07-03 18433, 2021

      • yyoung
        And editing existing links requires 2 extra clicks: open the popover, and save

        • 2021-07-03 18406, 2021

      • yvanzo
        what was the issue with bubble again?

        • 2021-07-03 18444, 2021

      • yyoung
        I didn't say there's an issue with bubble :)

        • 2021-07-03 18422, 2021

      • yvanzo
        I think we decided to go for popover for a reason?

        • 2021-07-03 18409, 2021

      • yyoung
        I thought you put up that idea?

        • 2021-07-03 18425, 2021

      • yyoung
        Oh you said it would make the list more compace

        • 2021-07-03 18448, 2021

      • yyoung
        s/compace/compact

        • 2021-07-03 18423, 2021

      • yyoung
        https://chatlogs.metabrainz.org/libera/metabrainz…

        • 2021-07-03 18449, 2021

      • yyoung
        <The bubble is not ideal either: it shows the clean URL only on rollover.>

        • 2021-07-03 18429, 2021

      • yyoung
        Well, we can keep the clean URL in the input box instead of raw URL

        • 2021-07-03 18413, 2021

      • yvanzo
        So there still is an issue with black magic happening to the input field while editor is typing.

        • 2021-07-03 18448, 2021

      • yyoung
        I don't think so, see this: https://community.metabrainz.org/t/a-discussion-o…

        • 2021-07-03 18420, 2021

      • yyoung
        When the bubble is shown, the input box is treated like raw URL, the clean URL is in the bubble

        • 2021-07-03 18420, 2021

      • yvanzo
        It's not the clean URL in this mockup, it's the raw URL.

        • 2021-07-03 18450, 2021

      • yyoung
        And when the bubble is closed, i.e. the input box blurred, the raw URL is replaced with clean URL

        • 2021-07-03 18452, 2021

      • yvanzo
        (in the input field, not the bubble)

        • 2021-07-03 18415, 2021

      • yvanzo
        then the raw URL is lost

        • 2021-07-03 18443, 2021

      • yyoung
        Yes, but it's the same as what we have now

        • 2021-07-03 18454, 2021

      • yyoung
        So it might not be a big deal

        • 2021-07-03 18400, 2021

      • yvanzo
        so if it's the same, let's do nothing ;)

        • 2021-07-03 18428, 2021

      • yyoung
        The advantage is you won't be interrupted by cleanup while inputting

        • 2021-07-03 18404, 2021

      • yvanzo
        yes

        • 2021-07-03 18430, 2021

      • yyoung
        I guess that did solve the issue? ;)

        • 2021-07-03 18443, 2021

      • yvanzo
        no, the raw URL should still be retained.

        • 2021-07-03 18427, 2021

      • yvanzo
        The main feature is to enable editors to see automatic changes.

        • 2021-07-03 18443, 2021

      • yyoung
        Is that suggested in the issue to keep raw URL?

        • 2021-07-03 18415, 2021

      • yvanzo
        This should also be a first step toward allowing to bypass broken cleanup.

        • 2021-07-03 18423, 2021

      • yyoung
        Won't the clean URL shown in the bubble indicates automatic changes?

        • 2021-07-03 18446, 2021

      • yyoung
        Oh, that makes sense

        • 2021-07-03 18447, 2021

      • yvanzo
        > These changes are implicit and difficult to see for editors. It would be nice to have separate display for the URL entered by the editor and the normalized URL.

        • 2021-07-03 18423, 2021

      • yyoung
        So we have separate display while inputting, but not after

        • 2021-07-03 18454, 2021

      • yyoung
        I guess we can add a option in the bubble to bypass cleanup?

        • 2021-07-03 18414, 2021

      • yvanzo
        this option is future work as it requires change to edit data too.

        • 2021-07-03 18427, 2021

      • yyoung
        As long the input box is focused, the raw URL is kept

        • 2021-07-03 18436, 2021

      • yyoung
        s/As long/As long as

        • 2021-07-03 18449, 2021

      • yvanzo
        yes, it should be kept until form is submitted

        • 2021-07-03 18442, 2021

      • yyoung
        So what about keeping the raw URL and switching to it when the input box is focused?

        • 2021-07-03 18401, 2021

      • yyoung
        And switch back to clean URL when blurred

        • 2021-07-03 18414, 2021

      • yyoung
        yvanzo: Why do you think a popover will compact the list again?

        • 2021-07-03 18435, 2021

      • yvanzo
        I'm not sure that was about popover vs bubble

        • 2021-07-03 18449, 2021

      • yvanzo
        I don't know what to think about switching from/to raw/clean URL in the same input field. Would that still allow to compare them?

        • 2021-07-03 18439, 2021

      • yyoung
        Yes I guess, the raw URL is in the input box, and clean URL is in bubble

        • 2021-07-03 18402, 2021

      • yyoung
        Though raw URL is not shown when blurred, it's the same as the popover

        • 2021-07-03 18400, 2021

      • yyoung
        yvanzo: ping

        • 2021-07-03 18439, 2021

      • yvanzo
        pong

        • 2021-07-03 18453, 2021

      • yyoung
        So what do you think?

        • 2021-07-03 18437, 2021

      • yvanzo
        yyoung: there seems to be a misunderstanding in the thread: the pop-over would be used to edit URLs only, not to add new ones.

        • 2021-07-03 18430, 2021

      • yyoung
        Maybe, but editing URL did become more complex

        • 2021-07-03 18431, 2021

      • yyoung
        Shall I make a clarification and mention the editors?

        • 2021-07-03 18434, 2021

      • yvanzo
        Switching content of the input field would probably tend to confuse editors, but it's hard to say for me.

        • 2021-07-03 18441, 2021

      • yvanzo
        I’m replying already.

        • 2021-07-03 18449, 2021

      • yyoung
        OK, thanks

        • 2021-07-03 18429, 2021

      • yvanzo
        When clicking on the pencil, is it possible to auto-focus the input field? It would remove an extra click at least

        • 2021-07-03 18448, 2021

      • yyoung
        Yes I think that's possible

        • 2021-07-03 18459, 2021

      • yyoung
        Will have a try later

        • 2021-07-03 18453, 2021

      • yvanzo
        yyoung: would that solve the extra click problem for good?

        • 2021-07-03 18444, 2021

      • yyoung
        yvanzo: I think so, but I haven't try it yet. Going to bed now, see you tomorrow :)

        • 2021-07-03 18407, 2021

      • yvanzo
        yyoung: Ok, I will reply about the output of our discussion to forums, good night :)

        • 2021-07-03 18433, 2021

      • yvanzo
        Done, see https://community.metabrainz.org/t/a-discussion-o…

        • 2021-07-03 18436, 2021

      • BrainzGit
        [bookbrainz-site] 14akashgp09 opened pull request #661 (03series-entity…series-routes-tests): test(series): add tests for main GET routes https://github.com/bookbrainz/bookbrainz-site/pul…

        • 2021-07-03 18448, 2021

      • agatzk has quit

        • 2021-07-03 18408, 2021

      • agatzk joined the channel

        • 2021-07-03 18442, 2021

      • lordie joined the channel

        • 2021-07-03 18401, 2021

      • akashgp09 has quit

        • 2021-07-03 18403, 2021

      • akshaaatt[m]
        Hi Everyone, I have recently summed up some part of our work which we have done on the MusicBrainz App so far at: https://community.metabrainz.org/t/musicbrainz-ap… Anyone interested can go through this and we would love to hear from you in the community!

        • 2021-07-03 18403, 2021

      • lordie has quit

        • 2021-07-03 18400, 2021

      • Sophist-UK joined the channel

        • 2021-07-03 18446, 2021

      • just1602 joined the channel

        • 2021-07-03 18411, 2021

      • Toasty has quit

        • 2021-07-03 18444, 2021

      • Etua joined the channel

        • 2021-07-03 18430, 2021

      • Etua has quit