#metabrainz

/

      • ritiek has quit
      • BrainzGit has quit
      • BrainzGit joined the channel
      • opal joined the channel
      • DragonsChild joined the channel
      • DragonsChild has quit
      • reosarevok
        Jeez. Does LB really need Google stuff? Because those emails where they're never happy sure do look like a pain in the ass
      • yyoung
        yvanzo: I've updated PR 2151
      • d4rk joined the channel
      • d4rkie has quit
      • ruaok
        that is exactly the question I was just asking myself.
      • I'm going to mail my contact at YouTube and ask him for advice.
      • lucifer
        now we are just going around in circles...
      • i do not understand which point of the list we do not meet.
      • ruaok
        yeah. all for something we don't actually want. which is the worst part.
      • lucifer
        exactly.
      • their last email about Privacy Policy did not have this section.
      • ruaok
        I think each reviewer we get, applies their own standards.
      • seems intractable.
      • lucifer
        yeah :/
      • oh well. did you see the security assessment BS down that page?
      • ruaok
        can we request NO SCOPES?
      • lucifer
        that was how things workedd till last year. google deprecated an removed that.
      • ruaok
        are there any non-restricted scopes at all?
      • lucifer
        not for youtube i think but i'll recheck.
      • alastairp
        morning
      • ruaok: sorry, I didn't reply to that tweet. just done it now
      • yesterday wasn't going my way, I turned off all of the computers at midday and took a day off, it was definitely needed
      • lucifer: agreed, we should structure the training process such that if an error happens, we propagate an exception to a single top-level error handler, report it to sentry, and then log it in a way to show the user that there was a problem
      • lucifer
        hi!
      • yes, makes sense.
      • i made some more progress on the sklearn stuff, i think its mostly ready except for the exception handling part.
      • alastairp
        cool, great! Let me concentrate on finishing off these two AB PRs that I'm currently working on, then I'll start with testing this one
      • ruaok
        alastairp: thanks!
      • Lotheric has quit
      • Lotheric joined the channel
      • ritiek joined the channel
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1542 (03master…youtube-again): Query Youtube API using api key only https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        thanks param !
      • BrainzGit
        [listenbrainz-server] 14mayhem merged pull request #1538 (03master…Pinned-Recording-Modal): Add Pinned Recording Modal https://github.com/metabrainz/listenbrainz-serv...
      • param
        sorry for the late review, I only just saw it today. :(
      • ruaok
        all good.
      • lucifer: another thought I had... I think we need to build content resolution into lb-server.
      • having it in brainzplayer makes BP far more complicated than it needs to be.
      • reosarevok
        Jesus
      • We have a week and a half of 30+ degrees coming
      • Maybe I should get a plane to somewhere cooler, like... the Mediterranean :p
      • lucifer
        yeah makes sense. so send 1 query to LB server and then LB sends back the link to play?
      • ruaok
        lucifer: or even on a whole playlist at a time. so that BP can just do playback and nothing else.
      • reosarevok: Is 24C here. :)
      • lucifer
        yup agreed.
      • reosarevok
        ruaok: sadly we are only 7 days past the second vaccine, so a bit early to travel anyway :(
      • ruaok
        and you don't want to come here. a huge number of youngsters, who never cared about covid are getting infected in record numbers.
      • reosarevok
        Well, hopefully the vaccine would help with that... but yeah
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1542 (03master…youtube-again): Query Youtube API using api key only https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        ruaok: let's release?
      • ruaok
        go!
      • alastairp
        meanwhile: Francia aconseja no veranear en España y Portugal
      • ruaok
        yerp.
      • BrainzGit
        [listenbrainz-server] release 03v-2021-07-08.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • alastairp
        veranear, what a verb
      • shivam-kapila
        30 degress? Its 50 degrees here
      • ruaok
        I can't wait to see what the foreign ministry of germany says for next week.
      • I'll be coming vaccinated and with a PCR test, but still.
      • reosarevok
        shivam-kapila: I'd like to think your buildings are built taking the heat into account though, at least?
      • ruaok
        shivam-kapila: reosarevok is a wimp
      • reosarevok
        (if not, yeesh)
      • Ours aren't, since we're a cold country - they're mostly built to keep the heat in :p
      • shivam-kapila
        Not at all reosarevok
      • lucifer
        nice of you to think buildings are planned before building in india
      • reosarevok
        haha
      • Sorry I had hopes for your country, should have known better (?) :p
      • ruaok
        your insulated house is good for keeping heat out... for a while.
      • shivam-kapila
        On point lucifer. Plus mine is a rented place. Why would the landlord care
      • reosarevok
        At least we're "only" at almost constant 27 degrees inside
      • Some people are at 35, so I guess I should be happy :p
      • shivam-kapila
        My mac is so heated that I can cook chapattis on it
      • ruaok
        I'm just glad that evenings still cool to 21C.
      • reosarevok
        It's a more normal temperature in Lapland, so that'd be an option - sadly it's death by mosquitoes in there in the summer AFAICT :D
      • Do they make laptops you can use while sitting in a river yet?
      • shivam-kapila
        Then offices will be in swimming pools rather than buildings :p
      • reosarevok
        Sounds like a plan
      • param
        lol someone at work got github copilot to solve an interview problem we give
      • shivam-kapila
        Its trending right now
      • How copilot can help crush leetcode questions
      • lucifer
        LB prod updated.
      • akshaaatt[m]
        <param "lol someone at work got github c"> Oh my😂😂
      • param starts reading up on those ML books
      • lucifer
        alastairp: the best model pickle file should be the history path in db, right?
      • alastairp
        lucifer: right, they're equivalent, but perhaps we could use a different key for the sklearn one, maybe just "model" ?
      • lucifer
        we could do that but that only causes to add more ifs elsewhere.
      • whenever we want to access the model. i don't think we do it anywhere currently though.
      • ritiek has quit
      • i'll do the model key then, if we need to change we can do that later anyways.
      • alastairp: there's also this warning in sklearn logs
      • alastairp
        lucifer: how many items are in your dataset?
      • 345?
      • lucifer
        345
      • alastairp
        yeah, looks like the warning is pretty harmless, then
      • lucifer
        👍
      • yvanzo has quit
      • yvanzo joined the channel
      • akashgp09 joined the channel
      • ritiek joined the channel
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1543 (03master…revert-privacy-policy): Remove LB specific privacy policy https://github.com/metabrainz/listenbrainz-serv...
      • agatzk has quit
      • yyoung has quit
      • yyoung joined the channel
      • [musicbrainz-server] 14yvanzo closed pull request #2081 (03master…MBS-10211): MBS-10211: Formatting Tweet links for recordings https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-android] 14akshaaatt opened pull request #82 (03master…asset_attributions): Asset Attributions https://github.com/metabrainz/musicbrainz-andro...
      • akshaaatt[m]
        Hi lucifer !
      • lucifer
        hi!
      • akshaaatt[m]
        <BrainzGit "[musicbrainz-android] akshaaatt "> If you could confirm quickly whether this format is good?
      • For attrubtions, I have basically prepared a table
      • attributions^
      • lucifer
        sure looks good to me. I would suggest to use markdown file instead though so that formatting is easier.
      • akshaaatt[m]
        Oh Okay!
      • lucifer
        and link the master version of this file in the about page of the app.
      • akshaaatt[m]
        Cool Sounds great!
      • yvanzo
        yyoung: are you able to run selenium tests atm?
      • yyoung
        yvanzo: I haven't tried to run it locally since then, I just found that CI combining with local Selenium IDE plugin works fine
      • yvanzo
        Ok thanks, I will look into running selenium tests locally, because it would be nice to add tests for your last fix in 2151.
      • yyoung
        If I was able to import json5 files into it, then it would work perfectly
      • BTW, I just found that the saved file of selenium IDE is in json format, maybe I could write a convertion script
      • yvanzo
        yyoung: If you’d like to explain how to use that plugin with CI, we could probably add it to HACKING.md notes.
      • yyoung
        Currently I have to manually enter every action from json5 to the IDE
      • If I found a way to convert, I would be glad to write the notes :)
      • lucifer
        alastairp: i'll start work on the model testing part meanwhile in a differrent PR. this only is already too big. sounds good?
      • alastairp
        lucifer: yeah, I think that's fine. this is the intermediate tables for doing evaluation?
      • lucifer
        alastairp: yes, that and in general for external validation of models.
      • alastairp
        cool
      • up to you - but we could even do this without the sklearn code integrated for now
      • in order to prevent us getting into trouble with multiple large prs that merge into each other
      • lucifer
        yes, right. i'll base the PR from master.
      • or should i do it from Py3 branch?
      • alastairp
        cool. gaia only, but designed so that adding sklearn in later would be fine
      • mmm
      • the highlevel extractor runs with subprocess.run, so we could probably get away with py3
      • lucifer
        yeah indeed but it uses future module.
      • i saw a ticket on gaia repo that py2 futures backport is different from py3 inbuilt futures module.
      • alastairp
        note that this is during the training process
      • ideally we'd still keep this in py 2
      • lucifer
        ah ok.
      • py2 + six then?
      • alastairp
        yep
      • lucifer
        +1