[musicbrainz-server] 14reosarevok opened pull request #2172 (03master…MBS-11781): MBS-11781: Add class to the "load all tracks" link on large mediums https://github.com/metabrainz/musicbrainz-server/…
2021-07-16 19731, 2021
reosarevok
bitmap: still around?
2021-07-16 19736, 2021
reosarevok
If not, for when you are: is there any significant reason not to allow recording-level-rels on release browse? https://tickets.metabrainz.org/browse/MBS-6140 - I think it shouldn't be a big problem and it seems better than forcing users to make one extra query per release
2021-07-16 19737, 2021
BrainzBot
MBS-6140: Add "recording-level-rels" (and "work-rels") support to "Release" browse web service
2021-07-16 19740, 2021
ruaok
mooin!
2021-07-16 19748, 2021
ruaok checks in from berlin
2021-07-16 19730, 2021
ruaok
GSoC> "Nice work! All MetaBrainz Foundation Inc evaluations are complete."
MBS-3774: Add URL relationship with begin and end dates
2021-07-16 19712, 2021
yyoung
reosarevok: Nope
2021-07-16 19740, 2021
reosarevok
To both questions? :D
2021-07-16 19708, 2021
yyoung
reosarevok: It's probably not related to the current URL input popover since is at relationship level, but it'll be implemented next in an editing dialog like other relationships
2021-07-16 19721, 2021
reosarevok
Ok :)
2021-07-16 19754, 2021
yyoung
I'll take a look at the first issue to see what can I do for it
2021-07-16 19725, 2021
yyoung
But I already have 2 PRs related to external links editor and they're dependent
yyoung: found two things, maybe you can take a look :)
2021-07-16 19732, 2021
reosarevok
I'll be around if you want to ask anything
2021-07-16 19708, 2021
reosarevok
Other than those things it looks good to me, anyway
2021-07-16 19723, 2021
yyoung
Well, the first things looks normal to me
2021-07-16 19732, 2021
yyoung
But you're right about Musicbrainz's custom, I'm not sure if yvanzo noticed this issue/feature?
2021-07-16 19730, 2021
reosarevok
Basically, if you are going to drop all changes on clicking elsewhere, then it should probably at least let the user know so their change is not lost without them noticing :) But my preference would still be that it'd be saved
2021-07-16 19707, 2021
reosarevok
(I thought I had changed it, and was quite confused when I saw the URL had not changed, I expect I wouldn't be the only one :) )
2021-07-16 19723, 2021
yyoung
OK, I'll fix that
2021-07-16 19713, 2021
BilleeKhoj
wait can you test this new url editing thing somewhere now?
2021-07-16 19734, 2021
reosarevok
This is one small step of the whole thing, and only if you run the code in your local server :)
2021-07-16 19733, 2021
BilleeKhoj
this is one small step for the whole thing, one girant leap for.. url editing?
2021-07-16 19747, 2021
BilleeKhoj
giant*
2021-07-16 19714, 2021
yyoung
reosarevok: Could you be more specific about the second issue?From my view the behavior is identical with the old version.
[musicbrainz-server] 14reosarevok opened pull request #2174 (03master…MBS-11689): MBS-11689: Report for pseudo-releases marked as the original tracklist https://github.com/metabrainz/musicbrainz-server/…
reosarevok: I took a look at MBS-11521, I've noticed that and commented about that in the PR, but since it would involve a large change, I decide to keep it as it is at this moment
(well, almost at the bottom if you're using live data, at the bottom with sample data)
2021-07-16 19743, 2021
reosarevok
Click "edit", change the link so it's not a correct Wikidata link (I just changed "/wiki/" to some gibberish)
2021-07-16 19746, 2021
reosarevok
Click Done
2021-07-16 19749, 2021
reosarevok
Now you can select any type
2021-07-16 19759, 2021
reosarevok
(of course, many won't be allowed by the checker, but still)
2021-07-16 19710, 2021
reosarevok
This is fine, it's the same in the current server
2021-07-16 19733, 2021
reosarevok
But now select something (dunno, "official site" or whatever), then fix the link again (replace the gibberish with "/wiki/" again)
2021-07-16 19756, 2021
reosarevok
It doesn't autoselect Wikidata again, even though the URL is now the same as it was before and one that normally would autoselect Wikidata
2021-07-16 19754, 2021
BrainzGit
[bookbrainz-site] 14akashgp09 opened pull request #669 (03series-entity…Series-Revision): feat(series,relationship): add revision for series and relationship attributes https://github.com/bookbrainz/bookbrainz-site/pul…
2021-07-16 19759, 2021
reosarevok
The current code does autoselect it again, from my quick testing
2021-07-16 19701, 2021
loujine_ is now known as loujine
2021-07-16 19751, 2021
yyoung
reosarevok: I tried on musicbrainz.org, modify 'wiki' to something else, select 'official homepages' and change it back, it doesn't autoselect, where did I go wrong?
2021-07-16 19706, 2021
reosarevok
Hmm
2021-07-16 19723, 2021
reosarevok
Maybe it's some userscript from when I tested earlier I wonder. I'll check again
2021-07-16 19758, 2021
reosarevok
oh, duh, no, you're right
2021-07-16 19704, 2021
reosarevok
There *is* a difference, but not that big
2021-07-16 19737, 2021
yyoung
What is the difference?
2021-07-16 19742, 2021
reosarevok
Oh. I would have sworn that last time when I selected Wikidata with your code locally it didn't lock it. But now it did, so the heat must be making me hallucinate.
2021-07-16 19746, 2021
reosarevok
Sorry for wasting your time then D:
2021-07-16 19753, 2021
reosarevok
Then it seems good now!
2021-07-16 19723, 2021
yyoung
Thanks for your review
2021-07-16 19744, 2021
reosarevok
One last thing that would be cool to have maybe? But certainly not needed to merge this PR
2021-07-16 19702, 2021
reosarevok
Would be to actually remember the original URL if the user edits it
2021-07-16 19753, 2021
reosarevok
Because if I close the editor after changing the URL, I can't ctrl+z to undo the change anymore like I could without the popup
2021-07-16 19721, 2021
reosarevok
Since we already have a popup, we could have a third row for the original URL in cases where it has been edited during this session
2021-07-16 19752, 2021
reosarevok
(maybe also mark the edited URLs in some way, with some highlighting like we do for relationships in the relationship editors?)
2021-07-16 19759, 2021
yvanzo
reosarevok: I guess that is/will be cover by edits preview.
2021-07-16 19701, 2021
reosarevok
But I'll approve this for now, in any case
2021-07-16 19709, 2021
yvanzo
cover+ed
2021-07-16 19712, 2021
reosarevok
Oh, I guess if that's part of the future plans then all is good :)
2021-07-16 19739, 2021
yvanzo
Actually future plans from last year's GSoC ;)
2021-07-16 19715, 2021
reosarevok
Oooh, not a specific preview option for this but the general concept
2021-07-16 19716, 2021
reosarevok
Sure
2021-07-16 19727, 2021
reosarevok
Well, if that ever happens, but :) One can hope
2021-07-16 19742, 2021
reosarevok
I would still like a way to go back to the original URL then though, because that's something we can currently do
2021-07-16 19749, 2021
reosarevok
(not so important re: highlighting)
2021-07-16 19749, 2021
yvanzo
I agree that having an undo feature for all fields (not just URLs) in a form would be nice, but probably to be worked on at a more general level.
2021-07-16 19735, 2021
yyoung
You mean resetting to the original URL in database?
2021-07-16 19746, 2021
yvanzo
In the form.
2021-07-16 19715, 2021
yyoung
I mean to the URL that is stored in database :)
2021-07-16 19723, 2021
yvanzo
Yes.
2021-07-16 19738, 2021
yvanzo
(at the time the form has been created.)
2021-07-16 19750, 2021
yyoung
Well that makes sense indeed
2021-07-16 19707, 2021
yyoung
But that would be another feature then
2021-07-16 19752, 2021
yvanzo
Two approvals are usually sufficient for a merge but since bitmap pointed an issue earlier, we will wait for him to confirm that the fix (restricting errors's display) correctly addressed it.
2021-07-16 19744, 2021
yyoung
Sure
2021-07-16 19728, 2021
Rotab joined the channel
2021-07-16 19728, 2021
ruaok
a portion of german rail's ticket booking process has been having proxy errors for several hours now.
2021-07-16 19704, 2021
rdswift has quit
2021-07-16 19754, 2021
rdswift joined the channel
2021-07-16 19735, 2021
ruaok
how can it be that we have waay better uptime than a well funded major railway?
2021-07-16 19737, 2021
ruaok
!m zas
2021-07-16 19737, 2021
BrainzBot
You're doing good work, zas!
2021-07-16 19745, 2021
yvanzo
DB’s website used to be my main reference to look for an itinerary for years: It was better than French rail’s website, even for French trains.
2021-07-16 19724, 2021
ruaok
still true for spanish trains. I find what I want to book, then book at renfe.
2021-07-16 19700, 2021
ruaok
at least the part that is broken is to buy discounted rail cards, the main ticketing site is working.
2021-07-16 19715, 2021
bitmap
reosarevok: I'd guess it'll time out for many requests unless we're careful about the number of tracks it can return info for. you can browse up to 100 releases in a single request - there are some individual releases we already struggle to make responses for
2021-07-16 19716, 2021
bitmap
thanks for reminding me about MBS-11311, I'll look at it today
2021-07-16 19716, 2021
BrainzBot
MBS-11311: Cache disallows seeing an Artist's list of releases until the cache refreshes if the artist was previously only used in VA releases https://tickets.metabrainz.org/browse/MBS-11311
2021-07-16 19708, 2021
bitmap
that's related to the query_to_list_limited caching I added way before the schema change, I think we can disable it now that the schema change is in place
2021-07-16 19721, 2021
bitmap
oh wait, we no longer use query_to_list_limited here either, it might've fixed itself
2021-07-16 19701, 2021
Clint_ is now known as Clint
2021-07-16 19743, 2021
reosarevok
bitmap: do we not limit the amount of returned stuff for each rel? I know there's a browse limit, after all, but not sure if that affects the linked entities too
2021-07-16 19709, 2021
bitmap
hmm. well, we have a limit on the number of recordings that we'll return relationships for: 500. so that should should apply to browse requests too
