#metabrainz

/

      • bitmap
        well you said some things probably shouldn't be reset every time

        • 2021-08-02 21443, 2021

      • bitmap
        to be fair resetContext did reset everything in the initial context object, just not all these things added from other files, right?

        • 2021-08-02 21408, 2021

      • reosarevok
        Yes

        • 2021-08-02 21424, 2021

      • reosarevok
        Well, not only other files

        • 2021-08-02 21429, 2021

      • reosarevok
        openBrackets is in this same file, for example

        • 2021-08-02 21435, 2021

      • reosarevok
        But yeah

        • 2021-08-02 21408, 2021

      • bitmap
        i think we should keep it as-is for now (maybe add a "it's unclear" comment to resetContext)

        • 2021-08-02 21421, 2021

      • bitmap
        and then later go through each prop and see if it needs to be in context

        • 2021-08-02 21446, 2021

      • reosarevok
        Ok

        • 2021-08-02 21409, 2021

      • reosarevok
        Yeah, my hope is to get this all typed, and then change stuff bit by bit when it seems off

        • 2021-08-02 21412, 2021

      • bitmap
        most of these we probably can safely reset though, I'm just not 100% sure

        • 2021-08-02 21430, 2021

      • reosarevok
        Which brings us to the

        • 2021-08-02 21432, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/j9m43N53/

        • 2021-08-02 21458, 2021

      • bitmap
        so those are for gc.i / gc.o?

        • 2021-08-02 21437, 2021

      • reosarevok
        And mode

        • 2021-08-02 21450, 2021

      • reosarevok
        Which I'd want to rename to gc.input and gc.output for clarity, btw, if that seems ok

        • 2021-08-02 21439, 2021

      • bitmap
        sure

        • 2021-08-02 21457, 2021

      • bitmap
        Input.js and Output.js are written weirdly -- to make adding Flow types easier, these should use `class` syntax

        • 2021-08-02 21432, 2021

      • bitmap
        which to be fair didn't exist when these were written

        • 2021-08-02 21407, 2021

      • reosarevok
        gc also has stuff like self.re and self.modeName

        • 2021-08-02 21411, 2021

      • reosarevok
        But we can type that later

        • 2021-08-02 21416, 2021

      • reosarevok
        I guess

        • 2021-08-02 21434, 2021

      • reosarevok
        self.re I'd rename to self.regexes at least

        • 2021-08-02 21438, 2021

      • bitmap
        but once these use class I don't think you need to define `GuessCaseInputT` etc. you'd just use the class name as the type

        • 2021-08-02 21411, 2021

      • bitmap
        makes sense

        • 2021-08-02 21444, 2021

      • reosarevok
        That's another object to which we add a ton of other regexes later after defining it in Main, of course

        • 2021-08-02 21410, 2021

      • reosarevok
        Also a bit confused about

        • 2021-08-02 21410, 2021

      • reosarevok
        CFG_UC_UPPERCASED

        • 2021-08-02 21432, 2021

      • reosarevok
        I guess "config... uppercase... uppercased"?

        • 2021-08-02 21406, 2021

      • reosarevok
        Given it's defined under

        • 2021-08-02 21414, 2021

      • reosarevok
        / Config

        • 2021-08-02 21414, 2021

      • reosarevok
        self.CFG_UC_UPPERCASED = getCookie('guesscase_keepuppercase') !== 'false';

        • 2021-08-02 21400, 2021

      • bitmap
        heh. CFG_KEEP_UPPERCASED seems more logical to me

        • 2021-08-02 21428, 2021

      • reosarevok
        I'll change it

        • 2021-08-02 21412, 2021

      • reosarevok
        So, do we have a good example of the class structure to copy?

        • 2021-08-02 21413, 2021

      • bitmap
        there are some in root/static/scripts/common/entity.js

        • 2021-08-02 21412, 2021

      • reosarevok
        Which is also not flow typed :p

        • 2021-08-02 21455, 2021

      • reosarevok
        static/scripts/work.js has a typed class at least

        • 2021-08-02 21415, 2021

      • bitmap
        heh

        • 2021-08-02 21442, 2021

      • bitmap
        yeah it should be the same other than declaring the member types above the constructor

        • 2021-08-02 21454, 2021

      • strider joined the channel

        • 2021-08-02 21439, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/ZVgAVIYx/

        • 2021-08-02 21443, 2021

      • reosarevok
        I love clear variable names

        • 2021-08-02 21442, 2021

      • reosarevok
        MB.GuessCase = MB.GuessCase ? MB.GuessCase : {};

        • 2021-08-02 21447, 2021

      • reosarevok
        It even starts clearly :D

        • 2021-08-02 21425, 2021

      • alastairp
        MB.GuessCase = MB.guesscase ? mb:gUessCasE : {}

        • 2021-08-02 21432, 2021

      • reosarevok
        :{

        • 2021-08-02 21436, 2021

      • reosarevok
        My thoughts exactly

        • 2021-08-02 21450, 2021

      • akashgp09 joined the channel

        • 2021-08-02 21458, 2021

      • reosarevok
        bitmap: how would this even start? Not sure how to turn MB.GuessCase.Input = function (gc) into a class

        • 2021-08-02 21414, 2021

      • reosarevok
        gc would be passed to the constructor instead or?

        • 2021-08-02 21455, 2021

      • reosarevok
        And in the end we'd do MB.GuessCase.Input = new GuessCaseInput(gc)?

        • 2021-08-02 21401, 2021

      • bitmap
        yeah, so gc would have to become member variable passed to ctor

        • 2021-08-02 21423, 2021

      • bitmap
        and s/self/this/ everywhere

        • 2021-08-02 21456, 2021

      • reosarevok
        And I guess var this = {}; does not need to be defined then

        • 2021-08-02 21456, 2021

      • bitmap
        the whole current '// Member variables' section would just be the constructor + assigning this.gc = gc;

        • 2021-08-02 21409, 2021

      • bitmap
        right

        • 2021-08-02 21433, 2021

      • bitmap
        you can assume 'this' refers to a new instance in the constructor

        • 2021-08-02 21416, 2021

      • reosarevok
        heh

        • 2021-08-02 21424, 2021

      • reosarevok
        I'm checking the timeline class, which first of all does

        • 2021-08-02 21425, 2021

      • reosarevok
        var self = this;

        • 2021-08-02 21443, 2021

      • reosarevok
        Is there any benefit to that I'm missing?

        • 2021-08-02 21417, 2021

      • bitmap
        well, that was written before arrow functions were available I guess

        • 2021-08-02 21419, 2021

      • reosarevok
        And I guess gc would be passed to the constructor and then stored as this.gc too, then

        • 2021-08-02 21436, 2021

      • reosarevok
        (yet another clearly named variable)

        • 2021-08-02 21438, 2021

      • bitmap
        so you needed to assign 'this' to a variable to access it from the closure

        • 2021-08-02 21443, 2021

      • reosarevok
        this.yacnv

        • 2021-08-02 21442, 2021

      • reosarevok
        And stuff like

        • 2021-08-02 21445, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/tTqRickJ/

        • 2021-08-02 21400, 2021

      • reosarevok
        Would become

        • 2021-08-02 21402, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/DKt3mCs8/

        • 2021-08-02 21403, 2021

      • reosarevok
        ?

        • 2021-08-02 21408, 2021

      • reosarevok
        (outside the constructor)

        • 2021-08-02 21424, 2021

      • bitmap
        yup

        • 2021-08-02 21432, 2021

      • reosarevok
        (oh, at least now it's clear what _l is

        • 2021-08-02 21433, 2021

      • reosarevok
        )

        • 2021-08-02 21439, 2021

      • bitmap
        I don't think you need the ; after the } though (or it might be a syntax error even)

        • 2021-08-02 21403, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/TK2xekpy/

        • 2021-08-02 21410, 2021

      • reosarevok
        so I assume wi is meant to be... word index?

        • 2021-08-02 21438, 2021

      • bitmap
        no idea, but that's a good guess

        • 2021-08-02 21458, 2021

      • reosarevok
        Or maybe "working index"...

        • 2021-08-02 21426, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/1mdFIRUN/

        • 2021-08-02 21429, 2021

      • reosarevok
        word it is

        • 2021-08-02 21442, 2021

      • reosarevok
        should this be this.wordIndex or this._wordIndex?

        • 2021-08-02 21438, 2021

      • bitmap
        the former is probably fine

        • 2021-08-02 21409, 2021

      • reosarevok
        https://www.irccloud.com/pastebin/NIE0GGvB/

        • 2021-08-02 21416, 2021

      • reosarevok
        I'm going to guess the first comment is wrong :p

        • 2021-08-02 21455, 2021

      • ritiek joined the channel

        • 2021-08-02 21413, 2021

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #1571 (03master…monkey-sanitize-websockets-front-end): Sanitize inputs from websocket messages used in anchor tags https://github.com/metabrainz/listenbrainz-server…

        • 2021-08-02 21421, 2021

      • bitmap
        seems so :P

        • 2021-08-02 21442, 2021

      • bitmap
        though it basically just repeats the function name anyway

        • 2021-08-02 21425, 2021

      • reosarevok
        Yeah, I might drop those

        • 2021-08-02 21408, 2021

      • Freso
        <BANG>

        • 2021-08-02 21408, 2021

      • Freso
        It’s World Breastfeeding Week Monday!

        • 2021-08-02 21408, 2021

      • Freso
        https://www.youtube.com/watch?v=ViYPKzDwwF0

        • 2021-08-02 21408, 2021

      • Freso
        I have received one mailed-in review, so:

        • 2021-08-02 21408, 2021

      • Freso
        yyoung says…

        • 2021-08-02 21409, 2021

      • Freso
        """

        • 2021-08-02 21409, 2021

      • Freso
        - I rebased my PR #2114 on PR #2151, refactored ExternalLinksEditor a little bit, fixed tests and bugs.

        • 2021-08-02 21410, 2021

      • Freso
        - Continued to implement MBS-9902, added a feature to limit possible type options and support of custom auto-select function.

        • 2021-08-02 21410, 2021

      • Freso
        - Looked into backend code related to MBS-3774.

        • 2021-08-02 21411, 2021

      • BrainzBot
        MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links https://tickets.metabrainz.org/browse/MBS-9902

        • 2021-08-02 21411, 2021

      • BrainzBot
        MBS-3774: Add URL relationship with begin and end dates https://tickets.metabrainz.org/browse/MBS-3774

        • 2021-08-02 21412, 2021

      • Freso
        - (Also regular editing on MB, more and more questions and confusion are coming up... :)

        • 2021-08-02 21413, 2021

      • Freso
        - That's all, thank you.

        • 2021-08-02 21413, 2021

      • Freso
        """

        • 2021-08-02 21413, 2021

      • Freso
        Others up for reviews: monkey, yvanzo, lucifer, alastairp, ruaok, reosarevok, bitmap, zas, Freso, akshaaatt, jasondk, ritiek, akashgp09, CatQuest – let me know if _you_ wish to give review too! :)

        • 2021-08-02 21413, 2021

      • Freso
        monkey: Go!

        • 2021-08-02 21424, 2021

      • monkey
        Hello !

        • 2021-08-02 21443, 2021

      • reosarevok
        yyoung: when you're around: don't hesitate to ask about editing questions in #musicbrainz :)

        • 2021-08-02 21448, 2021

      • monkey
        Last week I worked with akashgp09 on some details of the GSoC project

        • 2021-08-02 21403, 2021

      • monkey
        And also worked on more improvements to the ListenBrainz player

        • 2021-08-02 21419, 2021

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #1572 (03master…monkey-play-icon-button): Play icon button on listens https://github.com/metabrainz/listenbrainz-server…

        • 2021-08-02 21420, 2021

      • monkey
        Like this one

        • 2021-08-02 21443, 2021

      • ruaok
        well done. nice theatrics!

        • 2021-08-02 21445, 2021

      • monkey
        And that's about me for last week! I'll be mostly off comms in August but can be reached if need be !

        • 2021-08-02 21455, 2021

      • monkey
        lucifer: Go !

        • 2021-08-02 21412, 2021

      • lucifer
        hi all!

        • 2021-08-02 21414, 2021

      • lucifer
        I worked on migrating some more spark stuff to use new dumps. I also reviewed some MB Android PRs and did a new release of the app.

        • 2021-08-02 21415, 2021

      • lucifer
        I also worked on using CB Oauth in LB needed for jasondk's project. Then the release last week did not go as planned so did some TS writer hotfixes.

        • 2021-08-02 21424, 2021

      • lucifer
        that's it for me.

        • 2021-08-02 21427, 2021

      • lucifer
        ruaok: next?

        • 2021-08-02 21433, 2021

      • ruaok
        k

        • 2021-08-02 21448, 2021

      • ruaok
        vacation. fin. :)

        • 2021-08-02 21452, 2021

      • ruaok
        zas: go

        • 2021-08-02 21429, 2021

      • Freso
        Hm.

        • 2021-08-02 21434, 2021

      • Freso
        Or… yvanzo, maybe?

        • 2021-08-02 21442, 2021

      • yvanzo
        Hi!

        • 2021-08-02 21411, 2021

      • yvanzo
        Last week, I kept working on search indexer mostly.

        • 2021-08-02 21423, 2021

      • zas
        I'm here (but too slow to react), I'll go after yvanzo

        • 2021-08-02 21444, 2021

      • alastairp
        vue is much faster than react

        • 2021-08-02 21403, 2021

      • yvanzo
        Read the comments to yyoung’s project and continued helping him with the next steps.

        • 2021-08-02 21409, 2021

      • monkey
        Has it got a bigger angular momentum?

        • 2021-08-02 21438, 2021

      • zas
        ;)

        • 2021-08-02 21403, 2021

      • yvanzo
        alastairp: still slower than wasm I guess

        • 2021-08-02 21420, 2021

      • yvanzo
        Last, made progress towards running Selenium tests with MB Docker development setup.

        • 2021-08-02 21427, 2021

      • yvanzo
        Fin, go zas!

        • 2021-08-02 21431, 2021

      • zas
        Last week, I did usual server maintenance, blocked user support, upgrades, and supervision

        • 2021-08-02 21401, 2021

      • zas
        also worked on Picard, mainly code reviews, tests & feedback

        • 2021-08-02 21425, 2021

      • zas
        we finalized the move from williams to aretha

        • 2021-08-02 21454, 2021

      • zas
        and got a new server today (in place of williams): patton

        • 2021-08-02 21417, 2021

      • zas
        it is now up & running

        • 2021-08-02 21424, 2021

      • zas
        fin. bitmap ?

        • 2021-08-02 21429, 2021

      • yvanzo
        zas: it's olympics of server switching? ;)

        • 2021-08-02 21438, 2021

      • bitmap
        hey

        • 2021-08-02 21441, 2021

      • Freso
        (Others still up: alastairp, reosarevok, Freso, akshaaatt, jasondk, ritiek, akashgp09, CatQuest – let me know if _you_ wish to give review too! :))

        • 2021-08-02 21449, 2021

      • alastairp
        patton makes me think of general patton

        • 2021-08-02 21456, 2021

      • zas
        yvanzo: yup :)

        • 2021-08-02 21419, 2021

      • bitmap
        last week I worked more on porting the release relationship editor code from knockout, working on the batch-editing tools (creating works) and data submission

        • 2021-08-02 21438, 2021

      • bitmap
        fighting a lot with "state management" code right now...