#metabrainz

well you said some things probably shouldn't be reset every time

to be fair resetContext did reset everything in the initial context object, just not all these things added from other files, right?

Yes

Well, not only other files

openBrackets is in this same file, for example

But yeah

i think we should keep it as-is for now (maybe add a "it's unclear" comment to resetContext)

and then later go through each prop and see if it needs to be in context

Ok

Yeah, my hope is to get this all typed, and then change stuff bit by bit when it seems off

most of these we probably can safely reset though, I'm just not 100% sure

Which brings us to the

so those are for gc.i / gc.o?

And mode

Which I'd want to rename to gc.input and gc.output for clarity, btw, if that seems ok

sure

Input.js and Output.js are written weirdly -- to make adding Flow types easier, these should use `class` syntax

which to be fair didn't exist when these were written

gc also has stuff like self.re and self.modeName

But we can type that later

I guess

self.re I'd rename to self.regexes at least

but once these use class I don't think you need to define `GuessCaseInputT` etc. you'd just use the class name as the type

makes sense

Also a bit confused about

CFG_UC_UPPERCASED

I guess "config... uppercase... uppercased"?

Given it's defined under

/ Config

self.CFG_UC_UPPERCASED = getCookie('guesscase_keepuppercase') !== 'false';

heh. CFG_KEEP_UPPERCASED seems more logical to me

I'll change it

So, do we have a good example of the class structure to copy?

there are some in root/static/scripts/common/entity.js

Which is also not flow typed :p

static/scripts/work.js has a typed class at least

heh

yeah it should be the same other than declaring the member types above the constructor

I love clear variable names

MB.GuessCase = MB.GuessCase ? MB.GuessCase : {};

It even starts clearly :D

MB.GuessCase = MB.guesscase ? mb:gUessCasE : {}

:{

My thoughts exactly

bitmap: how would this even start? Not sure how to turn MB.GuessCase.Input = function (gc) into a class

gc would be passed to the constructor instead or?

And in the end we'd do MB.GuessCase.Input = new GuessCaseInput(gc)?

yeah, so gc would have to become member variable passed to ctor

and s/self/this/ everywhere

And I guess var this = {}; does not need to be defined then

the whole current '// Member variables' section would just be the constructor + assigning this.gc = gc;

right

you can assume 'this' refers to a new instance in the constructor

heh

I'm checking the timeline class, which first of all does

var self = this;

Is there any benefit to that I'm missing?

well, that was written before arrow functions were available I guess

And I guess gc would be passed to the constructor and then stored as this.gc too, then

(yet another clearly named variable)

so you needed to assign 'this' to a variable to access it from the closure

this.yacnv

And stuff like

Would become

?

(outside the constructor)

yup

(oh, at least now it's clear what _l is

)

I don't think you need the ; after the } though (or it might be a syntax error even)

so I assume wi is meant to be... word index?

no idea, but that's a good guess

Or maybe "working index"...

word it is

should this be this.wordIndex or this._wordIndex?

the former is probably fine

I'm going to guess the first comment is wrong :p

[listenbrainz-server] 14MonkeyDo merged pull request #1571 (03master…monkey-sanitize-websockets-front-end): Sanitize inputs from websocket messages used in anchor tags https://github.com/metabrainz/listenbrainz-serv...

seems so :P

though it basically just repeats the function name anyway

Yeah, I might drop those

<BANG>

It’s World Breastfeeding Week Monday!

I have received one mailed-in review, so:

yyoung says…

"""

- I rebased my PR #2114 on PR #2151, refactored ExternalLinksEditor a little bit, fixed tests and bugs.

- Continued to implement MBS-9902, added a feature to limit possible type options and support of custom auto-select function.

- Looked into backend code related to MBS-3774.

MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links https://tickets.metabrainz.org/browse/MBS-9902

MBS-3774: Add URL relationship with begin and end dates https://tickets.metabrainz.org/browse/MBS-3774

- (Also regular editing on MB, more and more questions and confusion are coming up... :)

- That's all, thank you.

"""

Others up for reviews: monkey, yvanzo, lucifer, alastairp, ruaok, reosarevok, bitmap, zas, Freso, akshaaatt, jasondk, ritiek, akashgp09, CatQuest – let me know if _you_ wish to give review too! :)

monkey: Go!

Hello !

yyoung: when you're around: don't hesitate to ask about editing questions in #musicbrainz :)

Last week I worked with akashgp09 on some details of the GSoC project

And also worked on more improvements to the ListenBrainz player

[listenbrainz-server] 14MonkeyDo opened pull request #1572 (03master…monkey-play-icon-button): Play icon button on listens https://github.com/metabrainz/listenbrainz-serv...

Like this one

well done. nice theatrics!

And that's about me for last week! I'll be mostly off comms in August but can be reached if need be !

lucifer: Go !

hi all!

I worked on migrating some more spark stuff to use new dumps. I also reviewed some MB Android PRs and did a new release of the app.

I also worked on using CB Oauth in LB needed for jasondk's project. Then the release last week did not go as planned so did some TS writer hotfixes.

that's it for me.

ruaok: next?

k

vacation. fin. :)

zas: go

Hm.

Or… yvanzo, maybe?

Hi!

Last week, I kept working on search indexer mostly.

I'm here (but too slow to react), I'll go after yvanzo

vue is much faster than react

Read the comments to yyoung’s project and continued helping him with the next steps.

Has it got a bigger angular momentum?

;)

alastairp: still slower than wasm I guess

Last, made progress towards running Selenium tests with MB Docker development setup.

Fin, go zas!

Last week, I did usual server maintenance, blocked user support, upgrades, and supervision

also worked on Picard, mainly code reviews, tests & feedback

we finalized the move from williams to aretha

and got a new server today (in place of williams): patton

it is now up & running

fin. bitmap ?

zas: it's olympics of server switching? ;)

hey

(Others still up: alastairp, reosarevok, Freso, akshaaatt, jasondk, ritiek, akashgp09, CatQuest – let me know if _you_ wish to give review too! :))

patton makes me think of general patton

yvanzo: yup :)

last week I worked more on porting the release relationship editor code from knockout, working on the batch-editing tools (creating works) and data submission

fighting a lot with "state management" code right now...