(that's from your recent fix and it works nicely I think, but flow doesn't like it)
2021-08-17 22914, 2021
BrainzGit
[musicbrainz-server] 14reosarevok opened pull request #2220 (03master…guess-case-refactoring-part-2): MBS-11805 (II): More guess case refactoring and flow types https://github.com/metabrainz/musicbrainz-server/…
2021-08-17 22931, 2021
reosarevok
Pushed the branch in case you want to play with it ^
2021-08-17 22916, 2021
yyoung[m]
yvanzo: Good morning! I've finished most of MBS-3774 implementation, rebased MBS-9902 and roughly finished refactoring, now testing.
I'm thinking whether we can remove the 'Type:' label, because text will overflow when relationship name is too long, since we have date period next to it; or we may display date period in the next line.
2021-08-17 22956, 2021
yvanzo
yyoung[m]: Using 'display' attribute (inline-block or something) should keep it on the same line if possible, and automatically move it to the next line if needed.
2021-08-17 22955, 2021
yvanzo
Good job with opening PR for begin/end date :)
2021-08-17 22957, 2021
yyoung[m]
yvanzo: Yes that's what it already is, but auto wrap doesn't look good to me.
2021-08-17 22904, 2021
yyoung[m] uploaded an image: (23KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/IRTZkRiMLLCFgdudMxtwlTus/image.png >
2021-08-17 22910, 2021
yvanzo
There should be a way to prevent breaking lines in the middle of dates.
2021-08-17 22901, 2021
yyoung[m] uploaded an image: (23KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/NUHySqUGoZfEzvEWpAzfPbVK/image.png >
2021-08-17 22908, 2021
yyoung[m]
OK so here is 'white-space: nowrap' ^
2021-08-17 22911, 2021
yyoung[m]
Looks good now, thank you.
2021-08-17 22943, 2021
yvanzo
Should work here since column’s width here is much larger than date range. :)
2021-08-17 22933, 2021
yvanzo
(Otherwise we would need a React version of formatUserDate)
2021-08-17 22904, 2021
yyoung[m]
What do you mean?
2021-08-17 22933, 2021
yvanzo
If we wanted the line break to occur in between begin date and end date (which is not what we want because of column’s width is large enough for a date range), we would need formatUserDate to include HTML tags (as React elements).
2021-08-17 22909, 2021
yyoung[m]
So is the image above the intentional effect?
2021-08-17 22926, 2021
yvanzo
Yes :)
2021-08-17 22948, 2021
yyoung[m]
OK then :)
2021-08-17 22955, 2021
yvanzo
That was not my initial thought, but it’s much better actually. :)
2021-08-17 22944, 2021
yyoung[m]
Same to me :)
2021-08-17 22918, 2021
yvanzo
reosarevok: I spotted a few issues with localization messages, do you have time to discuss them?
2021-08-17 22919, 2021
yyoung[m]
It's nice that we don't need another row or grid layout
2021-08-17 22948, 2021
ruaok
mooooooin!
2021-08-17 22929, 2021
Toasty joined the channel
2021-08-17 22957, 2021
reosarevok
yvanzo: sure
2021-08-17 22908, 2021
yvanzo
reosarevok: Ok, I did not translate server resources for a few releases.
2021-08-17 22929, 2021
yvanzo
First issue is with added curly quotes in root/search/error/General.js
2021-08-17 22902, 2021
yvanzo
It seems it has the same role as existing parenthesis.
In most cases it doesn't matter, really, but since we prefer the unicode punctuation on titles and names, it makes sense to try to use it elsewhere too
2021-08-17 22912, 2021
reosarevok
(we aren't super consistent with it rn)
2021-08-17 22919, 2021
yyoung[m]
Yes I ran into that days before and did some research :)
2021-08-17 22924, 2021
yvanzo
reosarevok: Yes, other one is “Cleaned up to”. When reading it as a translator, it seemed weird, probably not clear enough.
2021-08-17 22912, 2021
yyoung[m]
But curly quotes will cause problems under certain font, since it's wider
2021-08-17 22913, 2021
yvanzo
Many people got confused with “raw”, “clean”, “old”, “new” URLs.
2021-08-17 22915, 2021
reosarevok
Hmm. Not sure what would be better. Original: vs Cleaned up version:? But it's still not too obvious for translators, so maybe specify a context
2021-08-17 22944, 2021
yvanzo
It looks like these terms are not self-explanatory and were originally used in code (where there is a context).
2021-08-17 22916, 2021
yyoung[m]
+1 For translator problems, some expressions just don't make sense in other languages
2021-08-17 22943, 2021
yvanzo
This “clean-up” is actually formatting/normalizing URLs. Would that be more telling to non-coders? (Or the opposite? :/ )
2021-08-17 22952, 2021
reosarevok
yvanzo: is "processed" better? Or "normalized", yeah
2021-08-17 22927, 2021
yvanzo
“processed” doesn’t explain the goal of the process
2021-08-17 22942, 2021
CatQuest
yvanzo: yyoung[m]: actually I still think it would be beneficiary if the box didn't turn into a link but insteadstayed a box. then the pencilbox or whatever with he "pasted" and "normalised" could both be links/text instead
2021-08-17 22942, 2021
CatQuest
that's consistent with how it already works and doesn't break workflow that depends on pasting from two sources (eg how i do instrument statickbrainz image links)
2021-08-17 22902, 2021
CatQuest
furtherore i invite you to try this aproach and to ask users wich they prefer
2021-08-17 22900, 2021
yyoung[m]
CatQuest: Do you mean the raw URL is displayed as link in the popover instead of the editor?
2021-08-17 22914, 2021
CatQuest
yyoung[m]: Yes indeed!
2021-08-17 22900, 2021
yyoung[m]
Our main concerns about this before are related to highlights
CatQuest: Please be more specific about how it does “break workflow”.
2021-08-17 22946, 2021
CatQuest
because I do this by copying the first part from a text/stick and the second part (the one that varies) from typed text to reosarevok
2021-08-17 22918, 2021
CatQuest
so i'll have to click pencils every time instead
2021-08-17 22928, 2021
CatQuest
as a result i'm using prod right now
2021-08-17 22931, 2021
yyoung[m]
CatQuest: I'm sorry about the icons in your browser, I can't reproduce that here, I'll try Firefox some day
2021-08-17 22936, 2021
yvanzo
First part? second part?
2021-08-17 22948, 2021
CatQuest
of the url
2021-08-17 22955, 2021
yvanzo
Please give all the details.
2021-08-17 22903, 2021
yyoung[m]
It would be great if you can provide some details, e.g. using element inspector
2021-08-17 22908, 2021
CatQuest
what?
2021-08-17 22915, 2021
yvanzo
No need of element inspector
2021-08-17 22921, 2021
yvanzo
Bring a full example please.
2021-08-17 22942, 2021
yyoung[m]
yvanzo: IIUC he means he'll paste all the links of the same site, and change the path later
2021-08-17 22954, 2021
CatQuest
look I've been trying to be constructive here but you're bulldozing your way. this "nitpick" thing is osmething you're doing in order totake up my time and i orker ikke. talk to reosarevok
2021-08-17 22957, 2021
yyoung[m]
And I was talking about the display issues :)
2021-08-17 22902, 2021
yvanzo
yyoung[m]: I understood that, but we need a full example to reproduce the issue.
2021-08-17 22905, 2021
CatQuest
yyoung[m]: forget the dispaly issues
2021-08-17 22918, 2021
CatQuest
and yyoung[m] is right
2021-08-17 22926, 2021
yvanzo
Asking for example is not nitpicking.
2021-08-17 22957, 2021
CatQuest
i copy one part of the static url https://staticbrainz.org/irombook/ for ma stick or text box and the variable (for example bullhorn/bullhorn.png) from text pasted to reosarevok
2021-08-17 22915, 2021
CatQuest
so i am sure i use the exact name i uploads it in
2021-08-17 22902, 2021
CatQuest
he uploads it as*
2021-08-17 22908, 2021
yvanzo
reosarevok: would it be easy for you to pass the full URL to CatQuest instead?
2021-08-17 22934, 2021
CatQuest
I fukcing knew that your responce woudl be "do it differntly" I've ha enough of this
2021-08-17 22938, 2021
CatQuest has left the channel
2021-08-17 22951, 2021
yvanzo
reosarevok, yyoung[m]: Do you want to pause now?
2021-08-17 22911, 2021
reosarevok
I wasn't actively doing anything so I don't need to pause it, but :)
2021-08-17 22922, 2021
yyoung[m]
Pause what? :)
2021-08-17 22900, 2021
reosarevok
Anyway, I'm not copying the URLs to catcat. He's telling me "upload this file as x/x.png", then he copies the string he told me to his link
The idea being, IIRC, that then the URL can be added even before staticbrainz has started serving it and it will just work as soon as it's ready
2021-08-17 22909, 2021
CatQuest joined the channel
2021-08-17 22910, 2021
CatQuest
look the reason it doesn't work for him to "pass me the full url" is because i edit or add the instrument at the same tyme i type the "upload the image as " text to reosarevok, and he is not always there, sometimes he is absent and then uploads that image hours from then
2021-08-17 22948, 2021
reosarevok
To be fair, I *could* just link the images myself once they are added if that's the main issue :)
2021-08-17 22917, 2021
CatQuest
the main issue is that a text box tunring into a lin kis unintuitive, uneccasary and annoying
2021-08-17 22911, 2021
reosarevok
Right now I kind of agree with that, I do want to see how I feel once the whole thing is put together though, with highlights and all. Rn I'd still prefer the text box myself, but I'm giving it a chance
2021-08-17 22939, 2021
Freso
yvanzo: I could follow CatQuest’s example. Please try and take a step back and re-read what was said to try and understand. If there's a specific part you don’t understand, ask for clarification about that. "Bring a full example please." is vague as it was already provided.
2021-08-17 22908, 2021
yvanzo
Freso: Getting stressed like that is not a way to engage a constructive conversation.
2021-08-17 22913, 2021
reosarevok
So if in the meantime it helps, I can put those image links up myself :) If we figure out the link thing is still not really working once the whole tool is finished, then we can also change that post gsoc, since it's not set in stone
2021-08-17 22917, 2021
yvanzo
(Not you of course)
2021-08-17 22944, 2021
CatQuest
the thing is that you aren't really gettig who is the casue of my stress! :
2021-08-17 22946, 2021
yvanzo
We had another conversation when CatQuest hijacked it.
2021-08-17 22954, 2021
CatQuest
:|
2021-08-17 22906, 2021
CatQuest
well excuuse me for "hijacking" 🙄
2021-08-17 22928, 2021
reosarevok
CatQuest: please try to relax, even if this is annoying
2021-08-17 22936, 2021
CatQuest
*this* kind of attitude is the reason im stressed
2021-08-17 22936, 2021
Freso
CatQuest: yvanzo and yyoung[m] are trying to improve the workflow. Sometimes this means having to adapt to a new workflow. If it turns out new workflow is worse than the previous one, then it can be reverted. But a change of workflow is not necessarily bad. Please remember to treat yvanzo and others as them being in good faith. https://xkcd.com/1172/
2021-08-17 22941, 2021
reosarevok
yvanzo: please try to understand that changes that break people's workflow *will* annoy them :)
2021-08-17 22952, 2021
CatQuest
Freso: I have been?
2021-08-17 22959, 2021
CatQuest
but see above
2021-08-17 22911, 2021
CatQuest
I'm accused of higjacking and "typing to much"
2021-08-17 22930, 2021
CatQuest
Freso: remember you wheren't her for the first conversation we had
2021-08-17 22930, 2021
yvanzo
Freso: I just asked for clarifications, tried to resolve the issue, and received a "fucking" rage-quit in response.
2021-08-17 22944, 2021
CatQuest
yea I'm sorry about that. I'm having other problems
2021-08-17 22954, 2021
yvanzo
"blub"?
2021-08-17 22955, 2021
CatQuest
i'm also really nevous about talking liek this
2021-08-17 22902, 2021
Freso
yvanzo: If you feel like CatQuest’s comments are not relevant to what you’re currently discussing, tell them you’ll come back to them later, but you’re currently trying to do something else.
2021-08-17 22902, 2021
yvanzo
So don’t
2021-08-17 22922, 2021
yvanzo
I already suggested you to not talk like this, but rather make a summary.
