#metabrainz

/

      • ruaok goes to add caching to that big ass WS response
      • 2021-10-13 28619, 2021

      • ruaok
      • 2021-10-13 28622, 2021

      • akshat
        Hi ruaok!
      • 2021-10-13 28630, 2021

      • akshat
        I had to take a nap haha
      • 2021-10-13 28632, 2021

      • ruaok
        hi!
      • 2021-10-13 28641, 2021

      • ruaok
        smart man. :)
      • 2021-10-13 28649, 2021

      • akshat
        Please continue with what you had to say
      • 2021-10-13 28601, 2021

      • ruaok hopes lucifer is about
      • 2021-10-13 28614, 2021

      • lucifer
        yes i am.
      • 2021-10-13 28614, 2021

      • ruaok
        so, monkey is currently taking a stab at the colorwheel.
      • 2021-10-13 28635, 2021

      • ruaok
        I've added more metadata to the API call so that we can add tracklist
      • 2021-10-13 28641, 2021

      • ruaok
      • 2021-10-13 28641, 2021

      • monkey
        🔪
      • 2021-10-13 28658, 2021

      • ruaok
        click on an album. this gives us more control over playing the album tracks.
      • 2021-10-13 28601, 2021

      • ruaok
        akshat: if you have more time to work on this, I would like to add/improve a few things
      • 2021-10-13 28609, 2021

      • akshat
        Sure
      • 2021-10-13 28616, 2021

      • ruaok
        1. make the grid responsive, so that it fills the available space.
      • 2021-10-13 28647, 2021

      • ruaok
        2. when you click on an album, it would be nice to have an indicator that that album is selected.
      • 2021-10-13 28616, 2021

      • ruaok
        3. each album should have a hover play icon, letting users know they need to click on order to play.
      • 2021-10-13 28629, 2021

      • akshat
        For 2 we could have a sorta blur effect on others
      • 2021-10-13 28636, 2021

      • akshat
        3 sounds good
      • 2021-10-13 28600, 2021

      • ruaok
        and for ease of workflow, I think it would be best if we could start playing the tracks right when the album is clicked.
      • 2021-10-13 28611, 2021

      • ruaok
        interesting on 2 -- I'd be curious to see that.
      • 2021-10-13 28616, 2021

      • akshat
        Alright
      • 2021-10-13 28627, 2021

      • monkey
        >I think it would be best if we could start playing the tracks right when the album is clicked
      • 2021-10-13 28628, 2021

      • monkey
        That's done already
      • 2021-10-13 28651, 2021

      • ruaok
        monkey: thanks. I should add the YT api key to my setup. then that will work.
      • 2021-10-13 28656, 2021

      • monkey
        That too
      • 2021-10-13 28607, 2021

      • lucifer
        ruaok: i have one at hand if you want.
      • 2021-10-13 28616, 2021

      • lucifer
        generated yesterday for this task
      • 2021-10-13 28625, 2021

      • monkey
        Another thing: currently clicking on an album returns the tracks for another album by another artist. Is that expected (i.e. mock data) ?
      • 2021-10-13 28631, 2021

      • ruaok
        lucifer: thanks. should I just copy it from your account?
      • 2021-10-13 28637, 2021

      • lucifer
        yup sure
      • 2021-10-13 28641, 2021

      • ruaok
        thx
      • 2021-10-13 28603, 2021

      • ruaok
        monkey: no not at all.
      • 2021-10-13 28609, 2021

      • lucifer
        its at /home/lucifer/releases/listenbrainz-server/listenbrainz/config.py
      • 2021-10-13 28638, 2021

      • lucifer
        (i have two clones of LB, hence mentioning full path)
      • 2021-10-13 28643, 2021

      • monkey
      • 2021-10-13 28655, 2021

      • monkey
        recordings don't match the album
      • 2021-10-13 28615, 2021

      • ruaok
        thats a bit embarrasing, lol.
      • 2021-10-13 28618, 2021

      • ruaok
        on it.
      • 2021-10-13 28637, 2021

      • monkey
        Although it looks like the recordings are from another album matched by the same query, so probably a simple off-by-one error
      • 2021-10-13 28656, 2021

      • ruaok
        woo, nice. YT installed, playing right away. so cool!
      • 2021-10-13 28657, 2021

      • ruaok
        monkey: will fix soon
      • 2021-10-13 28608, 2021

      • monkey
        👍
      • 2021-10-13 28610, 2021

      • lucifer
        ruaok: any work for me to do?
      • 2021-10-13 28625, 2021

      • peterhil joined the channel
      • 2021-10-13 28606, 2021

      • ruaok
        not that I can think of right now. I have a lot of backend work to do to improve the script to keep things in sync, but I won't get to that until tomorrow.
      • 2021-10-13 28631, 2021

      • ruaok
        but, thanks for being the usual rock-start for getting us so far!
      • 2021-10-13 28637, 2021

      • ruaok
        *star
      • 2021-10-13 28651, 2021

      • lucifer
        cool, let me know if something else comes up. yeah, i see some cleanup can be done but probably best to wait till things finalize.
      • 2021-10-13 28602, 2021

      • ruaok
        👍
      • 2021-10-13 28638, 2021

      • ruaok
      • 2021-10-13 28653, 2021

      • ruaok
        monkey: the server keeps crashing with this since the last pull
      • 2021-10-13 28600, 2021

      • monkey
        Lemme look at that
      • 2021-10-13 28634, 2021

      • ruaok
        should I go fetch some noms or do you want to go out, monkey ?
      • 2021-10-13 28606, 2021

      • monkey
        We could get something here
      • 2021-10-13 28616, 2021

      • monkey
        A little faster, innit?
      • 2021-10-13 28627, 2021

      • ruaok
        eggactly.
      • 2021-10-13 28636, 2021

      • ruaok
        pizza from the close place ok?
      • 2021-10-13 28658, 2021

      • monkey
        Okidoke
      • 2021-10-13 28619, 2021

      • ruaok
        which one or should I just grab two random ones?
      • 2021-10-13 28628, 2021

      • monkey
        I guess a diavola for me, please
      • 2021-10-13 28632, 2021

      • ruaok
        k
      • 2021-10-13 28657, 2021

      • akshat
        ruaok monkey I have my container up on bono
      • 2021-10-13 28607, 2021

      • akshat
        It shows a type error upon selecting a color
      • 2021-10-13 28616, 2021

      • akshat
        Any quick fixes regarding that?
      • 2021-10-13 28613, 2021

      • ruaok
        No. monkey is working on that.
      • 2021-10-13 28624, 2021

      • akshat
        Thanks
      • 2021-10-13 28636, 2021

      • monkey
        Not sure that's the same issue
      • 2021-10-13 28635, 2021

      • monkey
        Confirming not the same issue
      • 2021-10-13 28600, 2021

      • monkey
        This is in the UI once loaded, fetching from the API endpoint doesn't seem to work
      • 2021-10-13 28644, 2021

      • monkey
        akshat: I think the API URL is misconfigured in you config.py, currently it's pointing to `https://api.listenbrainz.org/1/color/…` which doesn't exist
      • 2021-10-13 28626, 2021

      • akshat
        monkey what should it be configured as?
      • 2021-10-13 28643, 2021

      • lucifer
        akshat: try `http://bono.metabrainz.org:8081/`
      • 2021-10-13 28635, 2021

      • ruaok
        floating IPs are going from 1eur to 3eur a month, zas. time to move to another provider. 😡
      • 2021-10-13 28643, 2021

      • ruaok
        🤣
      • 2021-10-13 28627, 2021

      • zas
        :)
      • 2021-10-13 28646, 2021

      • Rotab
        💸
      • 2021-10-13 28603, 2021

      • alastairp
        shortage of ipv4 address? what shortage?
      • 2021-10-13 28622, 2021

      • ruaok
        lucifer: I need to update the meb.org site -- what do I need to do in order to avoid the cert issues? use a new docker-base image?
      • 2021-10-13 28616, 2021

      • lucifer
      • 2021-10-13 28611, 2021

      • lucifer
        or alternatively, yes use a new docker base image but we don't have one yet.
      • 2021-10-13 28652, 2021

      • ruaok
        ok
      • 2021-10-13 28656, 2021

      • alastairp
        lucifer: we do infact have a new base image - https://github.com/metabrainz/docker-python/pull/… `metabrainz/python:3.9-focal-20211007`, but we've not tested it in detail
      • 2021-10-13 28636, 2021

      • lucifer
        right, thats what i meant we dont have a newer image yet.
      • 2021-10-13 28617, 2021

      • alastairp
        yeah, unmerged PR, isn't really ready for prime time :)
      • 2021-10-13 28617, 2021

      • opal has quit
      • 2021-10-13 28634, 2021

      • opal joined the channel
      • 2021-10-13 28616, 2021

      • ruaok
        monkey: any news on that webpack issue?
      • 2021-10-13 28654, 2021

      • monkey
        I couldn't reproduce locally, it's gotta be due to available memory one way or another. Let me push what I think could be a fix
      • 2021-10-13 28609, 2021

      • ruaok
        k
      • 2021-10-13 28654, 2021

      • monkey
        Pushed. You're gonna have to rebuilt static_builder
      • 2021-10-13 28625, 2021

      • ruaok
        k
      • 2021-10-13 28659, 2021

      • ruaok
        works again, thanks!
      • 2021-10-13 28632, 2021

      • ruaok
        the data returned from end endpoint is still a hash, but hey.
      • 2021-10-13 28646, 2021

      • monkey
        lucifer: I ended up stealing and adapting the code from the react-colour-wheel library, because it was just too much of a headache to get it to compile properly.
      • 2021-10-13 28628, 2021

      • monkey
        Basically it didn't like that there was some JSX (`<canvas…`) in a file with .js extension
      • 2021-10-13 28600, 2021

      • monkey
        Oh, i'm getting this SQL error now when I run the colorplay PR:
      • 2021-10-13 28602, 2021

      • monkey
        sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) could not translate host name "db" to address: Name or service not known
      • 2021-10-13 28607, 2021

      • monkey
        Do I need to change anything?
      • 2021-10-13 28615, 2021

      • ruaok
        yes
      • 2021-10-13 28620, 2021

      • ruaok
        in config.py...
      • 2021-10-13 28654, 2021

      • ruaok
        SQLALCHEMY_DATABASE_URI = "postgresql://listenbrainz:listenbrainz@lb_db:5432/listenbrainz"
      • 2021-10-13 28613, 2021

      • ruaok
        all of these DB connect strings need to be @lb_db rather than @db
      • 2021-10-13 28618, 2021

      • monkey
        Okidoke
      • 2021-10-13 28620, 2021

      • akshat
        monkey: we even need to add the ability to manually test hex codes. Does the color wheel allow that? Realtime pointing to the color
      • 2021-10-13 28654, 2021

      • monkey
        The color wheel was leveraging another library to deal with colors: tinycolor2
      • 2021-10-13 28602, 2021

      • monkey
        Which does allo to validate inputs
      • 2021-10-13 28610, 2021

      • monkey
      • 2021-10-13 28626, 2021

      • monkey
        Not sure if that answers your question
      • 2021-10-13 28637, 2021

      • akshat
      • 2021-10-13 28617, 2021

      • akshat
        But in a superior UI
      • 2021-10-13 28648, 2021

      • ruaok
        monkey: fix for API pushed.
      • 2021-10-13 28625, 2021

      • ruaok
        nearly 250k pieces of cover art done.
      • 2021-10-13 28615, 2021

      • monkey
        Is the bono instance down on purpose?
      • 2021-10-13 28634, 2021

      • ruaok
        we can only ever have one instance at a time right now.
      • 2021-10-13 28655, 2021

      • ruaok
        would you like to run yours or should I update from git and restart periodically?
      • 2021-10-13 28631, 2021

      • ruaok brings up his instance with the latest
      • 2021-10-13 28602, 2021

      • ruaok
        up
      • 2021-10-13 28615, 2021

      • monkey
        Thanks :)
      • 2021-10-13 28633, 2021

      • monkey
        I'm almost there with the color wheel, just needed to test
      • 2021-10-13 28638, 2021

      • monkey
        OK, tested committed and pushed. It's pretty damn sweet
      • 2021-10-13 28610, 2021

      • monkey
        I think I broke the background color change, gonna fix that now
      • 2021-10-13 28609, 2021

      • ruaok
        let me update. hang on everyone
      • 2021-10-13 28628, 2021

      • ruaok
        back up
      • 2021-10-13 28629, 2021

      • ruaok
        ooooh!
      • 2021-10-13 28608, 2021

      • ruaok
        !m monkey
      • 2021-10-13 28608, 2021

      • BrainzBot
        You're doing good work, monkey!
      • 2021-10-13 28624, 2021

      • bitmap
        reosarevok: I think we can potentially remove the 500 recording limit, but we'd have to make some changes to how we time out requests. e.g. right now we don't distinguish between a single db query taking 60s vs. 60 db queries taking 1s each
      • 2021-10-13 28652, 2021

      • bitmap
        the latter isn't as problematic since we know it's still doing work and might complete (though there should still be some kind of overall limit)
      • 2021-10-13 28609, 2021

      • shivam-kapila
        Oh the color play looks really good. GG devs :)
      • 2021-10-13 28631, 2021

      • lucifer
        monkey: oh! nice :D
      • 2021-10-13 28602, 2021

      • akshat
        monkey coming at it with Colour. looks great! 💯
      • 2021-10-13 28638, 2021

      • monkey
        I do want to point out I didn't make the color wheel but shamelessly stole it from that one unmaintained library
      • 2021-10-13 28605, 2021

      • monkey
        So thanks…*checks library* talor-hammond !
      • 2021-10-13 28629, 2021

      • Zhele has quit
      • 2021-10-13 28653, 2021

      • Zhele joined the channel
      • 2021-10-13 28633, 2021

      • ruaok
        looking quite sweet.
      • 2021-10-13 28613, 2021

      • lucifer
      • 2021-10-13 28603, 2021

      • ruaok
        monkey: akshat : are you running your instance of listenbrainz? we can have only one running at a time.
      • 2021-10-13 28616, 2021

      • ruaok
        let me know if you want to take over, I'll shut mine down.
      • 2021-10-13 28623, 2021

      • monkey
        Negative
      • 2021-10-13 28634, 2021

      • akshat
        Yeah I am
      • 2021-10-13 28645, 2021

      • ruaok
        ok, I'll take mine down and let you play akshat
      • 2021-10-13 28648, 2021

      • akshat
        I'll shut mine
      • 2021-10-13 28656, 2021

      • akshat
        If there's anything urgent for you
      • 2021-10-13 28659, 2021

      • ruaok
        no, keep yours. I don;t need it.
      • 2021-10-13 28605, 2021

      • akshat
        Okayyy
      • 2021-10-13 28628, 2021

      • ruaok
        all down now.