Hi bitmap yvanzo reosarevok ! I have sorta completed the design for the mb homepage with the major functionalities. I would really like your opinion on it before I go further. Please once try https://musicbrainz-web.web.app on your mobile and desktop.
I am not firm on the drop-downs or the major content present and would be flexible to update that based on your expertise and thoughts but I think the general Skelton for the page works with even the dark mode!
You can just provide small comments here or for detailed overview, you can visit https://community.metabrainz.org/t/musicbrainz-... Please omit the starting comments on the forum since the page has evolved since then, haha!
akshat: that mock-up is looking really quite nice -- thanks!
a few more comments: "* Brainz Projects" -> "Other MetaBrainz Foundation Projects"
that section looks lovely, but it is still too larger. esp. the picard logo is much larger than the others, or at least it appears that way.
I think overall the logos should be shrunk a bit and sized so they more or less appear to be the same size
outsidecontext
oh yes, that picard logo is a monster :D The actual logo sizes vary, I think because of different text lengths and because of the logo images all scaled to same width. I think the logo itself should have same size, even if it means different image width
the spark reader side of things should all be fast right -- read data, write to disk. no real processing done, yes?
lucifer
yes, each message should be 2 or 3 db queries at most. the issue is that each stat for each user is 1 message so thousands of those pile up just after the results are received.
ruaok
ok, lets try it.
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #1663 (03master…missing-all-time-releases): LB-968: All time release stats are not being updated for some users https://github.com/metabrainz/listenbrainz-serv...
alastairp: ruaok: monkey: the performance monitoring stuff is also deployed now (in prod the value is set to 0, beta and test to 1 so effectively disabled in prod). if you browse LB on beta, the stats here will update and we'll have a better understanding of what's slow/fast. https://sentry.metabrainz.org/organizations/met...
(exception is test-lb container which is not yet updated because its running huesound)
cache would be useful, i have hit ratelimit a couple of times when testing huesound. issue will probably become worse when we move this to prod and more people start using
MrClon
ruaok indeed interesting. But i am not sure that node.js is good for non-web-dev cli tool
ruaok
MrClon: agreed.
lucifer: also agreed. just not certain that we can operate a cache.
monkey
There's a couple of 'issues' though; sometimes there is cover art available for another release of the same release-group, but not for the release matched, so I'm seeing much fewer cover arts than I'd expect.
i think we could setup an endpoint for this. send a release mbid, LB resolves a link - coverart of that release mbid if available or query db for another release of that release group that a covert art attached.
monkey
But see the matched listens at the top with no cover art… I'm sure there's cover art somewhere for Alan Parson's "Eye in the sky", but apparently not for this specific release
Yeah, I guess that would be ideal. I'm guessing we'll have the same issues for genres and other tags, URL relationships, etc.
lucifer
indeed
monkey
It would almost makes more sense to match to a release_group rather than a release, no?
monkey ducks before ruaok throws something
ruaok
in a way, yes.
a possible future improvement
monkey
Or is there any way to get that sort of information from the MB webservice using a recording MBID? i.e. query for recording, with included cover art ?
reosarevok
ruaok: answered re: your last email(s), do let me know what you think
I'm confused tbh
CatQuest
[11:27] <outsidecontext> the more features, the bigger the icon :D It'll grow with each release
that's.. evne a differnt iamge thna the last one :o
that's.. evne a differnt image than the last one :o
tandy
monkey: finally got round to working on that PR again :)
i also managed to use high level types across my listenbrainz-nim library, except for the Timeline endpoints, which require type unions, so im figuring out a way to make that work in nim
lucifer
zas: hi! does something in the monitoring system query lb.org/internal/metric/stats repeatedly? i see a bunch of failures for that url in sentry.
antlarr has quit
alastairp
hola
monkey: that's a nice can'o'worms
lucifer: that url sounds like my first attempt at stats in LB, in which case there might be a telegraf ingester still hitting that endpoint
but if that's the guideline I suppose it should be consistent
reosarevok
Well, they have the reasoning for columns that "Column aliases should always use the keyword AS This becomes significant when a query has several columns selected with columns aliased. Without the AS keyword, a dropped comma makes two columns become a single aliased column."
Not sure if that risk exists for tables
bitmap
I see. I don't think it's very important, we could make it optional for tables
zas
lucifer: nothing I'm aware of. ruaok ?
bitmap
akshat: the mockup looks pretty nice to me. how come the logo in the top left doesn't contain the (hexagon) logo anymore?
the sheet music stock photo feels a bit cheesy :) dunno what else to put there though
alastairp
zas: see my comment above, I think it was due to our experiments with LB monitoring.
bitmap
'The Music Database' being the h1 felt a bit werid to me at first since it's not the name of the project, but maybe it's fine
monkey
tandy: Thanks! I'll have a look at that PR
ruaok
lucifer: remind me please, which PR contains the fragement that fixes the expired LE cert issue? monkey needs it for BB
reosarevok: yeah, no ideas either on those spam reports
reosarevok
yvanzo ^ what do you think re: AS for tables? Mandatory or optional?
ruaok
zas: what was the last question in response to?
reosarevok
I kinda would rather we always did it or always did not, tbh
(I'm ok with it being different for columns and tables, but I'd want to be consistent for each one)
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (summit weekend!; next meeting: 2021-10-25): Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo)
ruaok
zas: can you tell if lidarr has sent us less traffic in the last 5 days?
zas
I'll check and tell you
reosarevok
yvanzo: huh, Root is not on my local install, wonder if it isn't exposed except on some specific version of DateTime::Locale
akshat
Thank you for your review bitmap! I do agree we should add the hexagon logo with the name on the navbar. Will do so! But I'll want to add the final logo with it.
monkey alastairp lucifer CatQuest your takes on the mb design mockup?
CatQuest
akshat: busy right now. ask me later
akshat
Sure!
Freso will give the final take :)
ruaok I would like to add the footer section to all meb projects in the same format as this mockup if that looks good to you. Content will be relevant for each project. Any thoughts?
We had good review regarding that on the forum
ruaok
might be nice, but you need to really ask all the team leads what they think about that. lucifer, bitmap, alastairp?
Freso
akshat: Not sure why I’m the one to give final take. :x
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (summit weekend!; next meeting: 2021-10-25): Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo), Allow account admins to see editor-editor subscript
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo), Allow account admins to see editor-editor subscriptions? (Freso)
akshat
Freso I believe you could do a sanity check as to all the important things which should be relevant, present and abide by our guidelines. 😇
