#metabrainz

I'll try it.

👍

still throw the same cardinality error

or do you think the distinct should be over the whole row?

I think i am asking just a wee bit too much:wq

ruaok: uhh strange. this query works for me locally.

quite frankly, I've sunk way too much time into this stupid query. any more changes and this will continue to be a timesink.

doing two separate inserts in one transaction is actually less code and understandable by humans.

makes sense

oh hey, that's what's happening outside my window

bitmap: when you're around, I'm not quite sure what I need to change to make https://github.com/reosarevok/musicbrainz-serve... work

MBS-11910: Allow editing relationship credits in the new URL editor pop-in

(right now it's some weird thing where it actually detects the credit as present sometimes, but not other times, and I'm not sure why)

lol alastairp that explains why nobody was trying to clean up the place :D

hah, yeah

they were filming in the building in the distance a bit a few months ago, not sure if it was related

but then about 3 weeks ago they started building fake sidewalk + road

last week they've been finishing the facades of the buildings

the green-screen blocks a lot of what I can see from the window :(

3-4 months of filming though. at least they won't be building any new houses there until that's finished...

yvanzo, I did update to the latest version so I guess the bug isn't fixed.

and yes, I blew everything away and redownloaded from git.

nelgin: ok then try setting MUSICBRAINZ_BASE_FTP_URL=ftp://ftp.musicbrainz....

I will try to reproduce the issue locally.

yvanzo that's what I already have it set to in .env

Ah

[listenbrainz-server] 14akshaaatt merged pull request #1730 (03master…monkey-listencard-flexbox-improvements): ListenCard responsive improvements https://github.com/metabrainz/listenbrainz-serv...

I missed the ftp:// Let me try that.

Thanks akshaaatt !

!m monkey

You're doing good work, monkey!

lucifer: cover art PRs are merged, ready to deploy whenever you want/can :)

And thank you

Since it says FTP_UTL you'd think it was implied that it would use ftp:// :)

monkey I just noticed that the huesound listencards do not showcase the menu options for opening in mb, etc

Is that intentional or a potential bug?

That's added automatically if the data required is in the listen, so we're probably missing it in the huesound listens, let me check

Yus

Hm, I guess not, recording_mbid is in there as expected

yvanzo, bitmap: let's try to add stuff to https://github.com/metabrainz/musicbrainz-serve... by tomorrow evening btw? We can meet at 18 or 19 and look into it a bit maybe

trolley: are you this kind of trolley https://www.unishop.co.uk/det/1563/Large-Superm... or troll-ey ?

If needed

:D

yvanzo, bitmap: also, we might want to stick to a three week cycle for *next* release too, and go back to 2 weeks after

Yes that's abug akshaaatt, please open a ticket :)

Sure! I'll fix it.

reosarevok: sounds good to me

akshaaatt: This condition is incorrect: https://github.com/metabrainz/listenbrainz-serv...

It doesn't take into account `recordingMBID`, `spotifyURL`, `youtubeURL` or `soundcloudURL`.

Time to refactor this into more readable code and avoid the mistake I made :)

Thanks for the head start!

monkey: 👍 doing a release

[listenbrainz-server] release 03v-2021-11-16.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

reosarevok: this line in handleConfirm is suspect - confirmedProps[state.creditableEntityCredit] = state.credit.value;

state.creditableEntityCredit is undefined there

Oh, yeah, I guess I need to pass that to the state on createInitialState

Now that we're adding cover art everywhere, it would be interesting to look at the Save-Data HTTP header, and set a global prop accordingly. Then in React we can decide to show artwork or not.

Unless you see a simpler way to do all this

never heard of Save-Data before

There's a proposed CSS solution for this as well (which is how I know of it) but in our case a property in React is more adapted. Plus it's not currently supported anywhere…

reosarevok: I guess props.relationship.creditableEntityCredit works too

bitmap: ok, the whole thing does the trick, but now I need to figure out how to actually save the credit :D

spotify reader emitting lots of 404s. trying to reach spotify.com manually also gives 404. probably a spotify downtime.

Confirming 404 on spotify.com

Interesting

Weird, I'm listening to Spotify rn, maybe it just pre-downloaded the podcast :D

I received an email from LB saying that there has been an issue with the import

Does this mean all our users who have authenticated Spotify on LB have received this email?

i think so. yes.

that also means that import will eventually be disabled for all users. once spotify is back up, will need to run a script to restart imports for all users

I did

Which reminds me, does the Spotify importer also import podcasts?

the mail will be sent after a few retries fail, i do see a lot of recent failures here https://listenbrainz.org/admin/listens_importer...

reosarevok: no it doesn't

lucifer: I wonder if we need some better error detection here. perhaps 404 shouldnt trigger thi failure

lucifer is it desirable to continue the entire process once we find a 404 or the script should put a hault? Considering sending emails to a large userbase in a short interval of time could be undesirable I think?

Ah, now I got the email

alastairp: i think that makes sense. but what to do for those errors, ignore and keep retrying?

at the very least we could do a back-off

we had a discussion about this a few months ago, to improve the importer and make it more responsive, especially for now-playings

and so the same system could help us add a backoff in some cases

we could back off a few times, and only after it fails many times we quit and send the mail

akshaaatt: the script halts the import and thus the user is notified. the intent is that the error usually means user intervention is needed. sending a lot of mails is undesirable indeed but not sure about the best way forward here

Right

I'm interested in what alastairp says I think that could be good

but I think we also now know of a few different failure modes now, and so perhaps should differentiate them

backing off makes sense.

the auth failure - we know that this can happen when people revoke permissions

but others seem to be a bit more transient - 500? 404? ...

yeah indeed. afair, auth revocation is the only one needing user intervention. all others are transient errors and resolve themselves after some retries.

perfect

to implement this stuff, i am thinking of a column like is_error_transient flag or error_type enum

for permanent errors (auth revocation), send email and stop. for transient errors, don't retry for another hour or so? for a few times and then upgrade that to a permanent error and send mail

yeah, that could work

alastairp: https://sentry.metabrainz.org/organizations/met...

weird thing, the rmq errors stopped 14 mins ago. roughly around when spotify reader stopped

or maybe an 'importer events' table

oh, interesting

you think that maybe the spotify tool is causing weird connections?

i think its not spotify but the load. bulk of incoming listens is spotify reader.

right, got it

The really strange thing is that I also received the email, but I'm not on Spotify.

oh, what's your LB username rdswift ?

lucifer: will we know which accounts failed due to this outage, compared to previous failures? :/

maybe based on the time that we marked it as failed?

rdswift

alastairp, we can see the last updated and make a reasonable guess

rdswift: but i do see in db that you have spotify connected.

latest listened at is very old though. 2020-01-06 17:28:51+00:00

I tweeted about the outage

thanks!

Interesting. I don't think I've listened to anything on Spotify for weeks.

afaiu importer works for free accounts too, its the playing now feature that needs premium.

I guess it's been years rather than weeks. :-)

I guess there's nothing that triggers an update to your database that I'm not connected, although I don't suppose that's an issue.

rdswift: you could turn it off yourself, but I guess we don't disable it ourselves if we don't see any activity

Not a big deal either way. I was just a bit surprised when I received the email. Might be an idea to check the last listen date and not send the email if it's over x days?

yeah, or we could automatically disconnect it after x months, sending an email indicating it

Is it a problem leaving it connected?

a problem for us? not at all

In that case, I don't think I would bother having you automatically show it as disconnected after x months.

One less piece of code to run periodically. ;-)

in this case I'd just do it as part of the infinite loop that we have recording listens anyway... if last_listened_time < 6 months ago: email and disable account, then it won't get caught the next time around

but you're right, if it's not causing us problems then probably no reason not to