#metabrainz

/

      • jess has quit
      • akshaaatt
        Hi bitmap! I was facing an issue with javascript working on my pull request and wanted to know what the relevant changes are, which should be made.
      • MRiddickW joined the channel
      • gcrkrause has quit
      • gcrkrause joined the channel
      • leonardo has quit
      • strider has quit
      • leonardo joined the channel
      • -- BotBot disconnected, possible missing messages --
      • BrainzBot joined the channel
      • reosarevok
        akshaaatt: what's the issue?
      • Nothing works at all? (you did run ./script/compile_resources.sh , right?)
      • akshaaatt
        Hi reosarevok!
      • MRiddickW has quit
      • Thanks a lot for the reply reosarevok. I can't seem to find the yarn command available for it.
      • I found the documentation for this step here at https://github.com/metabrainz/musicbrainz-serve... but couldn't find one for the docker setup. Is this step releavnt for the docker setup as well?
      • If it helps, I require some guidance for https://github.com/metabrainz/musicbrainz-serve.... The UI is present but none of the button clicks or so work. I am assuming it has something related to javascript for now.
      • Freso has quit
      • reosarevok
        Ok, lemme try to test your PR and see if I find the issue
      • Freso joined the channel
      • akshaaatt
        Thank you so much!
      • reosarevok
        akshaaatt: well, the first thing I'm seeing is "Refused to load the stylesheet 'https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css' because it violates the following Content Security Policy directive: "style-src 'self' staticbrainz.org". Note that 'style-src-elem' was not explicitly set, so 'style-src' is used as a fallback." in the console.
      • We probably should have those stylesheets locally
      • But bitmap can tell you exactly whether to put them on staticbrainz or what :)
      • GET http://reolappy:5000/static/images/music.jpg 404 (Not Found) seems you haven't added that yet? :)
      • akshaaatt
        Oh okay! I seem to have missed this over the logs I think.
      • reosarevok
        With buttons do you mean stuff like "Release", "Recording" etc on the main page?
      • Oh, the search one too, ok. Checking
      • akshaaatt
        Not those but the scroll to top button, clicking on the bootstrap stuff
      • reosarevok
        While I'm looking at this :)
      • All those should be {l('string')}
      • Do you have eslint set up?
      • If not, I'd suggest to try to get it - I expect intellij products support it too
      • VSCode gives me "Missing JSX expression container around literal string: “Release Group”eslintreact/jsx-no-literals" here
      • akshaaatt
        I can't seem to find the error in the logs reosarevok regarding the cdn link. Where should I look for those?
      • reosarevok
        I saw it locally in the browser console
      • akshaaatt
        Yuss bitmap mentioned about that to me reosarevok
      • Oh okayy
      • reosarevok
        For the header search, is there any reason you'd not just keep the existing, proper React component in https://github.com/metabrainz/musicbrainz-serve... and just add bootstrap classes to it?
      • I'm confused about why to change it so there's no actual form :)
      • (there's a million eslint issues here, by the way, please do try to set up eslint :) )
      • akshaaatt
        Yuss all of this is on my list
      • reosarevok
        Ok, I'm not sure tbh. One thing I suspect is that if this is using window it might need hydration? But bitmap can help with that better
      • I'd suggest that while you wait for him you clean up the code so it's easier to follow :)
      • Personally I'd use classes as little as possible, my understanding is hooks mostly do everything classes do better
      • But that you can also discuss with bitmap maybe and see what he thinks
      • akshaaatt
        Thanks a lot!
      • trolley has quit
      • trolley joined the channel
      • yvanzo
        O’Moin
      • reosarevok
        moin! :)
      • Freso: if you have some time, please check again that the warning in https://github.com/metabrainz/musicbrainz-serve... looks good enough :)
      • outsidecontext has quit
      • monkey has quit
      • Freso has quit
      • alastairp has quit
      • mruszczyk has quit
      • lucifer has quit
      • akshaaatt has quit
      • zas_ joined the channel
      • yvanzo_ joined the channel
      • zas has quit
      • zas_ is now known as zas
      • param has quit
      • Leftmost has quit
      • reosarevok has quit
      • HorusHorrendus_ joined the channel
      • yvanzo has quit
      • HorusHorrendus has quit
      • revi has quit
      • kuno has quit
      • yvanzo_ is now known as yvanzo
      • HorusHorrendus_ is now known as HorusHorrendus
      • ruaok has quit
      • lucifer joined the channel
      • BenOckmore has quit
      • KassOtsimine has quit
      • mruszczyk joined the channel
      • akshaaatt joined the channel
      • kuno joined the channel
      • KassOtsimine joined the channel
      • Freso joined the channel
      • param joined the channel
      • BenOckmore joined the channel
      • revi joined the channel
      • Leftmost joined the channel
      • monkey joined the channel
      • outsidecontext joined the channel
      • ruaok joined the channel
      • alastairp joined the channel
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2337 (03master…MBS-12087): MBS-12087: Fix TT TaggerIcon call https://github.com/metabrainz/musicbrainz-serve...
      • reosarevok joined the channel
      • ruaok
        zas: I'm going back to the listen count graph -- I have no idea how it got borked like that. very weird, I suspect a grafana update glitch.
      • tell me, given an absolute count of number of listens, how does one make a rate-of-change graph?
      • lucifer
        ruaok: should i merge and deploy this or do you want some changes? https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        that really depends on the question to zas. if there is a good way to make rate-of-change graph, then no I guess.
      • zas
      • for prometheus, rate()
      • ruaok
        but the absolute value of this metric is also not meaningful -- number of listens processed since ts writer start is meaningless.
      • zas: I'm going to hold off on the prom. migration for now. we can work on that in jan, but right now we have too much stuff on to add this to our tasks.
      • yeah, reading those docs, its clear as mud and I'll throw myself down yet another rabbit role wasting time.
      • lucifer: yes, please, lets change the graph to "number of listens processed since the last update"
      • lucifer
        ok 👍
      • ruaok
        which should be a simple and straightforward change, then grafana can follow easily.
      • thanks!
      • reosarevok
        ruaok: added a sample to https://github.com/metabrainz/musicbrainz-serve... as requested
      • (if you want the whole result I can send it, it's 30 mb of text)
      • ruaok
        ok, thanks all good.
      • a lot of those are not what I would expect spammers to look like. though the "dry run" bits seem clearly spam accounts.
      • zas
        "but the absolute value of this metric is also not meaningful -- number of listens processed since ts writer start is meaningless." -> how so? that's what is called a counter in metrics world, and it's widely used. Your app just have to increase it over the time. For example, that's how we get rates from interfaces traffic (number of bytes since the start). But it doesn't work for temperature for example (for this, a gauge is used)
      • ruaok
        yes, I understand counters.
      • but this counter is counting something meaningless. the number of counts like the start of the component. I could care less. this is not about the validity of counters, it is about the validity of the metric we're measuring.
      • zas
        ah, yes, that's another issue ;)
      • well, most apps just counts number of hits, number of items, etc... since the start because that's convenient (you don't have to store anything to disk), and since, by definition, the value cannot decrease, when it happens points are just ignored.
      • reosarevok
        yvanzo: https://github.com/metabrainz/musicbrainz-serve... passed now, in case you want to take a look again :)
      • ruaok
        yeah, I hear that. but for us it is trivial to make this into a meaningful metric by only reporting the listens processed in the last update interval. it requires no data storage -- dead simple.
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2334 (03master…MBS-12077): MBS-12077: Also block useless edit notes on the release editor https://github.com/metabrainz/musicbrainz-serve...
      • [listenbrainz-server] 14amCap1712 merged pull request #1751 (03master…simplify-request-manage): Simplify spark request manage https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        lucifer: remind me, which of the sitewide stats PRs should I review next? does it matter?
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1750 (03master…fix-spark-dumps): Dump listens for spark in order based on dump type https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        ruaok: https://github.com/metabrainz/listenbrainz-serv... first because its ready. other PRs still need changes like adding api docs. i'll do those and apply comments from this PR to those at the same time.
      • ruaok
        perfect
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1749 (03master…update-spotify-counter): Update spotify reader imported listen counts more frequently https://github.com/metabrainz/listenbrainz-serv...
      • zas
        ruaok: the graph for Incoming listens has no derivative anymore, is that expected? I also just noticed the use of fill(0) (that's perhaps me when I tried to fix those), it should be fill(previous) or fill(linear)
      • ruaok
        yes, just to reset the nonsense. I'll fix it when lucifer releases an updated timescale writer.
      • zas
        ok
      • ruaok
        at least it is good to know the seekrit incantation on how to make this graph.
      • zas
        fill() is tricky, because it is only used when values are missing, and missing values depends on group by time(), for counters, we usually want to fill with previous values (when no values, we assume it didn't change), it can also be linear (but it then extrapolates too much imho)
      • ruaok
        ah, very good to know, thanks.
      • zas
        query inspector is your friend in this field
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1752 (03master…timescale-writer-counts): Timescale Writer: Use counts since last metric update https://github.com/metabrainz/listenbrainz-serv...
      • zas
        I prefer prometheus query language over influx QL when it comes to rates, mainly because it does the right thing by default: https://prometheus.io/docs/prometheus/latest/qu...
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1744 (03master…sitewide-releases): Add sitewide release stats https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        what else should I be looking at this morning, lucifer ?
      • lucifer
        ruaok: nothing else from my side currently. i'll update the remaining the sitewide PRs and ping you when those are ready for review.
      • ruaok
        k.
      • lucifer
        should i do release?
      • ruaok
        yes, sounds good.
      • lucifer
        👍
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1752 (03master…timescale-writer-counts): Timescale Writer: Use counts since last metric update https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] release 03v-2021-11-22.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        ruaok: also trigger a full dump to fix missing pre-2018 listens?
      • ruaok
        absolutely. (no need to ask me this question in the future, you're the boss in this area)
      • lucifer
        intending to use the flags alastairp added last week to dump just spark listens first as that take ~4-5 hrs so can request import today and get stats fixed tomorrow. after that can trigger normal listens to complete the set of file (takes ~18-24 hrs).
      • :D 👍
      • ruaok
        I'm quite curious about the outcome of this -- the recheck on the mapping should have included a pile of new matches on the top discoveries. should be fun tomorrow.
      • lucifer
        oh. indeed then hoping tommorrow's stats to be better
      • re mapping, i think these listens should have got mapped. https://api.listenbrainz.org/1/user/amCap1712/l... and https://api.listenbrainz.org/1/user/amCap1712/l... (not sure if your mapping edge cases already include such cases)