#metabrainz

/

      • alastairp
        yum
      • oh, lol. right. I thought it was some india-specific music streaming service
      • !m ruaok
      • BrainzBot
        You're doing good work, ruaok!
      • alastairp
        just publicly saying how much I appreciate metabrainz's promptness at paying invoices
      • ruaok
        I watched my dad fuck around with his employees and what negative ramifications it had. I decided right then that I would never do that, should I ever have to pay people.
      • alastairp
        and I remember you making that explanation every time I get paid, and it still feels nice when it happens quickly
      • ruaok
        just one of those kid things that sticks with ya....
      • alastairp
        reosarevok: I cc'd support@, but I just renamed that user in LB
      • lucifer: how is the LB import?
      • lucifer
        6.8 M listens imported.
      • that's enough for test or should i do more?
      • alastairp
        that might be enough, not sure how many you have waiting to load
      • lucifer
        ~4M i guess.
      • alastairp
        depends on if you want to pick it up today, or leave the import going and work on it tomorrow
      • lucifer
        i stopped for about an hour earlier. the import will finish quicker than that.
      • i am yet to start importing the remaining ones so i'll only do that if we need it for testing.
      • alastairp
        ah, OK
      • I think it's probably enough
      • lucifer
        👍, i created the extra column already. can you remind what exactly to do?
      • alastairp
        that's step 3 in the 2nd list in the PR body: https://github.com/metabrainz/listenbrainz-serv...
      • reosarevok
        alastairp: thanks!
      • I hadn't renamed it on MB yet though :D
      • Hopefully it didn't get some stranded listens
      • lucifer
        oh i need to import users for that :/
      • alastairp
        reosarevok: oops, sorry! I thought the email was "i've done MB but not sure about LB!"
      • double-checking for stranded listens
      • none
      • reosarevok
        No, it was "won't touch it yet to not break anything in LB" :D
      • Ok, sweet, thanks
      • alastairp
        lucifer: ah - yes. I guess I did a full import with public user dump + listens dump to make this work
      • lucifer
        yeah imported that next.
      • sorry for the delay!
      • monkey
        Thank you ! :)
      • Perfect timing
      • lucifer
        i'll also have a lot of related data available in spark like recroding mbids for most of this stuff. so let me know if need something more to be added.
      • riksucks
        hi lucifer
      • so I added the Z in the api and removed the "Z" from spark code
      • but, the page that serves the missing mb data, it populates the page
      • from db methods and not from api
      • so can I add the addition of Z code at the db method too?
      • lucifer
        riksucks: sure. once you retrieve the data from db. add the "Z" after that
      • riksucks
        (the api only serves 25 entries and not more than that, plus, since the missing mb page updates every 2 week, I thought, populating the page directly from backend would be better, rather than from the api, hence this decision)
      • oh thanks for the clearance. on it now
      • lucifer: you can check this minor commit when free, to see if things are okay or not
      • lucifer
        riksucks: yes that looks about right to me.
      • riksucks
        monkey: hi! hope you are doing well. It seems that you are pretty busy, so no need to hurry. But when you do get time, check out the PR :D. I have actually not removed the nested divs, because either they messed with the responsiveness or messed up the footer (though my branch has the old footer). But if you feel like that similar effect can be achieved in a different manner, do let me know
      • lucifer: thanks for the review :D
      • monkey
        Will do, sorry it's fallen by the wayside !
      • riksucks
        no worries :D
      • CatQuest
        lucifer: i imported 11 pages, firts page is still https://beta.listenbrainz.org/user/CatCat/
      • lucifer
        CatQuest: can you console logs and see if there are errors there? it should be cmd + shift + j on mac (looking at https://developer.mozilla.org/en-US/docs/Tools/...)
      • reosarevok
        Freso: was having a quick chat with bitmap on the deleted/edited thing and we were thinking it might make sense to store all the history of changes in the DB even if we don't display it, actually
      • Freso
        Alright.
      • reosarevok
        Since it gives us an "undo button" of sorts if, let's say, one of our accounts is compromised or something
      • (and I guess, possibly, a literal undo button, if we later want it...)
      • Freso
        Would you export it with the dumps and replication?
      • reosarevok
        I would not. bitmap: do we have private dumps where we could keep that? I forget
      • I guess in the same way we have a copy of the user data with passwords and whatnot in case something breaks, the same should be enough for this, with more copies / availability being unneeded?
      • bitmap
        we do have a private dump where it would be stored on our servers, but the public dumps would only have the latest edit note
      • the change table would be empty
      • reosarevok
        So anyone using a public dump wouldn't be able to see it was deleted and why, just a blank note
      • But I think that's not a big issue
      • bitmap
        right
      • lucifer
        monkey: weird, i checked the db for the latest import from CatQuest and the latest import ts was updated but no listens were actually imported by last fm importer.
      • monkey
        lucifer: I don't think the last imported timestamp is being sent by the front-end
      • At least I don't see code for that anywhere
      • Ah wai
      • Spoke too fast, there's setLatestImport
      • lucifer
        yup right that one.
      • monkey
        Honestly at this point I'm not sure exacly how that code does its thing.
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2253 (03master…MBS-11942): MBS-11942: Deleted users can still use pending verification links https://github.com/metabrainz/musicbrainz-serve...
      • monkey
        Calls to setLatestImport are preceded by this comment, but… `// import was successful`
      • reosarevok
        bitmap: would you then have a numeric id for PK, or (edit_note, time)?
      • monkey
        We'll need a more thorough debugging session to figure it all out
      • lucifer
        uh LFM importer is a mess. we have at least 5 users report about it over the last 2 months but we don't have much visibility into what goes wrong when it stops working (partially?)
      • yeah indeed.
      • bitmap
        reosarevok: I think I'd add an integer PK for it
      • lucifer
        i am wondering why sentry doesn't record any errors on LFM importer.
      • CatQuest
        lucifer: I only get
      • class is a reserved identifier content.js:1:60
      • TypeError: this._recipeManager is null
      • lucifer
        that looks unrelated, CatQuest. i and monkey will try to debug this will probably some more time to figure out.
      • reosarevok
        bitmap: ok, let's do that
      • CatQuest
        ah
      • (I was reading scroll back and yo uasked for it so i did. later read the other convo)
      • basically it seems i'm not the only one having osme issue
      • anyway I also set my clock to actually non-dst but it still had the same issue, so it can't be that becasue you apparently did import it right
      • reosarevok
        bitmap, Freso: store just old note, right? or both old and new?
      • CatQuest
        but doing it from scratch worked...
      • i'd say both old and new tbh, reo
      • lucifer
        yeah other users had reported the issue that there imports didn't progress beyond a point but afaik it worked for them after some days.
      • bitmap
        reosarevok: you'll be able to derive the new note from the following change, right?
      • CatQuest
        i'm kinda curious what would happen if you now tey importing again to the test
      • so (not fro mcratch import)
      • try*
      • lucifer
        i'll try and check that
      • Freso
        reosarevok: I don’t know enough about db design to tell you. My instinct is that the new one should be there too, but then the other table should be normalised and just point to the revision in that table to normalise it… and at that point we’d need to replicate that table too, at least partially… so probably not a good idea.
      • CatQuest
        if it's a "resume" issue
      • reosarevok
        bitmap: yeah, we should be able to find the next note either in edit_note or the following change
      • CatQuest
        also i clic kthe "lastfm" button every time (it's not rally cealr if any are chosen already so i am careful incase it somehow defaults to the other one)
      • reosarevok
        I was just thinking for ease of checking for issues if needed
      • But probably not needed
      • CatQuest
        my gut says to keep the new one too tbh
      • just a warning incase we 3 years for mnow run inot an issue becasue of this
      • i *will* say "i told you so"
      • :P
      • lucifer
        CatQuest: i did another import. do you see your latest listens here https://listenbrainz.org/user/Listenbrainz%20Te...
      • CatQuest
        hm. it has not updated for 8 hours
      • i have listened to music the entire time
      • and "war child" was the song that was first last time
      • so i think, not
      • outsidecontext
      • CatQuest
        !m outsidecontext
      • BrainzBot
        You're doing good work, outsidecontext!
      • reosarevok
        bitmap: so https://gist.github.com/reosarevok/67bc8f1cc09b... with possibly also new_note TEXT NOT NULL
      • This is getting a lot more complex than I first envisioned, but seems useful
      • bitmap
        reosarevok: yeah and probably remove _last from the table name since it's not just the last anymore
      • reosarevok
        Yeah
      • CatQuest
        ah, i'm rolling in, good night everyone, natta! :D
      • rdswift has quit
      • reosarevok
      • If it all looks good I'll start implementing further
      • rdswift joined the channel
      • bitmap: I'd expect we'll want this as its own commit, and then the implementation probably split into a bunch more? :)
      • Freso, bitmap: also, opinions on whether reasoning should be a free-text field (nice but untranslatable) or a set of possible options?
      • BrainzGit has quit
      • Freso
        I’m leaning towards free text. Or if multi-options, then make it a non-code change to add more options. :x
      • rdswift_ joined the channel
      • alastairp
      • btw
      • only just saw this in LB
      • looks great!!
      • rdswift has quit
      • rdswift_ is now known as rdswift
      • bitmap
        reosarevok: free-text is what I was thinking too
      • separate commit sounds good
      • old_note instead of previous_note maybe? i'd expect old/new or previous/next
      • there's a missing comma on the change_time line
      • uZer joined the channel
      • reosarevok
        Fixed those, thanks
      • monkey
        !m akshaaatt (for the new footer ^)
      • BrainzBot
        You're doing good work, akshaaatt (for the new footer ^)!
      • akshaaatt
        More work upcoming
      • monkey I would like to work hand in hand with you regarding lb. Could I have your priority list on the ongoing stuff (bp,yim, bootstrap 5, lb redesign, etc)
      • Currently I got my attention back to MB and I see you are also focused on BB so having some common terms for LB would be great for us monkey
      • monkey
        Sure thing. YIM comes first, if we're aiming to release in a few weeks (I added some commits today — WIP of course).
      • Then I'd like to finish the BrainzPlayer redesign, and perhaps more work to make it standalone.