Hello everyone , due to college reopening I couldn't get much time to interact here and contribute . I tried working on the Search feature in music brainz- android, I tried a few things . From the observations , I saw if we can somehow relate the paging source nextKey , or the offset on which it depends, to a button , can fix the issue of too many requests.
akshaaatt: lucifer can we do something like passing null as the nextKey , and on pressing our " load more results " button , we continue the search with the new offset value
Also , a random doubt , I have heard jcenter repo is deprecated now. Is it something to worry about??
akshaaatt
Hi yellowhatpro !
Regarding jcenter, I feel we should migrate to maven central but some of our dependencies like for the barcode scanning don't allow us to do so
yellowHatpro I think the paging library has inbuilt support for the footer to show the loading state but our use case is different. From UI perspective, I think this looks good if we custom make it and do what do you suggest regarding the nextKey
... by finding a minor issue in the mbid mapping ...
lucifer
mayhem: ^ with added text. thoughts?
mayhem
🤦
lucifer
oh!!
atj
welcome aerozol :)
mayhem
the artist_mbids sort order is not stable across different entries in the mapping.
sorting on artist_mbids before using it removed that wobble.
monkey
Welcome aerozol !
lucifer
hmm interesting...
akshaaatt
Welcome aerozol 🔥💯
lucifer
i tried to handle that case in spark side by exploding after checking artist_credit_id so i don't think it should be an issue there but could be wrong.
mayhem
quite likely yes.
I am also moving away from a sliding window approach to a grouping approach.
right now it is very primitive. every 2 hours is a session and all tracks in a session get one similarity score against all the other tracks in the group.
when the alg starts it uses the first listened_at as the marker for the start of a session.
and when a listen is encountered that is more than 2 hours from that start, close the previous session, index it and then start a new session.
aerozol
thanks all!!
soo happy to be joining the dream team :)
mayhem
let me finish the announcements and then I'll poke at the results that just ran
aerozol
and hitting you all with the design stick
(gently)\
mayhem
I love the tone in your bio.
complaining in an official capacity. brilliant.
do you have a twitter handle, aerozol ?
aerozol
not one that I use
mayhem
ok
aerozol
(twitter hasn't really caught on in nz)
atj
we have a good spread of timezones now
mayhem
"I'm pleased to announce that designer Simon Hartman (Aerozol) has joined our team as a part time designer! We've been working towards this goal for years and are excited to be improving the UX of our sites. Welcome! https://blog.metabrainz.org/2022/02/23/stepping... -rk"
how does that sound?
atj: yeah, but 12 hours time difference is really challenging to work with.
aerozol: ^^
aerozol: what should your @metabrainz.org email be? aerozol@ ?
by the way akshaaatt I forgot to say yesterday: I deployed the brainzplayer PR on test.listenbrainz.org
If you ant to test it out
akshaaatt
Wonderful monkey!!
mayhem
sexy player at the bottom!
akshaaatt
ListenBrainz will beat everything out there with the help of MusicBrainz :)
CatQuest
..... can we *also* please also have an option to have the palyer on the side as before please?
ok i'mma gonne be frank: the current beta7prod design on https://test.listenbrainz.org/user/CatCat/ works well, it shows the listens and has enough space there and there is not an issue with verticla space
the issue is this: vertical space is now very limited. very limited
while the horizontal palne is jsut streached and harder to read
title of song is al lthe way to the left and actionable buttons are alll the way to the right
very easy to clik the wrong button whne you man another one
esp since it isn't as in f.ex mb where each and other line is coloured
making it *somewhat* easier to tell thme apart
aerozol
mayhem: yup that's good re. metabrainz email
CatQuest
please don't ignore me becasue i'm annoying. lsiten to me please
this is *exactly *thr sort of design that works well for mobile but is a *noghtmare* for desctop we need ot be able to cater ot both
perhasp rectionary. so that if the screen is narrow do this, and if not do it te old way?
fuck all these damn typoes
sigh
monkey
CatQuest: Yep, too wide a page at the moment. That's not expected to be the final look. We're just working on the player at the moment
aerozol
Love the player at the bottom, CatQuest may have a point about width, on my screen anyway :P
CatQuest
i rather prefer having a side palyer tbh :P
mayhem
aerozol: check your email. you should have an invite to your meb account.
aerozol: how about the tweet text I posted above?
CatQuest
to be clear: i'm not *against* the idea of a player that cna dock to the bottom. really
i'm about the flexibility
what about a player that coudl litterally be dragged around. lmao
monkey
CatQuest: heard. Honestly that player has been a PITA to use as it is, and is definitely incompatible with the technical changes that are coming in the future.
CatQuest
.. you mena the code background right?
aerozol
mayhem: great - you can @aerozol2 if you want but there's not much there
CatQuest
becase there shoudl be no such reason as to why it has to be bottom locket
locked*
monkey
Yes, code-related changes
CatQuest
like, rewrite the player by all means to make it better. that's great :D
tbh, i dislike bottom docking players. they're eating up massive verticla screen estate wich you know i don't have allverden of
monkey
I've been thinking about having a widget mode for the player, just as you say to be able to move it around the page. but it's not a priority at the moment
CatQuest
but on mobile this is like, the beesknees and i'd want that myself
yea widget sounds cool!
well rewriting the whole thing would be the priority i assume
as someone who never used the player I like it at the bottom, for what it's worth (doesn't often get results for me, so was dead screen space - I'm not linked into a Spotify account)
mayhem
the results look more... realistic. and perhaps more stable.
CatQuest
huh. i'm not linked ot spotify either, but i do tend to get hists on like youube
.. what is this
huh. i'm not linked to spotify either, but i do tend to get hits on like youube
T__T why can't I manage to type like a regular human being without fucking typing so really slow
aerozol
I think I just listen to bad music. But also I mainly look at my own page at the moment. When LB is more social I might start playing things off other peoples pages
If I'm on my own page I obviously don't need to play something, I just did after all :P
CatQuest
ha
there is the "feed" page thinger
monkey
Which reminds me, the ratio of metalheads in the team just increased !
CatQuest
you cna follwo people. so i followed people i know here, my friends, reosarevok and freso
