#metabrainz

ok, I can take down the web front ends for 30 seconds or so.

when do you want to do this?

within next hour, if we don't find a way to avoid it

k, tell me when you want to start.

we added clash to ansible, but changes related to docker/iptables didn't go well this time, not sure why yet, but likely missing rules in iptables, improper masquerading, which causes acousticbrainz to not being about to communicate with pg on frank. That said, it might be a wider issue

it might not be necessary to proceed, atj found the missing rule, we'll check if it is enough

was afk, back now.

mayhem: taking down all containers or prepping an image to show static page of a short downtime?

I don't think we need to reboot clash now

ah nice

Docker didn't like iptables mode being enabled without a full restart

yvanzo: when around you can review the blog post and the docker release and publish both :) Everything else should be done

reoping

reosarevok:

[musicbrainz-docker] release 03v-2022-03-28 has been published by 14reosarevok: https://github.com/metabrainz/musicbrainz-docke...

reosarevok: reviewed and published both, thanks!

Thanks!

akshaaatt: seems pretty good but left one comment that needs fixing

Apart from any issues bitmap might see with bootstrap (I need to learn bootstrap)

Thanks reosarevok!

reosarevok: I don't know much about bootstrap either, to be fair :)

!recall oh no.

mayhem: i ran the mapping tests and looked into the release mismatches. germany has country id 81 and uk 221 so make sense that germany release is chosen over uk release.

i see the now chosen release has an edit of ~2 months ago: https://musicbrainz.org/edit/86274679

lucifer: yeah, agreed. let's update test cases.

maybe this caused it to match now?

quite possibly. the tests against a live DB are always bound to be... iffy.

reosarevok, bitmap I have made the relevant fixes to https://github.com/metabrainz/musicbrainz-serve.... Can you have a quick look at it and give a green signal?

approved it but let's wait for tests to finish running :)

Thanks bitmap!

mayhem: https://imginn.org/p/CZuutyBrKh_/

mayhem: adding new mapping tests cases, https://musicbrainz.org/recording/d2f8257f-ca7f... need to deaccent and lower cases name or not necessary?

necessary, I think.

👍

<BANG>

It’s Respect Your Cat Monday!

:O

🐈

I’ve received one mailed in review…

atj says…

"""

Last week I resolved a few issues with the ansible role for haproxy, based on some feedback from zas. haproxy has now been installed and configured on rudi using ansible.

I also helped zas workaround some issues that cropped up when bootstrapping the new standalone server wolf, which was due to it only having a single NIC. This inspired me to implement some new functionality in the shorewall and shorewall6 roles, which meant we could signicantly simplify the Ansible firewall configuration.

Finally I also assisted zas with some minor issues he encountered whilst switching over moroder to ansible. We now have a total of 7 servers that are managed using ansible, which is fantastic progress!

"""

bitmap: Go!

hey

last week I mostly did code review and worked on schema change PRs

Hi guys!

(Others up: alastairp, zas, yvanzo, reosarevok, monkey, akshaaatt, mayhem, lucifer, CatQuest, Freso – anyone else who want to give review, let me know ASAP.)

I updated https://github.com/metabrainz/musicbrainz-serve... with the Amazon cover art removal schema changes, and started fixing the test failures in https://github.com/metabrainz/musicbrainz-serve...

though it requires tediously updating a lot of tag/genre test data under t/sql, so I didn't finish fixing them yet

I also started work on MBS-12256 and fixed a small bug with annotation diffs (MBS-12272)

MBS-12256: Keep rating and rating_count column on *_meta tables up-to-date with triggers https://tickets.metabrainz.org/browse/MBS-12256

MBS-12272: ISE when viewing editing history: missing low surrogate character https://tickets.metabrainz.org/browse/MBS-12272

fin. go akshaaatt!

No akshaaatt?

alastairp: Go!

hi there

last week I worked with mayhem and lucifer on the metadata viewer/storage, I got data refreshing/updates working

nice!!

I also helped a bit with wrangling some of mayhem's large sql queries and finding some edge cases with multiple recording artist credits

Hi everyone!

I fixed another bug in BU related to MB database access, and did some more CB reviews

I read Ansh's SoC proposal and made some notes on it, and will write that feedback up for him today/tomorrow

I had some discussion with PrathameshG about his experiments with MLHD data, and also did bono->wolf migration

(PrathameshG, talk to me after the meeting, I have some things to tell you)

that's me, akshaaatt now that you're here? ...

Hello!

Last week I continued work on the revamp (LB, MB and Android)

LB is broken with the bootstrap upgrade on a branch and seems like we'll have to fix individual components!

Making progress on that

MB looks good now that we have more things sorted

The Android app is on fire with loads of UI/UX updates! We're preparing to have the BP on it soon

Other than that I spent more time debugging this time around

That's about it for me. Go reosarevok!

Hi!

I worked a bit on schema change tickets, released beta/prod, reviewed akshaaatt's code a bit

Thanks

And helped fix a couple sir crashes (well, short term at least)

And helped lucifer and mayhem with a bunch of LB - MB issues

That's the main bits :)

CatQuest: you?

Recorder aliases are a nightmare `:D`

jk, but there is A-LOT of work getting them all

so that's what I've been doing

hopefully the result will be awesum ♓

fin, go zas

Hey

(Still up: yvanzo, monkey, mayhem, lucifer, Freso – anyone else who want to give review, let me know ASAP.)

last week, I set up a new server (wolf)

which pack?

I made significant progress on the new gateways front, on rudi, haproxy in front of multiple instances of openresty

yvanzo: marlboros, three a day.

it works, I'll do performance tests this week

I just added clash to ansible (with few issues)

discourse was upgraded

apart that, usual supervision, upgrades, Picard PRs reviews

fin. yvanzo ?

Hi!

Lmao monkey

I continued to work on the schema change and diagrams generation.

Plus indexer maitenance, documentation, a few MBS PR reviews, and support.

Fin. Go monkey?

Hi team !

(Only mayhem, lucifer, and myself left. Last call for anyone else who wish to give review!)

Last week I reviewed many PRs , thanks to all the new contributors !

I worked on mockups for the upcoming metadata viewer

Deployed the some adjustments to the youtube player in ListenBrainz to show videos while they are playing, and added required links to youtube and google ToS as per their request

Hopefully that's the last leg to get their approval. sigh.

I investigated and fixed an issue with entity merging in BB

Welcomed and helped new contributors get set up, and touched up some GSoC projects and reviews

And finally messed with github deployment actions to allow deploying docker images for PRs

(from forks)

That's it for me ! mayhem go !

hi!

I am the team member who needed help from the rest of the team last week.

fin.

just kidding. :)

but by the sounds of it, I made people busy last week. thanks for your help!

I'm learning so much sql, thanks mayhem and lucifer!

I worked on the mb_metadata_cache for the metadata viewer we're creating. also background tasks as usual.

nothing to report that hasn't already been reported.

lucifer: go

hi all!

same here, mostly worked on mapping improvements with mayhem, alastairp and reosarevok. took much time of the week but we were able to get lots of bugs fixed.

fin.

Freso: next?

🙋

The usual reports and skulking about.

I also removed the `+r` flag on this channel to hopefully help GSoC prospect to have a slightly lower barrier to entry (though people should still register with nickserv in case we need to put it back).

+1 to this

And I helped reosarevok a bit with the wording of the new Gender property Style guideline.

fin.

Oh yeah. I also did that :D

Or revised guideline rather than new, I guess.

Anyway.

No more people up for reviews, so this wraps up this item. Thank you all for your reviews!

Just a thing: we plan to upgrade pink tomorrow around 16UTC,

zas: PSA about tomorrow