#metabrainz

Moin :))

Just got over with exams.

Expect my annoyances from now on ( ͡° ͜ʖ ͡°)

Hi reosarevok! Please review https://github.com/metabrainz/musicbrainz-serve... :)

bitmap, yvanzo: should put a beta out today but we have only 3 tickets to release, I'll wait for the evening I guess in case we can review and merge some more things :)

mayhem: ^

I requested the export again now, by previous estimates we'll be able to see the data in ~a week.

ok, good job moving goliath, lucifer !

hehe :D

Ooh

Sweet

morning

welcome back PrathameshG[m], congratulations on finishing your exams

morning!

aerozol: no, there are no guidelines for how to moderate CB, and I don't think there has been much moderation applied so far. You're welcome to give it a go and come up with your own guide (if in fact we do get notifications, I had a quick look and there are very few)

alastairp: For connecting BB db to CB and fetching data, do I need to create a model for the BB database and then fetch the data like we do with BU, or simple SQL queries would work ?

Ansh: great question. traditionally, most metabrainz projects use sql queries. There is one exception in the musicbrainz_db package in brainzutils, which uses a set of models and the sqlalchemy ORM

in my opinion, ORMs are useful if you have to do very basic create/get queries. I'm not familiar with the BB schema, so I don't know how complex it is. I know that monkey uses a JS-based ORM for database access in BB

Got it

Also I found that some Authors, Work, Editions for BB have an associated MBID. So when the user reviews the author, should they review against the BBID or the MBID or both ?

:) another amazing question

we've had this discussion before within the context of the bookbrainz database and how it integrates with musicbrainz. I don't think there's a clear answer yet. For this project I think it would be easiest to consider the two databases separate, so you can review either the BB author or the MB composer

however, maybe over the next few months we can have a discussion with monkey and see if it's possible to integrate BB and MB more in this regard. (it could be as simple as another field in the BB database that says a particular entity is the same as an MB entity)

<alastairp> "welcome back PrathameshG..." <- Thanks!

Okay

mayhem: alastairp: i recently found this: https://wiki.postgresql.org/wiki/Don%27t_Do_Thi...

that's interesting, because I always thought that a serial _was_ an identity column

i wasn't aware of identity columns before reading this but those seem to be better in some respects.

I recall reading about them around the time they were introduced in postgres, and didn't really understand why they were needed

but now I"m seeing

being directly able to use the column name for reseting values seems useful.

right, without knowing the name of the sequence?

creating a new sequence on create table like may be problematic for the atomic table swap trick we use. those tables aren't meant to be inserted in directly but if ever want to there'll be conflicts.

yes

for the main metadata cache table we removed the sequence anyway, because of the same problem

ah i see

so you're saying if we insert into a table with an id column (and it automatically goes and updates the counter), and then we rename the column and then try and insert into the renamed column, then... ?

but in that case the sequence would be shared so this problem shouldn't have occurred anyway? or were the sequence values were being inserted manually from python.

yeah, in the initial version the id value was generated in python and directly inserted

>so you're saying if we insert into a table with an id column (and it automatically goes and updates the counter), and then we rename the column and then try and insert into the renamed column, then... ?

is this about being able to insert without knowing seq name or about the table insertion issue?

I guess about table insertion

you said that it might be problematic for the table swap trick, but I'm not 100% sure what you are saying the problem is

ah column rename isn't an issue iiuc. we rename tables though.

I did notice that I got into some situation where the sequence was named differently for the table

as mentioned in the 2ndquadrant link:

> Here, of course, it appears in the error message, and it is easy to guess, but sometimes a slightly different name is chosen, and then your deployment scripts will fail.

CREATE TABLE test_foo (id SERIAL). it creates test_foo_id_seq, now we do CREATE TABLE foo (LIKE test_foo). continues to use test_foo_id_seq. if we had inserted 10k rows in test_foo, insertion in foo will start from 10001.

because we rename the table and the indexes, but not the sequence. so in the case where we do need an id field, an identity would be better than a serial because it wouldn't be lying around with a wrong name

ah! I didn't know that

but if its identity coulmn, it restarts from 1.

we don't use LIKE in the metadata cache table, but I recall that it's used somewhere else

i think similar user table then

cool

Hi bitmap! I tried hydrating https://github.com/metabrainz/musicbrainz-serve... please check the latest commit and let me know how it could be corrected :) Other than that we have one selenium test failing, so after fixing that this PR should be good to go according to me

but we don't have a SERIAL there so fine there too.

lucifer: do you know how identity columns work when you are restoring dumps?

To fix the error, you can use the OVERRIDING SYSTEM VALUE clause as follows:

ah, that'll work

from https://www.postgresqltutorial.com/postgresql-t...

ah, cool

Hi reosarevok! We wanted you to review the wordings for https://github.com/metabrainz/musicbrainz-serve... after that we can look to merge :) You did review another PR so just wanted to check whether the two were mixed up :)

it appears pg dump handles that automatically but for the copy_table stuff we use probably need to handle manually

I'll take a look :) I try not to work weekends, so I had left this for Monday

lucifer: and will an identity field solve the problem we had when swapping pg primary when the id skipped?

Amazing, thanks!

Let me see

alastairp: unfortunately no. identity columns can have gaps too. same behaviour as serial in that case.

right

<alastairp> "welcome back PrathameshG..." <- thanks ^_^

Glad to be back

Hi mayhem! Could you once read through the explore musicbrainz section at https://test.musicbrainz.org/

akshaaatt: we should update test if you make any changes based on my comments :) So that mayhem only needs to read it once

I can update it myself if needed

plz

I have tagged mayhem on the gh conversations as well so that we can finalize what changes need to be made

lucifer: we received $1200 from Fidelity Charitable. 🤷‍♂️

(in the last quarter)

😆

weird but now we have some idea of what's going on.

yeah. I mean I was never going to ask too many question. "you sent me a check? cool." if someone wants their donation credited sure.

but it seems most of the donors have never ever heard about MeB. so odd.

indeed!

Huh!

Weird, but ok

come to think of it, I'm going to make an account for that, so we can keep track of how many phantom checks we get in a year.

makes sense

reosarevok: if you are interested, this article goes into what its about briefly. https://bam.kalzumeus.com/archive/charitable-do...

I read it the other day, it was interesting

(thanks for sharing

*)

ah cool. np

I just dunno, expected they mostly went for bigger, cooler orgs than us :p

Hey, are you guys facing problems with PSQL on wolf too?

I've been getting the following err for a min... (full message at https://libera.ems.host/_matrix/media/r0/downlo...)

PrathameshG[m]: seems to work fine for me.

mayhem: Has the port or host changed or something?

PrathameshG[m]: i see, ports changed between bono and wolf. try 5432 instead of 25432