#metabrainz

/

      • monkey
      • mayhem
        what a bunch of misfits we are. <3
      • Freso
        And that wraps up the meeting.
      • alastairp
        reosarevok: it's your birthright to have a "bridge"
      • zas
        monkey: :)
      • Freso
        Thank you all for your time! Take care of yourselves! (Remember to start on your allergy meds if you need to.)
      • </BANG>
      • yvanzo
        Thanks everyone!
      • akshaaatt
        Thank you!
      • monkey
        Thank you!
      • alastairp
        https://news.ycombinator.com/item?id=30990697 when does our jira license expire? :/
      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2485 (03master…MBS-12305): MBS-12305: Allow editing/translating instrument (root) rel attribute https://github.com/metabrainz/musicbrainz-serve...
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda [Easter Monday off; next meeting: 2022-04-25]: Reviews
      • mayhem
        alastairp: not so much license, but standalone installs are end-of-life.
      • and I think that is soonish, like this year. but I'm always wrong, so...
      • alastairp
        yeah, so if we want to upgrade it's cloud-only?
      • lucifer
        we should probably migrate off jira to something else?
      • Freso
        alastairp: "The cloud is just other people’s computers."
      • mayhem
        alastairp: I believe so.
      • lucifer: I think we should consider that.
      • reosarevok
        Jeez, not another ticket tracker migration
      • mayhem
        the landscape for issue trackers has changed a lot since we moved to jira.
      • alastairp
        reosarevok: that just shows how long you've been around at MeB for
      • lucifer
        oh lol. i just remembered seeing remanants of that in mbh tickets
      • reosarevok
        Yes, and we lost all data from there, which is fun
      • All dead links
      • lucifer
        uh :(. that's definitely a thing we need to take care of this time then if we choose to migrate to something else.
      • reosarevok
        And I've actually fixed 10+ year old tickets, so the history is certainly important
      • Unless the competition is *amazing*... I'd certainly stick with jira as long as possible. We also have working workflows etc
      • But I understand at some point it might not be doable
      • alastairp
        on another project that I just finished archiving, I just `wget --mirror`d the entire site and put it up on nginx
      • lucifer
        yeah makes sense
      • reosarevok
        If we end up migrating, ideally we'd find a way to copy everything, including comments
      • Not sure how doable that is but
      • lucifer
        monkey: oh if you are still around, chinmay had some UI related ques just before the meeting.
      • akshaaatt
        If it's too complicated, GitHub issues might be an easy answer for the migration. Unless I'm missing some important functionalities. There seem to be some migration scripts available online
      • monkey
        Let me look
      • lucifer
        oh Xianyi's question too is frontend ui related.
      • monkey
        chinmay: For your question 1, I'd say Followers + Following only. I don't know how worried we need to be with spamming, but the search box seems like we're just asking for it. But that's just my opinion, not sure what everybody else thinks
      • Question 2: Yes, it's good to have that visual confirmation
      • Question 3: I don't think so no. If we're talking about feed events anyway, those are all personal and only viewable by that user
      • skelly37
        outsidecontext: Hi, I see you're online, so: Should I include my personal details (name etc.) in actual GSoC application or just the draft posted on the forum (with info about me paragraphs stripped)? I did the second one but I'm just asking to be 100% sure I won't lose to formalities hah.. Also sorry if you've anwsered this question previously but I had to take a few days off.
      • akshaaatt
      • monkey
        Mockups look good, I'd also be interested in seeing what the recommend to a user modal would look like based on the above :)
      • yvanzo
        alastairp: We have until February 2024, see OTHER-373
      • BrainzBot
        OTHER-373: Migrate Tickets from Jira Server https://tickets.metabrainz.org/browse/OTHER-373
      • alastairp
        yvanzo: thanks
      • oh, but here I am thinking that 2024 is like 5 years in the future
      • reosarevok
        That's also end of support only, so we could technically continue using it, but I assume some terrible exploit will be found
      • lucifer
        skelly37: i think its upto. iirc i didn't include personal details in my proposal.
      • *upto you
      • reosarevok
        bitmap: is there any good way to add a small test for https://github.com/metabrainz/musicbrainz-serve...
      • skelly37
        lucifer: okay, good to hear it, thanks
      • reosarevok
        especially if we want to put it out today having a test would be good for peace of mind :)
      • chinmay
        monkey: Thanks for clarifying all of them :)
      • lucifer
        skelly37: to be clear, in my proposal when i participated 2 years ago but can say the same for now :D
      • Xianyi
        lucifer, yes, I don't know whether it's OK to update to the FontAwesome 6, because it may cause some trouble
      • lucifer
        monkey: again for you ^ :)
      • also thanks for answering the queries!
      • skelly37
        Gonna take it easy then :)
      • alastairp
        skelly37: you don't have to include any personal information in your proposal on the forums
      • chinmay
        Guys, I'm having a difficult time with the GSoC timeline for my draft proposal :(
      • Xianyi
        And may be all the code related to the icron need to change...
      • monkey
        Xianyi: You can try updating it in your local copy, and see if there are any issues. I'm sure there's a migration guide to follow
      • lucifer
        alastairp: i think they were asking about final proposal PDF.
      • alastairp
        any information that's required on the actual gsoc page will only be seen by this year's mentors
      • monkey
      • skelly37
        alastairp: I'm not talking about forums. I've already sent final PDF to google. My proposal on the forums was already approved by everyone :)
      • alastairp
        skelly37: right, sorry - I guess eventually we may need to contact you. but if you don't want to share some specific information such as name or email then I see no reason why you can't omit it and use just a nick
      • skelly37
        alastairp: That's not a problem, my name and email are public on my github in case they're needed.
      • lucifer
        alastairp: we'll see the email in mentor dashboard anyway (the mail used to apply to gsoc).
      • Xianyi
        monkey, Thank you! I already tried it(y)  Just not sure it's OK for the community to change the Package to another version. I will keep working on it!:]
      • =D
      • lucifer
        monkey: oh i just logged in to mentor dashboard and see there are a few BB proposals but iirc only 1 on forums. if those students are in touch, may want to ask them to submit on forums as well.
      • bitmap
        reosarevok: I'll see if it's feasible. it'll be kind of weird since it's testing if the page loads under x amount of time
      • outsidecontext
        skelly37: what lucifer and alastairp said
      • Also sorry for not answering earlier. I'm always lurking here and eventually will read everything mentioning me, but it might to able me some time to answer :)
      • lucifer
        alastairp: the BB reviews project is intended to be 175 or 350 hours?
      • skelly37
        relax, no problem :)
      • alastairp
        lucifer: yeah, i need to discuss that with monkey
      • lucifer
        ah cool 👍, i saw Ansh marked it as medium on SoC site whereas my impression was its a large one so wanted to confirm.
      • reosarevok
        bitmap: I was more thinking "testing that it uses the right kind of diff and that the diff works as expected"
      • Rather than speed as such
      • By definition it should be faster :)
      • skelly37 has quit
      • bitmap
        well, the diff itself should be identical
      • or do we not have any annotation diff tests at all?
      • reosarevok
        Well, I was thinking you could have a test of 900 chars and one of 1001 (using \s) and see they work
      • skelly37 joined the channel
      • Not so much directly about annotations
      • But dunno :)
      • yvanzo: any chance you could review https://github.com/metabrainz/musicbrainz-serve... ? That's basically a regression we should fix because it's *so* slow rn
      • So I was hoping to release it as part of today's (or I guess tomorrow's) prod release
      • Ansh
        alastairp: I've proposed a medium-sized project, but I plan to work for 30 hours/week. If you both feel the project should be changed to a large-sized project, please let me know. I'll rework my timelines.
      • bitmap
        reosarevok: do you think we should change annotation diffing to use \s+ then?
      • reosarevok
        This was a different issue (as in, this will change diff in very long \s+ strings so we should test those)
      • But I dunno about changing annotation
      • How well does that work with things like those damned emoji flags?
      • bitmap
        probably treats them each as one word
      • assuming they have spaces around them
      • reosarevok
        Then it might not be a bad idea
      • bitmap, yvanzo: given we have a fair amount of smaller bug fixes and whatnot, wonder if it would make sense to postpone one week, merge these to beta this week, release next week
      • Since the list of merged things is currently small
      • yvanzo
        I would prefer to keep the extra week for the schema change release if you don't mind
      • reosarevok
        I mean, I'd have no issues at all with releasing these next week, and then having no more releases until the schema change
      • yvanzo
        Count the weeks we have
      • reosarevok
        5, no?
      • asymmentric joined the channel
      • yvanzo
        Oh if you mean skipping a release... why not.
      • reosarevok
        I did :)
      • So, put any smaller bugfixes we have into beta this week, release all the bug fixes next week, then just concentrate on schema change
      • yvanzo
        That seems smoother than bypassing beta.
      • reosarevok
        Yeah, that was my thinking
      • And it gives us a bit more stress free time to test schema changes
      • yvanzo
        bitmap: what are your thoughts about it? ^
      • bitmap
        agreed, that sounds perfect
      • asymmentric28 joined the channel
      • asymmentric28 has quit
      • reosarevok
        Sweet
      • asymmentric25 joined the channel
      • asymmentric25 has quit
      • asymmentric has quit
      • asymmentric73 joined the channel
      • asymmentric73 has quit
      • There are three not yet approved recent bugfixes: https://github.com/metabrainz/musicbrainz-serve... and https://github.com/metabrainz/musicbrainz-serve... (which would be neat, but not urgent)
      • And https://github.com/metabrainz/musicbrainz-serve... (which we really should put out this time anyway)
      • Oh, I see yvanzo approved that last one
      • Awesome
      • bitmap: if you have a bit of time to check the other two, I can put all of these out tonight and then we hopefully do only schema change from then on
      • (and any beta fixes, but)
      • I'm not on holiday next Monday so I'm happy to release even if meeting is off and whatnot
      • Xianyi has quit
      • bitmap
        I can check them after I finish writing this test
      • reosarevok
        Awesome
      • asymmentric joined the channel
      • asymmentric has quit
      • riksucks
        monkey: thanks for letting me know how the new LB frontend is gonna be like. Also, thanks for the advice, I plan to proceed just like that (making the context menu first and then the drag and drop feature, feel free to check the timeline in the proposal :) ). Speaking of timeline, whenever you go by my proposal, please feel free to scrutinize the proposed timeline, since I have taken into account possible discussions on UI/UX or code
      • reviews that can take place during SoC, based on my experience in previous PRs. If you feel like I should scooch in more time or less, do let me know. Thanks again :D
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2485 (03master…MBS-12305): MBS-12305: Allow editing/translating instrument (root) rel attribute https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-server] 14reosarevok merged pull request #2467 (03master…MBS-12279): MBS-12279 / MBS-12283 / MBS-12284: Drop more manual deletion options and fix related issues https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-server] 14reosarevok merged pull request #2482 (03master…MBS-12303): MBS-12303: Display non-diff annotation data over all columns https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-server] 14reosarevok merged pull request #2483 (03master…MBS-12304): MBS-12304: Only run guess feat on nonempty names https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-server] 14reosarevok merged pull request #2481 (03master…MBS-12280): MBS-12280 (I): Add target _blank to edit form links https://github.com/metabrainz/musicbrainz-serve...
      • reosarevok
        bitmap: oh, btw, did you see my comments on https://github.com/metabrainz/musicbrainz-serve... ?
      • bitmap
        oh, yeah, I forgot about them
      • I can change it to options?.timezone, I think you're right about that
      • didn't check FormRowPartialDate though
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2479 (03master…MBS-12298): MBS-12298: Update to new triplejunearthed domain https://github.com/metabrainz/musicbrainz-serve...
      • Xianyi joined the channel
      • Xianyi has quit