0:34 AM
Shubh joined the channel
2:22 AM
darkstardevx joined the channel
2:23 AM
darkstardevx has quit
2:23 AM
darkstardevx joined the channel
3:43 AM
Shubh has quit
5:06 AM
Shubh joined the channel
6:45 AM
odnes joined the channel
7:09 AM
yvanzo
O’Moin
7:10 AM
recordings indexed, restart processing queued messages now
7:10 AM
zas
mooin
7:10 AM
yvanzo: what was needed from me? I saw few pings, but I was afk for a while
7:11 AM
do you still need /ws/2/recordings to 503?
7:11 AM
yvanzo
hi zas: not anymore
7:11 AM
however, it seems something is amiss with cover art
7:11 AM
zas
7:16 AM
yvanzo
possibly
7:18 AM
zas: "prod.caa-redirect" has been readded to consul config
7:19 AM
on Monday
8:11 AM
MRiddickW joined the channel
8:13 AM
Goldmaster61 has quit
8:14 AM
Goldmaster61 joined the channel
8:15 AM
Shubh has quit
8:35 AM
Shubh joined the channel
8:45 AM
chinmay joined the channel
8:48 AM
skelly37 joined the channel
9:10 AM
alastairp
tandy1000: yes! recommended albums + some fun way of filtering like huesound would be great
9:14 AM
good morning everyone
9:15 AM
lucifer
morning!
9:23 AM
akshaaatt
moin!
9:24 AM
alastairp books tickets to Prague
9:29 AM
mayhem
alastairp: beer trip?
9:29 AM
I got a beer place rec for ya.
9:29 AM
alastairp
conference / holiday / beer
9:29 AM
mayhem
very nice.
9:30 AM
alastairp
even nicer when the grant pays for the flights ;)
9:30 AM
mayhem
monkey: when I brought my desktop machine out of sleep, the metadata viewer updated to show my now listening.
9:30 AM
that is freaking great. :)
9:30 AM
monkey
Ah, good :)
9:30 AM
Good to know the websocket connection/reconnection works well
9:31 AM
mayhem
it does. quite happy about that.
9:33 AM
akshaaatt
reosarevok: do we have a doc/readme as to how tests are written for musicbrainz?
9:38 AM
reosarevok
There's maybe a bit in HACKING.md
9:38 AM
CatQuest
just as long as it's not in SLASHING.md
9:39 AM
akshaaatt
9:40 AM
I'm not quite sure as to how these tests work. Are there any resources available talking about how to understand the process?
9:48 AM
9:48 AM
alastairp spies 2022-05-018 sample dump
9:48 AM
alastairp
thanks bitmap, reosarevok, and yvanzo
9:53 AM
yvanzo
search indexer now processes upcoming updates normally, it still has to retry 70k updates sidelined during the recording reindex.
9:55 AM
alastairp
yvanzo: did it manage to finish recording index?
9:56 AM
yvanzo
yes
9:57 AM
reosarevok
akshaaatt: selenium is magic. I'm on holidayish until next week, but maybe yvanzo or bitmap can help
9:58 AM
Given it's open ac related, probably bitmap :)
9:58 AM
akshaaatt
Hahaha. Calling it magic in a positive term or considering it as an oracle?
9:59 AM
bitmap it is then!
9:59 AM
alastairp
great news
9:59 AM
akshaaatt
You guys do deserve a break btw. Congrats on the schema change bitmap, reosarevok, yvanzo!
9:59 AM
yvanzo
I’m still not to the level of Selenium tests.
10:00 AM
akshaaatt
I'm in no hurry btw. Already got a lot to work on. Feel free to setup a week or two for me where we can review and merge the revamp PRs
10:01 AM
yvanzo
bitmap, reosarevok: I will be half-off too once the search indexes have been fully restored.
10:03 AM
mayhem
monkey: is being able to tag a release from the metadata viewer on your radar? It seems we can tag a track, but not a release.
10:03 AM
monkey
There are currently no tags returned for releases in the metadata, but it would be easy to add if we get that piece of data
10:04 AM
alastairp
but do you mean to submit a tag to MB, or show them?
10:04 AM
mayhem
both, ideally.
10:04 AM
monkey
10:04 AM
mayhem
I believe you. :)
10:07 AM
mayhem asks himself why this wasn't included in the first place.
10:09 AM
monkey
And we did talk about it a month or so ago :)
10:09 AM
I've also got to add the API query to get more release info
10:10 AM
mayhem
sorry, my brain has been impacted for a couple of months now. hopefully digging out now.
10:10 AM
monkey
Because that panel is too empty for my taste at the moment
10:10 AM
No worries, I've had a mushy brain myself
10:13 AM
BrainzGit
10:17 AM
MRiddickW has quit
10:21 AM
mayhem
done. :) lol.
10:22 AM
Etua joined the channel
10:23 AM
lucifer
mayhem: what do you think of rechecking incoming listens if their msids are unmatched and were last checked over X days ago (2 weeks?) ?
10:25 AM
mayhem
yes, I'd love to have that happen.
10:25 AM
the devil is in the details, really.
10:25 AM
alastairp
if there is available time in the mapper then that sounds nice
10:25 AM
lucifer
cool, will add it then.
10:26 AM
mayhem
given that we have threads that fire off periodically, how would you do that, lucifer ?
10:26 AM
lets discuss a plan for that.
10:26 AM
lucifer
mayhem, i'd do it in the incoming thread.
10:26 AM
mayhem
elaborate, please.
10:26 AM
lucifer
sure one sec
10:28 AM
10:29 AM
WHERE recording_msid IN :msids AND (last_updated != '1970-01-01' OR (NOW() - last_updated > INTERVAL '2 weeks' AND match_type = 'no_match'))
10:29 AM
alternatively we could invalidate the msids matching ` last_updated > INTERVAL '2 weeks' AND match_type = 'no_match')` and wait for the legacy thread to pick those up
10:30 AM
mayhem
huh, your first idea is very clever.
10:31 AM
so your idea would re-check if an unmatched listen comes in again. but it would never match if that is never listened to again.
10:32 AM
lucifer
yes that is the case i currently aim at solving.
10:33 AM
mayhem
I think that is a simple fix for a lot of listens that don;t get rechecked. lets do that for sure.
10:33 AM
lucifer
if noone listened again, that is a case that'd need to be solved separately.
10:33 AM
makes sense
10:33 AM
mayhem
agreed. lets do that.
10:34 AM
I think the second idea is one we should pursue as well, but that isn't as pressing.
10:34 AM
lucifer
👍
10:52 AM
Etua has quit
10:55 AM
chinmay has quit
11:02 AM
akshaaatt
Hi monkey! Thanks for your review on the PR I had requested :)
11:02 AM
Regarding the updates, I'm hoping we'll fix the CSS including changes like hover color, width of the items etc in another PR once we have the base ready
11:03 AM
monkey
Yeah, that sounds good. I just wanted to put it on our radar, but it doesn't seem to be the right PR for this
11:03 AM
akshaaatt
My major aim is to completely get rid of the custom CSS and then target global variables/theme to work on that
11:03 AM
Yes, lovely review!
11:04 AM
monkey
11:04 AM
We might need to have some fallback css for older borwsers
11:04 AM
akshaaatt
Interesting!
11:04 AM
Makes sense
11:05 AM
Thanks for the heads up
11:05 AM
So, what do we consider the status of the PR, is it ready to be merged?
11:06 AM
monkey
There are some items in my reveiw that need to be modified in this PR (and I just added another comment: the navbar doesn't collapse in small sizes)
11:06 AM
akshaaatt
Yusss just saw that
11:06 AM
Onto it then! Thank you!
11:07 AM
monkey
My pleasure !
11:08 AM
Good work :)
11:10 AM
atj
akshaaatt: I noted that the README file for the docker dashboard is the index page on GitHub pages. What's the URL for the actual dashboard?
11:12 AM
akshaaatt
11:12 AM
Anytime we make updates to the repo, it will automatically be updated
11:13 AM
atj
OK, thanks
11:13 AM
can you install the Datatables plugins?
11:13 AM
akshaaatt
Yaass suree
11:13 AM
atj
we'll have to get some consensus about paging, I just disabled it because I think most people will want to be filtering the entire list
11:14 AM
akshaaatt
Makes sense
11:20 AM
For reference btw atj,
https://github.com/metabrainz/docker-container-... is where our actual code lies. Feel free to check it out and let me know what should be done. We'll mostly finalize the UI for this page by tomorrow and look to make an endpoint for serving the json
11:21 AM
Your script would be handy for the api
11:26 AM
BrainzGit
11:35 AM
Shubh has quit
12:21 PM
mayhem
among my BS tasks for the day: full out our insurance renewal.
12:21 PM
we're weird. very weird. even on paper we're weird.
12:21 PM
12:21 PM
no employees, 12 contractors, 25k volunteers.
12:22 PM
akshaaatt
😂😂😂😂😂😂
12:23 PM
Well, ideal open-source environment!
12:28 PM
mayhem
12:32 PM
yvanzo
dumping search update messages as 50k have still not been processed
12:36 PM
now re-queuing
12:39 PM
mayhem
WTF does insurance ask about cars?
12:39 PM
reosarevok has a car as Zas does. not sure about anyone else. what does it matter?
12:46 PM
skelly37 has quit
12:50 PM
reosarevok
Well, officially the car is my wife's, but :D
12:51 PM
yvanzo
isn't it just about professional car, rather than personal car?
12:51 PM
mayhem
it included mentions of personal cars, but it might only be in context of employees not contractors.
12:51 PM
it has no relevance for us.
12:52 PM
yvanzo nods
12:54 PM
yvanzo
nobody uses a personal car in the context of work afaik, even when BCNers go to the office it's not by car
12:54 PM
mayhem
exactly.
12:54 PM
there are almost no parking spots between my hour and the office. a car would be a nightmare!
12:59 PM
13:00 PM
monkey