#metabrainz

monkey: ^^ are you aware that the "no cover art image" is broken?

Ah, no, that's not expected

yes, it looks very odd since the web site does the right thing.

Let me restart the client.

Can you inspect the html in any way?

Maybe it's trying to get a cover art but it can't find it/ query failed or something

gah, just closed it and restarting it fixed it.

OK. Probably failed to fetch the image one way or another

yes, you can toggle dev tools.

should I happen again, I'll look for errors.

and yes, that does look better.

I set it up as we said so that's it lazily queries the API (only if tab is open), but currently it runs the query each time you expand that tab :p

So one more thing to fix before PR

great.

only if tab is open -> only if release tab is expanded

Here in India, a lot of 18 y/o people also have cars

I'm nearly done with MeB BS, after that I'll see about getting release tags going

Not me currently but a lot of my friends do

Neat. It's all set up for it

akshaaatt: I drove for 26 years in the US. there was no alternative.

Damn nice!

opposite problem here, the parking lot is so large that it wound be a nightmare finding my car if I ever had one

I'm so glad to not drive here anymore.

Europe seems well connected so a need for car wouldn't arise

The trains function well there I reckon

and yet, there are many car countries in europe. spain and germany both are car cultures.

despite both having excellent public transit.

yes, spainish trains are now more punctual and reliable than german ones. 🤯

Meh, train system in Spain is so-so sometimes

having spent a lot of time on trains in the last week.

Depends on the region, I found

Delhi, in India, has nice Metro connectivity. Probably the best in India. Yet the only problem is the population

yeah, for sure. was good near Jerez.

Poor Rodalies is overloaded and under supported. the system is already running at 110% of designed capacity.

Ohh!

even then more often than not train journeys go well without significant problems.

I think the point that pains train journey is that you do need a cab/car to get to/from the station. Hence a lot of people prefer one ride overall

which is the reason why high speed rail would never work in the US.

you need buses/trams, then metro, then regional rail, then intercity rail, THEN high speed rail.

you can't go from one to the last step.

Right!

Here in BCN we have all of that. In spades. Including Funiculars!

Can't wait to visit!

Some owl trains have been recently back on track in France, if you ever come from far to visit BCN…

owl trains being night trains?

yes

yes, they are coming back. next year we're getting BCN -> Zurich.

alastairp and I were just looking at those the other day. Overnight trains <3

DB used to have a lot of them and get rid of them ALL. Amidst many complaints. And ÖBB bought all their rolling stock, fixed them up and pushed our a new fleet of night trains. And now they are scrambling to catch up to something that has a lot of consumer demand behind it. 🤦

LB team: after some consideration, I think the route for the metadata viewer should be /listening-now instead of /playing-now. Thoughts?

I hear you and I think we need to step back a little and consider the branding of this overall.

because we have open questions about what we call this feature.

Listening Now

Now Listening

Playing now doesn't fit with the name of the project.

Yep. I think Listening Now works better

yes, it is inconsistent with our API docs, hower.

But we didn't choose that name, I think it comes from last.fm.

I'm not too fussed about calling listening now.

So, the features is called "Listening Now" and the app is called "ListenBrainz Listening Now" ?

Listening Now by ListenBrainz ?

[docker-python] 14yvanzo opened pull request #17 (03master…up-doc-27): Removed previous 2.7 images https://github.com/metabrainz/docker-python/pul...

alastairp: ping

pong

I'm reading your mapping docs... first off, thanks!

second, I don't consider those tables the mapping itself. the mapping, IMHO are the two tables stored in gaga.

these are supplemental tables for the mapping.

and I think it might be good to give these tables a bit of a differentiating name.

sure, makes sense

MBID Mapping supplemental tables?

happy to split it up into "this is a mapping", and "these are the data tables used to make the mapping (btw, here is a download link if you want them")

great.

I initially started to write it as a "how to debug if a mapping isn't showing on LB", but after reading into the code more I realised it tied right into the dumps stuff that I'm doing

supplementatl tables sounds fine to me

when you get around to the detuning TODO, lets me know and I can explain it. but we're hoping to make improvements there too.

sure

lucifer: ping

yvanzo:pong

lucifer: See https://github.com/acoustid/mbdata/issues/47 if you have time :)

yvanzo: i see. i had faced the same issue initially, will reply the fix in some mins.

I did not find which one of your many branches to submit as a pull request :D

bitmap, reosarevok: Indexed search has been fully restored, next dump will be available on Saturday as usual (I restarted cron service), I’m off now.

zas: hey, if you're available can you help look into the coverartarchive DNS change?

zas is off for the weekend. what do you need?

yvanzo: np, i have many branches waiting to be cleaned up :p. i opened a PR at mbdata now.

mayhem: we need coverartarchive.org to point back to the main gateways instead of purple

ok, on it.

effective immediately?

yes, the services are all up and running

done.

c3600/60

nope, irc doesn't do mathc.

should be done in 60 minutes, bitmap.

mayhem: thank you!

my personal cache has updated and I see caa.org fine. are you seeing traffic bitmap ?

the load on purple is dropping

I am seeing traffic now, yes

all looks good to me

great

zas: atj: purple will revert back to hetzner on June 1.

[design-system] 14akshaaatt opened pull request #76 (03master…containers-sass): Import Container Sass file https://github.com/metabrainz/design-system/pul...

[design-system] 14akshaaatt merged pull request #76 (03master…containers-sass): Import Container Sass file https://github.com/metabrainz/design-system/pul...

[listenbrainz-server] 14amCap1712 opened pull request #1998 (03master…recheck-listens): Recheck unmatched incoming listens periodically https://github.com/metabrainz/listenbrainz-serv...

Hi bitmap! Could you have a quick read at https://github.com/metabrainz/design-system/blo... and let me know if it looks good

[listenbrainz-server] 14MonkeyDo merged pull request #1994 (03master…fix-listens-page-feedback): Show *logged in user's* feedback on listens page https://github.com/metabrainz/listenbrainz-serv...

akshaaatt: hi, I'll have a look at the PR and leave some comments when I get a chance

akshaaatt: component usage guidelines look good. Not sure what "dumb" and "smart" components means though, maybe a very short description would be helpful.

I'd also suggest that we set up some form of automated formatting; a lot of these guidelines can basically be replaced and enforced by a bot

One option would be a Github action that runs on PRs

Thank you bitmap!

Sure monkey! The GitHub action idea sounds cool to me but not sure how that would work

I'll have a look. Another option would be to do it locally using git-hooks to format on pre-commit

For Github actions, something like this: https://github.com/marketplace/actions/prettier...

This uses prettier to format, but we could alsofind another tool if more appropriate

Interesting!

I've heard good and bad opinions about prettier: there are basically no options to tweak, so it will format in one style, end of discussion. No time wasted arguing about number of space or which quote characters to use.

For automatic linting, have a look at https://github.com/metabrainz/bookbrainz-site/b... and https://github.com/metabrainz/bookbrainz-site/b...

I'm fine with using prettier monkey

You can *probably* just copy those directly and they should work

I don't think we use it in musicbrainz currently though

Do you want these workflows added to MusicBrainz and ListenBrainz, monkey?

This action has an example of using Prettier and ESLint together: https://github.com/wearerequired/lint-action#ja...

I think we should leave those decisions to each project, but for the design system where components are shared across projects I think it makes sense to be tight about formatting and linting

Great!

I think BrainzPlayer UI would be a great fit for DS

Possibly yes :)

But that makes me question whether we would be duplicating code

I'm not sure how just the UI could be here in DS while the functionality is all the way in another repo

We still haven't figured out how individual components could be plugged from DS to another repo

Also, bitmap discussed with me a while back that since MusicBrainz provides content in many languages, it cannot share components as such.

Any thoughts on this monkey?

If we can't have the functionality bundled up with it, then it's not a good fit for the DS.

Right

I hadn't thought much about languages. Is this an issue with translations?

Yeah basically the i18n config needs to be managed per repo. Hence UI where any text is involved can't be plugged from someplace else

I guess we could make all text overridable with default in english (I guess); probably a fair amount of work but not crazy

Either that or we decide to only have components without text, which is probably quite limiting