And also also, happy 2000th pull request ListenBrainz !
2022-05-20 14024, 2022
monkey
🎉
2022-05-20 14007, 2022
lucifer
ooo 🎉🎉
2022-05-20 14054, 2022
chinmay
YESS💥
2022-05-20 14009, 2022
BrainzGit
[listenbrainz-server] 14amCap1712 opened pull request #2001 (03master…recs-improvement): Some misc improvements to recommendation processing and display https://github.com/metabrainz/listenbrainz-server…
atj: are you able to unblock IPs from the gateways?
2022-05-20 14020, 2022
mayhem
lucifer: regarding #1998 (which was an awesome year, all around, but that is off topic)... I see what you did and it makes me...
2022-05-20 14029, 2022
mayhem
want to complicate things. 🤦
2022-05-20 14001, 2022
mayhem
I have this, perhaps incorrect, impression that there will be a flurry of activity around new tracks around friday.
2022-05-20 14036, 2022
lucifer
i see. so rechecking old stuff may overwhelm the mapper?
2022-05-20 14043, 2022
mayhem
it would be nice if we could do some sort of exponential back-off here -- check a track frequently when it is new, but less frequently as time goes on.
2022-05-20 14031, 2022
mayhem
overloading the mapper is possible, but really hard to predict. I'm more concerned about people having to wait 2 weeks for a track to be remapped.
2022-05-20 14039, 2022
lucifer
ah i see
2022-05-20 14044, 2022
mayhem
e.g. I listen to a track. I realize its not in MB, I add it. then wait 2 weeks.
2022-05-20 14041, 2022
mayhem
but in order to do a back-off we would need another piece of information to build the back-off.
2022-05-20 14058, 2022
mayhem
tricky.
2022-05-20 14007, 2022
lucifer
yeah we'd need listened_at in the table i think.
2022-05-20 14003, 2022
lucifer
which is not as simple because the table is on msid and multiple people could have listened to it. or same person multiple times.
2022-05-20 14008, 2022
mayhem
slightly OT question: Will the last_listened timestamp be added to statistics too? I think it should -- because stats will be a source of info for troi and I would want to know when a track was last listened and having it in the stats API would be ideal.
2022-05-20 14019, 2022
mayhem
indeed, it is tricky.
2022-05-20 14022, 2022
lucifer
sure thats doable
2022-05-20 14043, 2022
mayhem
that would be most useful!
2022-05-20 14050, 2022
lucifer
for recordings currently, for releases and artists will need to implement it but not hard.
2022-05-20 14020, 2022
mayhem
I think recordings are the ones I care about the most. but the others could be useful, but not imprtant now.
2022-05-20 14027, 2022
lucifer
makes sense
2022-05-20 14008, 2022
mayhem
oh and I think I will try my hand at making a daily-jams-energy list and a daily-jams-chill list.
2022-05-20 14036, 2022
mayhem
I think I will try to classify top level genres into energy and chill and then pick those tracks from recommended tracks.
2022-05-20 14019, 2022
lucifer
how about building the backoff based on last_updated times. store all last_updated times in database. check after `number of times already checked days` or a multiple of it. so check on day 1, then day 2, day 4, day 8?
2022-05-20 14018, 2022
lucifer
the daily jams energy and chill idea sounds good! :D
2022-05-20 14034, 2022
mayhem
would we need to store all last_updated times or just last and previous-to-last?
2022-05-20 14056, 2022
mayhem
if we have previous to last we can just double the difference between the two last timestamps...
2022-05-20 14025, 2022
mayhem
actually more in reverse.
2022-05-20 14032, 2022
mayhem
how about a check-again, timestamp?
2022-05-20 14035, 2022
lucifer
thinking more maybe add another column of number of times checked? but previous to last also makes sense.
2022-05-20 14038, 2022
mayhem
last_updated and check-again.
2022-05-20 14033, 2022
lucifer
check again makes sense. so first time set it +1 day, after that keep doubling check again - last udpated time?
2022-05-20 14042, 2022
mayhem
so, if we get a listen for a track that has no match, check if we are past check-again. If so, check again. if still not found, push check-again out by twice the difference before and move on.
2022-05-20 14049, 2022
mayhem
yes!
2022-05-20 14055, 2022
lucifer
yes makes sense
2022-05-20 14005, 2022
mayhem
yeah, that feels right to me.
2022-05-20 14027, 2022
lucifer
cool, i can work on adding this.
2022-05-20 14029, 2022
mayhem
how should we proceed with #1998? close for now or accept for now?
2022-05-20 14022, 2022
lucifer
lets accept for now and release, i am not sure the change will be done today so maybe let the mapper run for 2-3 days on it.
mayhem: possibly, can you PM me the IP and I'll check?
2022-05-20 14021, 2022
Shubh joined the channel
2022-05-20 14028, 2022
alastairp
lucifer: sure, let's try it!
2022-05-20 14012, 2022
lucifer
alastairp: thanks! i'll update the PR with latest master and then merge.
2022-05-20 14036, 2022
alastairp
monkey: by the way, I've been told that there's a direct TGV from CDG to St Pierre-des-Corps, which solves most of the problems we encountered
2022-05-20 14013, 2022
monkey
Well that's handy.
2022-05-20 14010, 2022
monkey
Yes to the CB review PR ! Let me know if you need any front-end help
2022-05-20 14039, 2022
alastairp
although he has just suggested that I take a 6:15am flight on monday which will get me to the venue 5 minutes before they start. I think I'll politely decline and go on Sunday instead :-P
2022-05-20 14023, 2022
alastairp
monkey: got a moment to give some feedback on a react question?
you may have seen some similar code to this before - it's the stuff that uses Verovio to generate some svg text then we dangerouslySetInnerHTML it
2022-05-20 14044, 2022
alastairp
I want to highlight some elements on the svg (the 2nd useEffect) but I found that sometimes the effect triggers just before the render happens, and so the elements don't exist. hence I hacked it together by putting it in a setInterval
2022-05-20 14025, 2022
alastairp
I'm aware of course that directly modifying the dom after it's been rendered is a bit naughty, but I'm thinking of other ways to do it
2022-05-20 14046, 2022
alastairp
two options I thought of: instead of modifying the element directly, render a <style> block which applies a style to each #id; or load the svg into a DomParser after it's generated and modify it before rendering the component (I think you and I may have talked about this idea before?)
2022-05-20 14058, 2022
monkey
Option one sounds a bit cleaner. But I think it might be best to investigate why "sometimes the effect triggers just before the render happens" instead, if that would fix the issue cleanly
2022-05-20 14037, 2022
alastairp
yeah. it was happening in the right order on my local machine, but when I deployed it to a slower server it got out of whack
2022-05-20 14048, 2022
monkey
Hm, I don't have any better suggestion
2022-05-20 14004, 2022
alastairp
ideally I'd actually want to draw a box around it anyway, which I need to look into. In that case I need to render it, identify the coordinates of the things that need a box around them, then render the boxes with those fixed coordinates
2022-05-20 14008, 2022
alastairp
I have a bit of code for that already
2022-05-20 14048, 2022
monkey
Question: why setInterval? Do you want to run this repeatedly?
2022-05-20 14005, 2022
alastairp
because I don't know how js works? 🤷
2022-05-20 14043, 2022
monkey
User setTimeout :)
2022-05-20 14046, 2022
monkey
User*
2022-05-20 14049, 2022
monkey
Use*
2022-05-20 14049, 2022
alastairp
thank you!
2022-05-20 14051, 2022
monkey
Damn it
2022-05-20 14032, 2022
monkey
Honestly the current solution doesn't seem sooooo bad.
2022-05-20 14049, 2022
monkey
As long as you're limiting it to presentational changes
2022-05-20 14039, 2022
alastairp
yep, it's just a visual indication of "hey, here are the notes that you were interested in"
2022-05-20 14009, 2022
mayhem
akshaaatt: ping me when you have a moment.
2022-05-20 14012, 2022
atj
reosarevok: has anyone ever suggested that labels should support annotations?
2022-05-20 14037, 2022
reosarevok
They... do?
2022-05-20 14000, 2022
reosarevok
Link is on the sidebar
2022-05-20 14017, 2022
mayhem
reosarevok: aren't you supposed to be on vacation? 😠
2022-05-20 14040, 2022
reosarevok
I am! I'm sitting by a fireplace in a small hut while I wait for the rain to stop :D
2022-05-20 14056, 2022
mayhem
go play some video games then!
2022-05-20 14021, 2022
mayhem
sheesh, doing vacations like me.
2022-05-20 14001, 2022
atj
reosarevok: sorry :/
2022-05-20 14007, 2022
reosarevok
haha, it's ok!
2022-05-20 14019, 2022
reosarevok
atj: were you expecting it to be part of the main editor like for release?
2022-05-20 14031, 2022
reosarevok
I can see how that's a bit confusing
2022-05-20 14018, 2022
atj
yeah, that's why I was confused
2022-05-20 14030, 2022
atj
I went to edit the label and looked for the annotation field
2022-05-20 14003, 2022
MRiddickW has quit
2022-05-20 14041, 2022
akshaaatt appears
2022-05-20 14041, 2022
akshaaatt
pong mayhem
2022-05-20 14047, 2022
mayhem
akshaaatt: we have received a couple of app ratings saying that the desktop does a much better job at matching tracks.
2022-05-20 14058, 2022
akshaaatt
True
2022-05-20 14005, 2022
mayhem
so, I wonder if we should try this endpoint in the app:
given just the artist name and the recording name it tries to find the best entry on the server.
2022-05-20 14008, 2022
akshaaatt
Let's test how quick I am to updating this
2022-05-20 14011, 2022
mayhem
I think it has a lot of potential and if matching is an issue on the client, then this could be a useful improvement.
2022-05-20 14019, 2022
akshaaatt
Sure!
2022-05-20 14040, 2022
mayhem
thanks, I've been itching for someone to try this in this context.
2022-05-20 14054, 2022
akshaaatt
Cool!
2022-05-20 14017, 2022
mayhem
atj: thanks for that IP removal, that was the problem.
2022-05-20 14004, 2022
atj
mayhem: no problem, I've messaged zas to let him know as I couldn't see any references to him adding the IPs manually
2022-05-20 14010, 2022
mayhem
monkey: I now remembered why I didn't do release_tags at the time.
2022-05-20 14053, 2022
mayhem
it required me to solve a HARD PROBLEM, so I left it. But then I had to solve the same hard problem when dialing in the cover art. and I didn't realize that I had solve the tags problem too.
2022-05-20 14055, 2022
mayhem
fixing now.
2022-05-20 14016, 2022
akshaaatt
Never seen such a sexy api endpoint, mayhem
2022-05-20 14024, 2022
alastairp
lucifer: building schema-27 sample db now
2022-05-20 14034, 2022
lucifer
👍 thanks!
2022-05-20 14044, 2022
mayhem
akshaaatt: that is what I thought, but so far everyone has been "huh. ok".
2022-05-20 14049, 2022
mayhem
thanks for picking this up. :)
2022-05-20 14004, 2022
alastairp
mayhem: the thing is, it just works, and does it well. so it just melts into the background
2022-05-20 14021, 2022
alastairp
if it broke all the time maybe we'd pay more attention to it ;)
2022-05-20 14059, 2022
mayhem
lol, ok. ;)
2022-05-20 14037, 2022
alastairp
mayhem: wolf is still on schema 26, should I go ahead and upgrade it?
