#metabrainz

morning!

moin!

lucifer: did you deploy the cron LB container yesterday?

mayhem: no

can do now if needed?

oh i see, there was a crontab change as well in daily jams. i had updated spark reader but forgot cron.

updated cron now.

we can run the daily jams manually for today to test it?

no way to test it but to generate recommendations, but sure.

port 5000 on wolf is open, is that expected? if yes, is it here to stay? should we exclude a range of ports on this server?

it shuold be closed but iirc alastairp faced some error with exposing it on localhost.

I think it might be good to leave a small window open for us in case we need it.

but in general a range of ports for wolf probably make sense

but Ideally things should be exposed via nginx-proxy.

for more permanent-ish things.

[musicbrainz-server] 14reosarevok opened pull request #2556 (03beta…MBS-12420): MBS-12420: Support comma-separated IDs for edit search types again https://github.com/metabrainz/musicbrainz-serve...

yvanzo, bitmap ^ fix for beta regression no. 1 :)

hmm

monkey: while checking all feedback pages i found that feedback is not shown on playlist or player page either. probably wired incorrectly like recent listens page.

for another PR i guess, doing a final test before merging.

yeah, I know what that was

Ah interesting.

- "${MUSICBRAINZ_DOCKER_HOST_IPADDRCOL:-}${MUSICBRAINZ_WEB_SERVER_PORT:-5000}:5000"

the PR is up on test.listenbrainz.org btw if you'd like to test, only the Love/Hate page had a bug pushing a fix for it now.

Yes please! I'm about to leave for the office but can test when I get there. Give me an hour total?

sure sounds good

alastairp: monkey zas yvanzo akshaaatt lucifer Freso invoices please!

on it

on it

On it!

!ti no

oh engineers!

wolf MB listening on 127.0.0.1 again. it was due to changes in https://github.com/metabrainz/musicbrainz-docke... and some changes that I made yesterday

oh man, I feel seen!

mayhem: Sorry, had to run a quick errand in the morning before jumping into work, and then I got distracted by a lady in a wheel chair trying to handle a big box (thankfully not heavy), so I offered to walk with her all the way home and carry it for her. Just got home from that, fixed up the invoice, and sent it along now!

all good, thanks. and thanks for being a good samaritan.

lucifer: It looks like I triggered a 500 error on the server sending love feedback from my "pins" page with this payload:

{"score":1,"recording_msid":"0fbdb6bc-bc79-432f-9cfc-eaa055d86abf","recording_mbid":"1460126d-5c9b-4e25-9968-b740d4796da0"}

duplicate key value violates unique constraint "user_id_rec_msid_ndx_feedback

looks like we don't check if feedback already exists in the server

lucifer: did you request recommendations to be generated? I see models training for the past hour, so I am guessing yes?

mayhem: yes i had done it some time ago

ok, kewl.

I think I am going to create a toi-bot-debug user for the playlists made from recommendations.

they are piling up.

and maybe I should keep only a limited number of debug playlists and start deleting older ones.

monkey: alastairp: i see. that issue probably exists on prod as well. the easiest way is probably to add another unique index on msid and mbid.

there's also a bug if you submitted feedback using only msid and then submit feedback using msid and mbid both to unlove/unhate it, it won't work.

yeah, I think that's related to monkey's bug

chinmay: sorry its taken a while for me to get to review your proposal. lucifer and I are happy with it and wish to proceed pretty much as you propose. So, please proceed to start hacking on it.

I'll get moving on designing and implementing the API endpoint.

and once GSoC gets officially underway, I"ll have some sort of minimal agreement to put in place to make sure that both you and MeB know what our plan is and what the expected outcome is.

sound good?

[musicbrainz-server] 14reosarevok opened pull request #2557 (03beta…MBS-12332-fix): MBS-12415 / MBS-12416: Limit overenthusiastic overflow-wrap https://github.com/metabrainz/musicbrainz-serve...

yvanzo, bitmap ^ and the other one

we put some of our SoC proposals up on the office wall! https://usercontent.irccloud-cdn.com/file/OkCNr...

note the great example of "cumulative round-off error".

Some band posters would also go well on the wall

we have some. :)

Awesome mayhem!

nice!

I had a friend who had decorated his whole dorm room with CD packages and it looked much the same.

Amazing!!

Mine consists of tv shows, anime also, hehe :)

lucifer: Found the 'issue' with the playlist and player pages not showing the feedback buttons: https://github.com/metabrainz/listenbrainz-serv...

I thought there was something like that going on

ah i see. makes sense

can fix it in the current PR itself then.

Hi monkey! Can we merge https://github.com/metabrainz/listenbrainz-serv... ?

i'll update test with the PR again

Btw monkey, fixed-top doesn't seem to work currently. Do you think we're missing something in the DS?

monkey: updated test. feedback appears now on those pages :D

alastairp: I ordered a new server for AB. I'll configure it as a standalone server as soon as Hetzner confirms it is online.

mayhem: yvanzo also opened OTHER-373

OTHER-373: Migrate Tickets from Jira Server https://tickets.metabrainz.org/browse/OTHER-373

k

akshaaatt: I still need to review LB#2005 again before merging. Not sure about fixed-top (not really up to date on the BS5 classes to be honest)

Fix homepage: https://github.com/metabrainz/listenbrainz-serv...

lucifer: feedback PR looks quite good, I think ready to merge. There's that 500 error we ran into earlier but it sounds like material for another PR maybe?

And so now the recent page has feedback options for those listens that have MBIDs, that's nice :)

Hi ansh ! Are you around to have a discussion about your project?

akshaaatt: fixed-top does not appear in the bootstrap css in design-system/dist/

Or anywhere in the repo it seems: https://github.com/metabrainz/design-system/sea...

https://getbootstrap.com/docs/5.0/utilities/pos... monkey we do have this though

But I don't see anywhere that that API is used. I guess that's the missing part :)

Looking at this: https://getbootstrap.com/docs/5.0/utilities/api...

(All this is new to me, so don't quote me on this)

Right

Not sure though:

>The $utilities map contains all our utilities and is later merged with your custom $utilities map, if present.

That reads as "BS5 comes with a bunch of utilities out of the box"

I believe it should be present already. We don't need to add our custom classes

Well, I can definitely say fixed-top is not in the generated CSS :)

Yess

It is however present in the bootstrap-utilities.css file in the BS5 package.

Right

Btw monkey, I'm planning to remove https://github.com/metabrainz/design-system/blo... and the custom from bootstrap-generic. Those are specific to MusicBrainz I believe

I see.

My understanding is that we want to aim to harmonize the look of projects, so maybe it makes sense to keep (some of) it

Right, I agree

If there are vars in there that are fully 100% not going to be useful for other projects, perhaps they should be separated in a MB-specific var file

I believe we should focus on https://github.com/metabrainz/design-system/blo...

And prepare the same for all projects. I think currently it was vague for me to keep `intro-bg` etc as a thing but we can generalise the themes and at the root of every project, just mention this class to fix the themes for them

monkey: oh nice! lets merge this one then. i can open PRs for the recent page feedback fix and the 500 error. after that we can do a release for the feature.

Since all the themes will be in the same file, we could let ListenBrainz users also try the MB theme on ListenBrainz. Would be fun

A dropdown would let users select the theme they want

Not sure what that into-bg var does akshaaatt, but generally I think we're in agreement.

If we need to separate MB specific classes or vars, I think that's OK to do now.

Right

Interesting idea :)

lucifer: 👍

I'll let you merge ?

akshaaatt: Well, all that aside, that still doesn't tell us why we are missing utility classes.

Haha rightt

I'm sure I'm not the only dummy to not understand anything, gonna look for some questions out there

I did try googling thing stuff last week but couldn't find a resolution then

monkey: sure, the tests are failing looking at that currently.

This*

Found it monkey😂

`@import "../node_modules/bootstrap/scss/helpers/position"`

Guess I'll never understand how complicated even bootstrap is😂

Oof.