#metabrainz

Yeah, not the best :p

Do you have that mockup handy? I can't remember what it looked like

But `show_entity_type` is an `h4`so it should already have some margin at least

CB-442: Improve layout of CB entity page

monkey:

Oh wow that's already being implemented? Great :)

I was planning for implementing oauth login for CB. So if we have plans for linking other oauth services also later on, I can design the code in a similar way

monkey: just the location of the rating buttons I think

ansh: thanks for making this additional change to the macro in CB#440

Add Page for Edition Group: https://github.com/metabrainz/critiquebrainz/pu...

ansh: Yes I think that could happen in the future. If you can easily make it reusable then please do, but don't lose sleep over it :)

I could see a use-case of "I want to import my collections from ServiceX"

definitely :) I'll try to make the design easy to expand in the future

So, after I am done with displaying the reviews, I'll begin with creating tables and making changes in the ORM to support that

Awesome

alastairp: since we are also using the download-import script for tests, we should keep both of them at the same place

ansh: which both are you referring to?

the download-import bb database and the test data script

in the ./scripts directory?

yes

right, that's OK. I was referring to moving the bb-test-data.sql file out of the root directory

(I think, unless you are talking about another one of my comments)

I thought cb alrady had oauth from mb..

CatQuest: This is for BB to allow writing CB reviews straight from BB

oh ho

well evetually MeB will be the hub though.. so keep that in mind maybe 🤔

ansh: What was the reason for removing the space here? https://github.com/metabrainz/listenbrainz-serv...

I think that should probably be reverted as it is proper punctuation (and also making a snapshots test fail)

there is a space before the entity type https://usercontent.irccloud-cdn.com/file/u2BIl...

But the space you removed is the one between the entity name and the parens, I think

I commented on the PR; sometimes JSX isn't the best language…

oh :(

I've committed your suggestion

alastairp: all the tests are passing now

is the first released label of a release group denormalized in the database? Something like release_group_meta.first_release_year but for labels?

or would I have to fetch the first release, and get its label?

(e.g. something like release_group_meta.first_release_label)

ansh: last bit on LB#2053 is to update the snapshots (because you did fix the extra space in front of the entity type :) ). You can run `./test.sh fe -u` to run front-end tests and update the snapshots.

Then commit and push the snapshot changes.

Fix data-tip in Critiquebrainz Modal : https://github.com/metabrainz/listenbrainz-serv...

Thanks for fixing the extra space, it was bugging me

postgresql turns 26 today, happy birthday!

[critiquebrainz] 14alastair merged pull request #434 (03master…fetch_edition_group): Fetch edition group from BB database https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] 14alastair merged pull request #436 (03master…add_bb_entity): Allow CB to review Edition Group https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] 14alastair merged pull request #440 (03master…edition_group_frontend): Add Page for Edition Group https://github.com/metabrainz/critiquebrainz/pu...

CB still running node 12, I think we should upgrade this soon

hi lucifer, I had a question for you, do you think the index is not working because `recommendee_id` key doesn't exist in every metadata.

for the index to work at all, is it necessary that all metadata should have that?

riksucks: afaik, that shouldn't be the case. i'll need to look into deeper to find out what going on. will do that in 1-2 days.

monkey: hi, finished for the day?

Yes, but I'm around

monkey: OK, perhaps we need to leave it until next week then. I've deployed CB on beta, but we need the new views

thanks :)

because at the moment our queries are failing

I can run the views script

Let me try on test quickly

I already checked everything when doing the PR

Well alastairp we'll have to wait, something doesn't look right with search indexing with the views updated, I'll have to have a closer look

monkey: ok, no problem then

ansh: I've released your work to beta, but we're going to have to wait to fix this issue with the BB views before continuing

thanks for approving my work :)

another option is that we update the queries temporarily to perform this join/query, if you are interested in trying to get it running today

riksucks: not sure if you saw the message but like other SoC students, you can also contact mayhem for an IRC cloud account.

umm I think we should wait for the updated views

sure, no problem!

[listenbrainz-server] 14amCap1712 merged pull request #2053 (03master…cb_model_fix): Fix data-tip in Critiquebrainz Modal https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release 03v-2022-07-08.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

[bookbrainz-site] 14tr1ten opened pull request #860 (03master…fix/alias-language-select): fix(language-select): Correctly format language options for alias row https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14MonkeyDo opened pull request #861 (03master…fix-search-new-views): fix(search): Update entity indexing https://github.com/metabrainz/bookbrainz-site/p...

sorry monkey, I don't understand this PR enough to be able to give you feedback on it :(

No worries, I'll deploy that to test on monday for further testing

great

Pratha-Fish: another silly looking fish: https://www.lafiambrera.net/wp-content/uploads/...

CatQuest: damn this one looks..... Smart?

tuna watermelon is a thing apparently

CatQuest: I am glad that's a thing lol

:D