#metabrainz

hi Freso, I would love to participate too!

Poked at flags and reports. A number of reports were dealing with CB users, so I spent some time trying to find users on CB, but we’re still waiting on CB-169 for that. I saw that there was a CB PR in this area, but it doesn’t seem to have gotten attention in a bit. :( Not much else to report for this last week.

CB-169: Allow searching for users https://tickets.metabrainz.org/browse/CB-169

No skelly37… ansh: Go!

Hi everyone!

Last week I made some final revisions in the PR for fetching data from the updated BB DB.

I worked on allowing searching for edition group in CB

[mbsssss] 14reosarevok opened pull request #61 (03master…add-genre): SEARCH-681: Add genre entity https://github.com/metabrainz/mbsssss/pull/61

(Only Shubh and riksucks left on my list (unless atj or skelly37 show up), so last call for anyone else who wish to give review!)

Made changes suggested by alastairp and monkey before merging.

Finally my work is live on beta.critiquebrainz.org

🎉

I also started working on displaying CB reviews on the BB website.

thats it for me!

Shubh: next ?

Hi all!

last week since core work on unified form is done, i did some testing on it and tried to increase form usability.

happy to work with ansh on cB BB integration!

took reviews from CatQuest and monkey (really helpful), incorporating some of their suggestions in the form.

me too !!

now unified form POST route support editing existing entity as well, this provide us with more flexibility on how much automation we can provide user from unified form.

form now support copying authors directly from AC (of edition/book) to works.

their seem to be some performance issue with the form, so also done some profiling to find out its cause but no luck as of yet :

fin go riksucks?

oohhhh

I will test this later/tomorrow/wedensday for sure

hi! first of all I am just glad that after much delays summer break finally started for me few days earlier. And I have been able to get back to doing tasks according to what I proposed. It feels good to be back :)

last week I implemented the backend to support the personal recommendation feature in listenbrainz. I did notice that the queries will sometimes slow down when doing select queries from JSONB keys

had some issues with indexing, lucifer and I would look into it

apart from that, the whole backend is done and right now I am working on deleting personal recommendation feature. Once the PR is given green light, I would start writing tests

I think that is about it. In the next week work on frontend would commence

Alright.

riksucks, yuzie, and chinmay btw, if you want to be added to the "regulars" list, go ahead and add yourselves on https://wiki.musicbrainz.org/User:Freso/MetaBra... :)

Sure :)

Thank you

But this was the last on my list for reviews, so this wraps up that. Thank you all for your reviews!

sure thanks!

And we have no more items on today’s agenda, so this also wraps up the meeting.

Thanks for reminding us, Freso

Thank you all for your time, and take care of yourselves out there!

Thank you

</BANG>

<3 Freso

mayhem: that api lgtm.

mayhem: I had a question about showing release types on the card. Which of the two release types should the user see on the card?

My current logic is `(primary_type || secondary_type) || "Other"`.

Show "Other" if both types are null. Show `secondary_type` if primary type is null. Default to primary_type.

Sounds correct? Or Show secondary_type by default if both primary_type and secondary_type are present?

mayhem: question about the API: does it/will it respect timezones?

If it's 11th July for you and the 12th July for me, will I see releases starting from 28th June instead of 27th June like it currently shows?

Or is it static?

!!

!m ansh

You're doing good work, ansh!

oh, here is something: https://beta.critiquebrainz.org/user/8f65efe2-3... can't tell if it's release or edition on this page ( isee some boxes underneath the titles but it's kinda hard to read mediumblue text on lighter blue :s)

also author should be gotten from bookbrainz like performers are from mb

(also unrelated, it'd b great if fll text reviews and just ratings had some sort of distinction)

[sir] 14reosarevok opened pull request #136 (03master…SEARCH-680): SEARCH-680: Index genre annotations https://github.com/metabrainz/sir/pull/136

ansh: you should be in #bookbrainz too

sorry I'm blind, you are :D

[bookbrainz-site] 14MonkeyDo merged pull request #858 (03new-creation-form…uf-edit-entity): Feat(route): Edit exisiting entity through unified form POST route https://github.com/metabrainz/bookbrainz-site/p...

alastairp: Some parts of CB website are down.

If the reviews DB is same for the beta and main website, maybe its because it can't handle the new entity type

CatQuest: Thanks :)

ˆ__ˆ

Regarding the background colors , I agree we should change it to make it more readable

hey! when has reviews gotten commente feature? awesome!

The authors are being fetched from the BB DB, but since CB does not support authors yet, it is not being shown. As soon as I expand this feature across all the entity types, it will be there

and editions and releases should have differnt colour

perhaps something inspired by secondary colour of projects

as long as it's ok to just leave a paragraph abotu something

I'm bad about... writing really long thing andnot just repeating myself

honestly te only annoying bit is that only-star reviews and reviews with star+ text are precented the same way in the interface... i want to read what people thing about stuff I like/don't like/haven't heard of!

like on https://beta.critiquebrainz.org/

"recent reviews"

https://beta.critiquebrainz.org/search/?query=m... it should show if it has any reviews right on the page

[sir] 14reosarevok opened pull request #137 (03master…SEARCH-681): SEARCH-681: Index genres https://github.com/metabrainz/sir/pull/137

Great work everyone!! I couldn't drag myself out of bed super early today, I needed the sleep, catch you at the next meeting!

ansh: thanks for the checks on the pull request - I was practicing git so forgot to check how to do links properly and stuff! Please suggest away

chinmay: for how to display those bits of data, take a look at what MusicBrainz does, I would suggest.

and the API will only work on a date basis, no times, so no timezones.