aerozol: hey, I'm not sure about the "pending review" issue, perhaps there it's your own review you need to submit or cancel? You can probably do this from the "Files changed" tab and then click green "Review changes" dropdown.
unless the issue is with someone else's pending review, then I'm also confused :)
ansh
alastairp: monkey: For showing relationships in CB, should I show all the relationships like BB does or show a particular relationship? Because for author, I can show works they wrote, but I couldn't figure out something for EditionGroup, Publisher and Work
Because most of them are linked to Edition and we don't support it
taking a quick look at 2-3 items, it seems the difference is of release formats. not sure if that should happen. i'll check the format sort table on wolf later to confirm its the latest.
thanks Pratha-Fish.
Pratha-Fish
:D
lucifer
Pratha-Fish: which table on wolf do you use for canonical mbid lookups?
lucifer: I run MLHD mbids through the above tabels one by one to get the canoncial MBIDS
lucifer
to confirm, the canonical mbids in the html file above were done today?
*were looked up today
and not the result of an old lookup.
Pratha-Fish
lucifer: yep, the lookups were made today
lucifer
cool
Pratha-Fish
I randomly opened and cross checked a few of them just to confirm
Apparently the mismatches from the last time were due to some stupid matching techniques that I used. So the outputs were corresponding to their actual inputs
*were NOT
mayhem
yuzie: functions great, looks good too. Let me read the code, but I'll have to pester lucifer to help with the react portions, since I am still react illerate.
lucifer
sure, will review.
mayhem
thx
yuzie: you're really close to completing your project. are you up for working on some stretch goals?
also, the PR now has one merge conflict, could you please take a look at that?
lucifer
mayhem: for the api, thoughts on url name? currently its user-setting, i think just setting or settings or preferences would be a better name.
mayhem
settings seems better, ya
lucifer
👍
yuzie: i'll review the react code soon but 1 quick comment, currently don't see any tests in that PR. we should probably add some tests for the react component. same for the api endpoint if not already there.
mayhem
shit, good catch, lucifer.
yuzie
mayhem: I'd like to work on some stretch goal after completing this project, but I hope I can finish the work before September(school begins).
mayhem
given your speed a few tests won't take very long. :)
Pratha-Fish: thanks for the update, will try and grab an hour or so tomorrow to look through what you have if lucifer hasn't beaten me to it
yuzie
aha, I appreciate all the help!
Pratha-Fish
alastairp: Sure. I'll try to generate a bigger sample set till then :)
alastairp: BTW, I was exploring PyArrow the other day, and realized it can be used far beyond just dumping tables to parquet
monkey
Hi Freso, I don't have anything to report for last week, and won't be attending the meeting; can you please remove me from the list for today?
Pratha-Fish
e.g. It's CSV loader is 7x faster than Pandas's!
Freso
monkey: 👍
monkey
Merci!
See you all in a coue of days
Couple*
alastairp
Pratha-Fish: wow, great. does it have transparent decompression/compression too?
Pratha-Fish
yess it does. Infact, as far as I understand it doesn't have much to do with compression (although it can do it at very high speeds). Arrow is a standard for representing data in memory. It's super efficient for all that stuff.
Also, it was developed by the creator of Pandas, so I expect the learning curve to not be so steep
P.S. I have a noted down the resource I used to study arrow in my Journal
aerozol
Freso: could I please be added to today's list? Thanks!
alastairp
it's great to see you learning all of these new things@
anyway, sorry to barge in and out, but I'm supposed to be on holiday and I'd better go before I unexpectedly get dragged into the meeting ;)
enjoy your day everyone
mayhem
wise.
mayhem wonders what he is doing here
yuzie
I'm not sure how to solve the conflict with the master branch. Do I solve it online or locally first?
lucifer
yuzie: either way works. you can merge master locally and then push. or merge online and then pull.
Seems like all we have for today is reviews, so let’s get to it!
alastairp: Go!
alastairp says…
"""
Last week I was on holiday and at a conference, so I wasn't around much. I submitted evaluations for ansh and Pratha-Fish for GSoC.
I finished releasing all of the features for ansh's work for Edition Group reviews, well done ansh!
Pratha-Fish and I discussed how to finish his project, and we're coming to a final position on what we need to do. We've managed to fix a lot of items in the mapper, which has been very useful, thanks Pratha-Fish!
"""
yvanzo: Go!
yvanzo says…
"""
For the past week I completed generating diagrams for the MB DB schema.
These are visible from the wiki only until we finish updating this page: