#metabrainz

[listenbrainz-server] 14amCap1712 opened pull request #2100 (03master…fix-mb-metadata-cache): Add option to create canonical data tables in MB https://github.com/metabrainz/listenbrainz-serv...

moooin!

mayhem: I wondered why it was raining. you going to the office would do that

and in case you wonder about rail strikes, those are also my fault.

[listenbrainz-server] 14amCap1712 opened pull request #2101 (03fix-mb-metadata-cache…add-length-to-recording-data): Add new fields to mapping.mb_metadata_cache https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 opened pull request #2102 (03master…fix-submit-release): Fix submit_release click command https://github.com/metabrainz/listenbrainz-serv...

Moin! mayhem I'll be over to the office in about 45 min

monkey: morning. please ping me when you're in the office, ansh and I have a BB question

Moin!

monkey: cool!

I better get moving on my BS tasks then.

alastairp: Now that we have all the BB entities reviewable, I was planning to change the text on github, CB and MeB website to refer CB as repository for both music and book reviews.

perfect!

Are there any other places where it needs to be updated?

for now I don't think so, we can address them if they come up

ansh: how is the BB side of the project going for these 3 new entities?

Its going great

I've added the support for these entities also

amazing!

Just some final touches are left

did you see in the thread on the forums, the user who wanted to group together authors and artists?

good that we also thought about that :)

yeah

I was trying to get a count of these cases. There are roughly 900 entities that need to be handled

do you mean 900 items which have this relationship already set?

Yep

great. so we can read this relationship, and tell users to add it if they think that it's missing

then I was thinking that we could just have 2 subheadings in the review section, "as a writer" and "as a _____" (musician?)

not sure if musician is correct, because someone could review a composer? we can try some ideas and see what they look like

Handling these cases is a bit complex task

Let me check if I have the database queries I used.

I'm interested to know why you think this is the case, because I understand that it's quite simple

do you just mean that the query to obtain this relationship is complex?

The query is easy

ansh: after this, if you have time and if you would like to, we can also look at CB-442. It's not in the scope of your project, but I think it'd be a great improvement to CB

CB-442: Improve layout of CB entity page https://tickets.metabrainz.org/browse/CB-442

When I looked at the database, there were edition groups having rels to MB artists, label, release and work

So we need to integrate all the cases

ahhhh, right. I was only thinking of the artist-author case

but are you referring to any BB entity <-> MB entity relationship that may be relevant?

BB has an identifier for MB urls

So I filtered out using those

but there is no information in the relationship about what it is relating to?

Like it says that it is refering to an MB artist MBID

ah, so it does say that it's specifically to an Artist?

Yes

This is for author

right

bitmap: It does unset it for the Compose configuration, not for the current container. To make Compose picks up configuration changes: sudo docker-compose up -d

so we need to identify each of the pairs of items which we want to show linked, and implement the query for each of them?

Ig yes

(It will recreate the container as needed.)

We would still have more of there rels coming up, so we need to ensure each of these cases are handled

do you mean that more relations might be created?

Yes, like when I create an entity in BB, I can still add a new relationship with MB

and so then that new relationship should appear when we run the new query, right?

yes

I just saw that BB has restricted these cases. Now a rel can be for Author-artist, Series-series, Publisher-Label. So it would be a bit easier

ok, great. let's confirm with monkey when he gets to the office

Yep

For CB-442, i'd love to be a part of the revamp. I tried the new footer design once, It came out to be pretty good.

CB-442: Improve layout of CB entity page https://tickets.metabrainz.org/browse/CB-442

! amazing!

go ahead and open a PR for that if you want - monkey and I were talking last week and thought that it'd be a good initial improvement

Sure

if you haven't seen it, also check out the footer for https://listenbrainz.org/, we should make them as similar as possible

I see that the LB one has icons for Fellow Projects

and we also have the "Write a review" link in the top menu, so maybe we don't need the "About" column, we can make it similar to the "Useful links" one in LB

That can be added as well.

I referred to the mockups for this

I'll club it with the navigation bar redesign

yeah, we didn't clearly discuss with aerozol about making the footer design consistent over all of the projects, so they're a bit different

But I think lets not deploy these individually. Lets bunch it with more improvements

Sorry, I didn’t realise you were using my footer from the mockup! I usually am only working on what’s specified in the ticket

That said, I don’t like all the icons in the footer :)

hi aerozol

aerozol: no problem, we just really liked the footer!

I like it too :P

Hey mayhem! Back from holiday?

I’m just about to go to bed and saw my name pop up

For one day, yes. Then off to go hiking.

aerozol: so, how about I open another ticket for footer unification and we discuss it next week?

bona nit, aerozol !

bona nit!

alastairp: go for it!

goodnight kiwi

And the french equivalent "Bonne nuit les petits": https://usercontent.irccloud-cdn.com/file/oFBcL...

P.S: alastairp I'm here, let me read the backlog

one thing I've just worked out: QuickBooks online's email server IP addresses have been blacklisted due to spam (they send invoices too fast) and our invoices have not been reaching a lot of our corporate customers.

my hate for intuit has no bounds.

now I have to implement sending invoices because I can rely on the service that we have to pay for.

*can't

monkey: two items: 1) from yesterday: how do you make a query to get the items in a series ordered correctly (currently in CB they are mis-sorted)? 2) from today: this discussion about BB-MB relations to show related reviews on CB, 3) from just now: some discssion about footers

For 1): We sort on the server-side rather than in an SQL query: https://github.com/metabrainz/bookbrainz-site/b...

2) Indeed in BB there is one specific identifier type (id=2) to link MB Artists with BB Authors. If there are links between BB Authors and other MB entities they're almost certainly a mistake from previous versions of the website and should be ignored

3) Very much in favor of harmonizing footers with LB as a base. Ideally we would do the work of implementing the footer changes in the design-system and then import that in each project. However considering the DS will output React components that's not going to be very helpful for CB at the moment.

monkey: I found this sorting function, but when I saw the the series information, I saw that the relationship entities have 3 fields, 1. number, 2. position, 3. displayNumber. Where do these come from ?

Are they stored somewhere in the database?

Yes indeed, let me fish out that code for you

They are relationship attributes

it seems like we may be able to do an ORDER BY CASE to choose either the autogenerated ordering or manual ordering

ansh: So for starters here's the schema for the relationship attributes. In short a relationship can have an attribute set attached to it, and each attribute set can have one or more relationship attributes, some of which can have a text value: https://usercontent.irccloud-cdn.com/file/hqjpk...

monkey: if a series has manual ordering, is its position stored as a number or a string in the db?

alastairp: text

er, string

:( right

Yeah, the attributes aren't always numbers I'm afraid.

So when we load the relationships for an entity we also load it's attribute set and the values for the attributes: https://github.com/metabrainz/bookbrainz-site/b...

Then we re-attach the relationship attributes to the relationships before using them to sort the relationships: https://github.com/metabrainz/bookbrainz-site/b...

I haven't tried doing all this in an SQL query.

[listenbrainz-server] 14amCap1712 opened pull request #2103 (03master…msb-move): Simplify MsB and migrate data to TS db https://github.com/metabrainz/listenbrainz-serv...

monkey: Where is this "displayNumber" field stored?

monkey: NOM?

lucifer: is the spotify metadata cache still running?

mayhem: yup, but on wolf. it was already running for a few days before i got the time to move it to gaga so i thought to let it run on wolf only. we can export the database later once we move this to prod to avoid fetching this data again.

ah wolf, of.

ok

ansh: As far as I can see displayNumber is a front-end prop set to true manually for series item rows (not stored anywhere): https://github.com/metabrainz/bookbrainz-site/b...

of course we have no way of checking how many docs are in the DB yet, do we?

mayhem: 5min?

monkey: k

ansh: If you're talking about where the value of the attributes is stored, it's in the `relationship_attribute_text_value` table

woah, thanks!

nearly 1M? this is going faster than I expected. lets hope the data is usable. :)

phew, good news. :)

I found the position and number field. I'll try to fetch all this information in a single query.

a sample doc: https://gist.github.com/amCap1712/76cb647c318af...

Do we need attributes for other entities also?

(fyi, its currently running on my personal spotify oauth app so queries won't show up in LB account dashboard)

lucifer: I assumed that. all good.

[listenbrainz-server] 14amCap1712 merged pull request #2102 (03master…fix-submit-release): Fix submit_release click command https://github.com/metabrainz/listenbrainz-serv...

once I am fully back in Sept, I'll hammer out a MBID Mapping type lookup and then we can start testing the playlist resolution. which will be exciting.

ansh: So far the relationship attributes only apply to the relationships of type "entity is part of series"

sounds great, indeed!

monkey: if you have time later today, can you please look at LB#2095 and LB#2096

Hide actions menu if empty: https://github.com/metabrainz/listenbrainz-serv...

I'll put in on my list :)

uh, LB#2095

Only allow pinning if playing now listen has msid or mbid: https://github.com/metabrainz/listenbrainz-serv...