mayhem is in the office doing a pile of bs paperwork today
2022-08-17 22947, 2022
alastairp
mayhem: I wondered why it was raining. you going to the office would do that
2022-08-17 22949, 2022
mayhem
and in case you wonder about rail strikes, those are also my fault.
2022-08-17 22959, 2022
BrainzGit
[listenbrainz-server] 14amCap1712 opened pull request #2101 (03fix-mb-metadata-cache…add-length-to-recording-data): Add new fields to mapping.mb_metadata_cache https://github.com/metabrainz/listenbrainz-server…
Moin! mayhem I'll be over to the office in about 45 min
2022-08-17 22934, 2022
alastairp
monkey: morning. please ping me when you're in the office, ansh and I have a BB question
2022-08-17 22958, 2022
ansh
Moin!
2022-08-17 22959, 2022
mayhem
monkey: cool!
2022-08-17 22904, 2022
mayhem
I better get moving on my BS tasks then.
2022-08-17 22950, 2022
ansh
alastairp: Now that we have all the BB entities reviewable, I was planning to change the text on github, CB and MeB website to refer CB as repository for both music and book reviews.
2022-08-17 22902, 2022
alastairp
perfect!
2022-08-17 22949, 2022
ansh
Are there any other places where it needs to be updated?
2022-08-17 22901, 2022
alastairp
for now I don't think so, we can address them if they come up
2022-08-17 22923, 2022
alastairp
ansh: how is the BB side of the project going for these 3 new entities?
2022-08-17 22936, 2022
ansh
Its going great
2022-08-17 22958, 2022
ansh
I've added the support for these entities also
2022-08-17 22913, 2022
alastairp
amazing!
2022-08-17 22915, 2022
ansh
Just some final touches are left
2022-08-17 22929, 2022
alastairp
did you see in the thread on the forums, the user who wanted to group together authors and artists?
2022-08-17 22935, 2022
alastairp
good that we also thought about that :)
2022-08-17 22952, 2022
ansh
yeah
2022-08-17 22912, 2022
ansh
I was trying to get a count of these cases. There are roughly 900 entities that need to be handled
2022-08-17 22940, 2022
alastairp
do you mean 900 items which have this relationship already set?
2022-08-17 22948, 2022
ansh
Yep
2022-08-17 22909, 2022
alastairp
great. so we can read this relationship, and tell users to add it if they think that it's missing
2022-08-17 22951, 2022
alastairp
then I was thinking that we could just have 2 subheadings in the review section, "as a writer" and "as a _____" (musician?)
2022-08-17 22933, 2022
alastairp
not sure if musician is correct, because someone could review a composer? we can try some ideas and see what they look like
2022-08-17 22919, 2022
ansh
Handling these cases is a bit complex task
2022-08-17 22932, 2022
ansh
Let me check if I have the database queries I used.
2022-08-17 22942, 2022
alastairp
I'm interested to know why you think this is the case, because I understand that it's quite simple
2022-08-17 22952, 2022
alastairp
do you just mean that the query to obtain this relationship is complex?
2022-08-17 22904, 2022
ansh
The query is easy
2022-08-17 22921, 2022
alastairp
ansh: after this, if you have time and if you would like to, we can also look at CB-442. It's not in the scope of your project, but I think it'd be a great improvement to CB
bitmap: It does unset it for the Compose configuration, not for the current container. To make Compose picks up configuration changes: sudo docker-compose up -d
2022-08-17 22958, 2022
alastairp
so we need to identify each of the pairs of items which we want to show linked, and implement the query for each of them?
2022-08-17 22913, 2022
ansh
Ig yes
2022-08-17 22913, 2022
yvanzo
(It will recreate the container as needed.)
2022-08-17 22958, 2022
ansh
We would still have more of there rels coming up, so we need to ensure each of these cases are handled
2022-08-17 22949, 2022
alastairp
do you mean that more relations might be created?
2022-08-17 22930, 2022
ansh
Yes, like when I create an entity in BB, I can still add a new relationship with MB
2022-08-17 22949, 2022
alastairp
and so then that new relationship should appear when we run the new query, right?
2022-08-17 22958, 2022
ansh
yes
2022-08-17 22901, 2022
ansh
I just saw that BB has restricted these cases. Now a rel can be for Author-artist, Series-series, Publisher-Label. So it would be a bit easier
2022-08-17 22917, 2022
alastairp
ok, great. let's confirm with monkey when he gets to the office
2022-08-17 22921, 2022
ansh
Yep
2022-08-17 22948, 2022
ansh
For CB-442, i'd love to be a part of the revamp. I tried the new footer design once, It came out to be pretty good.
go ahead and open a PR for that if you want - monkey and I were talking last week and thought that it'd be a good initial improvement
2022-08-17 22931, 2022
ansh
Sure
2022-08-17 22936, 2022
alastairp
if you haven't seen it, also check out the footer for https://listenbrainz.org/, we should make them as similar as possible
2022-08-17 22950, 2022
alastairp
I see that the LB one has icons for Fellow Projects
2022-08-17 22925, 2022
alastairp
and we also have the "Write a review" link in the top menu, so maybe we don't need the "About" column, we can make it similar to the "Useful links" one in LB
2022-08-17 22953, 2022
ansh
That can be added as well.
2022-08-17 22921, 2022
ansh
I referred to the mockups for this
2022-08-17 22946, 2022
ansh
I'll club it with the navigation bar redesign
2022-08-17 22934, 2022
alastairp
yeah, we didn't clearly discuss with aerozol about making the footer design consistent over all of the projects, so they're a bit different
2022-08-17 22921, 2022
ansh
But I think lets not deploy these individually. Lets bunch it with more improvements
2022-08-17 22953, 2022
aerozol
Sorry, I didn’t realise you were using my footer from the mockup! I usually am only working on what’s specified in the ticket
2022-08-17 22901, 2022
aerozol
That said, I don’t like all the icons in the footer :)
2022-08-17 22908, 2022
mayhem
hi aerozol
2022-08-17 22909, 2022
alastairp
aerozol: no problem, we just really liked the footer!
2022-08-17 22923, 2022
aerozol
I like it too :P
2022-08-17 22932, 2022
aerozol
Hey mayhem! Back from holiday?
2022-08-17 22946, 2022
aerozol
I’m just about to go to bed and saw my name pop up
2022-08-17 22956, 2022
mayhem
For one day, yes. Then off to go hiking.
2022-08-17 22957, 2022
alastairp
aerozol: so, how about I open another ticket for footer unification and we discuss it next week?
one thing I've just worked out: QuickBooks online's email server IP addresses have been blacklisted due to spam (they send invoices too fast) and our invoices have not been reaching a lot of our corporate customers.
2022-08-17 22955, 2022
mayhem
my hate for intuit has no bounds.
2022-08-17 22924, 2022
mayhem
now I have to implement sending invoices because I can rely on the service that we have to pay for.
2022-08-17 22937, 2022
mayhem
*can't
2022-08-17 22956, 2022
alastairp
monkey: two items: 1) from yesterday: how do you make a query to get the items in a series ordered correctly (currently in CB they are mis-sorted)? 2) from today: this discussion about BB-MB relations to show related reviews on CB, 3) from just now: some discssion about footers
2) Indeed in BB there is one specific identifier type (id=2) to link MB Artists with BB Authors. If there are links between BB Authors and other MB entities they're almost certainly a mistake from previous versions of the website and should be ignored
2022-08-17 22920, 2022
monkey
3) Very much in favor of harmonizing footers with LB as a base. Ideally we would do the work of implementing the footer changes in the design-system and then import that in each project. However considering the DS will output React components that's not going to be very helpful for CB at the moment.
2022-08-17 22922, 2022
ansh
monkey: I found this sorting function, but when I saw the the series information, I saw that the relationship entities have 3 fields, 1. number, 2. position, 3. displayNumber. Where do these come from ?
2022-08-17 22937, 2022
ansh
Are they stored somewhere in the database?
2022-08-17 22948, 2022
monkey
Yes indeed, let me fish out that code for you
2022-08-17 22959, 2022
monkey
They are relationship attributes
2022-08-17 22924, 2022
alastairp
it seems like we may be able to do an ORDER BY CASE to choose either the autogenerated ordering or manual ordering
2022-08-17 22908, 2022
monkey
ansh: So for starters here's the schema for the relationship attributes. In short a relationship can have an attribute set attached to it, and each attribute set can have one or more relationship attributes, some of which can have a text value: https://usercontent.irccloud-cdn.com/file/hqjpk7z…
2022-08-17 22949, 2022
alastairp
monkey: if a series has manual ordering, is its position stored as a number or a string in the db?
2022-08-17 22905, 2022
monkey
alastairp: text
2022-08-17 22913, 2022
monkey
er, string
2022-08-17 22938, 2022
alastairp
:( right
2022-08-17 22937, 2022
monkey
Yeah, the attributes aren't always numbers I'm afraid.
monkey: Where is this "displayNumber" field stored?
2022-08-17 22951, 2022
mayhem
monkey: NOM?
2022-08-17 22930, 2022
mayhem
lucifer: is the spotify metadata cache still running?
2022-08-17 22946, 2022
lucifer
mayhem: yup, but on wolf. it was already running for a few days before i got the time to move it to gaga so i thought to let it run on wolf only. we can export the database later once we move this to prod to avoid fetching this data again.
once I am fully back in Sept, I'll hammer out a MBID Mapping type lookup and then we can start testing the playlist resolution. which will be exciting.
2022-08-17 22933, 2022
monkey
ansh: So far the relationship attributes only apply to the relationships of type "entity is part of series"
2022-08-17 22954, 2022
lucifer
sounds great, indeed!
2022-08-17 22947, 2022
lucifer
monkey: if you have time later today, can you please look at LB#2095 and LB#2096
