We lost images in Telegram alerts, I investigated, it is a bug with new version of alert system on grafana
2022-08-29 24150, 2022
zas
plus there were multiple issues after the upgrade I had to fix
2022-08-29 24117, 2022
zas
I'll work on alert templates later on
2022-08-29 24145, 2022
zas
plus usual supervision, upgrades, and MB edits
2022-08-29 24152, 2022
zas
fin. skelly37 ?
2022-08-29 24120, 2022
zas
no skelly37 ? yellowhatpro ?
2022-08-29 24121, 2022
skelly37
Hello everyone
2022-08-29 24125, 2022
zas
ah :)
2022-08-29 24154, 2022
skelly37
Last week was mostly about research how to improve the commands flow, I have also received final reviews (just applied your suggestions outsidecontext :) )
2022-08-29 24114, 2022
skelly37
I have some plans/ideas that we decided to discuss after the meeting
2022-08-29 24125, 2022
outsidecontext
!m skelly37
2022-08-29 24125, 2022
BrainzBot
You're doing good work, skelly37!
2022-08-29 24144, 2022
skelly37
Aaand I think I have finished my GSoC summary, I'll just append new PRs there
2022-08-29 24100, 2022
reosarevok
Only yellowhatpro left to review
2022-08-29 24115, 2022
skelly37
And I have a question
2022-08-29 24126, 2022
yellowhatpro
ヾ(•ω•`)o
2022-08-29 24141, 2022
skelly37
Should I leave it just on my Github or upload somewhere on musicbrainz site? I saw someone did so last year
2022-08-29 24121, 2022
Freso
Having it on the blog would be great.
2022-08-29 24143, 2022
reosarevok
Yeah. You can wait until you're fully done with gsoc if you want, but eventually we'd love it on the blog
2022-08-29 24158, 2022
skelly37
Fine, I'll discuss the details with zas and outsidecontext during our meeting :)
2022-08-29 24109, 2022
CatQuest
definitly
2022-08-29 24141, 2022
yellowhatpro
Yosh.. my turn
2022-08-29 24153, 2022
skelly37
I plan to do something with the command flow after we discuss the further ideas, but I'm away Wednesday-Friday, so you can expect any results on weekend or later...
2022-08-29 24157, 2022
yellowhatpro
Hii everyone11 (≧∀≦)ゞ
2022-08-29 24100, 2022
skelly37
Fine, yellowhatpro, I won't hold you any longer hah..
2022-08-29 24105, 2022
yellowhatpro
ono
2022-08-29 24118, 2022
yellowhatpro
No no you can continue
2022-08-29 24128, 2022
skelly37
I'm done anyway, no problem :)
2022-08-29 24147, 2022
yellowhatpro
okii ヾ(≧▽≦*)o
2022-08-29 24132, 2022
yellowhatpro
So last week I was able to complete much work on brainzplayer, that includes the local database, DAOs, repository work for various entities like artist, playlist, album, songs. Also done with the UI for the entity screens and the navigation part.
2022-08-29 24113, 2022
yellowhatpro
Took me so long because of ongoing intern season and a bit too many errors on which I took so much time
2022-08-29 24131, 2022
reosarevok
As CatQuest said, errors are how you learn, no worries :)
2022-08-29 24141, 2022
CatQuest
👍
2022-08-29 24112, 2022
monkey
Isn't it a programmer's job anyway to make mistakes continuously until the damn code works?
2022-08-29 24134, 2022
yellowhatpro
I will soon be uploading some screenshots and creating a PR soon, working on tests as well, gotcha akshaaatt ヾ(•ω•`)o .
2022-08-29 24136, 2022
CatQuest
haha
2022-08-29 24142, 2022
reosarevok
And always leave a couple mistakes in still so that they pay you to fix the code, monkey
2022-08-29 24100, 2022
yellowhatpro
aaah yeah
2022-08-29 24103, 2022
monkey takes notes
2022-08-29 24128, 2022
reosarevok
yellowhatpro: is that it? :)
2022-08-29 24141, 2022
yellowhatpro
Apart from it I am not keeping it lately, the mess food here is just awful.
2022-08-29 24150, 2022
yellowhatpro
Yess it is now. thank yaa
2022-08-29 24155, 2022
reosarevok
Can't be more awful than working on tests, surely
2022-08-29 24102, 2022
CatQuest
oh no.
2022-08-29 24103, 2022
yellowhatpro
o((>ω< ))o
2022-08-29 24109, 2022
reosarevok
Ok, nobody had anything else in the agenda
2022-08-29 24119, 2022
reosarevok
So I'm going to say that's a
2022-08-29 24120, 2022
reosarevok
</BANG>
2022-08-29 24121, 2022
yvanzo
Thanks everyone!
2022-08-29 24127, 2022
yellowhatpro
yeah true reo kek
2022-08-29 24130, 2022
monkey
Thanks reosarevok !
2022-08-29 24131, 2022
reosarevok
Thanks everyone for being here :)
2022-08-29 24132, 2022
alastairp
thanks everyone! have a good day
2022-08-29 24145, 2022
skelly37
thanks
2022-08-29 24154, 2022
skelly37
zas, outsidecontext: Time for us, I guess?
2022-08-29 24155, 2022
CatQuest
bangarang
2022-08-29 24157, 2022
riksucks
yellowhatpro: [off] take care, hard relate on the food part, government dorm food is usually trash
2022-08-29 24103, 2022
zas
skelly37: yup
2022-08-29 24104, 2022
riksucks
thanks everyone
2022-08-29 24106, 2022
outsidecontext
skelly37: yep
2022-08-29 24112, 2022
alastairp
riksucks: got to put it at the beginning :)
2022-08-29 24130, 2022
testicon joined the channel
2022-08-29 24131, 2022
yellowhatpro
thanks rik yeah it is ಥ_ಥ
2022-08-29 24146, 2022
alastairp
bitmap: hi, not sure if you saw https://github.com/metabrainz/docker-server-confi… - I just had a question about if it made sense to split up MB cron tasks depending on role, do you have any thoughts on this, if it's a good or bad idea for any reason?
2022-08-29 24108, 2022
skelly37
Okay so the first thing I'd like to do is a small change in Tagger constructor
2022-08-29 24147, 2022
skelly37
I already added the urlparsed list as a argument and Tagger takes files from there instead of using picard_args
2022-08-29 24121, 2022
skelly37
So the idea is to append other options taken fron picard_args and add it to to_be_added (converted to a dict)
2022-08-29 24126, 2022
skelly37
to shorten the arguments list
2022-08-29 24158, 2022
riksucks
alastairp: sorry, I didn't get what you meant 😅
2022-08-29 24145, 2022
skelly37
Because now we pass both parsed files/urls/commands and they are also kept in unparsed format in picard_args, which is pretty not optimal
2022-08-29 24156, 2022
skelly37
What do you think of it?
2022-08-29 24111, 2022
riksucks
ohhh gotcha, my bad, thanks alastairp :)
2022-08-29 24156, 2022
outsidecontext
skelly37: so basically we get one optimized set of things to handle again? makes sense to me
2022-08-29 24130, 2022
riksucks
lucifer, monkey: Hi, in the proposal I had suggested to put the names of the people you have selected to personally recommend beneath the search box. I am thinking of putting it above the searchbox so that the names don't get blocked by the recommendations
2022-08-29 24142, 2022
skelly37
Yeah, they keys would look like: config, loadable, etc.
and other used args would be added to the dict as well
2022-08-29 24111, 2022
alastairp
ansh: yes, but I think we need to make sure that it's fair, and that it's worth the amount of development time needed - in my opinion I think that we shouldn't send user's content to an external plagarism checker website without their permission
I'm not sure if we are encountering any problems at the moment where it seems that people are copying things?
2022-08-29 24152, 2022
monkey
Which also makes me think at some point we should refactor these components to have a single reusable "select one or more users" searchbar + display component
2022-08-29 24109, 2022
zas
skelly37: I'll prefer we create a new object, and keep the attribute syntax, but I see your point, basically unifying in one object
2022-08-29 24134, 2022
zas
parse_args historically comes from argparse results
2022-08-29 24136, 2022
ansh
alastairp: Not at the moment, but after CB scales up, it might become a bit difficult to moderate the reviews
lucifer: obviously not urgent, but ^ whenever you happen to release an update, feel free to merge that too maybe
2022-08-29 24119, 2022
zas
skelly37: what you can do is to open a draft PR so we can discuss details there. If it simplifies things we are usually for it :)
2022-08-29 24143, 2022
skelly37
zas: I have no hard feelings about the dict, it can be an object. I basically wanted to remove duplicated arguments
2022-08-29 24145, 2022
skelly37
thanks :)
2022-08-29 24100, 2022
reosarevok
alastairp: there were issues with that with GCI students, but I haven't seen much of that otherwise. I haven't been specifically checking either though
2022-08-29 24116, 2022
alastairp
reosarevok: ah, that's a good point that I had forgotten about
2022-08-29 24119, 2022
reosarevok
(if we're worried about people copy-pasting without a license, I'd be more worried about MB annotations)
2022-08-29 24137, 2022
skelly37
So I guess we can move to the next point
2022-08-29 24140, 2022
CatQuest
Fish
2022-08-29 24142, 2022
reosarevok
(those are probably full of copyrighted text and are licensed cc-nc :p )
2022-08-29 24142, 2022
outsidecontext
+1 for the object, and +1 for the general approach of bundling this all in a single parameter. In general this is still the arguments, the way we handle them just goes beyond what the default argparse impementation can do
2022-08-29 24147, 2022
alastairp
I don't know how to do ethical (read: not using garbage like turnitin) validation
2022-08-29 24102, 2022
riksucks
monkey: that makes sense. Also monkey, since most of the codebase is based on bootstrap 3, I tried to write it in bootstrap 3, but it didn't work out for me, and I wrote it kind of from scratch. I hope that is okay
2022-08-29 24140, 2022
monkey
Sure, I don't see why not if BS3 is in the way of the goal
2022-08-29 24150, 2022
skelly37
I see that zas has already starred my gsoc summary but I'm not sure if outsidecontext has seen it. Here's the link and give some feedback in free time, please: https://github.com/skelly37/GSoC-2022 :)
2022-08-29 24121, 2022
skelly37
And I think that we can handle adding it to the metabrainz site after the project is over, right?
2022-08-29 24139, 2022
riksucks
also monkey, in the playlist modal, the collaborator's name and in my modal a user's name, both are displayed differently, should I opt for how it's implemented for playlist modal
2022-08-29 24147, 2022
riksucks
or do you like the green pills with cross
2022-08-29 24158, 2022
reosarevok
alastairp: for now, I'd expect "deal with reports on a regular basis" is good enough, long-term if it becomes popular you can think of more?
2022-08-29 24113, 2022
outsidecontext
I hadn't seen it yet, I'll look over it. And yes, I think this can be done after the project is finished I think. Should be put on the blog, right zas?
2022-08-29 24126, 2022
zas
skelly37: I read it, and it looks good, may be convert lists to phrases and clean paragraphs if you aim to publish on blog
2022-08-29 24139, 2022
monkey
riksucks: Do your own component, and afterwards we can think about how to harmonize the two. I'm currently in favor of your version
2022-08-29 24148, 2022
zas
outsidecontext: yes
2022-08-29 24122, 2022
skelly37
zas: It's a github repo, so actually you could send me some PR with your suggetsions. I think that would be the easiest way :)
2022-08-29 24141, 2022
alastairp
reosarevok: I _believe_ that aerozol is on top of reports. although that being said we kind of just dropped him in the deep end, and we haven't discussed it since. aerozol: please tell us if report maintenance gets overwhelming!
2022-08-29 24141, 2022
riksucks
monkey: alright then, thanks :). Also, for adding collaborators on playlist, is there any restriction that the collaborator has to be a follower or something?
2022-08-29 24107, 2022
skelly37
Okay, 2 to go
2022-08-29 24112, 2022
monkey
riksucks: Nope. And as far as the user name input goes there's currently no validation (as you can see from my screenshot adding "someone" and "someone else") which can be improved
2022-08-29 24113, 2022
outsidecontext
skelly37, zas: so final submission deadline is september 12th, does this include publishing the gsoc summary?
2022-08-29 24141, 2022
skelly37
Yeah, I have to submit the summary before we do the final evaluation iirc
