hi reosarevok: Approval is already limited to auto-editors who have some obligations, it doesn’t seem that anyone abused it on the linked edit at least.
2022-09-01 24401, 2022
reosarevok
Yeah, I'm not sure whether it matters - my only reasoning to limit it would be to ensure someone doesn't approve overzealously when the editor wanted feedback
2022-09-01 24406, 2022
reosarevok
But I haven't seen it happen either
2022-09-01 24410, 2022
reosarevok
So it might not matter tbh
2022-09-01 24400, 2022
testicon joined the channel
2022-09-01 24423, 2022
zas
monkey, alastairp, mayhem : I added few directions from El Prat/Sants to city center for attendees at the end of https://wiki.musicbrainz.org/MusicBrainz_Summit/22 , can you double check it is correct?
2022-09-01 24442, 2022
zas
good news, T-casual cost decreases today (right?)
2022-09-01 24448, 2022
testicon has quit
2022-09-01 24406, 2022
mayhem
yes, half price.
2022-09-01 24448, 2022
mayhem
oh sorry. no T-casual is the same, but T-usual is discounted (more benefit for commuters, not visitors)
2022-09-01 24426, 2022
mayhem
zas: I updated it a little since the trains can be taken directly to Arc de Triomf, which is right near the office and the airbnbs. but thanks for adding that section.
I spoke to monkey about this yesterday. we decided that it would be a good idea to implement this feature as described, and to switch BB to use it to get review information
2022-09-01 24418, 2022
ansh
Okay
2022-09-01 24442, 2022
alastairp
we also found one additional feature that we could add to BB. If you as a user write a review from BB, when you refresh the page it may disappear (for example, if it's not a recent or a top rated review). We should do a query to the /ws/1/review endpoint with the username and entity id parameters set, so that we can see if the user has written a review
2022-09-01 24423, 2022
alastairp
this way we can mark it specifically ("this is your reveiew"), and also indicate if the rating is just the average rating of the entity, or if it's actually the rating of the user
2022-09-01 24436, 2022
ansh
This would be a really nice thing
2022-09-01 24442, 2022
reosarevok
Ooooh
2022-09-01 24445, 2022
reosarevok
Yes please
2022-09-01 24458, 2022
reosarevok
I was just thinking in MB we say "write a review" even if you already have
2022-09-01 24402, 2022
reosarevok
Since we just don't know
2022-09-01 24428, 2022
reosarevok
But please still return the average rating and the most recent review etc
2022-09-01 24441, 2022
reosarevok
Just if a username is passed then return also user-rating and user-review or whatnot
2022-09-01 24438, 2022
reosarevok
Then we can get all the data we need with one call
2022-09-01 24436, 2022
ansh
Absolutely! This change can also be integrated to LB as well
2022-09-01 24401, 2022
testicon joined the channel
2022-09-01 24439, 2022
reosarevok
You can always make it optional to return review contents, I guess? In case you want to avoid always returning a larger response
2022-09-01 24457, 2022
reosarevok
(dunno if most popular, latest and user starts seeming too much)
2022-09-01 24424, 2022
reosarevok
For example, MB only needs to know the reviews *exist* in most cases, and counts and whatnot, but when on the Reviews tab we will want to specifically ask for the reviews
2022-09-01 24449, 2022
reosarevok
But that's up to you to decide according to CB's needs :)
2022-09-01 24415, 2022
alastairp
reosarevok: mmm
2022-09-01 24400, 2022
alastairp
the existing review endpoint already lets you filter by username and entity id, monkey and I were thinking of using that (this would require 2 queries, one for "review & ratings overview" and one for "has this user written something?"
2022-09-01 24424, 2022
alastairp
are you suggesting to add a query parameter to the /artist/[mbid]?user=x endpoint to highlight this info there?
I was thinking I can call artist/x and it will give me average rating, review count, latest review, recent review (filterable as review/ is by text only or all)
2022-09-01 24430, 2022
reosarevok
And if I have a logged in user, I can call artist/x?user=foo to get that, plus user-rating and user-review
2022-09-01 24437, 2022
reosarevok
Can the same user review the same thing twice?
2022-09-01 24417, 2022
monkey
Negative
2022-09-01 24432, 2022
reosarevok
Then that's easy
2022-09-01 24438, 2022
testicon has quit
2022-09-01 24419, 2022
alastairp
yes, adding a user param actually makes sense, and allows you to do it all in 1 query
2022-09-01 24449, 2022
alastairp
what'd be even cooler is if it could return this automatically if you do an authenticated api call... LB and BB do this
2022-09-01 24401, 2022
testicon joined the channel
2022-09-01 24457, 2022
testicon has quit
2022-09-01 24441, 2022
testicon joined the channel
2022-09-01 24447, 2022
Sophist-UK has quit
2022-09-01 24450, 2022
testicon has quit
2022-09-01 24409, 2022
Sophist-UK joined the channel
2022-09-01 24459, 2022
nbin has quit
2022-09-01 24403, 2022
testicon joined the channel
2022-09-01 24447, 2022
testicon has quit
2022-09-01 24420, 2022
lucifer
alastairp: hi! if you have time later, please review any 1 type of LB PRs. want to avoid more merge conflicts as most of the codebase is being affected.
2022-09-01 24413, 2022
alastairp
lucifer: sure, I think I can book in some time this afternoon
2022-09-01 24427, 2022
lucifer
thanks!
2022-09-01 24444, 2022
testicon joined the channel
2022-09-01 24404, 2022
testicon has quit
2022-09-01 24401, 2022
testicon joined the channel
2022-09-01 24426, 2022
nbin joined the channel
2022-09-01 24424, 2022
testicon has quit
2022-09-01 24401, 2022
testicon joined the channel
2022-09-01 24404, 2022
bitmap
reosarevok: approving should be limited to people who can enter the edit IMO, but this probably won't cause many issues in practice. voting for all seems OK since the author has to enable that
2022-09-01 24425, 2022
Pratha-Fish
Hi alastairp lucifer
2022-09-01 24425, 2022
Pratha-Fish
Sorry for disappearing for 1.5 days straight, some stuff popped up
2022-09-01 24440, 2022
Pratha-Fish
lucifer: I noticed I didn't use ```mapping.canonical_recording_redirect``` in the cleanup process at all. Where do you suggest I fit in the ```mapping.canonical_recording_redirect_new_tmp```
2022-09-01 24436, 2022
lucifer
Pratha-Fish: can you remind me how you got the canonical mbid in that report?
