so, then all we really need to do is fix up the timezone before we submit data to PG and we're done?
2022-09-12 25542, 2022
mayhem
(if the user set the timezone)
2022-09-12 25503, 2022
alastairp
mayhem: when I looked into it, I think the recommendation was that if you want to store a time as local to the user then you need to store both the timestamp and the relevant timezone or offset as a separate data
2022-09-12 25520, 2022
lucifer
mayhem: alastairp: not sure, thinking about how we want to handle cases like travelling or when someone moves to another timezone after some years.
2022-09-12 25531, 2022
yuzie
yes, that makes sense, and then we don't need a column, but only apply the timezone when display to user?
2022-09-12 25544, 2022
alastairp
lucifer: yeah, we thought about those, but also recognise that they're quite infrequent and not the common case
lucifer: but moving timezone when a user moves, doesn't require us to have a separate column, does it?
2022-09-12 25545, 2022
mayhem
if the user needs to shift the listens between date A and date B, by X hours, we can adjust the timestamps.
2022-09-12 25550, 2022
lucifer
mayhem, sorry not sure how the adjustment would happen. do you mean by the user changing the config?
2022-09-12 25514, 2022
mayhem
no.
2022-09-12 25530, 2022
mayhem
literally adding X hours to timestamp if it needs adjusting
2022-09-12 25528, 2022
lucifer
i understand that part but where/what would do it? like would the ts writer do it the browser or something else?
2022-09-12 25508, 2022
lucifer
alastairp: yup agreed, but we should decide if that's a use case we want to support.
2022-09-12 25556, 2022
alastairp
lucifer: by altering timestamps/data at ingest stage, it means that once that change is done, all new items should be good (after you move, for example)
2022-09-12 25518, 2022
alastairp
for temporary movements, one would hope that eventually clients start sending the timezone info
2022-09-12 25539, 2022
alastairp
in which case, that timezone will apply even if the configurerd one is different
2022-09-12 25541, 2022
atj
are you forgetting about DST?
2022-09-12 25546, 2022
mayhem
the case I was thinking about was when a user says: Oh, I was on vacation for these 14 days.
2022-09-12 25503, 2022
mayhem
Move all timestamps by 2 hours between date X and date Y
2022-09-12 25529, 2022
lucifer
ah i see, mayhem so lettign the user select the listens they want to alter the timestmap for manually?
2022-09-12 25535, 2022
alastairp
atj: we have a utc timestamp, and a name of a timezone, so I believe with that we can say "render this timestamp with the correct rules for the tz"
2022-09-12 25539, 2022
mayhem
atj: I would love to forget about DST, but everytime I do, everyone gets angry that I am an hour late.
2022-09-12 25545, 2022
mayhem
lucifer: yes
2022-09-12 25554, 2022
lucifer
mayhem: yes that makes sense now 👍
2022-09-12 25558, 2022
mayhem
cool
2022-09-12 25518, 2022
mayhem
that said, we've not reached a conclusion: separate column or no?
2022-09-12 25542, 2022
lucifer
alastairp: yes makes sense. the user changes the config when they move and then the future listens get the timestmap accordingly.
mayhem: my understanding of the timestamp type is that modifying the time forward or back in this way will modify the underlying UTC value, which I don't think is what we want
> When you insert a value into a timestamptz column, PostgreSQL converts the timestamptz value into a UTC value and stores the UTC value in the table
2022-09-12 25512, 2022
alastairp
so I think a separate column makes sense
2022-09-12 25527, 2022
mayhem
ok.
2022-09-12 25540, 2022
alastairp
and it should be an offset, the realized value of the timezone at the time of the listen
2022-09-12 25543, 2022
mayhem
is that a real PG column, or a value on the "data" JSONB?
2022-09-12 25558, 2022
alastairp
so that it solves the DST issue, and the issue of DST dates changing
2022-09-12 25500, 2022
atj
based on my limited understanding, separate column which is a FK to table of timezones
2022-09-12 25501, 2022
mayhem thinks the latter
2022-09-12 25504, 2022
lucifer
alastairp: we can let the user select a custom timezone to be applied for a particular period of listens instead of actual +- hours.
2022-09-12 25511, 2022
alastairp
lucifer: yep
2022-09-12 25532, 2022
alastairp
my gut feel is that it's tied to listen time, and therefore should be an actual column
2022-09-12 25548, 2022
Freso
<BANG>
2022-09-12 25558, 2022
Freso
It’s United Nations Monday for South-South Cooperation!
2022-09-12 25514, 2022
Freso
(I didn’t find an appropriate song, sorry. :\)
2022-09-12 25541, 2022
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Per-project mb_db users (bitmap, reo), summit covid preparedness (alastairp, monkey)
2022-09-12 25550, 2022
mayhem
alastairp: actual columns is serious work. :(
2022-09-12 25531, 2022
lucifer
mayhem: we need to process the entire table for some tasks so we can do this at that time.
2022-09-12 25551, 2022
lucifer
get the code and all ready but not deploy to prod just yet.
2022-09-12 25506, 2022
reosarevok
mayhem, lucifer: shhh meeting time
2022-09-12 25508, 2022
reosarevok
:)
2022-09-12 25514, 2022
Freso
No mailed in reviews! (I could have sworn I saw one earlier today, but I don’t see it now, so it was probably never there.)
2022-09-12 25543, 2022
Freso
(Also, main machine is still out of business, so sorry for being a bit slow. Current setup is a bit cumbersome to work with.)
2022-09-12 25500, 2022
Freso
Anyway…
2022-09-12 25506, 2022
Freso
reosarevok: Go!
2022-09-12 25512, 2022
reosarevok
Hi!
2022-09-12 25542, 2022
reosarevok
I mostly worked on more React porting of small bits of the code such as cdstub and cdtoc templates
2022-09-12 25551, 2022
Freso
(Others up: bitmap, zas, mayhem, monkey, alastairp, lucifer, akshaaatt, atj, CatQuest, skelly37, Pratha-Fish, Shubh, yellowhatpro, ansh, riksucks, yuzie, Freso — anyone else who would like to give review, let me know ASAP!)
2022-09-12 25500, 2022
reosarevok
Also reviewed our TT macros and saw we could get rid of a surprising amount of them, which was nice
2022-09-12 25507, 2022
reosarevok
Still quite a bit to go, but a lot less :)
2022-09-12 25522, 2022
reosarevok
And small bugs and tickets here and there
2022-09-12 25545, 2022
reosarevok
Now helping bitmap test the React relationship editor, which is the next big bit of React coming, hopefully
2022-09-12 25554, 2022
reosarevok
Fin! CatQuest, go!
2022-09-12 25509, 2022
reosarevok
CatQuest told me that
2022-09-12 25521, 2022
reosarevok
"I'm healing and tired, will probably continue for a few weeks, been doing some editing (including cleaning that wikipedia-mess report)"
2022-09-12 25544, 2022
reosarevok
That'd be a list of issues in Wikipedia linkage the wikidata bot found, and I'm really happy CatQuest found some time to help with that :)
2022-09-12 25556, 2022
reosarevok
Freso: what about your week?
2022-09-12 25523, 2022
Freso
🙋
2022-09-12 25503, 2022
Freso
I mostly (finished with?) recovered from surgery plus tried to bring my main rig back to life. My working conclusion right now is that it’s the motherboard that’s dead. :( I’ve ordered new parts which should hopefully arrive between Wednesday and Friday, so I should be back up and running then. Had a couple of days where I was feverish but for the last several days I’ve been off painkillers and I’ve started eating hot
2022-09-12 25503, 2022
Freso
and non-soft food now, and it seems fine, so I think
2022-09-12 25518, 2022
Freso
I have more or less recovered from the surgery… so that’s nice at least.
2022-09-12 25510, 2022
Freso
In between struggling with this, I did manage to give blog access to a number of our GSoC students and I have scheduled (the last?) two posts for Tues and Thurs this week. :)
2022-09-12 25524, 2022
Freso
I think that’s fin.
2022-09-12 25528, 2022
Freso
bitmap: Go!
2022-09-12 25538, 2022
bitmap
hey
2022-09-12 25513, 2022
bitmap
last week I fixed an issue causing missing CSS when deploying new containers, which I noticed when putting the new relationship editor branch on test.mb
2022-09-12 25551, 2022
bitmap
(but css was missing on prod.mb for like 10 minutes while I debugged the issue and restored it...)
2022-09-12 25521, 2022
bitmap
I also spent time testing/reviewing/updating open PRs, and fixed MBS-12566
MBS-12566: Incorrectly warn about bundled/shortened URLs in release editor
2022-09-12 25503, 2022
bitmap
fin, go lucifer !
2022-09-12 25510, 2022
lucifer
hi all!
2022-09-12 25559, 2022
lucifer
last week, i worked on addressing feedback on existing PRs and finally merged almost a dozen of those.
2022-09-12 25520, 2022
lucifer
thanks mayhem and alastairp for the reviews. further, i worked on verifying the canonical data fixes by running it over entire MLHD dataset which also led to wolf going down 😅
finally worked on moving messybrainz data to timescale db and debugging issues with api validation that were discovered as a result of the messybrainz PR.
2022-09-12 25520, 2022
lucifer
alastairp: next?
2022-09-12 25524, 2022
alastairp
hi
2022-09-12 25528, 2022
mayhem
well done on the debugging and well done crashing a monster!
2022-09-12 25531, 2022
Freso
(Still up: zas, mayhem, monkey, akshaaatt, atj, CatQuest, skelly37, Pratha-Fish, Shubh, yellowhatpro, ansh, riksucks, yuzie — anyone else who would like to give review, let me know ASAP!)
2022-09-12 25545, 2022
Pratha-Fish 👀
2022-09-12 25552, 2022
alastairp
last week I reviewed some of lucifer's and ansh's PRs
2022-09-12 25505, 2022
alastairp
I also did some work with Pratha-Fish to finalise his goals for the SoC project (extended until end of Oct), and worked with lucifer on testing his improvements to the canonical tables
2022-09-12 25535, 2022
alastairp
I finished text dumps of the metadata and canonical tables, to be integrated periodically into lB dumps
2022-09-12 25500, 2022
alastairp
I also worked on saving MB oauth keys in LB so that users can add MB tags directly from the metadata viewer
2022-09-12 25530, 2022
alastairp
monkey and mayhem and I had a small talk about covid preparedness for the summit, which we'll discuss after the summit
2022-09-12 25540, 2022
alastairp
Pratha-Fish: do you want to speak? I know you're busy with exams this week...
2022-09-12 25546, 2022
Pratha-Fish
alastairp: sure
2022-09-12 25553, 2022
Pratha-Fish
Hello everyone :)
2022-09-12 25501, 2022
lucifer
alastairp: after the meeting? :)
2022-09-12 25517, 2022
alastairp
lucifer: after reviews :(
2022-09-12 25525, 2022
Pratha-Fish
last week I worked along with alastairp to figure out how to restructure the MLHD code base
2022-09-12 25537, 2022
lucifer
:+!
2022-09-12 25546, 2022
Pratha-Fish
and how to make it more "presentable" and usable for anyone new
2022-09-12 25547, 2022
Pratha-Fish
Halfway done through the README file. Super happy to share that we'll be potentially writing a series of blogs explaining all the new and interesting findings that we made through the project :D
2022-09-12 25511, 2022
Pratha-Fish
Currently busy with exams as well. But I'll be back on 14th 👌
2022-09-12 25515, 2022
alastairp
not potentially, we will!
2022-09-12 25518, 2022
alastairp
postive thinking
2022-09-12 25533, 2022
Pratha-Fish
indeed! Super excited for the blogs 🔥
2022-09-12 25544, 2022
Pratha-Fish
fin 🐡
2022-09-12 25549, 2022
Pratha-Fish
riksucks: next?
2022-09-12 25500, 2022
Freso
Or maybe… zas?
2022-09-12 25508, 2022
zas
hey
2022-09-12 25516, 2022
Freso
(Still up: mayhem, monkey, akshaaatt, atj, CatQuest, skelly37, Shubh, yellowhatpro, ansh, yuzie — anyone else who would like to give review, let me know ASAP!)
2022-09-12 25535, 2022
zas
last week, I reviewed last PRs from skelly37
2022-09-12 25511, 2022
zas
I also renewed few expiring certs (*.mb.o), did usual upgrades
2022-09-12 25553, 2022
zas
rebooted wolf that was killed by lucifer ;)
2022-09-12 25510, 2022
mayhem snickers
2022-09-12 25523, 2022
zas
plus usual supervision, patches, user support, Picard related stuff
2022-09-12 25525, 2022
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Per-project mb_db users (bitmap, reo), summit covid preparedness (alastairp, monkey), summit: extending main topic days to friday (mayhem, alastairp)
2022-09-12 25534, 2022
zas
fin. mayhem ?
2022-09-12 25535, 2022
alastairp
mayhem: ^ not sure if you think this is worth mentioning?
2022-09-12 25547, 2022
mayhem
k
2022-09-12 25507, 2022
mayhem
last week was catching up from the vacation and other emails. some convos that were already mentioned...
2022-09-12 25543, 2022
mayhem
but, over the summer I worked out that QuickBooks' mail servers have been blacklisted by many providers.
