#metabrainz

/

      • dseomn has quit
      • 2022-09-26 26933, 2022

      • dseomn joined the channel
      • 2022-09-26 26950, 2022

      • Sophist-UK has quit
      • 2022-09-26 26954, 2022

      • tandy1000 has quit
      • 2022-09-26 26954, 2022

      • yyoung[m] has quit
      • 2022-09-26 26909, 2022

      • Sophist-UK joined the channel
      • 2022-09-26 26938, 2022

      • elomatreb[m] has quit
      • 2022-09-26 26935, 2022

      • tandy1000 joined the channel
      • 2022-09-26 26902, 2022

      • yyoung[m] joined the channel
      • 2022-09-26 26933, 2022

      • elomatreb[m] joined the channel
      • 2022-09-26 26929, 2022

      • bitmap has quit
      • 2022-09-26 26935, 2022

      • bitmap joined the channel
      • 2022-09-26 26924, 2022

      • rozlav has quit
      • 2022-09-26 26930, 2022

      • rozlav joined the channel
      • 2022-09-26 26954, 2022

      • aerozol
        monkey: following your instructions in https://github.com/metabrainz/listenbrainz-server… (which did seem suspiciously simple!) - when I run any kind of ./test.sh command in git bash I get ‘docker-compose: command not found’ or similar
      • 2022-09-26 26957, 2022

      • aerozol
        I’m not able to intuit any ‘obvious’ steps so I’ve probably missed something? I just cd commanded to the project location and then ran the test command/s
      • 2022-09-26 26924, 2022

      • ephemer0l has quit
      • 2022-09-26 26931, 2022

      • lucifer
        aerozol: that means docker compose needs to be installed on the pc.
      • 2022-09-26 26900, 2022

      • lucifer
        its "non-trivial" to install it on windows imo.
      • 2022-09-26 26957, 2022

      • lucifer
        the prereqs and installation steps are here: https://docs.docker.com/desktop/install/windows-i…
      • 2022-09-26 26917, 2022

      • leonardo joined the channel
      • 2022-09-26 26936, 2022

      • pprkut has quit
      • 2022-09-26 26901, 2022

      • antlarr has quit
      • 2022-09-26 26926, 2022

      • antlarr joined the channel
      • 2022-09-26 26909, 2022

      • pprkut joined the channel
      • 2022-09-26 26903, 2022

      • aerozol
        lucifer: ah thanks! I will try it tomorrow for an hour or two and then want to die and give up. Looking forward to it :D
      • 2022-09-26 26959, 2022

      • lucifer
        aerozol: hehe, feel free to ask for help if needed.
      • 2022-09-26 26933, 2022

      • trolley has quit
      • 2022-09-26 26916, 2022

      • trolley joined the channel
      • 2022-09-26 26903, 2022

      • CatQuest
        aerozol: what new holiday?
      • 2022-09-26 26945, 2022

      • ephemer0l joined the channel
      • 2022-09-26 26922, 2022

      • monkey
        aerozol: Other option is: I can update the tests for you, and we have a look at installing docker etc. in a week when you're here :)
      • 2022-09-26 26907, 2022

      • aerozol
        CatQuest: queen dead day
      • 2022-09-26 26945, 2022

      • aerozol
        monkey: great, I'll have a shot tomorrow and then you can show me why I failed next week!
      • 2022-09-26 26916, 2022

      • monkey
        There should be a lot of resources online for installing Docker and Docker compose
      • 2022-09-26 26935, 2022

      • monkey
        For Windows, the software is called Docker Desktop: https://www.docker.com/products/docker-desktop/
      • 2022-09-26 26959, 2022

      • CatQuest
        :O
      • 2022-09-26 26933, 2022

      • CatQuest
        uhm, not nativlfy english here. what exact (or close) date ranges is "first half of the 19th century" exactly? 1900-1950 ?
      • 2022-09-26 26937, 2022

      • monkey
        If I remember correctly it should come already packaged with docker-compose, so perhaps that'll be the only step
      • 2022-09-26 26922, 2022

      • monkey
        CatQuest: That's first half of the 20th century
      • 2022-09-26 26938, 2022

      • monkey
        first half of the 19th century: 1800-1850
      • 2022-09-26 26944, 2022

      • CatQuest
        ngh, this always messes me up. since in norsk we say "1800-tallet" (attenhundretallet) and that measn 1800-1899
      • 2022-09-26 26951, 2022

      • CatQuest
        thanks monkey
      • 2022-09-26 26925, 2022

      • rozlav has quit
      • 2022-09-26 26925, 2022

      • Sophist-UK has quit
      • 2022-09-26 26935, 2022

      • Sophist_UK joined the channel
      • 2022-09-26 26925, 2022

      • Sophist_UK has quit
      • 2022-09-26 26930, 2022

      • Sophist-UK joined the channel
      • 2022-09-26 26931, 2022

      • ansh
        alastairp: I was planning to work on CB-394. For this should I also remove the license choice for the users in the database? https://github.com/metabrainz/critiquebrainz/blob…
      • 2022-09-26 26932, 2022

      • BrainzBot
        CB-394: Do not allow CC BY-NC-SA license for future reviews https://tickets.metabrainz.org/browse/CB-394
      • 2022-09-26 26931, 2022

      • lucifer
        ansh: probably not becuase there are existing reviews in db with that license.
      • 2022-09-26 26920, 2022

      • lucifer
        (and sorry for the undetailed ticket 😓)
      • 2022-09-26 26927, 2022

      • Sophist_UK joined the channel
      • 2022-09-26 26932, 2022

      • ansh
        lucifer: But the review licenses are there in the reviews table. This column is for the user's default preferences for their future reviews.
      • 2022-09-26 26952, 2022

      • Sophist_UK has quit
      • 2022-09-26 26934, 2022

      • Sophist-UK has quit
      • 2022-09-26 26907, 2022

      • lucifer
        ah ok! yes it should be fine to remove that column.
      • 2022-09-26 26909, 2022

      • lucifer
        ansh: actually wait, i do not remember whether we want to add new license choices in the future.
      • 2022-09-26 26936, 2022

      • mayhem
        lucifer: what PRs should I be looking at other than LB#2037 ?
      • 2022-09-26 26937, 2022

      • BrainzBot
      • 2022-09-26 26903, 2022

      • lucifer
        mayhem: LB#2175,2176,2159,2164
      • 2022-09-26 26905, 2022

      • BrainzBot
        LB-1123: Show total artist, recording, release count : https://github.com/metabrainz/listenbrainz-server…, Fix datetime formatting for listening activity stats: https://github.com/metabrainz/listenbrainz-server…, Remove redundant excepts from dump.py: https://github.com/metabrainz/listenbrainz-server…, Turn sqlalchemy.exc.Base20DeprecationWarning into errors in tests: https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26924, 2022

      • mayhem
        k
      • 2022-09-26 26928, 2022

      • lucifer
        thanks
      • 2022-09-26 26945, 2022

      • ansh
        lucifer: Oh. So then I'll keep the table for now
      • 2022-09-26 26915, 2022

      • lucifer
        sounds good, thanks
      • 2022-09-26 26920, 2022

      • ansh
        Maybe we can merge this with your PR #417.
      • 2022-09-26 26956, 2022

      • ansh
        Since mostly we would remove the form options and validators
      • 2022-09-26 26917, 2022

      • lucifer
        sure, i can update that once tests are fixed there. can you leave a comment on that PR so that I don't forget?
      • 2022-09-26 26939, 2022

      • ansh
        Sure I'll add it
      • 2022-09-26 26950, 2022

      • lucifer
        thanks
      • 2022-09-26 26946, 2022

      • kepstin has quit
      • 2022-09-26 26946, 2022

      • heyarne[m] has quit
      • 2022-09-26 26947, 2022

      • yellowhatpro has quit
      • 2022-09-26 26949, 2022

      • yyoung[m] has quit
      • 2022-09-26 26949, 2022

      • elomatreb[m] has quit
      • 2022-09-26 26950, 2022

      • tandy1000 has quit
      • 2022-09-26 26954, 2022

      • rik1 has quit
      • 2022-09-26 26926, 2022

      • mayhem
        reading LB#2175 is like having deja-vu over and over again, lol
      • 2022-09-26 26927, 2022

      • BrainzBot
        LB-1123: Show total artist, recording, release count : https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26958, 2022

      • lucifer
        hehe lol
      • 2022-09-26 26906, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #2178 (03master…add-back-left-joins): Add LEFT JOINs to link_attribute and link_attribute_type in mb_metadata_cache https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26943, 2022

      • elomatreb[m] joined the channel
      • 2022-09-26 26957, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2175 (03master…total-entity-counts): LB-1123: Show total artist, recording, release count https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26958, 2022

      • kepstin joined the channel
      • 2022-09-26 26958, 2022

      • tandy1000 joined the channel
      • 2022-09-26 26913, 2022

      • yellowhatpro joined the channel
      • 2022-09-26 26929, 2022

      • rik1 joined the channel
      • 2022-09-26 26941, 2022

      • yyoung[m] joined the channel
      • 2022-09-26 26942, 2022

      • heyarne[m] joined the channel
      • 2022-09-26 26907, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2159 (03master…improve-dumps): Remove redundant excepts from dump.py https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26954, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2178 (03master…add-back-left-joins): Add LEFT JOINs to link_attribute and link_attribute_type in mb_metadata_cache https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26907, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2176 (03master…fix-listening-activity-stats): Fix datetime formatting for listening activity stats https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26939, 2022

      • lucifer
        mayhem: oh there's also LB#2153
      • 2022-09-26 26939, 2022

      • BrainzBot
        Allow recommendations with only mbids: https://github.com/metabrainz/listenbrainz-server…
      • 2022-09-26 26927, 2022

      • chinmay
        lucifer: for the fresh releases API how many days should we have by default in days parameter?
      • 2022-09-26 26958, 2022

      • lucifer
        i think 30 is fine for now. mayhem thoughts?
      • 2022-09-26 26917, 2022

      • mayhem
        yeah.
      • 2022-09-26 26929, 2022

      • mayhem
        we'll figure the right value out pretty quick
      • 2022-09-26 26905, 2022

      • chinmay
        Alright
      • 2022-09-26 26928, 2022

      • BrainzGit
        [critiquebrainz] 14amCap1712 opened pull request #467 (03master…update-pg-repo): Dockerfile: Install postgresql-client from current base image repo https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-09-26 26938, 2022

      • lucifer
        alastairp: cb image fails to build for me without this change ^. this probably broke at same time as LB, i wonder how CB builds in test/prod/wolf continued to work for so long. they still work apparently in CI.
      • 2022-09-26 26909, 2022

      • monkey
        Having the same issue with building images on BB
      • 2022-09-26 26940, 2022

      • monkey
        Hm, not sure about same actually.
      • 2022-09-26 26903, 2022

      • BrainzGit
        [critiquebrainz] 14amCap1712 merged pull request #467 (03master…update-pg-repo): Dockerfile: Install postgresql-client from current base image repo https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-09-26 26907, 2022

      • lucifer
        monkey: what's the error?
      • 2022-09-26 26938, 2022

      • monkey
      • 2022-09-26 26951, 2022

      • monkey
        xenial not supported
      • 2022-09-26 26955, 2022

      • lucifer
        yup same error
      • 2022-09-26 26906, 2022

      • lucifer
        copy pasting commit should work
      • 2022-09-26 26934, 2022

      • monkey
        But BB already uses that formatting, at least very similar: https://github.com/metabrainz/bookbrainz-site/blo…
      • 2022-09-26 26903, 2022

      • lucifer
        hmm maybe the node image is outdated
      • 2022-09-26 26957, 2022

      • monkey
      • 2022-09-26 26934, 2022

      • lucifer
      • 2022-09-26 26925, 2022

      • lucifer
        yeah that base image is outdated.
      • 2022-09-26 26925, 2022

      • monkey
        Right, probably using the latest tag which is an old version: https://hub.docker.com/r/metabrainz/base-image/ta…
      • 2022-09-26 26929, 2022

      • lucifer
      • 2022-09-26 26942, 2022

      • monkey
        Thx !
      • 2022-09-26 26902, 2022

      • BrainzGit
        [metabrainz.org] 14mayhem merged pull request #390 (03master…send-invoices): Send invoices https://github.com/metabrainz/metabrainz.org/pull…
      • 2022-09-26 26901, 2022

      • riksucks
        Hello Freso , won't be able to participate in today's meeting due to upcoming examinations. I hope you guys had a great week and an amazing weekend :)
      • 2022-09-26 26931, 2022

      • BrainzGit
        [critiquebrainz] 14amCap1712 opened pull request #468 (03master…update-wtf): Update WTForms https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-09-26 26930, 2022

      • lucifer
        mayhem: did you see spotify's new playlists? it sounds kinda similar to huesound. give it three colors, pick 2 categories and it gives you a playlist.
      • 2022-09-26 26916, 2022

      • mayhem
        yeah, see, spotify is so desperate that they are starting to copy us....
      • 2022-09-26 26922, 2022

      • mayhem
        🤣
      • 2022-09-26 26932, 2022

      • lucifer
        😆
      • 2022-09-26 26913, 2022

      • lucifer
      • 2022-09-26 26914, 2022

      • mayhem
        close tab close tab close tab!
      • 2022-09-26 26924, 2022

      • mayhem gets allergic to their design choicse
      • 2022-09-26 26927, 2022

      • mayhem
        choices
      • 2022-09-26 26948, 2022

      • lucifer
        yeah indeed
      • 2022-09-26 26944, 2022

      • mayhem
        that color wheel. soo intuitive!
      • 2022-09-26 26915, 2022

      • lucifer
        lol
      • 2022-09-26 26949, 2022

      • mayhem
        one thing that this page does validate for me is this: If you want to stay relevant with the times, you need make music... more visual. and this does it. while making me shudder.
      • 2022-09-26 26928, 2022

      • lucifer
        yes, makes sense
      • 2022-09-26 26952, 2022

      • mayhem
        and then it stops working. likely because I dare not use chrome.
      • 2022-09-26 26959, 2022

      • mayhem closes the tab and goes on with life
      • 2022-09-26 26921, 2022

      • mayhem
        huesound rules. click, look, listen. repeat.
      • 2022-09-26 26946, 2022

      • mayhem
        lucifer: what if we make a MEGA image for YIM 2022?
      • 2022-09-26 26958, 2022

      • mayhem
        Composed of all the cover art from all the releases of 2022?
      • 2022-09-26 26916, 2022

      • mayhem
        giant image. would be cool, but also huge and hard to share.
      • 2022-09-26 26937, 2022

      • mayhem
        but sounds like fun. especially if it was sorted by... color. 🤩
      • 2022-09-26 26953, 2022

      • lucifer
        oh that sounds great! kinda like the reddit thing where people can create anything on the yim page.
      • 2022-09-26 26953, 2022

      • lucifer
        it would definitely be hard to share. also where can we host it?
      • 2022-09-26 26900, 2022

      • mayhem
        yeah, I'm already looking forward to YIM stuff.
      • 2022-09-26 26928, 2022

      • mayhem
        I wonder if the gigapan project has a viewer that would could hijack.
      • 2022-09-26 26903, 2022

      • mayhem
        also, I wonder if we should split YIM into two parts this year.. since we're purists.
      • 2022-09-26 26917, 2022

      • mayhem
        the YIM review near time time spotify does their thing.
      • 2022-09-26 26925, 2022

      • mayhem
        and then the Full YIM on Jan 1.
      • 2022-09-26 26947, 2022

      • mayhem
        where the preview is all the stuff that is likely not impacted by the last month of listens.
      • 2022-09-26 26904, 2022

      • mayhem
        and the full has it all, 100% correct, including playlists.