#metabrainz

/

      • GibusWearingMann has quit
      • 2022-10-04 27700, 2022

      • darkstardevx has quit
      • 2022-10-04 27756, 2022

      • aerozol
        mayhem: I'm on the bus now. Feels surreal!
      • 2022-10-04 27726, 2022

      • mayhem
        Welcome!
      • 2022-10-04 27738, 2022

      • mayhem
        Ping me when the bus leaves.
      • 2022-10-04 27722, 2022

      • aerozol
        mayhem: has left. No hurry though I can soak in the sights
      • 2022-10-04 27708, 2022

      • mayhem
        Ok
      • 2022-10-04 27740, 2022

      • mayhem
        When you arrive, watch your belongings. Many a passport and mobile have been stolen there... Today.
      • 2022-10-04 27752, 2022

      • aerozol
        :0 will do!
      • 2022-10-04 27757, 2022

      • mayhem
        Monkey alastairp : dinner at la Pachucha gótico at 19h, if you wanna join.
      • 2022-10-04 27743, 2022

      • zas
        marlon is missing disk space, on /data/datanode it uses almost 800Gb
      • 2022-10-04 27758, 2022

      • mayhem
        lucifer: ^
      • 2022-10-04 27753, 2022

      • mayhem
        wow, the airbnb host is being super annoying.
      • 2022-10-04 27716, 2022

      • lucifer
        zas: thanks for the report.
      • 2022-10-04 27736, 2022

      • lucifer
        fixed now, there were log files of 1.8T in the cluster. removed all.
      • 2022-10-04 27710, 2022

      • mayhem
        aerozol: bitmap yvanzo akshaaatt atj_mb : please email me a copy of your passport. I need it to register everyone with the Airbnb host.
      • 2022-10-04 27737, 2022

      • akshaaatt
        Done mayhem
      • 2022-10-04 27745, 2022

      • mayhem
        Thanks. How was your flight?
      • 2022-10-04 27726, 2022

      • zas
        lucifer: thanks
      • 2022-10-04 27702, 2022

      • monkey
        mayhem: down for dinner tonight !
      • 2022-10-04 27750, 2022

      • reosarevok
        mayhem: isn't that needed always anyway? I remember having to do that a few years back
      • 2022-10-04 27756, 2022

      • reosarevok
        Literally go to their office too
      • 2022-10-04 27721, 2022

      • reosarevok
        Also, dinner at 19, so... European :p
      • 2022-10-04 27733, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2672 (03master…MBS-11063): MBS-11063: Convert event edit form to React [WIP] https://github.com/metabrainz/musicbrainz-server/…
      • 2022-10-04 27746, 2022

      • akshaaatt had the sandwich at the Frankfurt airport and was blown away
      • 2022-10-04 27725, 2022

      • atj_mb
        reosarevok: I think it might be some legal req in BCN. Didn't need to do it in Madrid IIRC...
      • 2022-10-04 27731, 2022

      • lucifer
      • 2022-10-04 27748, 2022

      • lucifer
        1m vs 21m ::exploding_head: same plan
      • 2022-10-04 27701, 2022

      • alastairp
        lucifer: interesting!
      • 2022-10-04 27703, 2022

      • lucifer
        are aretha disks slower?
      • 2022-10-04 27703, 2022

      • alastairp
        (morning!)
      • 2022-10-04 27707, 2022

      • lucifer
        morning!
      • 2022-10-04 27750, 2022

      • lucifer
        i see there's a difference in buffer contents as well, prod had to read entire recording table from disk where it was in cache on wolf.
      • 2022-10-04 27708, 2022

      • alastairp
        I think they might both be hard drives
      • 2022-10-04 27718, 2022

      • alastairp
        zas: md3 on aretha is rebuilding, not sure if that's expected or known
      • 2022-10-04 27746, 2022

      • lucifer
        you mean both aretha disks are HDD or both wolf and aretha are HDDs?
      • 2022-10-04 27755, 2022

      • alastairp
        lucifer: both servers have hdds
      • 2022-10-04 27716, 2022

      • lucifer
        ah i see.
      • 2022-10-04 27727, 2022

      • lucifer
        i'll dump the settings from both instances and do a compare to see if i can figure out some difference.
      • 2022-10-04 27736, 2022

      • mayhem
        aaargh.
      • 2022-10-04 27713, 2022

      • mayhem
        the signup process for the airbnb has become decisively spanish. type on lots of data, in triplicate and sign it.
      • 2022-10-04 27717, 2022

      • zas
        alastairp: that's not a rebuild, but a check. Those are done on regular basis. That's still a resync.
      • 2022-10-04 27733, 2022

      • atj_mb
        Will there be an iris scan on arrival?
      • 2022-10-04 27737, 2022

      • lucifer
        alastairp: its the cache difference. mapping.canonical_release_redirect needs to read entirely from disk and takes about 15mins to read. rerunning the query after cache is built take 43s.
      • 2022-10-04 27741, 2022

      • alastairp
        zas: right thanks, I didn't look into it in too much detail, only the .....>
      • 2022-10-04 27755, 2022

      • alastairp
        lucifer: right, makes sense
      • 2022-10-04 27708, 2022

      • alastairp
        atj_mb: only for people who left the EU
      • 2022-10-04 27732, 2022

      • mayhem
        reosarevok: is you want to eat at this restaurant at 10pm, you'll wait until 1am before you get in.
      • 2022-10-04 27749, 2022

      • atj_mb
        alastairp: as ever, thanks for the reminder
      • 2022-10-04 27737, 2022

      • lucifer
        alastairp: i guess the 3.5hours runtime makes sense then. not sure anything can be done about this.
      • 2022-10-04 27747, 2022

      • alastairp
        lucifer: ok, great
      • 2022-10-04 27727, 2022

      • aerozol
      • 2022-10-04 27735, 2022

      • aerozol
        👌
      • 2022-10-04 27703, 2022

      • lucifer
        🥳
      • 2022-10-04 27728, 2022

      • mayhem is still angry and bummed that this summit will happen without lucifer present.
      • 2022-10-04 27753, 2022

      • lucifer
        yeah :(
      • 2022-10-04 27703, 2022

      • aerozol
        So dumb!!
      • 2022-10-04 27723, 2022

      • zas
      • 2022-10-04 27744, 2022

      • zas
        check loctag -> "-" is for website alone, "sk" for websocket
      • 2022-10-04 27736, 2022

      • zas
        so we can now have all stats (like before); but also distinguish web and websocket traffic
      • 2022-10-04 27742, 2022

      • lucifer
        alastairp: CB-403 lgtm, should i merge or do you want to take a look later?
      • 2022-10-04 27743, 2022

      • BrainzBot
        CB-403: Show all reviews referred to by a redirected MBID https://tickets.metabrainz.org/browse/CB-403
      • 2022-10-04 27751, 2022

      • lucifer
        uh CB#403
      • 2022-10-04 27752, 2022

      • BrainzBot
        CB-416: Identify users by musicbrainz username, not uuid: https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27729, 2022

      • monkey
        nice zas !
      • 2022-10-04 27719, 2022

      • BrainzGit
        [critiquebrainz] 14alastair merged pull request #403 (03master…CB-416): CB-416: Identify users by musicbrainz username, not uuid https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27720, 2022

      • alastairp
        lucifer: let's do it!
      • 2022-10-04 27736, 2022

      • lucifer
        thanks!
      • 2022-10-04 27747, 2022

      • alastairp
        does this require any sql?
      • 2022-10-04 27703, 2022

      • lucifer
        yes, i'll open a PR for the script
      • 2022-10-04 27706, 2022

      • alastairp
        thanks
      • 2022-10-04 27716, 2022

      • alastairp
        let me merge a few more things and we can make a release and put it on beta
      • 2022-10-04 27742, 2022

      • alastairp
        lucifer: you made a new BU release, right? so CB#469 can be merged as-is?
      • 2022-10-04 27742, 2022

      • BrainzBot
        Upgrade SQLAlchemy and enable 2.0 warnings: https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27743, 2022

      • lucifer
        this one is already on beta fwiw.
      • 2022-10-04 27706, 2022

      • alastairp
        I wonder if we should put `run_sql_script` and `run_sql_script_without_transaction` in BU
      • 2022-10-04 27735, 2022

      • lucifer
        need to update the PR to fix the new functions the PR merged above and others to be merged soon will add.
      • 2022-10-04 27747, 2022

      • lucifer
        but otherwise yes the SQLAlchemy 2.0 PR should be ready
      • 2022-10-04 27706, 2022

      • alastairp
        I approved it, can you merge/change as necessary?
      • 2022-10-04 27719, 2022

      • lucifer
        yes sure.
      • 2022-10-04 27741, 2022

      • alastairp
        also just approved wtforms
      • 2022-10-04 27705, 2022

      • lucifer
        i'll update/merge the SQLAlchemy one at last today otherwise will have to update all other PRs which will be messier i think.
      • 2022-10-04 27728, 2022

      • BrainzGit
        [critiquebrainz] 14amCap1712 merged pull request #468 (03master…update-wtf): Update WTForms https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27702, 2022

      • BrainzGit
        [critiquebrainz] 14dependabot[bot] opened pull request #470 (03master…dependabot/npm_and_yarn/glob-parent-5.1.2): build(deps): bump glob-parent from 3.1.0 to 5.1.2 https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27706, 2022

      • BrainzGit
        [critiquebrainz] 14dependabot[bot] opened pull request #471 (03master…dependabot/npm_and_yarn/json-schema-and-jsprim-0.4.0): build(deps): bump json-schema and jsprim https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27711, 2022

      • lucifer
        also +1 on adding run_sql_script and the non transaction version to BU.
      • 2022-10-04 27731, 2022

      • BrainzGit
        [critiquebrainz] 14dependabot[bot] opened pull request #472 (03master…dependabot/npm_and_yarn/ajv-6.12.6): build(deps): bump ajv from 6.10.0 to 6.12.6 https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27729, 2022

      • alastairp
        lucifer: hi
      • 2022-10-04 27740, 2022

      • lucifer
        hey!
      • 2022-10-04 27746, 2022

      • alastairp
        consul config for LB has ` "websockets_server_url": "https://sockets.listenbrainz.org",`
      • 2022-10-04 27756, 2022

      • alastairp
        but this seems obviously wrong
      • 2022-10-04 27706, 2022

      • lucifer
        yes that config url is unused.
      • 2022-10-04 27750, 2022

      • alastairp
        I'm just talking to monkey now about it
      • 2022-10-04 27759, 2022

      • alastairp
        we see that in js we use window.location.path and append socket.io to the end
      • 2022-10-04 27711, 2022

      • lucifer
      • 2022-10-04 27717, 2022

      • alastairp
        yeah, we just found that
      • 2022-10-04 27717, 2022

      • lucifer
        right
      • 2022-10-04 27739, 2022

      • alastairp
        do you think we should remove it completely from config and use this pattern, or add full url back into the config file as the correct value? monkey ?
      • 2022-10-04 27748, 2022

      • lucifer
        i am not sure about the best way to go about this. we also need to fix this to make WS working in dev.
      • 2022-10-04 27738, 2022

      • monkey
        Ditto
      • 2022-10-04 27751, 2022

      • lucifer
        we could probably remove from config, and update the code here to special case dev that if a url is supplied then use it over the pattern.
      • 2022-10-04 27706, 2022

      • lucifer
        or we could add 2 config values, one for path and one for base url.
      • 2022-10-04 27746, 2022

      • lucifer
        both ways seem okay-ish too me but yeah not the best way i guess.
      • 2022-10-04 27719, 2022

      • alastairp
        LB-1004
      • 2022-10-04 27719, 2022

      • BrainzBot
        LB-1004: Improve websocket server setup in local development and production https://tickets.metabrainz.org/browse/LB-1004
      • 2022-10-04 27749, 2022

      • Pratha-Fish
        alastairp: apparently the cleanup process is taking ~24 seconds for 105k rows 🗿
      • 2022-10-04 27718, 2022

      • Pratha-Fish
        And was without factoring in the r/w time
      • 2022-10-04 27751, 2022

      • Pratha-Fish
        I suspect that's because the functions I am using (pandas.series.map / pandas.series.apply) are just glorified for loops. I am currently trying out ways to vectorize the operations somehow
      • 2022-10-04 27746, 2022

      • lucifer
        alastairp: i don't think we can do ws in same containers in local development. flask dev server serves only 1 request at a time iirc so incompatible with having a ws server running. unless we want to replace to flask dev server with something else.
      • 2022-10-04 27709, 2022

      • lucifer
        (regarding the last point in that ticket)
      • 2022-10-04 27709, 2022

      • alastairp
        lucifer: new flask actually uses threads I think
      • 2022-10-04 27719, 2022

      • lucifer
        oh, nice.
      • 2022-10-04 27752, 2022

      • alastairp
        you're right that we'd need to test is
      • 2022-10-04 27716, 2022

      • alastairp
        doing this would mean that our ws server was on the same host as the flask server, allowing us to continue using window.location
      • 2022-10-04 27741, 2022

      • lucifer
        yes makes sense. also 1 less container is better
      • 2022-10-04 27746, 2022

      • alastairp
        yep, right
      • 2022-10-04 27708, 2022

      • alastairp
        but there is the magic in the ws container with the extra thread for rmq connections
      • 2022-10-04 27720, 2022

      • alastairp
        which makes me a bit worried about how we do that
      • 2022-10-04 27757, 2022

      • lucifer
        yeah, i wonder if we should add celery and move the magic to it.
      • 2022-10-04 27722, 2022

      • lucifer
        there are probably better resources available on how celery interacts with flask/threads etc.
      • 2022-10-04 27736, 2022

      • alastairp
        I think I had another thought about how we could do it
      • 2022-10-04 27708, 2022

      • alastairp
        OK, for now let's delete all of the websocket data in the config file (I'll do that now, to assist zas with some cleanup he's doing). This isn't going to make anything _more_ broken than it is now
      • 2022-10-04 27719, 2022

      • alastairp
        and if we need to add something back in when we try and fix local dev, we can do that
      • 2022-10-04 27734, 2022

      • lucifer
        👍
      • 2022-10-04 27747, 2022

      • alastairp
      • 2022-10-04 27705, 2022

      • atj_mb
        I'll teach aerozol vim this week 😆
      • 2022-10-04 27746, 2022

      • alastairp
        atj_mb: we do want him to stick around with us :)
      • 2022-10-04 27707, 2022

      • mayhem
        dont teach him :wq and he will!
      • 2022-10-04 27731, 2022

      • atj_mb
        It's the perfect time, he can't leave!
      • 2022-10-04 27746, 2022

      • BrainzGit
        [critiquebrainz] 14amCap1712 opened pull request #473 (03master…add-text-index): Add index on "user".id::text https://github.com/metabrainz/critiquebrainz/pull…
      • 2022-10-04 27754, 2022

      • alastairp
      • 2022-10-04 27702, 2022

      • aerozol
        loll, trapped
      • 2022-10-04 27719, 2022

      • alastairp
      • 2022-10-04 27730, 2022

      • BrainzGit
        [listenbrainz-server] 14alastair opened pull request #2192 (03master…remove-websocket-config): Remove configuration options for websocket server https://github.com/metabrainz/listenbrainz-server…
      • 2022-10-04 27758, 2022

      • mayhem
        akshaaatt: you near the bus yet?
      • 2022-10-04 27719, 2022

      • akshaaatt
        Noi mayhem
      • 2022-10-04 27725, 2022

      • akshaaatt
        Need to collect baggage
      • 2022-10-04 27741, 2022

      • mayhem
        yes, can be slow at times.
      • 2022-10-04 27748, 2022

      • mayhem
        seems busy there right now.
      • 2022-10-04 27736, 2022

      • atj_mb
        Flight departing shortly, see you on the other side!
      • 2022-10-04 27746, 2022

      • mayhem
        have a good flight atj
      • 2022-10-04 27706, 2022

      • mayhem
        fingers crossed for no stag or hen-dos on the flight.
      • 2022-10-04 27726, 2022

      • mayhem
      • 2022-10-04 27755, 2022

      • mayhem
        I would put money on more than 50% being duplicates and other other unlistenable shit.
      • 2022-10-04 27733, 2022

      • lucifer
        MB has 27 M recordings and 40 M tracks. it would be odd if 60M tracks were missing from MB but in apple music. so a lot more than 50% in dupes i think.
      • 2022-10-04 27751, 2022

      • mayhem
        agreed.
      • 2022-10-04 27706, 2022

      • mayhem
        40M tracks. wow.
      • 2022-10-04 27719, 2022

      • mayhem
        seems it was just yesterday we celebrated 1M tracks.
      • 2022-10-04 27709, 2022

      • mayhem
        turns out that was 2003. lol
      • 2022-10-04 27724, 2022

      • lucifer
        hehe lol