chinmay, i think that ties in with the coverartgrid mayhem has been working on recently.
2022-10-14 28726, 2022
lucifer
the problem as he mentioned in the summit is with hosting.
2022-10-14 28747, 2022
mayhem
I'll be picking up the work on that later next week, trying for the client side version -- see if we can make it work.
2022-10-14 28750, 2022
mayhem
all JS/CSS.
2022-10-14 28752, 2022
monkey
Hmm, the coverflow looks OK on mobile in landscape mode, but portrait not so much. There is support for configuration overrides per breakpoint so I'll look into that https://swiperjs.com/swiper-api#param-breakpoints
2022-10-14 28740, 2022
chinmay
monkey: it looks awesome. the animations are smooth. I'd change release name font size to 1.5rem and change the artist name font color to #46433a a.k.a @asphalt
2022-10-14 28757, 2022
chinmay
testing for mobilenow
2022-10-14 28725, 2022
monkey
lucifer: ^ I'm not quite done with the coverflow PR, so don't wait for me for the release :)
For me it auto-formats, but I think it's my code editor extension doing it on save
2022-10-14 28717, 2022
chinmay
hmm.. let me check my extension
2022-10-14 28714, 2022
chinmay
when i do Ctrl Shift I it uses it's own config
2022-10-14 28727, 2022
chinmay
something wrong with my extension it looks like
2022-10-14 28716, 2022
lucifer
mayhem: oh i remembered just now. we forgot to discuss the mapper metrics issue. do you want to discuss it now or later?
2022-10-14 28713, 2022
mayhem
now works.
2022-10-14 28738, 2022
lucifer
i checked the indiviudal counts for each match type are correct. but the percent calculation rate has some issue. not exactly sure what. i propose we calculate the match rate by doing (exact + high + med + low) / (exact + high + med + low + no) directly in influx.
2022-10-14 28715, 2022
lucifer
we can use the spread() method of influx to only consider listens of a particular time period instead of the overall cumulative count if we want.
2022-10-14 28736, 2022
mayhem
I like it, but...
2022-10-14 28749, 2022
lucifer
this way is probably also more in line with how we have to do it when we move to prometheus.
2022-10-14 28751, 2022
mayhem
we're migrating away from influx. (thank fuck)
2022-10-14 28720, 2022
lucifer
i believe that prometheus will have same features available.
2022-10-14 28722, 2022
mayhem
ahh, ok. shall we move this batch to prometheus to start with? we can move the metrics python code over.
2022-10-14 28731, 2022
lucifer
sure.
2022-10-14 28710, 2022
lucifer
i'll add a flask endpoint to metrics as we discussed in the summit and then work with zas/atj_mb so that prometheus starts querying it.
2022-10-14 28716, 2022
mayhem
and yeah, the stats are deffo a lagging feature and when you have no idea what you're doing those tend to become a mess.
2022-10-14 28743, 2022
lucifer
yeah makes sense
2022-10-14 28703, 2022
mayhem
I was really hoping to avoid this endpoint and move the metrics writer to promethues and expose an HTTP endpoint from it.
2022-10-14 28731, 2022
lucifer
yes right. isn't that what we are going to do?
2022-10-14 28751, 2022
lucifer
my understanding was we finalized that during the summit but i might be misremembering?
2022-10-14 28715, 2022
mayhem
my understanding "move the metrics writer to promethues and expose an HTTP endpoint from it." is what we decided.
2022-10-14 28746, 2022
lucifer
right.
2022-10-14 28704, 2022
lucifer
"I was really hoping to avoid this endpoint" <- which endpoint did you mean by this?
2022-10-14 28731, 2022
mayhem
the parameters to the metrics writer will need to change, so that makes things a bit tricker. we may need a new method name, unless BU can isolate it from the codebase that expects the old format.
2022-10-14 28746, 2022
mayhem
I'm really hoping to avoid adding another endpoint to LB.
2022-10-14 28703, 2022
lucifer
i think that's fine. we won;t need to add another LB endpoint.
2022-10-14 28716, 2022
mayhem
š
2022-10-14 28753, 2022
lucifer
the BU method can write 2 times, once for influx and one for prometheus. till we move all LB stuff to prometheus.
2022-10-14 28709, 2022
mayhem
brilliant!
2022-10-14 28748, 2022
lucifer
historical user counts, spotify connections is something i'd like to retain over long time and afaiu prometheus isn't currently configured for that.
2022-10-14 28714, 2022
lucifer
so at least those 2 things will remain in influx for now.
the conclusion we reached in this case that for items we want stored longer, is that we should ask atj_mb or zas to update the retention rules for us accordingly.
2022-10-14 28711, 2022
mayhem
(in prometheus)
2022-10-14 28716, 2022
lucifer
ah i see. makes sense
2022-10-14 28759, 2022
mayhem
not soon -- in JSONB is fine for now.
2022-10-14 28708, 2022
lucifer
š thanks!
2022-10-14 28720, 2022
atj_mb
IIRC zas said he has configured Prometheus to retain stats for 5yrs by default
hello. i set up a listenbrainz scrobbler (cmus-status-scrobbler), which claims to send musicbrainz ids if present. all of my music has musicbrainz ids, and i've verified by modifying the script to dump http requests to a file that it is in fact sending the ids...
2022-10-14 28744, 2022
naom
...however, when i look at my recent listens, it often shows the wrong recording id (different recording with the same title by the same artist, etc)
2022-10-14 28708, 2022
naom
am i doing something wrong, or is this expected behavior/a known bug?
2022-10-14 28713, 2022
mayhem
hi naom!
2022-10-14 28726, 2022
mayhem
thanks for sending MBIDs, we <3 that!
2022-10-14 28703, 2022
mayhem
lucifer: monkey : I forget -- where is the UI at in showing user submitted MBIDs?
2022-10-14 28737, 2022
mayhem
we've been trying to get our mapper working well (its a looong task) and for that effect we decide to show the mapped MBIDs and ignore user MBIDs.
2022-10-14 28746, 2022
lucifer
mayhem: not sure what you mean?
2022-10-14 28753, 2022
lucifer
naom: what's your LB username.
2022-10-14 28758, 2022
mayhem
we're planning on changing that before too long iirc
2022-10-14 28710, 2022
mayhem
are we showing user submitted MBIDs over mapped MBIDs in the LB UI?
2022-10-14 28711, 2022
lucifer
i mean not sure which UI you mean.
2022-10-14 28733, 2022
lucifer
for listens page, we prefer user submitted mbids iirc.
2022-10-14 28738, 2022
mayhem
a users personal listens page, for example. but any page where listens are shown, really.
2022-10-14 28738, 2022
lucifer
everywhere else mapped ones.
2022-10-14 28748, 2022
naom
lucifer: naomiii
2022-10-14 28701, 2022
naom
i noticed in one case, the album art of an incorrect album is displayed, but if i hover it, the correct release title is the alt text
2022-10-14 28705, 2022
lucifer
mayhem: we have three cases iirc, user listens page, prefer user submitted over mapped. stats prefer mapped over user submitted. everywhere else mapped.
2022-10-14 28747, 2022
lucifer
naom: i see. can you also tell which listens are problematic?
2022-10-14 28749, 2022
mayhem
"everywhere else mapped." should probably prefer user submitted now. what do you think?
2022-10-14 28730, 2022
lucifer
sorry, i meant we use data from mapping every where else. like feedback stores recording mbid only, and need to fetch metadata from mapping.
2022-10-14 28729, 2022
lucifer
we do use recording mbids from user submitted listens there if present afair. but that the metadata is still looked up from mapping in all those cases.
2022-10-14 28712, 2022
naom
lucifer: for the track "FUCKMYLIFE666", i should have submitted 595e0a92-3fbe-493e-bd45-522c11ed576e but my user page links to 096eed95-18b9-4fe1-9c3a-6f49fb3d92c5. for "His Arm Was Her Leg", submitted 0e112194-f4cd-44ee-930a-f6f07c045872 and links to ef134fcd-1c21-439f-a7b2-e477b4b2e58d
this is trying to send a track mbid not recording mbid probably. this is a guess from a brief look at the code so can be wrong.
2022-10-14 28701, 2022
lucifer
mayhem, thoughts on whether we want to accpet mbids in the lfm api?
2022-10-14 28719, 2022
naom
i see
2022-10-14 28734, 2022
mayhem
please use our normal API for submissions, naom.
2022-10-14 28755, 2022
mayhem
the old API was created for making old tools backwards compatible
2022-10-14 28706, 2022
mayhem
but if people keep writing tools against this API, maybe we should just remove it.
2022-10-14 28720, 2022
mayhem
this has historically been the case and this is a bad pattern, really.
2022-10-14 28719, 2022
lucifer
we can reach out to the owner of the repo and help them use the new api. its python and looks simple enough for us to help port.
2022-10-14 28703, 2022
mayhem
that's be much better.
2022-10-14 28708, 2022
lucifer
removing the api altogether is probably fine but we should analyze how much traffic we have there and do a blog post offering to help port i guess and then sunset in some time.
2022-10-14 28714, 2022
mayhem
and if the compat api gives us issues again, lets rip it out.
2022-10-14 28725, 2022
lucifer
sounds good to rip out in any case i think, if we can help existing users switch over. would be one less thing to maintain.
2022-10-14 28740, 2022
mayhem
yes, plz.
2022-10-14 28727, 2022
lucifer
cool, i'll open a ticket for the analysis, blog post etc.
2022-10-14 28709, 2022
naom
now that you mention it sending a track mbid and not a recording mbid, i'm looking at my music's metadata and it has MUSICBRAINZ_TRACKID but nothing explicitly mentioning recordings, is that abnormal? i use beets for tagging
2022-10-14 28724, 2022
naom
i don't actually think i realized track ids were a thing per se
2022-10-14 28754, 2022
lucifer
i am not sure how beets work but something might be falling back to recording mbid because the mbid you shared was indeed a recording mbid.
2022-10-14 28706, 2022
lucifer
i'll try to reach out to the author and see if we can port it to the newer LB api.
2022-10-14 28737, 2022
naom
wonderful
2022-10-14 28705, 2022
lucifer
oh it appears the C* Music Player only supports track id not recording mbid.
2022-10-14 28727, 2022
lucifer
in any case, porting the scrobbler would be a good idea.
2022-10-14 28714, 2022
alastairp
keep in mind that back in the original lastfm days, trackid is what we now call recording id
2022-10-14 28718, 2022
alastairp
due to schema changes, etc
2022-10-14 28732, 2022
lucifer
oh.
2022-10-14 28749, 2022
alastairp
anyway, having number of accesses to compat api via our new metrics monitor would be great ;)
2022-10-14 28715, 2022
lucifer
yup makes sense
2022-10-14 28749, 2022
mayhem
for that, yes, great use case. :)
2022-10-14 28723, 2022
lucifer
naom, can you show what's the value of various mbid fields of the file in beets?
so RELEASETRACKID is a track id and TRACKID is a recording id?
2022-10-14 28746, 2022
naom
ah, yeah that's what the page says
2022-10-14 28706, 2022
lucifer
yes
2022-10-14 28735, 2022
naom
so a track is like a single entry in a medium, then? i don't think i realized those had their own ids separate from recordings until now
2022-10-14 28716, 2022
lucifer
yes right.
2022-10-14 28736, 2022
alastairp
lucifer: I wondered why my battery was going down so quickly. fleet was stuck in a loop using 50% of an entire cpu core trying to ssh to the remote workspace
2022-10-14 28705, 2022
alastairp
still a bit to improve...
2022-10-14 28711, 2022
lucifer
oh. oops!!
2022-10-14 28717, 2022
lucifer
indeed
2022-10-14 28753, 2022
naom has quit
2022-10-14 28705, 2022
chinmay
8000 commits to LB!
2022-10-14 28758, 2022
outsidecontext
lucifer: I recently wrote a longer explanation of the history of the musicbrainz_trackid tag on the Mp3 tag forums: https://community.mp3tag.de/t/logik-hinter-musicbā¦ . It's in German, but Google Translate can give a rather good translation if you're interested.
2022-10-14 28753, 2022
aerozol
Thanks alastairp! Nice to be home. Hopefully the luggage is delivered soon, with your gifts D:
2022-10-14 28728, 2022
aerozol
CatQuest: ex-battery chicken friendos :D
2022-10-14 28741, 2022
CatQuest
<3<3<3
2022-10-14 28756, 2022
CatQuest
i knew a lady that also did that. good humans!
2022-10-14 28723, 2022
aerozol
They are very cute, and provide eggs for the neighbours as well (we only have 2, RIP Sunny Jim)
