#metabrainz

/

      • zas
        bitmap: I can create and attach a volume, main SSD is already at max size
      • 2022-10-18 29103, 2022

      • bitmap
        zas: would it be possible to move some containers' docker volumes to the new volume?
      • 2022-10-18 29147, 2022

      • zas
        I just freed 3.5G from /var/log/journal
      • 2022-10-18 29107, 2022

      • bitmap
        oh, thanks. maybe redis can start now
      • 2022-10-18 29129, 2022

      • zas
        yes, please try
      • 2022-10-18 29134, 2022

      • chinmay
        monkey: interesting! I think the marks approach will help
      • 2022-10-18 29143, 2022

      • zas
        then we'll think about a long term solution
      • 2022-10-18 29158, 2022

      • chinmay
        monkey: yep, debounce ftw
      • 2022-10-18 29159, 2022

      • monkey
        chinmay: I think you can even define a label for each mark, so you can show the date in question
      • 2022-10-18 29109, 2022

      • monkey
        Should look pretty good
      • 2022-10-18 29153, 2022

      • chinmay
        yeah
      • 2022-10-18 29155, 2022

      • chinmay
      • 2022-10-18 29101, 2022

      • chinmay
        ^ examples
      • 2022-10-18 29111, 2022

      • monkey
        Ah yiiss
      • 2022-10-18 29150, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #890 (03master…fix-build-workflow): chore: Fix CI builds https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29116, 2022

      • BrainzGit
        [bookbrainz-site] 14dependabot[bot] opened pull request #891 (03master…dependabot/npm_and_yarn/passport-0.6.0): chore(deps): bump passport from 0.5.2 to 0.6.0 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29126, 2022

      • chinmay
        The "Slider with marks, included=false" example is something we need
      • 2022-10-18 29101, 2022

      • monkey
        yep
      • 2022-10-18 29130, 2022

      • chinmay
        it doesn't snap to the marks though
      • 2022-10-18 29111, 2022

      • zas
        a volume costs €0.044/GB/month (100GB = 4.4€/month), current VM costs 16€/month, the lowest price for a dedicated server with 512Gb is ~37€, so we can stay on VM if we had <400gb volume. The question is: do we really need more disk space, or sentry needs to be tuned and/or we need disk cleanup routines to be added
      • 2022-10-18 29125, 2022

      • zas
        bitmap: is the freed disk space enough to recover?
      • 2022-10-18 29151, 2022

      • bitmap
        zas: yes but sentry-cleanup didn't really help
      • 2022-10-18 29112, 2022

      • zas
        let me see, I suspect docker
      • 2022-10-18 29158, 2022

      • zas
        hmmm, nope, only 335mb freed on docker system prune
      • 2022-10-18 29118, 2022

      • bitmap
        the sentry-kafka volume is taking up 62G, double the postgres volume (29G)
      • 2022-10-18 29142, 2022

      • zas
        yes; that's the main disk space user
      • 2022-10-18 29138, 2022

      • zas
      • 2022-10-18 29152, 2022

      • zas
        is there any restriction in place?
      • 2022-10-18 29139, 2022

      • bitmap
      • 2022-10-18 29151, 2022

      • zas
        perhaps time to add something like (as per thread posted above) https://www.irccloud.com/pastebin/X2y57Ath/
      • 2022-10-18 29125, 2022

      • zas
        but I don't know anything about this stuff, so just a suggestion
      • 2022-10-18 29149, 2022

      • zas
        I would prefer to avoid adding an extra volume if that's just disk space used by logs
      • 2022-10-18 29158, 2022

      • alastairp
        zas: bitmap: hmm, I've not seen sentry use too much space on the other instance I run, that's interesting
      • 2022-10-18 29126, 2022

      • bitmap
        I'll try the suggested environment variables
      • 2022-10-18 29130, 2022

      • alastairp
        and it's even strange that the database is so large, because it should prune to only last 15 days of events too. I wonder if it's doing that
      • 2022-10-18 29147, 2022

      • bitmap
        I ran sentry cleanup with 90 days interval and it deleted a ton of stuff (though it didn't help the disk usage)
      • 2022-10-18 29118, 2022

      • bitmap
        restarted the services after adding those kafka settings in .env and now 12GB is free at least
      • 2022-10-18 29120, 2022

      • bitmap
        though the kafka and postgres volumes are the same size as before so it must have come from elsewhere
      • 2022-10-18 29113, 2022

      • outsidecontext
        mayhem: I forwarded you a notification that we need to renew the Picard code signing certificate we use for the Windows builds. I think Apple subscription renewing is also something that might come up soon, but I don't now the date right now. Have to check.
      • 2022-10-18 29146, 2022

      • mayhem
        ahhhh, zas and I have been trying to figure out what this email was for. we thought it was phishing.
      • 2022-10-18 29111, 2022

      • mayhem
        I'll take a look later
      • 2022-10-18 29112, 2022

      • tykling
        hah :)
      • 2022-10-18 29101, 2022

      • mayhem
        but seriously, which SSL company sends out HTTP links? (not HTTPS) FFS!
      • 2022-10-18 29108, 2022

      • outsidecontext
        nope, that was the code signing on ssl.com. I just had logged in (their UI is horrible). But I think only the main account holder can renew (that's rob AT mb)
      • 2022-10-18 29111, 2022

      • zas
        huh? how does it relate to Picard code signing certificate? this is totally unobvious from the email
      • 2022-10-18 29127, 2022

      • outsidecontext
        yes, that I also wondered
      • 2022-10-18 29134, 2022

      • mayhem
        seriously unobvious.
      • 2022-10-18 29106, 2022

      • outsidecontext
        just log in, everything in their UI is unobvious
      • 2022-10-18 29122, 2022

      • zas
        yes, email from ssl.com, but with http links to a subdomain hosted somewhere in Asia... I was thinking about hacked DNS and phishing attempt
      • 2022-10-18 29136, 2022

      • outsidecontext
        took me 15 minutes to actually find the certificate details there
      • 2022-10-18 29149, 2022

      • outsidecontext
        zas: who knows. maybe still phishing and they just send mails to certficate owners whose cetificates are about to expire ^^
      • 2022-10-18 29113, 2022

      • outsidecontext
        nah, but the real thing in any way is that this certificate is about to expire in not quite a month
      • 2022-10-18 29123, 2022

      • mayhem
        so confused by this UI
      • 2022-10-18 29100, 2022

      • mayhem
        I paid, now we wait. I think.
      • 2022-10-18 29105, 2022

      • outsidecontext
        I think it's somewhere under orders
      • 2022-10-18 29110, 2022

      • outsidecontext
        oh, yes. let's see
      • 2022-10-18 29135, 2022

      • zas
        well, it seems to be legit then... and they use bulk email company to send those, that is known as relaying a lot of spam and phishing emails (and currently on some blacklists)...
      • 2022-10-18 29116, 2022

      • outsidecontext
        🙄
      • 2022-10-18 29126, 2022

      • zas is paranoid, normal people would have follow links without asking questions
      • 2022-10-18 29103, 2022

      • mayhem
        yep, I'm dealing with same shit now. sending invoice reminders since ours never arrive.
      • 2022-10-18 29110, 2022

      • mayhem
        fuck paypal, fuck quickbooks.
      • 2022-10-18 29156, 2022

      • alastairp
        bitmap: did you add these to .env or docker-compose.yaml?
      • 2022-10-18 29137, 2022

      • bitmap
        alastairp: I temporarily added them to .env. should they go in the compose file instead?
      • 2022-10-18 29154, 2022

      • alastairp
        yes, .env doesn't get exposed to the services
      • 2022-10-18 29102, 2022

      • alastairp
        I see that the compose file has some but not all of the settings
      • 2022-10-18 29106, 2022

      • alastairp
        I'll move them and restart
      • 2022-10-18 29110, 2022

      • bitmap
        thanks
      • 2022-10-18 29133, 2022

      • bitmap
        .env is for building the images then?
      • 2022-10-18 29129, 2022

      • alastairp
        not really. in docker-compose, env allows you to do substitutions in the docker-compose file itself
      • 2022-10-18 29132, 2022

      • alastairp
      • 2022-10-18 29145, 2022

      • lucifer
      • 2022-10-18 29117, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2702 (03master…RequireCleanNamespace): Use Perl::Critic::Moose::RequireCleanNamespace https://github.com/metabrainz/musicbrainz-server/…
      • 2022-10-18 29123, 2022

      • lucifer
        the test code is ~200 lines and the code being tested is ~135 lines. lol
      • 2022-10-18 29109, 2022

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #66 (03main…spotify-submit): Add spotify submission support https://github.com/metabrainz/troi-recommendation…
      • 2022-10-18 29133, 2022

      • bitmap
        alastairp: oh, I see. I was blindly following https://forum.sentry.io/t/sentry-disk-cleanup-kaf… which said they edited their .env file
      • 2022-10-18 29139, 2022

      • alastairp
        ah, right. it's possible that back in 2020 onpremise used `env_file` in docker-compose.yml to load `.env` as the environment
      • 2022-10-18 29140, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo closed pull request #889 (03critiquebrainz-integration…cb-star-rating-fixes): fix: CritiqueBrainz star rating issues https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29154, 2022

      • alastairp
        or maybe they had a different configuration
      • 2022-10-18 29103, 2022

      • alastairp
        it's just starting back up, let's see what happens
      • 2022-10-18 29125, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo opened pull request #892 (03master…critiquebrainz-integration): Critiquebrainz integration https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29158, 2022

      • mayhem
        lucifer: thanks!
      • 2022-10-18 29155, 2022

      • alastairp
        bitmap: re: the postgres tables it looks like this is https://github.com/getsentry/self-hosted/issues/7…
      • 2022-10-18 29116, 2022

      • alastairp
        seems to indicate that sentry cleanup should fix it, but also requires a vacuum to actually free the space
      • 2022-10-18 29134, 2022

      • bitmap
        yeah, I had to do a vacuum full in the past and it helped, but required a bit of downtime
      • 2022-10-18 29142, 2022

      • alastairp
        yes, right. and I'm not sure if the 9gb free is even enough to rewrite the table
      • 2022-10-18 29137, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2703 (03master…fix-test-errors-and-warnings): Don't use no longer existing merge.tt https://github.com/metabrainz/musicbrainz-server/…
      • 2022-10-18 29156, 2022

      • alastairp
        nginx proxy container log file is 3gb
      • 2022-10-18 29139, 2022

      • alastairp
        although we have the daemon.json with log-opts set
      • 2022-10-18 29141, 2022

      • alastairp
        `ps` and `ls` output shows that it's possible that docker wasn't restarted after daemon.json was written, I'm going to restart it now
      • 2022-10-18 29156, 2022

      • alastairp
        18gb sql dump in /root too ;)
      • 2022-10-18 29103, 2022

      • Maxr1998_ joined the channel
      • 2022-10-18 29113, 2022

      • Maxr1998 has quit
      • 2022-10-18 29104, 2022

      • CatQuest
        Guys! we have obtained a splendid boom within all of India and Pakistan!
      • 2022-10-18 29114, 2022

      • yvanzo
        bitmap: I looked into Data::CoreEntity and found that it is about GID and name rather than relationships; At first sight, does it seem fine to split into two roles? Or do we want to name that? https://github.com/metabrainz/musicbrainz-server/…
      • 2022-10-18 29117, 2022

      • CatQuest
        (sorry, jsut some gogle transalte slliness)
      • 2022-10-18 29146, 2022

      • CatQuest
        (but if any indians know about harmoniums, NOW is the time to speak up)
      • 2022-10-18 29156, 2022

      • yvanzo
        bitmap: It seems more and more likely that "core = relatable" might date from React migration rather than from NGS migration.
      • 2022-10-18 29124, 2022

      • reosarevok
        bitmap: from https://metacpan.org/pod/Perl::Critic::Policy::Co… - do you know if " strict is also enabled automatically with a use declaration of perl version 5.12 or higher" also means that since we require 5.30 all our files are use strict by default and indicating that is redundant, or whether that really only applies if you specifically write "use 5.12"?
      • 2022-10-18 29128, 2022

      • alastairp
        bitmap: zas: I cleaned some unneeded files and did a vacuum on the large postgres table, up to 45gb free now. the kafka flags don't seem to have helped, but I'll have another look at it. if the "sentry cleanup" command isn't already being run periodicly then we should probably do that too, I'll see the best way to run it
      • 2022-10-18 29148, 2022

      • alastairp
        I guess that frequent "sentry cleanup" + autovacuum should keep postgres under control
      • 2022-10-18 29131, 2022

      • alastairp
        although, already 2gb used since I last did a df. are we really getting so many messages that it's using up so much space?
      • 2022-10-18 29143, 2022

      • agatzk has quit
      • 2022-10-18 29155, 2022

      • agatzk joined the channel
      • 2022-10-18 29111, 2022

      • BrainzGit
        [metabrainz.org] 14mayhem opened pull request #393 (03master…send-invoice-reminders): Send invoice reminders https://github.com/metabrainz/metabrainz.org/pull…
      • 2022-10-18 29158, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo opened pull request #893 (03master…new-creation-form): feat[BB-484]: Unified creation form https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29117, 2022

      • atj_mb
        reosarevok: "use v5.xx" enables strict https://www.irccloud.com/pastebin/I812DMgn/
      • 2022-10-18 29100, 2022

      • reosarevok
        atj_mb: huh, annoying.
      • 2022-10-18 29101, 2022

      • reosarevok
        Thanks
      • 2022-10-18 29159, 2022

      • mayhem
        ok, that pesky task is done. but at least automating this shit is going to make it easier for me to stay on top of all of this.
      • 2022-10-18 29148, 2022

      • lucifer
        one more enhancement could be to avoid logging in to the admin portal to add the token. if it could be retrieved via oauth, then this process be run on a quarterly basis cron job that'd be nice as well.
      • 2022-10-18 29128, 2022

      • mayhem
        yeah, not sure I am comfortable with putting something like this on cron.
      • 2022-10-18 29144, 2022

      • mayhem
        there is a lot of quickbooks stuff that needs to happen before the script can run.
      • 2022-10-18 29104, 2022

      • lucifer
        i see. makes sense.
      • 2022-10-18 29129, 2022

      • mayhem
        and getting rid of paypal will make it this whole process easier too -- payments via stripe correctly record the paid invoice number. makes everything super easy.
      • 2022-10-18 29154, 2022

      • mayhem
        later on, we'll only use our paypal account for receiving existing recurring donations and the libera donations. nothing else.
      • 2022-10-18 29120, 2022

      • lucifer
        nice, sounds good.
      • 2022-10-18 29145, 2022

      • mayhem
        yes, it will be really good to get rid of paypal. its been needing doing for too long.
      • 2022-10-18 29126, 2022

      • mayhem
        lucifer: reviewing TROI#71... resave playlist isn't really clear what the PR does.
      • 2022-10-18 29159, 2022

      • mayhem
        I mean, yes, resaving a playlist is possible with this, but I guess in the grander scheme it is load from LB save to spotify. that's more like a copy function.
      • 2022-10-18 29140, 2022

      • mayhem
        but the way we have the bits in place, we should literally call the Element LoadListenBrainzPlaylist
      • 2022-10-18 29116, 2022

      • mayhem
        no, that isn't correct either.
      • 2022-10-18 29102, 2022

      • mayhem
        TransferPlaylistPatch ?
      • 2022-10-18 29120, 2022

      • lucifer
        yes, makes sense. the patch itself only retrieves a LB playlist. its generate playlist that does uploading stuff.
      • 2022-10-18 29138, 2022

      • lucifer
        transfer sounds good. maybe even IdentityPlaylistPatch?
      • 2022-10-18 29102, 2022

      • mayhem
        too hoitytoity, I think. (how do you spell that)?
      • 2022-10-18 29115, 2022

      • mayhem
        let's go with transfer.
      • 2022-10-18 29127, 2022

      • lucifer
        lol. yes sounds good.
      • 2022-10-18 29114, 2022

      • BrainzGit
        [metabrainz.org] 14mayhem merged pull request #393 (03master…send-invoice-reminders): Send invoice reminders https://github.com/metabrainz/metabrainz.org/pull…
      • 2022-10-18 29116, 2022

      • monkey
        mayhem: hoity-toity
      • 2022-10-18 29105, 2022

      • agatzk has quit
      • 2022-10-18 29118, 2022

      • alastairp
        lucifer: hi,
      • 2022-10-18 29123, 2022

      • lucifer
        hi!
      • 2022-10-18 29138, 2022

      • alastairp
        I'm just looking at sentry. still lots of rmq exceptions in LB even after your changes?
      • 2022-10-18 29111, 2022

      • lucifer
        yes, because most of the exceptions come from API container which is still on pika.
      • 2022-10-18 29116, 2022

      • alastairp
        got it
      • 2022-10-18 29156, 2022

      • alastairp
        can I delete the current events? (assuming that they'll make a new version when the error happens again)
      • 2022-10-18 29116, 2022

      • lucifer
        yes sounds good
      • 2022-10-18 29117, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #892 (03master…critiquebrainz-integration): feat[BB-613]: Critiquebrainz integration https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29131, 2022

      • alastairp
        bitmap: https://medium.com/@sunny_81705/kafka-log-retenti… was a good explanation of how the kafka log cleanup works
      • 2022-10-18 29155, 2022

      • alastairp
        I wonder if the BYTES option wasn't actually working because we alrady have the 24 hours option set
      • 2022-10-18 29107, 2022

      • alastairp
        we are at ~60gb and the setting you copied was ~50gb. Maybe the usage was actually "below" this setting, I'm trying to set it lower, to 20-30gb to see if that does anything, but perhaps 24h keeps us at a consistent disk usage already. I'll monitor usage for a while longer
      • 2022-10-18 29143, 2022

      • bitmap
        yvanzo: I don't think it was ever clearly defined anywhere but the 'relatable' usage predates the react migration. it just so happened that anything with an MBID was also relatable in the initial NGS schema
      • 2022-10-18 29134, 2022

      • yvanzo
        bitmap: there is nothing about relationships in Perl CoreEntity packages
      • 2022-10-18 29159, 2022

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #71 (03main…playlist-from-lb): Add element to load a playlist from LB https://github.com/metabrainz/troi-recommendation…
      • 2022-10-18 29124, 2022

      • yvanzo
        I’m alright with using "relatable" instead of "core" and keep the current usage of "core" in public documentation about data
      • 2022-10-18 29128, 2022

      • yvanzo
        I understand that Perl CoreEntity was making sense at NGS time, but it currently doesn't make more sense than RickRollEntity.
      • 2022-10-18 29142, 2022

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #893 (03master…new-creation-form): feat[BB-484]: Unified creation form https://github.com/metabrainz/bookbrainz-site/pul…
      • 2022-10-18 29128, 2022

      • bitmap
        yvanzo: i know i'm just talking about how the term is used. I can dig up some development chat logs from 2009-2011 if you're curious
      • 2022-10-18 29135, 2022

      • bitmap
        alastairp: thanks, that was informative!
      • 2022-10-18 29121, 2022

      • bitmap
        I think you may be right about the BYTES option