#metabrainz

/

      • lucifer
        re mbdata supported versions, we can probably drop py3.6 support but i guess makes sense to ask luks once first
      • alastairp
        yes, of course
      • mmm
      • maybe some space for improvement here 🤣
      • lucifer
        ah right! now that i remember that's why we probably wanted to unite dump utils in BU.
      • alastairp
        ah, I see
      • I wasn't considering CB when I saw that PR I think
      • yeah, I'm not sure. 90% of our dumps are uniform, but it's that last 10% which makes a generic helper difficult to work with
      • lucifer
        indeed
      • alastairp
        lucifer: got some bugs running init_db, looking into it
      • sqlalchemy.exc.InvalidRequestError: This transaction is inactive
      • lucifer
        ah yes. makes sense. i think `connection.connection.set_isolation_level(0)` was enough but could be wrong.
      • alastairp
        yeah, init_db and the create extension works fine after this change
      • import works fine too
      • oh wait. I tested only the import without the warning env variables
      • so of course it worked
      • every single test has failed at the init step, oops
      • lucifer: fixed with an updated commit: https://github.com/metabrainz/critiquebrainz/pu...
      • but I'm a bit confused as to what actually failed for me, because we run init_db in the tests. but I saw an error running init_db locally on my machine
      • adhawkins has quit
      • adhawkins joined the channel
      • adhawkins has quit
      • BrainzGit
        [critiquebrainz] 14alastair merged pull request #469 (03master…sqlalchemy-warnings): Upgrade SQLAlchemy and enable 2.0 warnings https://github.com/metabrainz/critiquebrainz/pu...
      • [critiquebrainz] release 03v-2022-10-25.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/critiquebrainz/re...
      • adhawkins joined the channel
      • lucifer
        alastairp: ah cool, 👍
      • alastairp
        lucifer: urg, continuing failing builds: https://github.com/metabrainz/critiquebrainz/ac...
      • just after I said that the caching wasn't causing problems...
      • lucifer
        alastairp: that's a docker hub issue. i am currently getting it while trying to push a lb image locally as well
      • alastairp
        ah, wasn't sure if it was docker or github
      • lucifer: did you see python 3.11 out? with some interesting speedups
      • lucifer
        yup saw a blog post about it earlier today. on average 20% faster iirc. we can probably migrate as soon as numpy etc support it
      • alastairp
        well. no CB release today, sorry :(
      • rdswift_ joined the channel
      • dseomn has quit
      • dseomn joined the channel
      • rdswift has quit
      • rdswift_ is now known as rdswift
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #2217 (03master…tsconfig-exclude-dist): tsconfig: exclude `**/dist` directory https://github.com/metabrainz/listenbrainz-serv...
      • s1b1 has quit
      • loujine has quit
      • kgz has quit
      • rcombs has quit
      • everdred has quit
      • loujine joined the channel
      • everdred joined the channel
      • s1b1 joined the channel
      • rcombs joined the channel
      • akshaaatt
        Hi Indian peeps, we have moved our meeting from Saturday to tomorrow at CP in Delhi
      • ansh: riksucks , it that interests you
      • monkey
        lucifer: I added a commit to your multi-stage-build-branch, supporting relative paths in webpack config so I can use it outside of docker. Small change so I don't expect any difference from what the PR changes.
      • Everything seems to be working great on my side for the whole PR. Wanna give it a spin?
      • alastairp
        monkey: that's great!
      • kgz joined the channel
      • lucifer
        monkey: changes lgtm.
      • monkey
        Added a comment about paths as well, I think my brain isn't working well enough for this :p
      • lucifer
        i wondered the same and had tried copying at same path but then realized it would copy over node modules as well. easiest way was to keep copying to a separate place.
      • mayhem, alastairp, reosarevok: i ran the script for daily jams manually for users who hadn't got the daily jam today to test the fixes. i checked manually and see dails jams in your and jukevox's accounts
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2221 (03master…update-troi): Update troi to v-2022-10-25 https://github.com/metabrainz/listenbrainz-serv...
      • v6lur joined the channel
      • aerozol
        Mōrena! Doing my daily message catch-up :D
      • BrainzGit
        [listenbrainz-server] release 03v-2022-10-25.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • alastairp
        thanks lucifer
      • aerozol
        monkey: ooh the circles look really good!! Will they finally melt the circle-haters heart?
      • v6lur has quit
      • BrainzGit
        [sir] 14amCap1712 opened pull request #144 (03master…perf-reg): Fix Sir Performance Regression https://github.com/metabrainz/sir/pull/144
      • v6lur joined the channel
      • alastairp
        !!!
      • !m lucifer
      • BrainzBot
        You're doing good work, lucifer!
      • lucifer
        hehe, still need to do more timing testing. it ran fast enough on wolf and i manually checked the sql queries and this produces less queries.
      • aerozol
        Glad people are digging into the signup UX. I've hit my hours for this week, but itching to get those LB mockups started
      • lucifer
        however, best to test on an isolated vm so that the numbers are comparable.
      • aerozol
        akshaaatt: I can't see the 3d cover :(
      • akshaaatt
        Yeah aerozol, I broke my code while converting the library to typescript
      • I was hoping no one would notice…😂
      • aerozol
        Haha that's all good I was just having a sneaky peek at your message to monkey anyway
      • Re. signup woes I think when we have centralized oauth we will have to have a way of redirecting users back to where they can't from anyway. Bit cheeky to just assume everyone wants to go back to mb?
      • I liked @elomatreb[m]s suggestion of having them input the email but not needing to confirm it to start using LB. I don't know if we would ever need them to confirm it? Maybe if we start having issues? I wonder what other modern sites do
      • rdswift
        alastairp, reosarevok, et al: I know I'm a bit late to the user account structure discussion (I'm blaming that on my timezone), but I've put together a brief discussion of the way I've set it up for the sports pools sites that I manage.
      • Each of the pools was originally on a separate site, with a separate database. Last year, I combined the databases and sites so that someone participating in more than one pool only had to have a single account for logging in and managing their information for all of the pools.
      • I'm not for a moment suggesting that you need to use this structure, but perhaps it might prompt some ideas when the time comes to combine the various *Brainz accounts.
      • alastairp
        rdswift: thanks! Definitely not too late to add ideas to the list, and nice to see how other people do similar things too
      • rdswift
        Some of the benefits include:
      • * Allows different display name for each pool/site;
      • * Allows multiple email addresses associated with an account, with one designated as Primary
      • * Allows each email to subscribe to different notifications
      • alastairp
        lucifer: was the issue slow queries or too many queries?
      • lucifer
        alastairp: more queries and not too many actually just 1-2 more queries per artist.
      • note that the code currently produces 10-12 queries per artist which is the same as the existing prod.
      • alastairp
        sure, but that multiplies out
      • interesting, is this something you've tried to optimise?
      • lucifer
        not yet, i am not sure why defer_everything_but and load_only are broken.
      • and the code is too much abstract imo. i think we should just write down all the loads explicitly just as we do in BU.
      • aerozol
        mayhem: are you putting off reading the blog post! Hopefully it's not too boring
      • lucifer
        it will be a bit repititive but no "magic" in code.
      • aerozol
        Freso: thanks, I have asked for admin access on Li 🙏
      • monkey
        Hello aerozol ! Yes I think the circles have gotten Good Enough™ to be of use
      • aerozol
        They look perfect tbh
      • lucifer
        anyways, my hunch is that those lists of fields here are incomplete https://github.com/metabrainz/sir/blob/63aa1cb0...
      • once we confirm the regression is fixed and we should probably move to py3 first and then look further into improving rest of stuff. newer sqlalchemy versions have `raisedload` feature which will give an exception with stack trace when we access a lazily loaded property. which is probably what we want.
      • monkey
        The interactive part is what sells it. It'll be fun to have on LB.
      • A friend suggested making it into a sort of banner at the top of a user's profile (sort of like they have in facebook etc.), but unfortunately the charting library doesn't take advantage of the extra horizontal space, so not great for that. Perhaps we'll find a good home for it
      • alastairp
        lucifer: yes, right. Lots of small steps to make, as with all projects
      • monkey glares at the small steps
      • lucifer
        indeed
      • alastairp
        but I agree, get it to same level as it currently is, and py3 would be great
      • monkey
        "but I want my cake NOW!"
      • alastairp
        I agree that individual custom queries per entity may be better
      • lucifer
        there's also the rmq library issues, moving to kombu will probably stablise sir.
      • alastairp
        neat. I've tried to stay away from that side of things
      • leave it to the new rmq expert
      • lucifer
        hehe lol
      • alastairp
      • lucifer
        🤣
      • monkey
        !m rdswift and thanks for the breakdown
      • BrainzBot
        You're doing good work, rdswift and thanks for the breakdown!
      • rdswift
        Just trying to get the collective creative juices flowing... ;-)
      • chinmay
        Can someone tell me what am I doing wrong here? https://github.com/chinmaykunkikar/listenbrainz...
      • (cc monkey lucifer)
      • monkey
        A bit more context please :)
      • What's the issue?
      • chinmay
      • monkey: ^ I cant get tests to work
      • monkey
        Hm. Any more stacktrace to help pinpoint the issue?
      • Nothing obvious, might be an issue with the slider library for example
      • lucifer
        chinmay: try copying over the imports for the test file from another file that already works.
      • i vaguely remember yuzie facing the same issue and it was a react import issue that time
      • chinmay
        monkey: that's all the error it spits
      • monkey
        Ooooohhh, that might be it indeed
      • `import * as React from "react";` instead of `import React from "react";`
      • chinmay
        lucifer: I did copy imports from other files. Playlist.test.tsx
      • monkey: let me try
      • monkey
        I also see import * as React from "react"; in the Playlist test file
      • (and not import React…)
      • chinmay
        I never noticed the react import line :p
      • monkey
        Eagle-eyed lucifer over there…
      • Sniping your bugs.
      • chinmay
        hehe
      • lucifer
        createElement gave it away hehe lol
      • monkey
        I've had a similar issue with a library that wasn't liking the server environment without some browser-specific things
      • Different issue altogether, similar stacktrace
      • chinmay
        IT WORKED! I got another error though, but it worked!
      • and I was sulking about it for 24 hours :/
      • monkey
        The appropriate time spent bashing one's head on the keyboard before asking around, in my experience, is less than 2 hours :)