[musicbrainz-server] 14mwiencek opened pull request #2739 (03master…fix-type-constraint-genre-error): Add another missing Types module import for Genre https://github.com/metabrainz/musicbrainz-server/…
2022-11-17 32104, 2022
wargreen has quit
2022-11-17 32141, 2022
wargreen joined the channel
2022-11-17 32129, 2022
matterharz joined the channel
2022-11-17 32158, 2022
matterharz has left the channel
2022-11-17 32131, 2022
chancey joined the channel
2022-11-17 32135, 2022
chancey has quit
2022-11-17 32135, 2022
chancey joined the channel
2022-11-17 32118, 2022
chancey has quit
2022-11-17 32135, 2022
daKu18 joined the channel
2022-11-17 32143, 2022
kaine2 has quit
2022-11-17 32103, 2022
daKu18 has quit
2022-11-17 32107, 2022
kaine2 joined the channel
2022-11-17 32108, 2022
chancey joined the channel
2022-11-17 32130, 2022
chancey has quit
2022-11-17 32120, 2022
chancey joined the channel
2022-11-17 32125, 2022
chancey has quit
2022-11-17 32123, 2022
BrainzGit
[musicbrainz-server] 14reosarevok merged pull request #2739 (03master…fix-type-constraint-genre-error): Add another missing Types module import for Genre https://github.com/metabrainz/musicbrainz-server/…
2022-11-17 32113, 2022
reosarevok
yvanzo: I'd love to get https://github.com/metabrainz/musicbrainz-server/… finished and merged, since it's a minor change *and* a definite improvement. If you don't have time to do the same for Data::Editable, I'd happily merge this and send a second PR myself (or send a commit to yours, but I'm not sure I can push to your repo :) )
reosarevok: I can try it with some of their other contact addresses. I had written to their metadata services, because it seemed fitting
2022-11-17 32123, 2022
reosarevok
And also, I merged bitmap's hopeful selenium fix into master, so yvanzo, you should be able to rebase on master to see whether other errors appear now :)
reosarevok: Refactoring Perl code should be below our lowest priorities, I’d love to get your help with everything else, e.g. SEC-123, see the draft PR. Investigating the 5xx from this night right now. Will get back to PRs after that.
Well, I'm mostly working on that at the moment because I have a ton of React PRs open and I don't want to keep adding more of those until we review and merge some :)
2022-11-17 32148, 2022
yvanzo
So you are opening a ton of Perl PRs instead.
2022-11-17 32153, 2022
reosarevok
Yes, those are a lot easier to review and merge whenever we have time :)
2022-11-17 32111, 2022
reosarevok
And reviewing stuff as often as I can, too
2022-11-17 32128, 2022
yvanzo
If you are out of inspiration, just ask, there are a tons of things that can be done without conflicting with current changes.
2022-11-17 32106, 2022
reosarevok
I'm not out of inspiration, I just care about improving old code
2022-11-17 32112, 2022
reosarevok
What help do you want with the SEC one? Should I be researching the CI errors or?
2022-11-17 32130, 2022
yvanzo
There is a blocking Ecmascript error.
2022-11-17 32147, 2022
yvanzo
I copied the log in the last commit.
2022-11-17 32148, 2022
reosarevok
(and don't worry, my plan with those Perl ones is to merge your stuff, then adapt my stuff accordingly)
2022-11-17 32103, 2022
reosarevok
(not make you deal with all the conflicts)
2022-11-17 32135, 2022
reosarevok
FWIW, I tried to use Moose with properly on controllers and it broke, so we're doing shit wrong somewhere, I'll figure that out eventually :)
2022-11-17 32102, 2022
reosarevok
Ok, I'll take a look at those errors, see what I can figure out
reosarevok: However I don’t understand the first warning (maybe it is usual, I didn't check), I tried several alternative export/import notations unsuccessfully.
2022-11-17 32103, 2022
reosarevok
This one?
2022-11-17 32104, 2022
reosarevok
export 'DEVELOPMENT_SERVER' (imported as 'DEVELOPMENT_SERVER') was not found in './common/DBDefs-client.mjs' (possible exports: default)
lucifer: I truncated the similarity.recording table and am requesting piles of new data, but with higher thresholds, so each set should be considerably smaller.
2022-11-17 32110, 2022
lucifer
👍
2022-11-17 32126, 2022
mayhem
and as I was trying to brainstorm how to move forward with similarities and artist radio, my brain delivered a Picard AutoTag feature that might making tagging MUCH faster and acoustic fingerprints... useless. thanks brain. not what I needed.
lucifer: any idea why the prefetch_count thing works?
2022-11-17 32140, 2022
lucifer
mayhem: it ensures that only a fixed numbers of messages are sent to ts writer at time. without prefetch count, rmq/kombu will try to send as many as possible. when it was failing, this was as large as 10k at a time.
2022-11-17 32127, 2022
lucifer
why it silently crashes at 10k messages is not known though because logs were empty. probably a bug in kombu i'd assume.
We should probably filter ones that have front but also other attributes?
2022-11-17 32102, 2022
monkey
Or prefer only front
2022-11-17 32123, 2022
monkey
No, I don't think it's an issue in MB, the attribute is correct as it does show the front.
2022-11-17 32126, 2022
lucifer
hmm i see but MB website does show the correct cover.
2022-11-17 32148, 2022
lucifer
maybe an issue in the query I copied from CAA.
2022-11-17 32151, 2022
monkey
However my code for fetching the image from CAA json response probably doesn't do more than "get an image with 'front' attribute"
2022-11-17 32127, 2022
lucifer
iiuc, this mbid should have been resolved by the backend. frontend would be getting a caa id.
2022-11-17 32134, 2022
monkey
mayhem: This is displayed in the Listening Now standalone deb, yes?
2022-11-17 32144, 2022
monkey
Ah, odd
2022-11-17 32145, 2022
monkey
Well, maybe the same mistake I thought I had in the JS code exists in the python code, i.e. "get the first 'front' image" rather than get the first image with only 'front' attribute
