#metabrainz

aerosol: Hey I picked the LB-1170 ticket and is working on it

LB-1170: Options missing from listen/recording drop-downs https://tickets.metabrainz.org/browse/LB-1170

Hahaha aerozol this is fine!

I was able to identify the problem as some conditionals were returning false in getListenCard and i tried deactivating those conditionals and directly pushing the options

and It worked

I just need some clarity about other options like where which options should come

So about the options on the listencard, there are some that we should definitely have on all cards (recommendations and pin options) and some we can only show in certain conditions (open in spotify/musicbrainz, for which we need a spotify ID and MusicBrainz ID respectively).

should I attach screenshots in JIRA

For the recommendation options it might depend on whether we have an MBID or and MSID available, not sure if any of the API endpoints still work with MSID.. calling dr. Lucifer

No need for screenshots jivte_ if you open a PR I'll be able to check it at some point

Actually if I remove the MSID or MBID conditions It was working

But there's no guarantee that the feature would actually work, apart from showing the option in the dropdown. In theory the conditionals are there for a reason

That being said some of our features have evolved over time and some checks might not be necessary anymore.

Thats what I discovered if only we remove the conditionals our issue also gest resolved and feature was also working

One thing to check is which information the API endpoint requires (in the dev docs) and compare to the implementation in the APIService.ts file

OK, then perhaps that's all that was needed! Check the "recent" page for an example of a page where we don't usually have an MBID available.

Other than that i'd be hapy to review a pr if you open one. Thanks for working on this!

monkey: I just need to learn about MSID and MBID part where I can learn about there

Is it in the documentation

Bcz these MSID and MBID are creating all the problems

For the most part you should be able to ignore MSIDs, we are moving away from using them.

MBID

that also should we ignore

You'll see that some endpoints talk about recorgind_msid, others of recording_mbid: https://listenbrainz.readthedocs.io/en/producti...

Both are unique identifiers

Some docs on MBID: https://musicbrainz.org/doc/MusicBrainz_Identifier

okk thanks

👍

They are the way we refer to a recording, which is the base of all our endpoints. if you like a track in ListenBrainz, or recommend it, or review it, etc. that uses a unique identifier

An esay way to see if a listen has a recording MBID is if the track title is a link to musicbrainz. If it'l not a link, we don't have an MBID for that listen at that moment, which also most likely means we can't use the recommend, write a review, open in MusicBrainz, and maybe other features

(since they rely on an MBID)

Perhaps the options could be grayed out and unclickable when not available, rather than not having them in the dropdown? That could be less disturbing for users.

Now I got the clarity will make a PR soon

thanks for helping out

Thank you for digging in !

aerozol: Actually, I think a little speech bubble popping out with a "This if fine." would be *chef's kiss*

+1 to the use of memes for extra shareability

Thanks jivte__ !

monkey: cool I'll see what I can do

aerozol: awesome art!

jivte: i see monkey answered your questions already. in case you have any other doubts, feel free to ask us again

chinmay: your blog post lgtm. published. https://blog.metabrainz.org/2022/11/16/fresh-re...

!m chinmay

You're doing good work, chinmay!

aerozol: BWAHAHA il ove that idea too

aerozol: did you seriously SERIOUSLY spend 3 hours drawing that.

FAB

i think witouht the speech bubble is best. more subtle, and more international

lucifer: thank you so much!

lucifer: Everything is working fine but in my local development server It is taking to long to compile javascript code

It also gives a error on the UI everytime I refresh recent listens page

Is there anything I could do to solve this error

jivte__: what's the error?

I am getting this errot

error*

moin moin!

\ö/

this is really good news. :) 30 days, less so. lets make sure everyone hits the button so they make the process faster.

I really love this https://usercontent.irccloud-cdn.com/file/Q5ZDM...

colour choices and everything

awesome. :)

!m aerozol

You're doing good work, aerozol!

but one thing, we should aim to be the gyys that alway can do these things, ie"not become a n ultracorp"

<3

> Per poder fer el check-in sense entretenir-los tant,

el check-in, huh?

al check-in

.. why is it bad to entertain people tho

we can put on the yim "original firedog idea KC " in smal letter right?

CatQuest: it's the sense "take too much of your time"

oooh

kc green

mayhem: payment received 💯

🎉

well done chinmay!

yay! no hassles, it just appeared in your account?

Yeah!

(well done mayhem for making that happen too!)

:)

Thanks alastairp :)

perhaps lucifer should change banks. :)

what a great year of projects this year

Lol

Love you, MetaBrainz ❤️

now what we need is to find a volunteer who will constantly watch the fresh releases and import missing cover art.

jivte__: thanks for the report, this is actually an issue with our development environment when a new developer needs to do something that involves MBIDs and MSIDs. This is definitely something that we need to fix so that new developers can set up listenbrainz and work with it

alastairp: anything I could do to solve it

jivte__: yes, I think you should be able to create the database table but with no data in it, so the operation should run but just return no data

however I believe we don't have an automated way to do this.

jivte__: how familiar are you with postgresql and the psql query console?

I know sql databases but not much as I mainly work with mongoDB.

But I will try to solve this error

mayhem: lucifer: https://github.com/metabrainz/listenbrainz-serv...

I wonder if this metadata blueprint should have a local dev version which passes through to labs-api instead of doing a local db lookup

jivte__: are you working on a react or python part of listenbrainz?

I started contributing recently and working on the react part

ok, no problem :) I think there is a quick fix that I can make here which will prevent this issue from happening for you

jivte__: in a new terminal, can you run `./develop.sh timescale`

you should get a prompt that looks like this:

listenbrainz_ts=>

okk

now paste the following, pressing return after each of the 2 commands

you can exit from this by typing \q [return]

okk thanks

after that, try and load the page again. I think that you might get a different error now

same error

:)

hm, interesting. exactly the same error? (psycopg2.errors.UndefinedTable: relation "mapping.canonical_musicbrainz_data" does not exist)

jivte__: alastairp: try changing api url to api.listenbrainz.org in local config

lucifer: oh right, I forgot that we had that setting

I think api should be localhost?

for different pages, it needs different settings

jivte__: that's this configuration: https://github.com/metabrainz/listenbrainz-serv...

in your 'config.py' file

if you set it to api.listenbrainz.org then the react frontend should request this data from the main listenbrainz server instead of requesting it from your server

okk okk

after setting I should run the magic script again right

sorry, which magic script is that?

./develop.sh up

ah yes, right. stop the original one that you ran, and run it again

alastairp: thank you so much IT is gone finally :)

[musicbrainz-server] 14reosarevok opened pull request #2756 (03master…MBS-12725): MBS-12725: Add "Refine this search" link on Votes by [user] page https://github.com/metabrainz/musicbrainz-serve...

Oh, thankfully, no more IT. Time to retire :D

mayhem: perhaps *we* should change banks, tbh :p If there's any normal, modern banks in the US, anyway

reosarevok: thanks for MBS#2746 :)

MBS-12716: Output the right JSON-LD @context: https://github.com/metabrainz/musicbrainz-serve...

alastairp: you're welcome, feel free to ask for as many easy changes as you want :D

I need to teach people to write their own tickets instead of sending me private messages

Not necessarily a bad idea either, but :)