#metabrainz

/

      • Etua joined the channel
      • Etua has quit
      • vibhoo_24 joined the channel
      • vibhoo_24 has quit
      • jasje joined the channel
      • serialata has quit
      • jivte joined the channel
      • vibhoo_24 joined the channel
      • aerozol
        Who has wiki admin access? Let’s finally update that favicon
      • zas?
      • Etua joined the channel
      • Etua has quit
      • davidovski joined the channel
      • Maxr1998_ joined the channel
      • Maxr1998 has quit
      • antlarr2 is now known as antlarr
      • yvanzo
        akshaaatt: It is probably fine to use the current sentry instance for mobile apps if needed.
      • bitmap, mayhem, zas: Is it fine ^ to use MeB Sentry instance for mobile apps? I have admin privileges so I can probably follow these steps: invite akshaaatt to a #mobile team and create a project for the app.
      • strider has quit
      • strider joined the channel
      • jasje has quit
      • vibhoo_24 has quit
      • vibhoo_24 joined the channel
      • vibhoo_24 has quit
      • jivte has quit
      • jasje joined the channel
      • adhawkins
        Anyone help with how to fix the track artist on track 5 or https://musicbrainz.org/release/e2d4719c-34d2-4...
      • Looks like the wrong recording is associated with that track, as it's listed as a cover recording, when this is the original album.
      • yvanzo
        adhawkins: wrong channel :) but you should reach https://musicbrainz.org/user/IvanDobsky about this recording as he added the “cover” attribute yesterday.
      • adhawkins
        Whoops, sorry. Meant to post it in #musicbrainz. Sorry yvanzo
      • yvanzo
        No worry :)
      • alastairp
        yvanzo: seems fine by me to use MeB sentry for mobile apps, especially in terms of sending user information to MeB controlled servers instead of 3rd party ones
      • vibhoo_24 joined the channel
      • yvanzo
        Thanks alastairp, I should have pinged you too as you wrote the Sentry admin doc :)
      • akshaaatt: sent invitation
      • akshaaatt
        Thanks a lot yvanzo!
      • vibhoo_24 has quit
      • yvanzo
        alastairp: please approve the invitation if you can, I don’t have enough privileges for that.
      • alastairp looks
      • alastairp: Also maybe invite him as Admin rather than Member.
      • Thank you!
      • alastairp
        done.
      • yvanzo: would you like to be a manager or owner too?
      • akshaaatt: let us know if you have any problems creating a project. I guess sentry knows all of the correct things to set up when making a mobile one
      • yvanzo
        alastairp: I rarely use it. But shouldn’t previous team members be removed now?
      • mayhem
        yvanzo: I dont see why not...
      • yvanzo
        mayhem: I didn’t set up Sentry, just asking.
      • alastairp
        yvanzo: what a great task to do during doc-week :)
      • yvanzo
        It’s not really a doc thing.
      • alastairp
        it's not, but it's "organisation health" related I guess
      • yvanzo
        alastairp: actually, wasn't there a doc with steps when on/off-boarding team members?
      • alastairp
        yvanzo: there is!
      • one thing about sentry is that it's not team-only. e.g. I added ansh when he was working on CB in order to see bug reports
      • lucifer
        mayhem, alastairp: i was thinking to improve accuracy of listens we could dump deleted listesn and remove those from spark.
      • *accuracy of stats reports
      • alastairp
        lucifer: is that because when listens are deleted we don't remove them from spark?
      • how do you know what a deleted listen is if it's deleted?
      • lucifer
        Yes
      • mayhem
        not until the next dump, which might not be for 15 days.
      • yvanzo
        alastairp: Do they still need it? Do they have a contract with MeB to access users’ data.
      • mayhem
        remind me are, IP addresses listed in sentry? if so, it must contract-holders only. :(
      • vibhoo_24 joined the channel
      • yvanzo
        mayhem: yes
      • alastairp
        yes, that's a good point. user ip's are in sentry, so it should be contractors only
      • mayhem
        ok, lets get rid of non-contractor accounts and in the future not add them.
      • alastairp
        I believe there is a way to get sentry to anonymise IPs, but I don't know if you can do that on a per-user basis
      • however in the meantime, I'll remove other users
      • done
      • mayhem
        thx
      • jasje_ joined the channel
      • yvanzo
        alastairp: Thanks
      • Sentry is already mentioned in ContractorOnboarding.md and it only mentions removing Admin flag.
      • mayhem
        here is our coordination doc this week:
      • alastairp
        that should definitely be updated until we can identify if we can block IPs from particular users
      • yvanzo
        But it doesn’t seem possible to restrict access to PII based on role: https://docs.sentry.io/product/accounts/members...
      • mayhem
        hmm. I dont quite see how to share the document so that Meb contractors can edit, everyone else comment.
      • yvanzo
        alastairp: Related backlogged issue: https://github.com/getsentry/sentry/issues/26300
      • alastairp
      • but it seems that you can only do this globally on an entire project. We could look and see if it's actually necessary for us to capture this information
      • mayhem
        ok, explicitly listed the team now. let me know if there are problems with the doc.
      • alastairp
        however it might be easier to just ensure that sentry-jira connection is properly working, and we can raise tickets in jira for other devs
      • alastairp looks at the doc
      • mayhem
        please jump in and clean up from last year -- I just copied last year's doc as a starting point for this year.
      • yvanzo
        Right, I don’t think that IP addresses are useful to musicbrainz-server since we have these in server logs already, but editor names are.
      • alastairp
        lucifer: I think we did a pretty good job on combining LB docs into user/dev/sysadmin last year, right?
      • Thuraabtech joined the channel
      • Thuraabtech
        monkey can you help me out to install bookbrainz locally
      • it will really help me as i am trying to figure out why i am getting this error after reading the documentation
      • reosarevok
        bitmap: I dropped the seemingly unneeded JS bits of MBS-8668 now but I also noticed the error message it used to show when the rels were already dupes is also gone, maybe we can look into that at some point. Just to make sure that all the errors we *do* expect for rels do still appear.
      • BrainzBot
        MBS-8668: Adding duplicate entities to a series is still allowed https://tickets.metabrainz.org/browse/MBS-8668
      • alastairp
        yvanzo: the planning doc has the sysadmin/onboarding doc item from last year. From your reading of the onboarding doc just now do you think there is anything that could be added?
      • mayhem
        zas: IP unblock request in mail for ya
      • Thuraabtech has quit
      • yvanzo
        alastairp: I just updated it about Sentry account removal; It looks fine otherwise.
      • reosarevok
        yvanzo: updated the MB section a bit, but I'm sure there's more stuff to add there :)
      • Thuraabtech joined the channel
      • zas
        mayhem: handled
      • mayhem
        thx!
      • alastairp
        thanks yvanzo
      • lucifer: monkey: do I remember you talking in the last few weeks about the API documentation system that is used in BB and how it might be applied to LB?
      • jasje_ has quit
      • vibhoo_24 has quit
      • vibhoo_24 joined the channel
      • reosarevok
        bitmap: we changed this, right?
      • IIRC we always need to get import $c now?
      • monkey
        alastairp: indeed. lucifer asked for the swagger config files in BB
      • Hi Thuraabtech, what error are you hitting?
      • Thuraabtech
         > [bookbrainz-webservice 1/10] COPY ./docker//rc.local /etc/rc.local:
      •  > [bookbrainz-webservice 4/10] COPY ./docker//webserver.command /etc/service/webserver/exec-command:
      • monkey
        Try a pastebin or something similar, it will be easier to paste the whole output
      • Thuraabtech
        i got this error when i used docker buildx build --platform=linux/amd64 -t getting-started . --network="host"
      • okay
      • Thuraabtech has quit
      • vibhoo_24 has quit
      • Thuraabtech joined the channel
      • when i tried running the container locally with this command
      • docker run -d -p 9200:9200 docker.elastic.co/elasticsearch/elasticsearch:5.6.8
      • i got a warinig
      • WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
      • 014a1f04e6130a687512ebb96354cae26125a7e6da12b7e37bc4421254c95654
      • i'm actually using mac m1 chip so that's why i think i am getting this warning
      • monkey
        Sorry Thuraabtech I've never seen this issue, not sure I can help you much other than googling the error message :/
      • Thuraabtech
        i searched it on stack over flow and it recommended me to use this command: docker buildx build --platform=linux/amd64 -t myorg/mytag:1.0.0 .
      • [+] Building 2.8s (27/31)
      • monkey
        Anyone else here seen this type of docker issue before?
      • mayhem
        no, but I would guess that it is m1 related as Thuraabtech suspects
      • alastairp
        where are the BB build/run docs?
      • monkey
      • alastairp
        yes! thanks
      • Thuraabtech: which command were you running when you got your initial error?
      • Thuraabtech
        initially i got warning when i was trying to run bookbrainz locally
      • docker run -d -p 9200:9200 docker.elastic.co/elasticsearch/elasticsearch:5.6.8
      • i used the following above command to run it locally
      • alastairp
        Thuraabtech: I don't see that command in the installation docs: https://bookbrainz-dev-docs.readthedocs.io/en/l...
      • were you following a different guide?
      • Thuraabtech
        actually i am new to docker so i don't know how to run it locally , so i used google for the help
      • alastairp
        it looks like on apple silicon you need to include the `--platform=linux/amd64` flag in any command that you execute
      • I see that you tried this with the build step above
      • so in the case of the run command, you would need something like "docker run --platform=linux/amd64 -d -p 9200:9200 docker.elastic.co/elasticsearch/elasticsearch:5.6.8"
      • however, this is perhaps something that we can improve in the bookbrainz documentation and tools
      • monkey
        Perhaps something that would need to be added to the docker-compose file?
      • yvanzo
        akshaaatt: You should have received an email from Sentry, I created a #mobile team and a project for each app.
      • alastairp
        monkey: I think it might be time that we do something about bb's develop.sh (to allow people to add this flag)
      • I'm not sure if the `--platform` flag has a docker-compose equivalent
      • monkey
        It does, just checked
      • (starting with compose v2)
      • alastairp
      • yeah, that kind of indicated the same
      • yeah, that might be a good solution then