put the "2023-01-18T14:28:13+05:30" representation in the tooltip
2023-01-19 01949, 2023
lucifer
yes, the tooltip does show that
2023-01-19 01956, 2023
alastairp
mmm, of course - I see the reason to use the offset value in the "standard" case of daylight savings
2023-01-19 01911, 2023
alastairp
because it'd be nice for it to show 4pm when I was actually listening to it at 4pm, not 3 or 5
2023-01-19 01943, 2023
lucifer
monkey: hi! have you used luxon before?
2023-01-19 01958, 2023
alastairp
I don't want to sound like I'm saying "stop everything and throw it away", though I can see how this might sound like that
2023-01-19 01912, 2023
alastairp
but I wonder if we should stop, make a ticket, and list all of these cases
2023-01-19 01916, 2023
alastairp
and get aerozol's feedback
2023-01-19 01936, 2023
alastairp
and work out what we want to show in each of these cases
2023-01-19 01910, 2023
alastairp
I can think of a few cases off the top of my head: 1) daylight savings, 2) someone gets on a plane and goes somewhere else in a different tz
2023-01-19 01910, 2023
reosarevok
Sounds sensible to me
2023-01-19 01930, 2023
alastairp
after thinking through it, I think you're right in the way that you've shown the data in your screenshot
2023-01-19 01948, 2023
reosarevok
My alternative proposal: use browser time for display on the list, show submitted time + timezone on hover or with some see more option
2023-01-19 01954, 2023
lucifer
ii agree but i don't think we'll figure out the cases until we do put it for testing or regular use.
2023-01-19 01903, 2023
alastairp
it's just that this is a very uncommon situation to be in. normally you're going to submit all in one tz, and then there'll be a switch and it'll all be in the other timezone
2023-01-19 01919, 2023
alastairp
reosarevok: right, I initially thought that (and that's basically what we do now), but that breaks daylight savings
2023-01-19 01950, 2023
alastairp
as in the summer, all of the things you listened to in the winter will be an hour out (ok, it's a small thing, but this idea of introducing the timezone was our way of preventing this from happening)
2023-01-19 01956, 2023
lucifer
reosarevok: i think if the datetime iso string include the correct dst offset then dst would be observed fine.
2023-01-19 01903, 2023
lucifer
uh that was for alastairp ^
2023-01-19 01923, 2023
alastairp
I'm wondering if we could have a little "/!\ the tz in this listen doesn't really match where you are, but we're showing it as submitted" popup
2023-01-19 01926, 2023
lucifer
because my hunch is that tz-data accounts for this.
2023-01-19 01916, 2023
alastairp
lucifer: yes right, I think we're both agreeing on the same thing
2023-01-19 01951, 2023
lucifer
ah ok, makes sense.
2023-01-19 01924, 2023
lucifer
there's also this thing of how we show 3 hours ago, 4 hours ago thingy.
2023-01-19 01903, 2023
alastairp
(and this is kind of why I'm asking for a ticket - for me I find it much easier to look at a list of our decisions instead of always trying to remember what we decided in the last discussion)
2023-01-19 01909, 2023
lucifer
like aerozol listens a track at 11 PM NZ time, when i look at his page, should it show as 6 hours from now or 1 hour ago?
2023-01-19 01940, 2023
alastairp
1 hour ago
2023-01-19 01921, 2023
lucifer
makes sense, will have to account for that in tz handling.
2023-01-19 01921, 2023
reosarevok
alastairp: how is your playing going? Any luck with inc?
i'll open a draft PR for now because except test/docs its mostly done.
2023-01-19 01948, 2023
alastairp
> The Schema Object allows the definition of input and output data types. These types can be objects, but also primitives and arrays. This object is an extended subset of the JSON Schema Specification Wright Draft 00.
reosarevok: it seems that "you can only include x if y is set" is going to include a twisty maze of anyOf/allOf
2023-01-19 01949, 2023
reosarevok
I think so, yes
2023-01-19 01928, 2023
alastairp
but is that strictly necessary? e.g.
2023-01-19 01929, 2023
alastairp
> If you request work-level-rels for a recording, you will still need to request work-rels (to get the relationship from the recording to the work in the first place) and any other relationship types you want to see
2023-01-19 01933, 2023
alastairp
(from the wiki)
2023-01-19 01948, 2023
alastairp
would could just add this as a description to the specification on /release
2023-01-19 01904, 2023
alastairp
at least initially
2023-01-19 01936, 2023
reosarevok
I guess
2023-01-19 01921, 2023
reosarevok
We will return a bad request in that case, with the error
2023-01-19 01935, 2023
reosarevok
$i is not a valid option for the inc parameter for the $resource resource unless you specify one of the following other inc parameters: $params
2023-01-19 01947, 2023
reosarevok
But I guess if it's documented maybe it's fine as a start
2023-01-19 01945, 2023
alastairp
and the inline "try it out" does nicely show these error messages
reosarevok: ^ paste that into editor.swagger.io if you want
2023-01-19 01932, 2023
reosarevok
Ok, I could play with that while you SOLR
2023-01-19 01929, 2023
jivte joined the channel
2023-01-19 01956, 2023
alastairp
hi yvanzo, can we talk starting in ~20 minutes? Or after lunch (approx 2pm CET) if that's better
2023-01-19 01959, 2023
jivte
monkey: Hey for that throttle change it is not for promises and searchUsers is a promise based utility so should I use throttle-promise library or something else can un please help in it. :)
2023-01-19 01944, 2023
yvanzo
alastairp: as you prefer :)
2023-01-19 01922, 2023
alastairp
yvanzo: after lunch, in 1h45m would be much better for me, thanks
2023-01-19 01939, 2023
reosarevok
Ah, good old Spanish lunch
2023-01-19 01951, 2023
yvanzo
👍 🧑🍳
2023-01-19 01951, 2023
reosarevok comes back from his 10 min lunch
2023-01-19 01911, 2023
alastairp
reosarevok: we have people in the lab who don't eat with us at 1:30, because that's too early for them
2023-01-19 01929, 2023
reosarevok
I meant more the "lunch taking over an hour" bit :D
2023-01-19 01944, 2023
alastairp
hey, I didn't say that I'm going to lunch now!
2023-01-19 01952, 2023
reosarevok
But yeah, my family ate fairly consistently at 3 PM actually
2023-01-19 01904, 2023
yvanzo
right, you started a few hours ago?
2023-01-19 01913, 2023
reosarevok
Maaaaybe 2:30 if we were in a hurry
2023-01-19 01916, 2023
vibhoo_24 has quit
2023-01-19 01922, 2023
alastairp
🙄
2023-01-19 01953, 2023
jivte has quit
2023-01-19 01911, 2023
reosarevok
alastairp: lol, so I guess *technically* we can make it so Swagger is happy with splitting browse and search by having /artist: and /artist/:
2023-01-19 01916, 2023
reosarevok
🙄 indeed
2023-01-19 01953, 2023
reosarevok
Not sure if that'd even work though when trying to use try it out
2023-01-19 01925, 2023
reosarevok
Getting really tempted to add an alias mbid/search?query :p
> Basically, you can have two definitions to the same path by adding a slash (/) in the URL.
2023-01-19 01949, 2023
alastairp
:D
2023-01-19 01937, 2023
mayhem
I have to say, writing docs is pretty rewarding when that is the only goal for the week.
2023-01-19 01919, 2023
alastairp
This also means that it is impossible to have multiple paths that differ only in query string, such as: [what we want to do]
2023-01-19 01928, 2023
alastairp
This is because OpenAPI considers a unique operation as a combination of a path and the HTTP method, and additional parameters do not make the operation unique. Instead, you should use unique paths such as: [what reosarevok wants to do]
But better to document it semi-properly even if it's a bit hacky now, then improve on it
2023-01-19 01931, 2023
reosarevok
So if //artist or whatever works, then I'll try it out
2023-01-19 01935, 2023
alastairp
tbh, generating 2 sections with an extra / or ? is probably a great temporary solution with a small note
2023-01-19 01949, 2023
alastairp
as long as MBS supports the auto-generated URLs
2023-01-19 01900, 2023
reosarevok
Yeah
2023-01-19 01908, 2023
reosarevok
I'll go for a walk to leave the house before it's dark
2023-01-19 01916, 2023
reosarevok
Then come back and play with that idea
2023-01-19 01937, 2023
reosarevok
(and maybe comment on whether I can follow your SOLR docs at all :p )
2023-01-19 01918, 2023
jasje_ has quit
2023-01-19 01943, 2023
monkey
lucifer: I saw your message yesterday and wondered "WTF is a Luxon", so that should answer your question :D
2023-01-19 01943, 2023
monkey
Gotta say, luxon looks nice to handle timezone stuff
2023-01-19 01906, 2023
monkey
Also I like the sass in their DST docs:
2023-01-19 01910, 2023
monkey
>Because our ancestors were morons, they opted for a system wherein many governments shift around the local time twice a year for no good reason. And it's not like they do it in a neat, coordinated fashion. No, they do it whimsically, varying the shifts' timing from country to country (or region to region!) and from year to year. And of course, they do it the opposite way south of the Equator. This is all a tremendous waste of
2023-01-19 01910, 2023
monkey
everyone's energy and, er, time, but it is how the world works and a date and time library has to deal with it.
yvanzo: when you get a timeout, I see this error message on solr
2023-01-19 01934, 2023
alastairp
The request took too long to iterate over terms. Timeout: timeoutAt: 11426689695006838 (System.nanoTime(): 11426689945661048), TermsEnum=org.apache.lucene.codecs.blocktree.SegmentTermsEnum@2d9515ef
