aerozol: The new mockup is good but It seems that the cross button twice looks bad like for user search as well as listen details
2023-01-24 02404, 2023
jivte
There is no such need
2023-01-24 02434, 2023
aerozol
Jivte: one is the search bar right? It's not intuitive to use that to clear a selection below
2023-01-24 02455, 2023
aerozol
If anything I would take it off the search bar
2023-01-24 02426, 2023
jivte
then why not we after search the track we make the search bar empty
2023-01-24 02448, 2023
jivte
and to clear the details we can keep that button
2023-01-24 02458, 2023
jivte
then no need of cross in search
2023-01-24 02448, 2023
aerozol
Yeah, as long as we keep the cross button next to the album information? At least, that's where I would expect it. Maybe monkey has a second opinion
2023-01-24 02408, 2023
alastairp
Pratha-Fish: hi, that's an interesting question about IRC. I think it's hard to find a balance here because people who know about IRC clearly understand that there are different networks and then each network has channels
2023-01-24 02426, 2023
jivte
yeah will talk when he is around
2023-01-24 02437, 2023
jivte
anyways great mockup aerozol
2023-01-24 02450, 2023
jivte
better than mine
2023-01-24 02452, 2023
jivte
xDD
2023-01-24 02409, 2023
aerozol
jivte: stretch goal for sure, but I was wondering if we do it that way we could queue up multiple tracks/albums under the search? E.g. with a box for each, that can be removed
2023-01-24 02430, 2023
aerozol
It's yours with some changes! Always easy to fix things up after
2023-01-24 02455, 2023
Pratha-Fish
alastairp: true that. And it looks like the new ones really just look up #metabrainz on the default matrix server and enter the wrong channel haha
2023-01-24 02427, 2023
jivte
the thing is for a single track we are showing cover-art
2023-01-24 02450, 2023
jivte
like in add album we will be showing them as a select-deselect feature
but yeah aerozol for single track too we can add multiple tracks interesting add on
2023-01-24 02445, 2023
jivte
thanks
2023-01-24 02401, 2023
alastairp
but you're right, I completely understand the possible confusion if someone just tells you "connect to #metabrainz on matrix IRC bridge"
2023-01-24 02402, 2023
monkey
Personally I think for the album add feature we should keep it simple with a single album. Might make the modal a bit messy otherwise.
2023-01-24 02415, 2023
monkey
(For a limited benefit, I guess)
2023-01-24 02420, 2023
aerozol
I think single album for now for sure. Even for tracks
2023-01-24 02443, 2023
jivte
monkey: clarity is neededed
2023-01-24 02401, 2023
jivte
for add track option (single track or multiple)
2023-01-24 02411, 2023
aerozol
Did you see my mockup monkey edit monkey? With that look I think it would be possible to do multiple if wanted later
2023-01-24 02414, 2023
monkey
I don't think automatically clearing the search field is a much used UX in the wild, I would advise against it
2023-01-24 02436, 2023
monkey
Personally don't see too much of a problem with the double cross
2023-01-24 02440, 2023
aerozol
imo ignore everything I said about multiple tracks/albums for now jivte ;)
2023-01-24 02405, 2023
jivte
yeah I and monkey think single track/album is fine
2023-01-24 02435, 2023
monkey
Did see the mockup, still not super convinced about the idea of multi album, again mainly out of concern of simplicity both in look and in code
2023-01-24 02440, 2023
monkey
But maybe I'm obverse cautious
2023-01-24 02444, 2023
monkey
Over*
2023-01-24 02446, 2023
aerozol
Monkey: I don't know if I understand, our other searches don't have crosses on them?
2023-01-24 02409, 2023
aerozol
After someone's selected something from the results we could also just leave the text in there and they can backspace it
2023-01-24 02412, 2023
monkey
Search input? The one in the playlist page sure does
2023-01-24 02419, 2023
jivte
aerozol: I have a ides
2023-01-24 02422, 2023
jivte
idea
2023-01-24 02429, 2023
monkey
For adding a track to the playlist
2023-01-24 02431, 2023
aerozol
Ah I was trying to find where it was, I only checked the user search at the top and the 'personally recommend' search
2023-01-24 02446, 2023
jivte
to not put the cross on search
2023-01-24 02454, 2023
aerozol
'personally recommend' clears the search after a user has been clicked
2023-01-24 02402, 2023
jivte
as it will make the UX and overall feature messy
2023-01-24 02412, 2023
monkey
I think both would benefit to be more like the playlist one, based on the react-select library. Better accessibility etc
2023-01-24 02430, 2023
Pratha-Fish
alastairp: exactly :)
2023-01-24 02430, 2023
Pratha-Fish
and conveniently, element.io's network selection drop down box is placed super oddly, so most people don't even see it. But I hope the updated documentation solves it.
2023-01-24 02430, 2023
Pratha-Fish
P.S. I've also added some features of the brainzbot that weren't covered before in the docs, put the channel details in a convenient table, added some more explanation about the asynchronous nature of IRC and why it doesn't store chats when you disconnect, etc.
2023-01-24 02436, 2023
aerozol
Ugh I can't check on my phone. I wonder if it's a phone bug re. the personally suggest feature
2023-01-24 02449, 2023
monkey tries
2023-01-24 02406, 2023
jivte
monkey: both are fine but need some clearance on what both cross button does
2023-01-24 02422, 2023
aerozol
If there's an accessibility benefit to keeping the last selection in the search bo until cleared I'm all good with that.
2023-01-24 02434, 2023
monkey
Hmm aerozol mine didn't work at first but it was because phone auto-capitalizes which returned no result
2023-01-24 02434, 2023
aerozol
(just checked how it works on the playlist page)
2023-01-24 02439, 2023
monkey
Something to improve there
2023-01-24 02404, 2023
aerozol
Ah that was it!
2023-01-24 02433, 2023
jasje_ joined the channel
2023-01-24 02416, 2023
aerozol
Yeah, I would be fine with mirroring the behavior in personally recommend (selection goes into the people box, which can then be cleared, last typed stays in the search bar) which works well for me. But if it's not best practice then let's do the other way :D
2023-01-24 02450, 2023
monkey
One other way we could solve this issue is keeping the cross in the search input, removing it from the album, and adding a "clear" button in the footer of the modal that will both remove the search words and the selected album
2023-01-24 02452, 2023
aerozol
I'm heading to bed, hopefully you guys can sort out the 'close buttons' questions without too much trouble zzzzz
2023-01-24 02431, 2023
jivte
monkey: so what is final how many buttons we need
2023-01-24 02433, 2023
jivte
xd
2023-01-24 02438, 2023
aerozol
To me I would look for the close button in the box with the album/track selection. That's all I'm sayin' ;)
2023-01-24 02453, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #921 (03master…dependabot/npm_and_yarn/cookiejar-2.1.4): chore(deps): bump cookiejar from 2.1.3 to 2.1.4 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-24 02412, 2023
monkey
What about a garbage can icon instead in the album?
2023-01-24 02419, 2023
monkey
To differentiate them
2023-01-24 02424, 2023
jasje_
alastairp: While you guys are at fixing, i wanted to mention an issue where when we scroll upwards in https://chatlogs.metabrainz.org/libera/metabrainz/ (chatlogs), there seems to a bug where i come back to the start or some other scroll position that is always before my target scroll position or offset
2023-01-24 02437, 2023
alastairp
jasje_: yeah, this has been a problem forever :(
2023-01-24 02451, 2023
jasje_
This happens on mobile and pc both
2023-01-24 02457, 2023
Etua joined the channel
2023-01-24 02457, 2023
jasje_
really annoying
2023-01-24 02401, 2023
aerozol
That's inconsistent with how we do it in 'personally recommend'. That cross already looks different to the one used to clear the text from the playlist search bar though
2023-01-24 02409, 2023
aerozol
So that's two different icons
2023-01-24 02410, 2023
alastairp
unfortunately the chatlogs software isn't supported any more. we need to make a decision if we keep maintaining it and fixing bugs (which is annoying because it's not our software),
2023-01-24 02413, 2023
monkey
Fair enough
2023-01-24 02418, 2023
jasje_
oh if its known then good
2023-01-24 02424, 2023
alastairp
or if instead we rewrite it into a much simpler page
2023-01-24 02436, 2023
alastairp
well, it's known but theres no time or resources to fix it, which isn't good :)
2023-01-24 02445, 2023
alastairp
jasje_: unless you'd like to try and fix it??
2023-01-24 02455, 2023
aerozol
Bed time for real real!!
2023-01-24 02402, 2023
monkey
jivte: I'd say put both cross icons as in the mockup, until we have consensus on a way we all think is an improvement over that
2023-01-24 02408, 2023
monkey
Nn aerozol
2023-01-24 02422, 2023
jasje_
alastairp: i have the mobile dept no website :P
2023-01-24 02450, 2023
jivte
monkey: okk understood so now this is new UI
2023-01-24 02454, 2023
jivte
RIGHT?
2023-01-24 02431, 2023
jasje_
alastairp: if you want there could be a mobile application
2023-01-24 02443, 2023
alastairp
jasje_: for what? the chatlogs?
2023-01-24 02454, 2023
jasje_
but that wont be so helpful on the pc part
2023-01-24 02456, 2023
alastairp
I don't think that's very useful, not many people would use it
