yvanzo: I'd love your feedback on that PR (not the code itself which is pretty trivial, but the question at the end of the PR message)
2023-02-08 03912, 2023
jivte joined the channel
2023-02-08 03912, 2023
jasje joined the channel
2023-02-08 03918, 2023
jasje
hi akshaaatt
2023-02-08 03950, 2023
akshaaatt
I looked at your additions to the doc. LGTM!
2023-02-08 03917, 2023
jasje
Thanks
2023-02-08 03920, 2023
akshaaatt
Let’s link relevant UI screens for the functionalities for 2023 roadmap
2023-02-08 03928, 2023
akshaaatt
Figma links should work
2023-02-08 03931, 2023
jasje
Recommend me some topics and ill write em too
2023-02-08 03906, 2023
jasje
Yea we could do that
2023-02-08 03922, 2023
akshaaatt
Rishav showed an interest on working on the profile page
2023-02-08 03939, 2023
jasje
ill add figma link to the issues ticket
2023-02-08 03947, 2023
jasje
great!
2023-02-08 03950, 2023
akshaaatt
He has dm’ed me on irc but I am unable to reply to him because his irc nick doesn’t exist anymore
2023-02-08 03913, 2023
jasje
tell him to message/ ping here
2023-02-08 03918, 2023
jasje
ill get in on the stuff
2023-02-08 03927, 2023
akshaaatt
yellowhatpro: showed interest in the addition of remote players to BP
2023-02-08 03948, 2023
jasje
(i hope rishav reads this convo)
2023-02-08 03907, 2023
jasje
yellowhatpro seems kinda busy
2023-02-08 03914, 2023
akshaaatt
Yeah
2023-02-08 03922, 2023
jasje
internship clg stuff ig
2023-02-08 03938, 2023
akshaaatt
Would you like to take up the searching functionality for now jasje after the tests are done?
2023-02-08 03949, 2023
akshaaatt
Post that we could work on follow
2023-02-08 03900, 2023
jivte has quit
2023-02-08 03906, 2023
jasje
search for bp or profile?
2023-02-08 03915, 2023
akshaaatt
Search for profile
2023-02-08 03917, 2023
jivte joined the channel
2023-02-08 03928, 2023
jasje
look heres my point of view
2023-02-08 03956, 2023
jasje
the feed and profile will have alot of common api calls
2023-02-08 03913, 2023
jasje
and also
2023-02-08 03933, 2023
jasje
you want search on profile page?
2023-02-08 03929, 2023
akshaaatt
Let’s talk about search only for now
2023-02-08 03934, 2023
jasje
better to have it on feed because that is where people might find it more useful
2023-02-08 03944, 2023
akshaaatt
Search could be jn the dashboard for now
2023-02-08 03948, 2023
akshaaatt
In*
2023-02-08 03905, 2023
jasje
i was looking to eliminate the dashboard xDD
2023-02-08 03911, 2023
akshaaatt
I mean a button for it
2023-02-08 03922, 2023
akshaaatt
Which opens up the search page like we did in the MB app
2023-02-08 03936, 2023
akshaaatt
Feed should be different from search
2023-02-08 03940, 2023
jasje
yupp
2023-02-08 03951, 2023
akshaaatt
Or I am also fine with the search button in the bottom nav
2023-02-08 03905, 2023
jasje
see'
2023-02-08 03920, 2023
jasje
the functionality of our search will be limited to just users
2023-02-08 03935, 2023
akshaaatt
Obviously we’ll eliminate the dashboard soon jasje.
2023-02-08 03954, 2023
akshaaatt
Yes jasje but below the search, we could throw song recommendations
2023-02-08 03911, 2023
akshaaatt
I’m thinking like an insta search UI
2023-02-08 03918, 2023
jasje
me too xD
2023-02-08 03922, 2023
akshaaatt
Yus
2023-02-08 03945, 2023
akshaaatt
Beautiful album covers below the search bar
2023-02-08 03950, 2023
akshaaatt
In a grid
2023-02-08 03954, 2023
jasje
so lets have search functionality different from profile
2023-02-08 03904, 2023
akshaaatt
Yes it is different
2023-02-08 03934, 2023
akshaaatt
Feed, Player, Search, Explore, Profile
2023-02-08 03941, 2023
akshaaatt
I think these should be our bottom nava
2023-02-08 03944, 2023
akshaaatt
Navs*
2023-02-08 03917, 2023
jasje
akshaaatt: prolly better if we get figma setup
2023-02-08 03942, 2023
jasje
but before we begin all this ill be needing to refactor alot of code
2023-02-08 03950, 2023
jasje
moving sharedPrefs and all
2023-02-08 03901, 2023
akshaaatt
Sure that sounds good to me jasje
2023-02-08 03920, 2023
jasje
Heres what ill do
2023-02-08 03928, 2023
akshaaatt
Let’s not miss out on features though jasje , just a reminder
2023-02-08 03945, 2023
akshaaatt
At the end of the end, people want features. And we want people using the app :)
2023-02-08 03948, 2023
jasje
create repos for different shared prefs
2023-02-08 03907, 2023
akshaaatt
What do you mean by different shared prefs?
2023-02-08 03909, 2023
jasje
akshaaatt: dont worry its the good part
2023-02-08 03915, 2023
jasje
i want bad part out of the way
2023-02-08 03924, 2023
jasje
sharedPreferences
2023-02-08 03946, 2023
akshaaatt
I treat shared Prefs as local storage for us
2023-02-08 03955, 2023
akshaaatt
Why have different local storages?
2023-02-08 03912, 2023
jasje
no no
2023-02-08 03927, 2023
jasje
ill just be calling the shared prefs as it is
2023-02-08 03940, 2023
jasje
but through repositories
2023-02-08 03957, 2023
jasje
this makes mocking easy + no context issues
2023-02-08 03910, 2023
akshaaatt
I would like to see an example before we agree on this
2023-02-08 03911, 2023
jasje
future of testing ++
2023-02-08 03917, 2023
akshaaatt
Sounds good though
2023-02-08 03945, 2023
jasje
i would only after you review the tests pr, it has all the test setup
2023-02-08 03906, 2023
akshaaatt
Right. On my target for tonight
2023-02-08 03912, 2023
jasje
cant progress without those changes
2023-02-08 03918, 2023
jasje
and about the benchmarking pr
2023-02-08 03932, 2023
jasje
wanna have it?
2023-02-08 03940, 2023
jasje
im having second thoughts
2023-02-08 03950, 2023
akshaaatt
I think we’ll be rushing by getting it in
2023-02-08 03958, 2023
jasje
yeah
2023-02-08 03904, 2023
jasje
ill just draft it
2023-02-08 03924, 2023
jasje
its not that useful as was expecting it to be
2023-02-08 03930, 2023
jasje
as i was*
2023-02-08 03934, 2023
jivte has quit
2023-02-08 03939, 2023
akshaaatt
Right
2023-02-08 03951, 2023
akshaaatt
Btw, we should use chatgpt to write test cases for us
2023-02-08 03911, 2023
akshaaatt
I am able to just copy paste it the code and it will write test cases for the entire code
2023-02-08 03939, 2023
jasje
not so sure about that
2023-02-08 03954, 2023
jasje
ill have a look at it
2023-02-08 03933, 2023
akshaaatt
I am sure about the results from an iOS perspective. It is actually accurate. Sometimes it makes a few mistakes but atleast gets the boilerplate code ready for us!
2023-02-08 03944, 2023
akshaaatt
Definitely should be added to the list
2023-02-08 03949, 2023
jivte joined the channel
2023-02-08 03915, 2023
akshaaatt
I don’t want us to send too many efforts for testing if chatgpt already exists and can take care of most of the work
