yvanzo: I'd love your feedback on that PR (not the code itself which is pretty trivial, but the question at the end of the PR message)
jivte joined the channel
jasje joined the channel
jasje
hi akshaaatt
akshaaatt
I looked at your additions to the doc. LGTM!
jasje
Thanks
akshaaatt
Let’s link relevant UI screens for the functionalities for 2023 roadmap
Figma links should work
jasje
Recommend me some topics and ill write em too
Yea we could do that
akshaaatt
Rishav showed an interest on working on the profile page
jasje
ill add figma link to the issues ticket
great!
akshaaatt
He has dm’ed me on irc but I am unable to reply to him because his irc nick doesn’t exist anymore
jasje
tell him to message/ ping here
ill get in on the stuff
akshaaatt
yellowhatpro: showed interest in the addition of remote players to BP
jasje
(i hope rishav reads this convo)
yellowhatpro seems kinda busy
akshaaatt
Yeah
jasje
internship clg stuff ig
akshaaatt
Would you like to take up the searching functionality for now jasje after the tests are done?
Post that we could work on follow
jivte has quit
jasje
search for bp or profile?
akshaaatt
Search for profile
jivte joined the channel
jasje
look heres my point of view
the feed and profile will have alot of common api calls
and also
you want search on profile page?
akshaaatt
Let’s talk about search only for now
jasje
better to have it on feed because that is where people might find it more useful
akshaaatt
Search could be jn the dashboard for now
In*
jasje
i was looking to eliminate the dashboard xDD
akshaaatt
I mean a button for it
Which opens up the search page like we did in the MB app
Feed should be different from search
jasje
yupp
akshaaatt
Or I am also fine with the search button in the bottom nav
jasje
see'
the functionality of our search will be limited to just users
akshaaatt
Obviously we’ll eliminate the dashboard soon jasje.
Yes jasje but below the search, we could throw song recommendations
I’m thinking like an insta search UI
jasje
me too xD
akshaaatt
Yus
Beautiful album covers below the search bar
In a grid
jasje
so lets have search functionality different from profile
akshaaatt
Yes it is different
Feed, Player, Search, Explore, Profile
I think these should be our bottom nava
Navs*
jasje
akshaaatt: prolly better if we get figma setup
but before we begin all this ill be needing to refactor alot of code
moving sharedPrefs and all
akshaaatt
Sure that sounds good to me jasje
jasje
Heres what ill do
akshaaatt
Let’s not miss out on features though jasje , just a reminder
At the end of the end, people want features. And we want people using the app :)
jasje
create repos for different shared prefs
akshaaatt
What do you mean by different shared prefs?
jasje
akshaaatt: dont worry its the good part
i want bad part out of the way
sharedPreferences
akshaaatt
I treat shared Prefs as local storage for us
Why have different local storages?
jasje
no no
ill just be calling the shared prefs as it is
but through repositories
this makes mocking easy + no context issues
akshaaatt
I would like to see an example before we agree on this
jasje
future of testing ++
akshaaatt
Sounds good though
jasje
i would only after you review the tests pr, it has all the test setup
akshaaatt
Right. On my target for tonight
jasje
cant progress without those changes
and about the benchmarking pr
wanna have it?
im having second thoughts
akshaaatt
I think we’ll be rushing by getting it in
jasje
yeah
ill just draft it
its not that useful as was expecting it to be
as i was*
jivte has quit
akshaaatt
Right
Btw, we should use chatgpt to write test cases for us
I am able to just copy paste it the code and it will write test cases for the entire code
jasje
not so sure about that
ill have a look at it
akshaaatt
I am sure about the results from an iOS perspective. It is actually accurate. Sometimes it makes a few mistakes but atleast gets the boilerplate code ready for us!
Definitely should be added to the list
jivte joined the channel
I don’t want us to send too many efforts for testing if chatgpt already exists and can take care of most of the work