#metabrainz

iconoclasthero: any one else who’s interested: I made a little mockup reminder to myself in the redesign figma: https://usercontent.irccloud-cdn.com/file/aqXW8...

I’m curious as to if some of the aspects here would help? One in particular is having a ‘edit’ background on edit pages to make it clear that you’re not viewing a regular page, you’re in a ‘workspace’. That should hopefully make it clearer that clicking ‘-’ or ‘+’ on something, and so on, wont immediately have an effect?

The other thing that would be nice is using the UI at this stage to let people know things will go into the edit queue, which is always confusing for new users. I don’t want to have to explain it with a big paragraph they wont read, maybe this could help. I thought maybe the button could be orange if it’s not an auto edit, but I don’t know if people won’t get that it’s a submit button in that case

e.g. could do https://usercontent.irccloud-cdn.com/file/FHDQn...

aerozol: what happens if there's a bunch of different changes submitted as different edits, and some will be entered as autoedits while others will not'

* ?

FWIW, we are still hoping to add a way to preview edits to all entity editing like we have for releases

Maybe when previewing, a small icon could be shown by each edit that will be entered with the info of what will happen to it?

Good point - I'd probably do an orange submit button and just change the message to indicate the split. I don't think it has to be perfect, just a thought re. pointing out that there's more to the 'submit' button than people might think

But highlighting each edit so people can see what's what would work in tandem well

mayhem: I was looking at the LB similar users - we have a fair amount of similar ones at the top which look legit (as in, not spammers) but also clearly have duplication. Your document said:

"it would be good to contact both users and ask what is going on. Due to storage reasons and gaming the overall stats for the whole site, it would be good to remove duplicate accounts. Not sure what to do if we get no response from the users. Thoughts?"

Since a bunch of these haven't listened for months, we probably should think about that indeed

Assuming aerozol and you are around for the meeting, maybe we can talk it there?

aerozol: I do think an orange button makes it look a bit like they did something wrong?

I'm around for meeting (I left some comments on that part of the doc btw)

But yes, we should certainly make this clear in some way because people often get confused

Can always have it green like in the screenshot, that was my initial thought too

Anybody else getting a rather gnarly error on this page? https://listenbrainz.org/user/aerozol/

rdswift: I only got to check your doc updates now, but it seemed good, anyway, AFAICT :) Thanks!

aerozol: as far as errors go, it's better than many MB ones, but yes, it's broken. lucifer ^

lucifer, mayhem: Also, my last entry in https://listenbrainz.org/feed/ is from November, is that expected? Are the daily jams listed elsewhere now?

aerozol ^^

dark theme is a must

jasje! Definitely! If you want to code it I’ll mock it up asap ;P

oh neo neo me only app dev

Don't apps use CSS? :D

just wanted you to give the web guys some push ;)

reosarevok: neoo

also we already have dark theme on the app ;)

yvanzo: See MBS-12894 - what do you think? I agree this seems useful, but it's kinda unclear to me how to do it *well*. I guess we still want to autoselect channel since that'll be the correct choice in most cases. I wonder if the least bad option would still be to preselect channel, but allow changing it to interview and say in the error message something like "if you want to add an interview, change this to interview"

MBS-12894: Allow YouTube links for interview relationships https://tickets.metabrainz.org/browse/MBS-12894

aerozol: ^ your opinion also welcome

reosarevok: If I understand correctly, your suggestion may run into trouble with MBS-9040

MBS-9040: Allow bypassing URL autoselect https://tickets.metabrainz.org/browse/MBS-9040

Well, once we have that, then it shouldn't be a problem :)

(this is one of those instances the ticket talks about)

We already kinda-sorta have a way to do that even, the issue here is that the *format* of the URL is different

Normally the artist page errors when you post a video link, because the most common issue is that users copied a music video URL when we want them to link to the artist

But in this case I guess we'd want to allow video links, but only for interviews

Yeah I understood that. Your suggestion makes sense - though we would, as always, have to deal with people abusing it to get in video links

moin

reosarevok: https://listenbrainz.org/user/reosarevok/recomm...

Ah, ok

but apparently our fix for daily jams didn't fix it yet. meh.

reosarevok: talking about LB duplicate accounts before the meeting sound good.

mayhem: i had forgotten to update the containers after merging the PRs 😓. done now

d'oh.

monkey: hi! that error aerozol mentioned is because the track metadata in the pin can be null sometimes.

how about the mapping container, was that updated?

updated that too a few mins ago

also, lucifer and monkey : we should make sure we address that youtube issue that YT keeps whining about.

monkey: i remember having some code to display an error message in the card to the user that we don't have data for this recording but can't find it now. do you remember anything about it?

mayhem: yes makes sense. i guess we should talk with aerozol about how to structure the UI while conforming to Youtube requirements

indeed.

lucifer: re. error I did pin it while it was still playing, but the ’now playing’ box had links to MB. But I guess that’s not the same. Can I do anything to fix my homepage?

aerozol: i'll remove that pin from the db. due to some reason the data for that recording mbid is missing from MB.

uh not from MB but from the data tables in LB that fetch data from MB.

i'll have to investigate why the data is missing but in any the error can be better handled.

Thanks!

aerozol: Hey!!

jivte: Hey! I’m heading to bed soon fyi but feel free to message anyway

oh no problem take rest!!

HTF did HFA get MB into their DB??

Interesting question, innit

does HFA need to pay us?

Interesting question, innit

Yeah I'm really confused about the whole thing

Let's see what they answer

I *really* hope they are not using MB as a source of anything rights-related...

I doubt that, but likely as a source of metadata and they are not supporting us.

time to add this as a board meeting agenda item.

O’Moin

moin!

yvanzo: do you have any suggestions on how we could do MBS-12843 ? :)

MBS-12843: Allow searching for edits by entity type related edit type https://tickets.metabrainz.org/browse/MBS-12843

(as per my last comment)

Obviously no rush with that ticket, just in case you have some quick ideas

Night all! I have a meeting early tomorrow morning ;)

[musicbrainz-server] 14reosarevok opened pull request #2836 (03master…MBS-12742): MBS-12742: Convert Split artist page to React [WIP] https://github.com/metabrainz/musicbrainz-serve...

Night!

(everyone ignore that PR for now, just putting old half-done code up to not forget about it once we go back to other React stuff)

reosarevok: not at the moment about this particular issue. But about edit search, I would consider profiling of higher priority given the outage that occurred in December: https://tickets.metabrainz.org/browse/MBS-12734

MBS-12734: Profile edit search conditions w.r.t. resources usage

Bye aerozol!

Agreed, not sure how we'd do the profiling though. Something to discuss in one of our team meetings I think ? :)

I do think it's a good idea though

It’s mainly based on Postgres queries and there are hopefully tons of tools for their performance analysis.

Sure, we just need to decide how to do it consistently and pick a tool and whatnot, and then do it :)

👍

jivte: yes, media queries should work fine to solve the overlap issue

monkey: I solved the issue it looks fine now

you can check it too

Thanks, will check

I resolved the conversations hope it will help

:)

lucifer: I don't remember an error message showed when pin data is missing

other recording data

or* other…

lucifer and mayhem: about the Youtube requirements, where I left it was that we needed to do two things, one of which is fine (removing the option to minimize the youtube video player).

The other breaks continuous playback: users need to manually click on the YT video play button once it's loaded, instead of our current play-next-track-when-finished mechanism. I guess if we don't have a choice that's what we gotta do, but it's very annoying.

> Proposed Solution: Please make the necessary changes so that YouTube player plays when the user initiates an action. Please update the YouTube icon on the video and only when the user clicks on the icon, the video has to be played.

💩

monkey: have you tried to ask if it's ok for the user to play *once*, then get continuous playback?