we should in the future have an API endpoint where we provide a list of recording_mbids and get back that list of recording_mbids with last (or never) listened at.
2023-03-06 06506, 2023
mayhem
the thing is, all other patches will need this too.
2023-03-06 06520, 2023
mayhem
well, not so much new jams, but artists radio does.
2023-03-06 06548, 2023
lucifer
i think TS can support that fast once we resize the chunks.
2023-03-06 06501, 2023
lucifer
scan the 8-10 latest chunks only.
2023-03-06 06532, 2023
mayhem
it would be nice to not have to make yet another dataset.
2023-03-06 06535, 2023
lucifer
that gives us whether the track was listened to in the last 3 months
2023-03-06 06545, 2023
mayhem
that should be sufficient.
2023-03-06 06517, 2023
mayhem
I forget, we still had a rewrite of the listens table planned, but that hasn't happened yet, right?
2023-03-06 06523, 2023
lucifer
i'll add that endpoint and once we resize the chunks i hope it to become faster.
2023-03-06 06527, 2023
mayhem
resizing chunks should be done at the same time?
2023-03-06 06542, 2023
lucifer
not necessarily,
2023-03-06 06553, 2023
lucifer
but we planned to do it at the same time.
2023-03-06 06514, 2023
lucifer
the rewrite is pending on figuring out how to display the timezone data to users.
2023-03-06 06517, 2023
mayhem
ok, sounds good. that will improve the run time of the upcoming patches. they keep getting more and more intensive. :(
2023-03-06 06540, 2023
mayhem
how to display it or how to store it?
2023-03-06 06501, 2023
lucifer
figure out how to display so that we can work out what exactly to store.
Ah, I see, that's why I was asking if it was a background :) It won't work that way then. Let me take a look
2023-03-06 06538, 2023
mayhem
oh, sorry, I didn't quite understand that question correctly.
2023-03-06 06544, 2023
monkey
No worries.
2023-03-06 06500, 2023
monkey
CSS, amirite?
2023-03-06 06507, 2023
mayhem
yerp
2023-03-06 06510, 2023
antlarr has quit
2023-03-06 06537, 2023
antlarr joined the channel
2023-03-06 06534, 2023
monkey
OK, maybe not the absolute most bare-bones approach, but definitely the easiest way to do this is to add the `flex-center` class to the parent element.
2023-03-06 06535, 2023
monkey
This is one of our custom classes that makes the parent a flex container and centers the children.
monkey: ^^ I think changing the breaks is the only thing that is left. any tips on how to do that?
2023-03-06 06535, 2023
olbld has quit
2023-03-06 06552, 2023
olbld joined the channel
2023-03-06 06558, 2023
atj
this is bootstrap right?
2023-03-06 06504, 2023
monkey
Yes, media queries. But this means departing from bootstrap scaffolding
2023-03-06 06530, 2023
monkey
I'm trying out some of the existing BS breakpoints to see if they could match those dimensions close enough
2023-03-06 06541, 2023
mayhem
ok
2023-03-06 06506, 2023
atj
can you not use bootstrap breakpoints?
2023-03-06 06508, 2023
atj
ah
2023-03-06 06515, 2023
monkey
Other wise it will mean removing the BS scaffolding classes, and writing custom CSS to manage the element width as percentages depending on screen size. Not toooo ticky.
2023-03-06 06510, 2023
mayhem
is that worth it? for this page?
2023-03-06 06523, 2023
monkey
It's only a few lines of CSS in the end
2023-03-06 06530, 2023
mayhem
ok
2023-03-06 06550, 2023
reosarevok
zas: oops, I just noticed you replied only to the account admins account with that French email
2023-03-06 06512, 2023
reosarevok
Because for some reason reply-to is kept when they answer me?
2023-03-06 06519, 2023
reosarevok
I'll forward it to them
2023-03-06 06532, 2023
monkey
We're too limited by BS breakpoints I think mayhem.
2023-03-06 06532, 2023
monkey
Instead of using BS scaffolding classes (col-xx-xx), you'll need to give the card container element a class name to target.
2023-03-06 06532, 2023
monkey
Then here's what the css would look like for those elements:
mmm, something not quite right with one of the card images, let me dig
2023-03-06 06529, 2023
trolley has quit
2023-03-06 06556, 2023
trolley joined the channel
2023-03-06 06508, 2023
trolley has quit
2023-03-06 06535, 2023
trolley joined the channel
2023-03-06 06534, 2023
trolley has quit
2023-03-06 06540, 2023
monkey
Right, the cover art collage image when resized is smaller than the 171px we need to fill the card image container, which results in this weird layout. one fix is to change the .explore-card-img-clip `max-height` css property to `height` instead, which will fix the layout (but not the image ration as you can see in this screenshot:)
It looks like the linting of your less files is what's failing, unless I'm missing something. Try running `npm run lint:less` if you have node installed locally, or `./test.sh fe -f` for docker version