Shelly: That is the ‘for you’ rating - how relevant the release it to you (when you’re logged in). It’s not entirely clear if we have the data to be able to display it everywhere. But at least for the ‘for you’ section it’s good if we can find a way to display it - so that we can arrange it by release date. See the current For You section: https://listenbrainz.org/explore/fresh-releases/
Currently that ‘For You’ part is arranged by how relevant LB thinks it is (as far as I know!). But it means you can’t check what’s coming up and it’s hard to know if something new has been added
Shelly
Got it..What about the image at the top right corner?
Shelly has quit
Shelly joined the channel
reosarevok
yvanzo: when you're around, can you respond to "Voir l'historique des ajout"? :)
Shelly has quit
(I guess that's a quick link to an edit search for release adds...)
aerozol
Shelly: that's to add an image to the musicbrainz release, if there is none. Because clicking the cover plays the album
iconoclasthero_ has quit
iconoclasthero_ joined the channel
duncan- is now known as duncan
yvanzo
O’Moin
gauri joined the channel
gauri has quit
reosarevok
yvanzo: I remember we left a discussion on digital release events halfway. We should restart that, although not sure exactly when :)
yvanzo
reosarevok: answered to the mail, it was full of acknowledgements for once :)
reosarevok
<3
Thanks!
yvanzo
reosarevok: I reviewed the list of other DBs by genre, will open some tickets.
reosarevok
Ok :) What kind of review? Have any disappeared, or is it mostly https issues and whatnot?
jasje joined the channel
jasje
lucifer: somehow YIM data is being generated for me (earlier it wasn't)
and stuff is empty
lucifer
jasje: yes, i had rerun the report to fix a bug. if you didn't have listens in 2022, it'll be empty.
jasje
oof
but
some data is being generated and some not
lucifer
oh weird, i'll take a look
jasje
okeyss
yvanzo
reosarevok: this kind of review yes
reosarevok
Ok, that sounds useful, thanks :)
yvanzo: should we drop at least the sidebar bits for videogam.in then?
yvanzo
reosarevok: I don’t know what to do about the URL cleanup though.
reosarevok
aerozol: should we replace the + icon with some New Set By Aerozol TM? :p
yvanzo: I guess we should leave it since we don't want to make the existing (soon to be ended) links show as invalid?
yvanzo
Sure but the URL cleanup doesn't apply to existing links unless you edit those.
reosarevok
Hmm. So it wouldn't show these as disallowed on loading the page?
yvanzo
The current URL cleanup is not able to deal with "ended" flag anyway, probably better to leave it as-is indeed.
reosarevok: It should not, it’s a bug otherwise.
reosarevok
Hmm, ok. I didn't remember if we showed the errors but did not block editing, or we didn't show them at all
I can remove the sidebar bits :)
yvanzo
I’m sure that no error is shown if the URL format is invalid, but I don’t remember about invalid relationship types.
Thanks
Oh right, maybe an error is shown but it doesn’t block editing.
Don’t remember either.
Better not remove it then :)
There are two other genre-specific DBs that are currently down but for a few months only, so I guess we can keep those for now as they might hopefully be back within in the near future.
reosarevok: are we all set to release a server update?
reosarevok
Probably :) Do I understand that you'd want me to merge these two master PRs into beta before I do the release?
I can do, anyway :)
Nothing else merged in the meantime, so seems safe enough
yvanzo
Thanks, actually don’t bother about these two PRs, they have a very low impact.
reosarevok
Oh
Ok, that works too (and you're right about that)
I guess in fact the readme one already effectively applies
Since most people will see the master branch on the github site
So I'll just release as usual :)
yvanzo
Thanks!
Shelly joined the channel
Shelly
There is an error on loading fresh releases on my local server. How can deal with this? https://pastebin.com/xxqsSuai
Shelly has quit
yvanzo is off for brlunch
vishalftw joined the channel
vishalftw has left the channel
reosarevok
yvanzo: when back, anything special for docker this time?
pixelpenguin[m] joined the channel
jivte joined the channel
pixelpenguin[m]
Hi mayhem and lucifer, I am interested and going through Dataset Hoster Improvements project idea for ListenBrainz. Is there a possibility for 350hrs version project implementation for it?
mayhem
hi
pixelpenguin[m]
Also, where could I find issues for
data-set-hoster repo?
mayhem
if you come up with enough things to do for it, then it could be 350, but that might be a stretch.
one bug that has been annoying is that the input fields are not white space truncated and that often causes an error. that would be a good first ticket.
jivte has quit
lucifer
pixelpenguin[m]: i'll add a few tickets for ds hoster issues on JIRA. till then you can set it up locally and try working on the whitespace issue mayhem mentioned.
the view should definitely trim spaces from the input.
pixelpenguin[m]
lucifer: Thanks a lot for sharing the issue, I will go through it
lucifer
mayhem: do we want to trim spaces for api inputs too?
on one hand i think it would be better to have the same behaviour in UI and API but i think trusting the api user's intent for spaces somewhere might be good as well.
mayhem
I feel that that is invasive, lucifer
what if we detect tailing spaces on input and if the search results in a 404, give a userful reminder that we don't trim API input?
lucifer
that sounds good to me. but it will probably be a 500 not 404 in case of failure.