500? that doesn't seem right to me. the server didn't fail. it should be a 4xx response, since the user did something wrong.
2023-03-20 07906, 2023
lucifer
it fails if we pass like that string as a uuid to sql query.
2023-03-20 07922, 2023
reosarevok
Probably should catch it and return 400 bad request then
2023-03-20 07933, 2023
lucifer
postgres fails the query with invalid uuid and so a 500.
2023-03-20 07940, 2023
lucifer
yup indeed, makes sense
2023-03-20 07914, 2023
mayhem
lucifer: yeah, we should catch that PG exception and turn it into a 400.
2023-03-20 07915, 2023
lucifer
it might be useful to add type checking to dataset hoster i guess before passing params to postgres.
2023-03-20 07930, 2023
mayhem
loads for pixelpenguin[m] to do already. :)
2023-03-20 07951, 2023
mayhem
I guess that would mean adding types, other than strings.
2023-03-20 07904, 2023
mayhem
but yes, agreed, adding types would be good.
2023-03-20 07915, 2023
lucifer
yeah, i think uuid, numerics and strings would be sufficient for now. maybe boolean too?
2023-03-20 07918, 2023
mayhem
because then we can trim a UUID field if we find whitespace
2023-03-20 07925, 2023
lucifer
yeah indeed
2023-03-20 07926, 2023
mayhem
yes, bool, please.
2023-03-20 07905, 2023
lucifer
yeah i actually have a few ideas about ds hoster. mostly about how we should separate ui and api parts. i'll try to write it down and ping you later this week.
2023-03-20 07932, 2023
mayhem
ok, sounds good. that was always the trickiest/messiest part.
2023-03-20 07933, 2023
lucifer
that would also solve rain0r's woes who was trying to experiment with similar artists/recordings data.
2023-03-20 07947, 2023
mayhem
yes.
2023-03-20 07906, 2023
mayhem
oh, while we're dreaming things up, a dropdown field would be a killer feature.
2023-03-20 07915, 2023
mayhem
for selecting the various datasets to query.
2023-03-20 07937, 2023
lucifer
oh yeah indeed. that's on the lists of things to do.
2023-03-20 07903, 2023
mayhem
question remaining: how do we populate this field?
2023-03-20 07910, 2023
lucifer
a bit trickier to model if we want to allow dynamic items in the dropdown.
2023-03-20 07913, 2023
mayhem
DB discovery or update the hoster def?
2023-03-20 07920, 2023
mayhem
heh, great minds.
2023-03-20 07929, 2023
lucifer
hehe lol
2023-03-20 07936, 2023
lucifer
db discovery i'd say.
2023-03-20 07949, 2023
mayhem
when? startup>
2023-03-20 07900, 2023
lucifer
i think every query time.
2023-03-20 07907, 2023
mayhem
because querying for the different versions can be quite slow.
2023-03-20 07914, 2023
mayhem
I've done it when I've forgotten all the options.
2023-03-20 07925, 2023
lucifer
we can cache the query name somewhere else then.
2023-03-20 07926, 2023
mayhem
then each query would take a few minutes.
2023-03-20 07943, 2023
lucifer
but i think ds hoster should allow dynamic discovery in general.
2023-03-20 07948, 2023
mayhem
agreed.
2023-03-20 07900, 2023
lucifer
upto each individual query to make sure it remains fast enough.
2023-03-20 07904, 2023
mayhem
a cache entry that is manually invalidated would work fine too
2023-03-20 07915, 2023
lucifer
yeah indeed.
2023-03-20 07937, 2023
lucifer
from ds hoster perspective it should't matter whether we load from redis or PG.
2023-03-20 07948, 2023
mayhem
agreed.
2023-03-20 07900, 2023
lucifer
i guess this all will actually make it a 350 hours project
2023-03-20 07917, 2023
mayhem
possibly. lets get the complete list going and then we'll see.
2023-03-20 07922, 2023
lucifer
yup sounds good
2023-03-20 07930, 2023
mayhem
but it would be nice to really turbo charge that project since we've gotten so much use from it.
2023-03-20 07937, 2023
mayhem
it still has loads of sharp edges.
2023-03-20 07947, 2023
lucifer
indeed indeed.
2023-03-20 07959, 2023
lucifer
it could also use more tests i think.
2023-03-20 07902, 2023
mayhem
and the good thing is that with these improvements, we can run troi as a query!
2023-03-20 07913, 2023
lucifer
ah true indeed!
2023-03-20 07923, 2023
mayhem
hosted troi. not so sure that is a greatest idea ever, but we'll see.
2023-03-20 07934, 2023
lucifer
oh on that note, do we want to put migrating daily jams to spark as a project idea?
2023-03-20 07956, 2023
mayhem
do you think that would make a good project? I have a feeling you would spend 3x your time mentoring someone to do it than it would take you to hammer it out. I'm less enthusiastic about this than the others.
another side note: I've starting playing around with regular expressions for detuning and two regexps alone can do a lot of parsing. I think this is a very promising approach.
2023-03-20 07925, 2023
mayhem
oh. let me contact them about that.
2023-03-20 07934, 2023
lucifer
yeah, actually thinking about it. it would be simpler to do it myself.
2023-03-20 07944, 2023
lucifer
oh noice!
2023-03-20 07916, 2023
mayhem
mail to google sent.
2023-03-20 07931, 2023
mayhem
yeah, the regexps are gnarly, but they work really well.
2023-03-20 07936, 2023
lucifer
thanks
2023-03-20 07951, 2023
lucifer
indeed, better than having an entire ai engine for detuning though
2023-03-20 07906, 2023
mayhem
crafting one takes quite some time, but with the help of regex101.com it is totally workable.
2023-03-20 07955, 2023
mayhem goes for a walk and will do more work later.
reosarevok: There is probably something to be said about cache change.
2023-03-20 07908, 2023
yvanzo
(Oops, good walk)
2023-03-20 07943, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #99 (03main…dependabot/gradle/com.github.bumptech.glide-compiler-4.15.1): Bump com.github.bumptech.glide:compiler from 4.15.0 to 4.15.1 https://github.com/metabrainz/listenbrainz-androi…
2023-03-20 07955, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #100 (03main…dependabot/gradle/com.github.bumptech.glide-glide-4.15.1): Bump com.github.bumptech.glide:glide from 4.15.0 to 4.15.1 https://github.com/metabrainz/listenbrainz-androi…
2023-03-20 07900, 2023
reosarevok
yvanzo: I'm not quite sure what to say - I think most people didn't even notice the issue (we never got a ticket from someone else about it at least)
2023-03-20 07911, 2023
reosarevok
But if you have some idea, maybe you can add it and I'll review it in a bit? :)
2023-03-20 07926, 2023
yvanzo
Yes, I’m just looking into instructions to clear the cache on mirrors.
2023-03-20 07935, 2023
reosarevok
I'm not sure the issue affected anything outside editing pages which mirrors don't use, but maybe bitmap can help with instructions once around
2023-03-20 07911, 2023
adhawkins has quit
2023-03-20 07910, 2023
adhawkins joined the channel
2023-03-20 07902, 2023
bitmap
yvanzo: on mirrors entities are only cached for 1 hour by default, so it probably won't be necessary to clear the cache, but you can do it via the redis 'flushall' command (`redis-cli -p $PORT flushall` should work, but if there isn't a separate redis store, it will also clear logins)
2023-03-20 07929, 2023
bitmap
I also only noticed the errors on edit pages, not when viewing data or using the web service
I went ahead and tried out adding functionality for adding ISO codes and Links to other entities over the weekend, and looks like Mechanize doesn't even detect the control/text-box required for adding links as shown in the following screenshot:
Fin. And the SEC Award of the week goes to... monkey!
2023-03-20 07906, 2023
yvanzo
monkey: As an award-winner, what are your impressions about the past week?
2023-03-20 07914, 2023
monkey
:tad:
2023-03-20 07920, 2023
monkey
🎉 even
2023-03-20 07925, 2023
monkey
Hello everyone !
2023-03-20 07942, 2023
reosarevok
Still on my list: reosarevok, bitmap, zas, mayhem, lucifer, akshaaatt, atj, aerozol, CatQuest, riksucks, jasje, jivte, kellnerd
2023-03-20 07943, 2023
Pratha-Fish
congrats monkey :D
2023-03-20 07921, 2023
monkey
last week I spent entirely too much time on updating our test runner (jest) in LB, and looking at our migration path to replace the React testing library (enzyme) that we use with it.
2023-03-20 07957, 2023
monkey
I also finished replacing our modal components in LB. We should now have all features available on all listenCards across the website
2023-03-20 07911, 2023
aerozol
:0
2023-03-20 07923, 2023
monkey
I continued with the LB redesign, which you can get a rough preview of on test.listenbrainz.org
2023-03-20 07958, 2023
monkey
Ah, and along with the modal thing I mentioned, started working on LB-1148 as well
