#metabrainz

/

      • kellnerd has quit
      • 2023-03-21 08015, 2023

      • Pratha-Fish
        reosarevok, bitmap after 6 hours of fiddling around I finally figured out how to add the rest of the attributes using the mechanize browser API (using Requests) to tackle the lack of javascript support 😭
      • 2023-03-21 08034, 2023

      • Pratha-Fish
        I've updated the PR with 3 separate commits and examples as well: https://github.com/metabrainz/musicbrainz-bot/pul…
      • 2023-03-21 08047, 2023

      • Pratha-Fish finally runs off to sleep šŸ›ļøšŸƒā€ā™‚ļø
      • 2023-03-21 08019, 2023

      • Maxr1998 joined the channel
      • 2023-03-21 08025, 2023

      • Maxr1998_ has quit
      • 2023-03-21 08054, 2023

      • iconoclasthero has quit
      • 2023-03-21 08002, 2023

      • iconoclasthero joined the channel
      • 2023-03-21 08053, 2023

      • iconoclasthero_ is now known as adoigfyweqiuogty
      • 2023-03-21 08012, 2023

      • iconoclasthero has quit
      • 2023-03-21 08017, 2023

      • adoigfyweqiuogty is now known as iconoclasthero
      • 2023-03-21 08025, 2023

      • iconoclasthero_ joined the channel
      • 2023-03-21 08017, 2023

      • andrerodriguex joined the channel
      • 2023-03-21 08034, 2023

      • andrerodriguex has quit
      • 2023-03-21 08056, 2023

      • andrerodriguex joined the channel
      • 2023-03-21 08031, 2023

      • pixelpenguin
        <lucifer> "pixelpenguin: 1. you can write a..." <- Okay, I will add the tests. Thanks
      • 2023-03-21 08056, 2023

      • andrerodriguex
        Hi, everyone. I am applying as a contributor for GSoC and I'm really thrilled to have found a music-related project! I am an aspiring front-end developer and I hope I can add to the community, nice to meet y'all :)
      • 2023-03-21 08029, 2023

      • pbryan
        Hi andrerodriguex. Welcome!
      • 2023-03-21 08005, 2023

      • andrerodriguex has quit
      • 2023-03-21 08022, 2023

      • nbin has quit
      • 2023-03-21 08007, 2023

      • nbin joined the channel
      • 2023-03-21 08026, 2023

      • nbin has quit
      • 2023-03-21 08055, 2023

      • nbin joined the channel
      • 2023-03-21 08059, 2023

      • yvanzo
        O’Moin
      • 2023-03-21 08010, 2023

      • iconoclasthero has quit
      • 2023-03-21 08012, 2023

      • iconoclasthero__ joined the channel
      • 2023-03-21 08038, 2023

      • Diviloper joined the channel
      • 2023-03-21 08045, 2023

      • Diviloper
        when I am trying to run this command
      • 2023-03-21 08045, 2023

      • Diviloper
        ./develop.sh build
      • 2023-03-21 08046, 2023

      • Diviloper
        It shows me this "unknown shorthand flag: 'f' in -f"
      • 2023-03-21 08046, 2023

      • Diviloper
        I don't know why this is coming can anybody help me ? I removed all the -f from the build.sh and tried to run the command again but still I got the same error
      • 2023-03-21 08035, 2023

      • lucifer
        Diviloper: which project is this?
      • 2023-03-21 08036, 2023

      • Diviloper
        ListenBrainz
      • 2023-03-21 08043, 2023

      • Diviloper
        lucifer
      • 2023-03-21 08004, 2023

      • lucifer
        Diviloper: weird, it was working fine for me. i am currently afk but can take a look in a few hours.
      • 2023-03-21 08000, 2023

      • Diviloper has quit
      • 2023-03-21 08056, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo opened pull request #2907 (03production…mbs-13007): MBS-13007: Fix a regressive ISE on broken WikiLink https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-21 08048, 2023

      • yvanzo
        Diviloper: Which version of bash is installed on your system? To find out, run: echo ${BASH_VERSINFO[@]}
      • 2023-03-21 08029, 2023

      • yvanzo
        Diviloper: macOS usually comes with an old version, you can install a more recent one using Homebrew: https://brew.sh/ https://formulae.brew.sh/formula/bash#default
      • 2023-03-21 08036, 2023

      • yvanzo
        reosarevok: are you around for reviewing a regression? ^
      • 2023-03-21 08040, 2023

      • reosarevok
        yvanzo: if it's a short review. I'll check
      • 2023-03-21 08047, 2023

      • yvanzo
        it is
      • 2023-03-21 08057, 2023

      • yvanzo
        (it should be)
      • 2023-03-21 08007, 2023

      • jivte joined the channel
      • 2023-03-21 08039, 2023

      • reosarevok
        Ok, let's see
      • 2023-03-21 08011, 2023

      • yvanzo
        bitmap, reosarevok: We didn't ack an MB dev meeting date yet, will be resetting trille today, but I'm available tomorrow, 3pm UTC as usual?
      • 2023-03-21 08014, 2023

      • reosarevok
        yvanzo: looks good, thanks :) Easy thing to miss too
      • 2023-03-21 08033, 2023

      • reosarevok
        I think tomorrow is good for me, yes
      • 2023-03-21 08047, 2023

      • reosarevok
        (might meet a friend an hour or two after that time, so let's not make it super long :) )
      • 2023-03-21 08024, 2023

      • reosarevok
        What should we have as the topic?
      • 2023-03-21 08056, 2023

      • reosarevok
        More entity naming, a schema change ticket status review, or do we have something else?
      • 2023-03-21 08004, 2023

      • reosarevok
        yvanzo: also, re: that support SPARQL query... there was a working LinkedBrainz dump at some point, although missing a lot of data
      • 2023-03-21 08037, 2023

      • reosarevok
        I worked on that a bit a couple years ago, but the interest just wasn't there so I mostly gave up on it... the dump is probably some 4 years old and maybe not of any use, anyway, though :)
      • 2023-03-21 08042, 2023

      • reosarevok
        Not even sure where that lives :D
      • 2023-03-21 08002, 2023

      • reosarevok
        So, I think your answer was mostly good, just wanted to let you know what the actual status of that mess is :D
      • 2023-03-21 08032, 2023

      • yvanzo
        reosarevok: apparently there was a ~2010 dump https://chatlogs.metabrainz.org/libera/metabrainz…
      • 2023-03-21 08031, 2023

      • yvanzo
        reosarevok: as you seem to know a lot about it, do you think it will be resurrected some day?
      • 2023-03-21 08053, 2023

      • reosarevok
        I mean, if someone actually cares about SPARQL and MB and wants to work on it, I'd be happy to give a hand
      • 2023-03-21 08004, 2023

      • reosarevok
        But I'm not going to be the main person there because I just don't know enough
      • 2023-03-21 08015, 2023

      • reosarevok
        I remember asking alastairp for help with stuff and him asking others IIRC
      • 2023-03-21 08021, 2023

      • reosarevok
        About schema issues and whatnot
      • 2023-03-21 08001, 2023

      • yvanzo
        I agree that we would be clearly missing manpower to carry it on, it just seems that it was something quite important and useful to keep it in mind for the future.
      • 2023-03-21 08035, 2023

      • yvanzo
        reosarevok: about tomorrow's meeting, yes mostly that; as we won't have time for something else: search, docker, infra...
      • 2023-03-21 08019, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo merged pull request #2907 (03production…mbs-13007): MBS-13007: Fix a regressive ISE on broken WikiLink https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-21 08037, 2023

      • BrainzGit
        [musicbrainz-docker] release 03v-2023-03-21-hotfix has been published by 14yvanzo: https://github.com/metabrainz/musicbrainz-docker/…
      • 2023-03-21 08001, 2023

      • yvanzo
        Deploying the patch to beta.
      • 2023-03-21 08024, 2023

      • jivte_ joined the channel
      • 2023-03-21 08043, 2023

      • yellowhatpro_ has left the channel
      • 2023-03-21 08014, 2023

      • jivte has quit
      • 2023-03-21 08036, 2023

      • yvanzo
        Deploying the patch to prod website containers only.
      • 2023-03-21 08056, 2023

      • jivte_ has quit
      • 2023-03-21 08043, 2023

      • monkey
        aerozol: No huge rush for the landing pages, we still have a lot of other work to do that we can focus on
      • 2023-03-21 08028, 2023

      • yvanzo
        Done with hotfix release.
      • 2023-03-21 08007, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2418 (03master…comment-out-add-to-mb): Hide "Add to MB" button from missing MB links page https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-21 08012, 2023

      • BrainzGit
        [bookbrainz-site] 14stoichy closed pull request #955 (03master…master): BB-583: Changed button-links and contact-links size in homepage https://github.com/metabrainz/bookbrainz-site/pul…
      • 2023-03-21 08027, 2023

      • daftano joined the channel
      • 2023-03-21 08037, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2419 (03master…lb-1148): LB-1148: Distinguish "no cover art" and "not mapped" listens https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-21 08016, 2023

      • Pratha-Fish
        Hi reosarevok / bitmap I have submitteed an updated to my PR on the musicbrainz bot. Can someone kindly help me review it? :)
      • 2023-03-21 08016, 2023

      • Pratha-Fish
      • 2023-03-21 08014, 2023

      • Pratha-Fish
        P.S. I'll be off for a few days due to my college exams, and will be back on 25th. So if possible I'd love to get some more work sorted out today before leaving
      • 2023-03-21 08006, 2023

      • Pratha-Fish
        *submitted an update
      • 2023-03-21 08012, 2023

      • atj
        Pratha-Fish: it looks like you could use the approach already used here: https://github.com/Prathamesh-Ghatole/musicbrainz…
      • 2023-03-21 08030, 2023

      • atj
        rather than using requests directly and having to duplicate headers
      • 2023-03-21 08022, 2023

      • atj
        very minor, but as a general rule you don't define uppercase constants in the body of a function
      • 2023-03-21 08037, 2023

      • Pratha-Fish
        atj: thanks for the recommendation :)
      • 2023-03-21 08037, 2023

      • Pratha-Fish
        I'll try and update my function to use the built-in functions ASAP.
      • 2023-03-21 08033, 2023

      • Pratha-Fish
        The uppercase constraints will be dealt with too šŸ‘Œ
      • 2023-03-21 08025, 2023

      • nexus joined the channel
      • 2023-03-21 08011, 2023

      • daftano has left the channel
      • 2023-03-21 08052, 2023

      • jasje joined the channel
      • 2023-03-21 08020, 2023

      • jasje
        hi akshaaatt
      • 2023-03-21 08031, 2023

      • akshaaatt
        Hi jasje
      • 2023-03-21 08001, 2023

      • jasje
        akshaaatt: So i was thinking about the critiqueBrainz part of the project
      • 2023-03-21 08025, 2023

      • jasje
        do i need to implement auth(if its possible)
      • 2023-03-21 08056, 2023

      • akshaaatt
        You don’t have to worry about auth fpr this
      • 2023-03-21 08011, 2023

      • akshaaatt
        We need to connect to cb though
      • 2023-03-21 08020, 2023

      • jasje
        so should i just redirect user to website
      • 2023-03-21 08028, 2023

      • akshaaatt
        Hmm I mean yeah it is a part of auth
      • 2023-03-21 08054, 2023

      • jasje
        akshaaatt: is there a CritiqueBrainz token
      • 2023-03-21 08004, 2023

      • jasje
        lookin at the website's frontend code
      • 2023-03-21 08016, 2023

      • jasje
        it just says a generic token
      • 2023-03-21 08025, 2023

      • jasje
        idk if its mb token or lb token
      • 2023-03-21 08043, 2023

      • jasje
        or cb token (if it exists)
      • 2023-03-21 08025, 2023

      • jasje
        Consider my webdev skills limited to html only
      • 2023-03-21 08035, 2023

      • akshaaatt
        Give me 10mins
      • 2023-03-21 08014, 2023

      • jasje
        alrighty
      • 2023-03-21 08035, 2023

      • jasje
        maybe monkey can help tho
      • 2023-03-21 08053, 2023

      • monkey
        uh-oh, what did I do?
      • 2023-03-21 08001, 2023

      • monkey reads the backlog
      • 2023-03-21 08021, 2023

      • jasje
        no problems just queries
      • 2023-03-21 08040, 2023

      • monkey
        This is for the app, yes?
      • 2023-03-21 08052, 2023

      • jasje
        in APIService, what token is used to submit the CBReview?
      • 2023-03-21 08056, 2023

      • jasje
        monkey yess
      • 2023-03-21 08026, 2023

      • monkey
        On the LB frontend, we pass the CB token as a prop in a global context. Let me fish the code out
      • 2023-03-21 08044, 2023

      • jasje
        oh no
      • 2023-03-21 08047, 2023

      • jasje
        3 tokens
      • 2023-03-21 08001, 2023

      • jasje feels nervous
      • 2023-03-21 08001, 2023

      • monkey
        So we pass a number of global props which we inject in the HTML page, then parse in React: https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-21 08011, 2023

      • monkey
        the CB token is one of these global props.
      • 2023-03-21 08028, 2023

      • jasje
        looks like we need the user to enter that to the app just like lb token
      • 2023-03-21 08041, 2023

      • monkey
        That sounds right.
      • 2023-03-21 08048, 2023

      • jasje
        feels very primitive
      • 2023-03-21 08005, 2023

      • monkey
        Yeah, single sign-on would be ideal for these use-cases
      • 2023-03-21 08052, 2023

      • jasje
        also monkey: seems like the create review API endpoint doc isn't updated
      • 2023-03-21 08017, 2023

      • jasje
      • 2023-03-21 08033, 2023

      • monkey
        In the meantime, there are two ways to do it: 1. users can get a token here: https://critiquebrainz.org/profile/applications/ or 2. users can link their CB account to LB here https://listenbrainz.org/profile/music-services/d… and then you can call an LB API endpoint to get a token for the user
      • 2023-03-21 08056, 2023

      • monkey
        I reckon 2 might be easier since you already have an LB token, but it does require users go to the LB page
      • 2023-03-21 08028, 2023

      • monkey
        Yeah, missing Request Headers: Authorization in the docs it looks like
      • 2023-03-21 08043, 2023

      • monkey
        Would you mind opening a PR or a ticket for that?
      • 2023-03-21 08000, 2023

      • jasje
        monkey ill update em no worries
      • 2023-03-21 08005, 2023

      • monkey
        Thanks !
      • 2023-03-21 08023, 2023

      • jasje
        btw i did wanna ask that
      • 2023-03-21 08042, 2023

      • jasje
        my last changes haven't taken effect on the docs
      • 2023-03-21 08020, 2023

      • jasje
        monkey^^
      • 2023-03-21 08030, 2023

      • monkey
        lucifer: Hi! I think one of the recent PRs (LB#2415 possibly) is making a server test fail : https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-21 08031, 2023

      • BrainzBot
      • 2023-03-21 08018, 2023

      • monkey
        jasje: I'm not exactly sure how the API docs are updated or at what frequency
      • 2023-03-21 08053, 2023

      • monkey
        Looks like the docs compilations are failing
      • 2023-03-21 08053, 2023

      • jasje hides
      • 2023-03-21 08008, 2023

      • monkey
        Nope, nothing you did jasje :) Looks like a package update gone wrong
      • 2023-03-21 08007, 2023

      • jasje relaxes
      • 2023-03-21 08055, 2023

      • jasje
        looks like updating docs is something i could do in freetime for the server
      • 2023-03-21 08032, 2023

      • jasje
        seeing all those prs with 5/10 commits fixing tests really scares me on server xD
      • 2023-03-21 08035, 2023

      • akshaaatt is back
      • 2023-03-21 08002, 2023

      • akshaaatt
        Thanks monkey for clarifying things.
      • 2023-03-21 08023, 2023

      • akshaaatt
        Just to confirm, which endpoint helps us fetch the CB token from LB?
      • 2023-03-21 08001, 2023

      • jasje
      • 2023-03-21 08007, 2023

      • jasje
        this looks the one
      • 2023-03-21 08011, 2023

      • akshaaatt
        I didn't realize before but why are we hardcoding the refresh tokens in the app?
      • 2023-03-21 08025, 2023

      • yvanzo
        zas: looking into trille containers now; how long the downtime to be announced? 10 minutes?