So we only do this when 1. user submitted a release MBID and 2. it is not the same as the mapped release MBID
lucifer
because release date
monkey: yes sounds good.
mayhem: the redesign PR, why not release today?
mayhem
friday.
err, thursday.
lucifer
thursday. yeah
mayhem
big shit like this is best to go out monday.
ok, I really want to get some datasets work done. does anyone else need me before I put my head down for an hour or so? speak up now.
monkey
I'd like our resident designer to have another pass, give another few days for users to chime, and have a blog post ready to be posted when we do deploy.
sorry, i couldn't find a way to add my commits to the already existing PR 😢
mayhem
you likely dont have the rights to do that. :(
but this should work fine, methinks.
reosarevok: for when you return to work: https://test.metabrainz.org/datasets -- the datasets page flow is done now and can be checked for all manners of mishappen things. the only thing left on my list is redirecting users who took the signup plunge to the download page, but that is a project for the morning.
Two things from #137. 1) Where are we picking up the now playing feature in this PR? 2) I am not sure if maintaining our own timer is the right solution.
Have we checked what impacts it has on performance?
jasje joined the channel
jasje
akshaaatt: no playing now will be done later.
akshaaatt
You have it linked in the description of the PR
jasje
2) Timer is just one solution, since it executes a little amount of code after 1 sec
actually the reporter mixed up the title and description
just read the description for details
the exact thing timer solves is that it keeps track of how much a track is played. lets say i were to skip to some part of the song, the timer will keep track of total listen time
but ofcourse this a very initial approach and I would like some suggestions on it
this approach is also used due to the unstability of android's APIs
jasje has quit
pranay has quit
BrainzGit
[listenbrainz-server] 14faraz16iqbal opened pull request #2463 (03master…refresh-playlists-page): fix: refresh playlists page on while creating, editing and deleting a… https://github.com/metabrainz/listenbrainz-serv...
akshaaatt
I think we can just use the delayed message thing to submit the listen after 1min or so has been played jasje
What’s the harm in doing that?
pranay joined the channel
jasje joined the channel
jasje
akshaaatt: pausing and playing again doesn't extend delay.
we might have to cancel listen, then note down the remaining appropriate duration left
and post the message again when the user plays with calculated duration.
I think MusicBrainz app should just be converted to a sdk type of thing
akshaaatt^^
akshaaatt
SDK for what jasje?
jasje
for search apis?
akshaaatt
An app is just an interface jasje
The app itself uses apis from the backend
jasje
all apis musicbrainz has to offer
akshaaatt
MB already offers them
jasje
but i would be simpler if we just made the calls. none of the retrofit stuff
it would*
akshaaatt
Lol
jasje
probably create a module inside that others can access
some suggested this in tickets :P
akshaaatt
Ouu
I don’t think that’s what we are aiming for currently
jasje
tru but still putting the idea out
akshaaatt
The mb app is still great for searching, barcodes thing, picard thing and collections
I am not focusing on the mb app currently but I do think we should continue that in future
I want to experiment with some ML stuff soon on both MB and LB based on user interactions in the app
jasje
its not that helpful if adding artist takes you to web anyways
akshaaatt
Sure we can look into that soon. We just need apis made for those
jasje
all the apis are so clunked together with the website
akshaaatt
Plus some hard UI/UX decisions which are hard to make currently. But we can do so in future
jasje
alot of work indeed
akshaaatt
Tbh we already have the base ready for things now. It’s just a matter of pumping features out
I’m assuming MeB will soon come out of that hell hole where we were just refactoring stuff everywhere. The important decisions have already been made and are in progress
v6lur joined the channel
jasje
less workforce
akshaaatt
The only major thing left is the MB revamp… let’s see if santiagofn and I can work through some of it
It’s not just about the workforce jasje. Tbh there are only a few people who understand the tech we are working on and have experience with it
jasje
mb sure does need the revamp
akshaaatt: no no not mb/lb, the apps
android is pretty abundant
akshaaatt
The fact is that our user base MB wide is not a fan of editing on the app yet because of obvious reasons
jasje
but still very less people here
akshaaatt
Opening browser for stuff and all..
jasje
agree on that
akshaaatt
LB android has a huge chance of winning people according to me because it is relevant to the use case
But LB lacks a brand yet overall
Which we need to create via the revamp, app, and more exciting features like yim
Recommendation engine is the key here
jasje
true
akshaaatt
Once we have the apps and things there for us, we can focus closely on user interactions and work on stuff which people want more
jasje
I guess recommendation engine could use some help from users
akshaaatt
Right. Exactly that
I want to use ML on the app side to recommend songs better to the users
jasje
like dislike a recommendation
akshaaatt
Yeah. Tiktok does that
jasje
use listen time
akshaaatt
Yeah
Even on server side more of what your following listen to and stuff
Plus better engagement with users through stuff like yim or push notifications..
jasje
push notifications is a must
FCM is the way
akshaaatt
Let’s see…
jasje
can we replicate FCM tho?
akshaaatt
Lol no
jasje
how on earth do they do it
akshaaatt
Google uses the play services for it internally
They don’t want to expose push notifications to users now because a lot of people used to misuse it earlier
Like reading other ap’s notifications
jasje
it should be just repeated API calls?
akshaaatt
Yeah but that drains the battery jasje
jasje
what extra do they do then?
akshaaatt
Google and these smartphone guys don’t want it to seem like their phones are shitty and that they drain in 4hrs just because some shady slim wanted to do repeated api calls every 2secs throughout the phone’s lifetime
jasje
xD
akshaaatt
The thing with push notifications are that they run even when the app is closed
That’s the whole point of them
jasje
is there competitor of FCM?
santiagofn
Talking about MB revamp, it's the first time I see a backend done using Perl. It's also the first time I encountered Flow instead of typescript