We will eventually end up using some library for making the app network proof
2023-05-28 14803, 2023
akshaaatt
I don’t wanna get into this currently because the basic norm is to first make an internet always only app and then implement caching and local stuff for network calls
2023-05-28 14843, 2023
akshaaatt
The biggest example is that even the websites just die down as soon as the internet is gone
2023-05-28 14826, 2023
jasje
um so no cache
2023-05-28 14852, 2023
jasje
?
2023-05-28 14852, 2023
akshaaatt
Yes to cache but not right now with the current bandwidth we have
2023-05-28 14819, 2023
akshaaatt
I'm fine with it if you wanna explore stuff and send me more libraries
2023-05-28 14809, 2023
jasje
welp i was just looking to cache the reviews a user would write that would be drafted, but now then i went towards total caching
2023-05-28 14823, 2023
jasje
but then**
2023-05-28 14838, 2023
akshaaatt
That sounds good to me jasje
2023-05-28 14850, 2023
akshaaatt
For that use case of yours, roomdb would be good
2023-05-28 14800, 2023
akshaaatt
Basically drafts
2023-05-28 14817, 2023
jasje
I was thinking of that too
2023-05-28 14837, 2023
jasje
but i thought maybe something more automated?
2023-05-28 14840, 2023
akshaaatt
Btw, I need some help with testing a few things jasje. Can you please pull the latest main branch and try to play with it? I have revamped a lot of stuff. Also, I need some help with switching the theme. Idk what the issue is there.
2023-05-28 14858, 2023
akshaaatt
Gimme a min before I merge
2023-05-28 14829, 2023
jasje
alrite
2023-05-28 14810, 2023
jasje
woah 1.3k
2023-05-28 14836, 2023
jasje
a lot of work you got in
2023-05-28 14812, 2023
akshaaatt
Yeah it’s as much as 1/4th of a gsoc project lol
2023-05-28 14855, 2023
jasje
lol
2023-05-28 14808, 2023
jasje
i thought rip profile
2023-05-28 14814, 2023
jasje
but yay
2023-05-28 14805, 2023
jasje
also about the removal of settings
2023-05-28 14817, 2023
jasje
is this the right step?
2023-05-28 14820, 2023
akshaaatt
Nothing is rip here. We need to complete this app in terms of features by the end of this year
2023-05-28 14851, 2023
akshaaatt
Yes jasje. We need a better UX. Just giving a settings panel is not a good ux
2023-05-28 14814, 2023
akshaaatt
Also why tf do we even need settings for? Our app doesn’t even have any settings as such
2023-05-28 14828, 2023
jasje
we could have later on tho
2023-05-28 14833, 2023
akshaaatt
This will also give us the right motivation to move to compose completely
2023-05-28 14842, 2023
jasje
just look at website
2023-05-28 14845, 2023
akshaaatt
Yeah, we’ll it in JC then
2023-05-28 14851, 2023
jasje
that i agree it
2023-05-28 14858, 2023
jasje
agree with**
2023-05-28 14814, 2023
jasje
so about caching
2023-05-28 14815, 2023
akshaaatt
Tbh I’m bot a fan of settings even kn the website
2023-05-28 14821, 2023
akshaaatt
Not*
2023-05-28 14827, 2023
jasje
me fan
2023-05-28 14833, 2023
akshaaatt
Lol
2023-05-28 14849, 2023
akshaaatt
Everything should just be jn the basic profile page itself tbh
2023-05-28 14852, 2023
jasje
its intuitive to look into settings for something "core"
2023-05-28 14827, 2023
akshaaatt
I agree with it but there shouldn’t be a separate settings panel for the app until and unless your app has only one functionality
2023-05-28 14841, 2023
jasje
we can remove it for now
2023-05-28 14842, 2023
akshaaatt
For example, we want to give the user to control their bass, etc for BP on the app
2023-05-28 14851, 2023
akshaaatt
Where would those settings be?
2023-05-28 14853, 2023
jasje
+1
2023-05-28 14816, 2023
jasje
could have it in bp too
2023-05-28 14823, 2023
akshaaatt
Exactly
2023-05-28 14831, 2023
jasje
I think we are drifting from the focus here
2023-05-28 14837, 2023
jasje
caching
2023-05-28 14843, 2023
akshaaatt
Lol
2023-05-28 14854, 2023
akshaaatt
I did change the topic so we didn’t drift actually
[listenbrainz-android] 14dependabot[bot] closed pull request #151 (03main…dependabot/gradle/com.google.android.material-material-1.9.0): Bump com.google.android.material:material from 1.8.0 to 1.9.0 https://github.com/metabrainz/listenbrainz-androi…
2023-05-28 14849, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] closed pull request #149 (03main…dependabot/gradle/compose_version-1.4.3): Bump compose_version from 1.4.2 to 1.4.3 https://github.com/metabrainz/listenbrainz-androi…
2023-05-28 14854, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] closed pull request #153 (03main…dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-test-1.7.1): Bump org.jetbrains.kotlinx:kotlinx-coroutines-test from 1.6.4 to 1.7.1 https://github.com/metabrainz/listenbrainz-androi…
2023-05-28 14812, 2023
akshaaatt
Yeah we should definitely improve BP.
2023-05-28 14836, 2023
BrainzGit
[listenbrainz-android] 14dependabot[bot] closed pull request #152 (03main…dependabot/gradle/app.cash.turbine-turbine-0.13.0): Bump app.cash.turbine:turbine from 0.12.3 to 0.13.0 https://github.com/metabrainz/listenbrainz-androi…
2023-05-28 14845, 2023
jasje
currently we do kotlin calcs or runtime calcs which is slower
2023-05-28 14852, 2023
akshaaatt
Yus
2023-05-28 14816, 2023
jasje
also keep in mind to use viewpager for loading songs in bp screen
2023-05-28 14819, 2023
akshaaatt
I’m happy with it if you wanna update those jasje
2023-05-28 14832, 2023
jasje
akshaaatt: we could have a ticket
2023-05-28 14841, 2023
jasje
a lot of stuff needs updating
2023-05-28 14842, 2023
akshaaatt
Sure
2023-05-28 14856, 2023
jasje
priorities are must
2023-05-28 14831, 2023
akshaaatt
Yeah you’ll soon realize that everything needs to be maintained and updated
2023-05-28 14851, 2023
akshaaatt
In a while, you’ll realize the need to refactor YIM stuff as well
2023-05-28 14812, 2023
akshaaatt
But again, as even you said, priorities will matter then
2023-05-28 14828, 2023
jasje
this app needs a fulltime dev
2023-05-28 14833, 2023
jasje
no cap
2023-05-28 14854, 2023
jasje
upgraded gradle version huh
2023-05-28 14806, 2023
akshaaatt
Lol
2023-05-28 14834, 2023
jasje
akshaaatt: not sure about this one
2023-05-28 14811, 2023
jasje
the some bottom nav icons are different in terms of shape and size when selected
2023-05-28 14818, 2023
jasje
while others arent
2023-05-28 14825, 2023
jasje
about the system theme
2023-05-28 14844, 2023
jasje
we were using isUiModeDark for that
2023-05-28 14837, 2023
jasje
when you remove the activity restart thing it works fine
2023-05-28 14846, 2023
jasje
we arent updating the preference here.
2023-05-28 14850, 2023
akshaaatt
Ouu right
2023-05-28 14837, 2023
jasje
too much done in this pr
2023-05-28 14841, 2023
akshaaatt
Can you please make a PR for it? Also, about the icons, I couldn’t find the same icons for free on fontawesome. I need but selected and unselected. After beta release, we can get aerozol to provide us the icons
2023-05-28 14859, 2023
akshaaatt
Both*
2023-05-28 14814, 2023
jasje
let me see
2023-05-28 14819, 2023
akshaaatt has been working since morning today and is now headed out with friends for a drink or two
2023-05-28 14848, 2023
jasje
akshaaatt: where did you get these theme icons
2023-05-28 14818, 2023
jasje
its confusing to use two
2023-05-28 14846, 2023
jasje
separate icons
2023-05-28 14856, 2023
jasje
plus both have black tints
2023-05-28 14803, 2023
jasje
🫠
2023-05-28 14812, 2023
akshaaatt
Fontawesome, jasje
2023-05-28 14822, 2023
jasje
wait
2023-05-28 14836, 2023
jasje
we dont have white tints at all?
2023-05-28 14803, 2023
akshaaatt
Reddit uses this as well
2023-05-28 14810, 2023
akshaaatt
Moon and sun to switch the theme
2023-05-28 14839, 2023
akshaaatt
Ouu they don’t use sun
2023-05-28 14846, 2023
akshaaatt
Fine, let’s do one icon then
2023-05-28 14855, 2023
jasje
akshaaatt: can you please do "validate token" call as well?
