#metabrainz

yvanzo: I noticed something weird about SOLR

solr-4 has only a replica for recordings, while others have all

For recording collection, from SOLR UI https://usercontent.irccloud-cdn.com/file/mOd9i...

For annotation collection https://usercontent.irccloud-cdn.com/file/Ku5wB...

for recording, we have one replica per node, but for annotation we have 2 replicas on the same node, and one node without a replica

url collection has only 4 replicas

akshaaatt: found this lib for caching https://github.com/MobileNativeFoundation/Store

the lib is updated twice every month

should we use this

or build something of our own?

(given maintenance overhead as well)

Hi jasje

yoo

We will eventually end up using some library for making the app network proof

I don’t wanna get into this currently because the basic norm is to first make an internet always only app and then implement caching and local stuff for network calls

The biggest example is that even the websites just die down as soon as the internet is gone

um so no cache

?

Yes to cache but not right now with the current bandwidth we have

I'm fine with it if you wanna explore stuff and send me more libraries

welp i was just looking to cache the reviews a user would write that would be drafted, but now then i went towards total caching

but then**

That sounds good to me jasje

For that use case of yours, roomdb would be good

Basically drafts

I was thinking of that too

but i thought maybe something more automated?

Btw, I need some help with testing a few things jasje. Can you please pull the latest main branch and try to play with it? I have revamped a lot of stuff. Also, I need some help with switching the theme. Idk what the issue is there.

Gimme a min before I merge

alrite

woah 1.3k

a lot of work you got in

Yeah it’s as much as 1/4th of a gsoc project lol

lol

i thought rip profile

but yay

also about the removal of settings

is this the right step?

Nothing is rip here. We need to complete this app in terms of features by the end of this year

Yes jasje. We need a better UX. Just giving a settings panel is not a good ux

Also why tf do we even need settings for? Our app doesn’t even have any settings as such

we could have later on tho

This will also give us the right motivation to move to compose completely

just look at website

Yeah, we’ll it in JC then

that i agree it

agree with**

so about caching

Tbh I’m bot a fan of settings even kn the website

Not*

me fan

Lol

Everything should just be jn the basic profile page itself tbh

its intuitive to look into settings for something "core"

I agree with it but there shouldn’t be a separate settings panel for the app until and unless your app has only one functionality

we can remove it for now

For example, we want to give the user to control their bass, etc for BP on the app

Where would those settings be?

+1

could have it in bp too

Exactly

I think we are drifting from the focus here

caching

Lol

I did change the topic so we didn’t drift actually

this way of cahcing good rn?

caching*

or use room db?

If we can do room db, I would like that jasje

i don't want to cache alot of data anyways but searchinng and deletion would be faster in roon=m

also i had this in back of my mind

But you do understand that drafting is different from caching, right?

akshaaatt: no

same same

it is a lil different

Not actually

but the methods with which we are going to store is same

Caching helps is quick retrieval of items and is a good fallback for things

jasje: you’ll have to compare here which is good for quick retrieval and which is good for better maintenance

Like the json cache which we have in place is very quick

We shouldn’t use that for long term things like drafting

Where the user regularly updates the format

hm i agree. any changes in the api itself would be hard to migrate

Right

room eases that

Yus

alr room for s=drafting

Kewl

also about the back of my mind

[listenbrainz-android] 14akshaaatt merged pull request #158 (03main…additions): Improved Profile Screen, Added a dummy Explore Screen and Bumped dependencies https://github.com/metabrainz/listenbrainz-andr...

we could have used foreign keys for relationship between songs and albums and artists

please test this ^jasje. I want to put this in beta asap

[listenbrainz-android] 14dependabot[bot] closed pull request #144 (03main…dependabot/gradle/hilt_version-2.46): Bump hilt_version from 2.45 to 2.46 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] closed pull request #151 (03main…dependabot/gradle/com.google.android.material-material-1.9.0): Bump com.google.android.material:material from 1.8.0 to 1.9.0 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] closed pull request #149 (03main…dependabot/gradle/compose_version-1.4.3): Bump compose_version from 1.4.2 to 1.4.3 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] closed pull request #153 (03main…dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-test-1.7.1): Bump org.jetbrains.kotlinx:kotlinx-coroutines-test from 1.6.4 to 1.7.1 https://github.com/metabrainz/listenbrainz-andr...

Yeah we should definitely improve BP.

[listenbrainz-android] 14dependabot[bot] closed pull request #152 (03main…dependabot/gradle/app.cash.turbine-turbine-0.13.0): Bump app.cash.turbine:turbine from 0.12.3 to 0.13.0 https://github.com/metabrainz/listenbrainz-andr...

currently we do kotlin calcs or runtime calcs which is slower

Yus

also keep in mind to use viewpager for loading songs in bp screen

I’m happy with it if you wanna update those jasje

akshaaatt: we could have a ticket

a lot of stuff needs updating

Sure

priorities are must

Yeah you’ll soon realize that everything needs to be maintained and updated

In a while, you’ll realize the need to refactor YIM stuff as well

But again, as even you said, priorities will matter then

this app needs a fulltime dev

no cap

upgraded gradle version huh

Lol

akshaaatt: not sure about this one

the some bottom nav icons are different in terms of shape and size when selected

while others arent

about the system theme

we were using isUiModeDark for that

when you remove the activity restart thing it works fine

we arent updating the preference here.

Ouu right

too much done in this pr

Can you please make a PR for it? Also, about the icons, I couldn’t find the same icons for free on fontawesome. I need but selected and unselected. After beta release, we can get aerozol to provide us the icons

Both*

let me see

akshaaatt: where did you get these theme icons

its confusing to use two

separate icons

plus both have black tints

🫠

Fontawesome, jasje

wait

we dont have white tints at all?

Reddit uses this as well

Moon and sun to switch the theme

Ouu they don’t use sun

Fine, let’s do one icon then

akshaaatt: can you please do "validate token" call as well?

Yeah we should do that

Good point

also

i think you have ported the white icons as well