#metabrainz

/

      • BrainzGit
        [listenbrainz-android] 14dependabot[bot] opened pull request #189 (03main…dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-test-1.7.2): Bump org.jetbrains.kotlinx:kotlinx-coroutines-test from 1.7.1 to 1.7.2 https://github.com/metabrainz/listenbrainz-androi…
      • 2023-07-05 18648, 2023

      • nawcom has quit
      • 2023-07-05 18601, 2023

      • nawcom joined the channel
      • 2023-07-05 18603, 2023

      • rudrakshkarpe[m] has quit
      • 2023-07-05 18633, 2023

      • vfosnar has quit
      • 2023-07-05 18645, 2023

      • vfosnar joined the channel
      • 2023-07-05 18649, 2023

      • aerozol
        Just popping in to drop this, had an alert for some keyqords: https://hydrogenaud.io/index.php/topic,124384.msg…
      • 2023-07-05 18652, 2023

      • aerozol
        *keywords
      • 2023-07-05 18625, 2023

      • aerozol
        Foobar2000 ListenBrainz plugin, looks pretty cool. And has recommendations for artist/track etc?
      • 2023-07-05 18609, 2023

      • aerozol
        mayhem: FYI I am honoured that MeB will consider flying me across the globe, and if finances don’t allow for it I will not take it personally :)
      • 2023-07-05 18623, 2023

      • MusicFreakzCR has quit
      • 2023-07-05 18612, 2023

      • vscode_
        ricksucks: and lucifer: I went through the doc Lucifer shared the other day and it gave me some idea but it would be great if you guys could give some pointers on how exactly can I implement it.
      • 2023-07-05 18639, 2023

      • vscode_
        riksucks ^
      • 2023-07-05 18601, 2023

      • vscode_
        riksucks:
      • 2023-07-05 18656, 2023

      • kuno has quit
      • 2023-07-05 18606, 2023

      • kuno joined the channel
      • 2023-07-05 18647, 2023

      • mayhem
        aerozol: I did finances, we can afford it. we should look for tickets for you soon.
      • 2023-07-05 18638, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2513 (03master…bulk-spotify-export): Export batch generated weekly playlists to Spotify https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18600, 2023

      • mayhem
        lucifer: can you please put the tag query stuff back on test?
      • 2023-07-05 18606, 2023

      • lucifer
        sure
      • 2023-07-05 18610, 2023

      • mayhem
        thx
      • 2023-07-05 18627, 2023

      • lucifer
        mayhem: do you want to release the weekly recommendations stuff?
      • 2023-07-05 18647, 2023

      • mayhem
        yes, please. (but not monkey's branch just yet)
      • 2023-07-05 18616, 2023

      • mayhem
        once the generation of the playlists works as we expect, we merge monkey's branch and set the crontab to weekly.
      • 2023-07-05 18603, 2023

      • lucifer
        there's also one issue about that. currenlty those playlists don't take timezones into account.
      • 2023-07-05 18637, 2023

      • lucifer
        i think the solution would be to run the cronjon hourly like we do for daily jams and pass an explicit list of users to spark to generate playlists for
      • 2023-07-05 18609, 2023

      • mayhem
        oh. hmm.
      • 2023-07-05 18622, 2023

      • lucifer
        i'll add that
      • 2023-07-05 18633, 2023

      • mayhem
        yes, please.
      • 2023-07-05 18654, 2023

      • mayhem
        but lets release the just merged PR to make sure that works...
      • 2023-07-05 18624, 2023

      • lucifer
        i tested it already, it works.
      • 2023-07-05 18600, 2023

      • lucifer
        mayhem: done for tags
      • 2023-07-05 18603, 2023

      • lucifer
      • 2023-07-05 18617, 2023

      • lucifer
        you need to provide a condition always for now. even if its one tag.
      • 2023-07-05 18635, 2023

      • lucifer
        pass multiple tags by adding `tag=:tag_name` each time
      • 2023-07-05 18626, 2023

      • mayhem
        ok, thanks. is the : correct there?
      • 2023-07-05 18637, 2023

      • mayhem
        or is that the placeholder name?
      • 2023-07-05 18615, 2023

      • mayhem
        its not -- ok, cool. :) thanks let me send invoices and then I'll dive it.
      • 2023-07-05 18617, 2023

      • mayhem
        in
      • 2023-07-05 18649, 2023

      • BrainzGit
        [listenbrainz-server] 14KasukabeDefenceForce opened pull request #2514 (03master…build-problem): Updated dependencies. https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18639, 2023

      • mayhem does a little dance as it starts raining
      • 2023-07-05 18657, 2023

      • lucifer
        mayhem: yeah :tag_name is the placeholder
      • 2023-07-05 18608, 2023

      • aerozol
        mayhem: <3 can’t wait!!!
      • 2023-07-05 18605, 2023

      • reosarevok
        yvanzo: seems decoda.com (which we banned as malware) is now the site for some mining-related company
      • 2023-07-05 18615, 2023

      • reosarevok
        Should we unmalware those I guess?
      • 2023-07-05 18623, 2023

      • reosarevok
        (starzik is still dodgy)
      • 2023-07-05 18600, 2023

      • yvanzo
        So it’s time to invest in cryptos?
      • 2023-07-05 18610, 2023

      • reosarevok
        The physical sort :D
      • 2023-07-05 18600, 2023

      • yvanzo
        But yes, it’s completely fine to drop it now, it’s been banned for 2 years, I didn’t even remember it used to be a lyrics website.
      • 2023-07-05 18647, 2023

      • yvanzo
        It’s not listed in URL reputation databases either.
      • 2023-07-05 18649, 2023

      • monkey
      • 2023-07-05 18613, 2023

      • monkey
        *chef's kiss*
      • 2023-07-05 18619, 2023

      • monkey
        Now to see if it actually works :p
      • 2023-07-05 18620, 2023

      • trolley has quit
      • 2023-07-05 18642, 2023

      • jasje
        lucifer: anymore changes in feed following?
      • 2023-07-05 18659, 2023

      • Lotheric_ has quit
      • 2023-07-05 18640, 2023

      • Lotheric joined the channel
      • 2023-07-05 18628, 2023

      • reosarevok
        yvanzo: ok, pushing the drop commit to master - seems pointless to have a PR for it. Will explain the issue in the commit message :)
      • 2023-07-05 18621, 2023

      • reosarevok
        Thanks for checking!
      • 2023-07-05 18623, 2023

      • lucifer
        jasje: will check and let you know
      • 2023-07-05 18627, 2023

      • mayhem
        99% of which will be unread by the people who are supposed to read it.
      • 2023-07-05 18646, 2023

      • lucifer
        for sure.
      • 2023-07-05 18634, 2023

      • reosarevok
        lucifer: really hope you get in this time 🤞
      • 2023-07-05 18601, 2023

      • lucifer
        reosarevok: thanks! hope so
      • 2023-07-05 18650, 2023

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2483 (03master…separate-follow-listes-lb-1269): LB-1269: Separate follow listens from feed https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18618, 2023

      • lucifer
        jasje: thanks for the contribution, merged.
      • 2023-07-05 18623, 2023

      • lucifer
        vscode_: hi! ping me when around and i'll walk you through on the changes required.
      • 2023-07-05 18608, 2023

      • mayhem
        arsh: ping
      • 2023-07-05 18657, 2023

      • jasje
        great onto similar listens now!
      • 2023-07-05 18632, 2023

      • arsh
        Hi mayhem:
      • 2023-07-05 18639, 2023

      • mayhem
        hi!
      • 2023-07-05 18608, 2023

      • mayhem
        do you have a day job or something arsh? you should be more available to be working on your gsoc project....
      • 2023-07-05 18641, 2023

      • arsh
        No
      • 2023-07-05 18650, 2023

      • arsh
        I believe its the time difference
      • 2023-07-05 18600, 2023

      • arsh
        I do work sometimes on weekends though
      • 2023-07-05 18631, 2023

      • arsh
        Sure I will allocate more time to it
      • 2023-07-05 18632, 2023

      • mayhem
        I've been available in the evenings, so that shouldn't be it. I work with others on pacific timezone and its not a problem.
      • 2023-07-05 18654, 2023

      • ApeKattQuest
        man the Schengen visa thing is bullshit
      • 2023-07-05 18654, 2023

      • ApeKattQuest
        if i wanted to go to india i bet there wouldn't be any issue
      • 2023-07-05 18655, 2023

      • mayhem
        yes, you're quite behind and I would really need you to show me in the next few days that you can catch up.
      • 2023-07-05 18609, 2023

      • mayhem
        once behind, most students never get caught up.
      • 2023-07-05 18649, 2023

      • arsh
        Yes I agree I have been taking a lit longer than I expected as well
      • 2023-07-05 18657, 2023

      • arsh
        Sure I will try my best
      • 2023-07-05 18606, 2023

      • mayhem
        that said, before the mid-term evaluation you'll need to open a PR against the LB codebase.
      • 2023-07-05 18635, 2023

      • arsh
        ok
      • 2023-07-05 18645, 2023

      • mayhem
        for now, it is fine to check-in the codepen (or whatever) code you've written. there is no need to integrate it wit the LB site just yet.
      • 2023-07-05 18610, 2023

      • mayhem
        but, I need to see your code and see a PR, before I can pass you. ideally, have the PR be approved too.
      • 2023-07-05 18640, 2023

      • arsh
        Sure
      • 2023-07-05 18647, 2023

      • arsh
        I will do it at the earliest
      • 2023-07-05 18604, 2023

      • mayhem
        ok, great.
      • 2023-07-05 18622, 2023

      • monkey
        mayhem: After mergin master in my feature branch, running the web docker container exits early with this error: `ModuleNotFoundError: No module named 'troi.patches.periodic_jams'`. Tried rebuilding the image, no luck. Anything I should be doing?
      • 2023-07-05 18628, 2023

      • monkey
        Full tracelog:
      • 2023-07-05 18632, 2023

      • monkey
      • 2023-07-05 18617, 2023

      • lucifer
        monkey: tried `./develop.sh build` ?
      • 2023-07-05 18625, 2023

      • monkey
        Yes
      • 2023-07-05 18632, 2023

      • monkey
        Same result
      • 2023-07-05 18634, 2023

      • lucifer
        let me check
      • 2023-07-05 18642, 2023

      • mayhem
        then what does requirements.txt say about troi?
      • 2023-07-05 18601, 2023

      • monkey
        `troi@git+https://github.com/metabrainz/troi-recommendation-playground.git@ad2cf2fe2486efc5f9c40b5456ec7be0d949cf42`
      • 2023-07-05 18633, 2023

      • mayhem
        try @main
      • 2023-07-05 18639, 2023

      • mayhem
        and then build again.
      • 2023-07-05 18603, 2023

      • monkey
        OK, will try tomorrow
      • 2023-07-05 18626, 2023

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 opened pull request #104 (03main…spotify-export-util): Separate spotify submission into a utility function https://github.com/metabrainz/troi-recommendation…
      • 2023-07-05 18646, 2023

      • lucifer
        mayhem: ^ mostly moving code around
      • 2023-07-05 18651, 2023

      • mayhem
        mañana, mañana, nur nicht heute, sagen alle faulen leute.
      • 2023-07-05 18642, 2023

      • mayhem
        lucifer: yeah, makes sense. LGTM
      • 2023-07-05 18629, 2023

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #104 (03main…spotify-export-util): Separate spotify submission into a utility function https://github.com/metabrainz/troi-recommendation…
      • 2023-07-05 18620, 2023

      • arsh
        One question mayhem: Are there any particular steps for the submitting the PR and any specific directory where I should submit code
      • 2023-07-05 18616, 2023

      • lucifer
        this might help, monkey had shared a step by step list on how to add a new page to LB: https://chatlogs.metabrainz.org/libera/metabrainz…
      • 2023-07-05 18624, 2023

      • mayhem
        not any particular steps, per se.
      • 2023-07-05 18641, 2023

      • mayhem
        lucifer: we're not quite ready to add that page yet. we're just adding the contents to a codepen for the time being.
      • 2023-07-05 18626, 2023

      • lucifer
        mayhem: just copy the contents from the codepen to a js/html component like that?
      • 2023-07-05 18617, 2023

      • lucifer
        maybe don't add the flask route.
      • 2023-07-05 18628, 2023

      • mayhem
        I was thinking of temporarily dumping everything into frontend/js/src/explore/artist-similarity
      • 2023-07-05 18640, 2023

      • mayhem
        and don't even connect anything to the rest of LB just yet.
      • 2023-07-05 18607, 2023

      • mayhem
        more work needs to continue in the codepen, but for review purposes we want to have it in the LB repo.
      • 2023-07-05 18614, 2023

      • mayhem
        arsh: does that make sense?
      • 2023-07-05 18634, 2023

      • arsh
        Yes understood
      • 2023-07-05 18640, 2023

      • lucifer
        cool makes sense
      • 2023-07-05 18606, 2023

      • arsh
        mayhem: I believe I should leave the tinkering of the graph and start working on layout of the page
      • 2023-07-05 18619, 2023

      • BrainzGit
        [troi-recommendation-playground] release 03v-2023-07-05 has been published by 14amCap1712: https://github.com/metabrainz/troi-recommendation…
      • 2023-07-05 18620, 2023

      • arsh
        Does it sound good to you?
      • 2023-07-05 18643, 2023

      • arsh
        After submitting the PR
      • 2023-07-05 18614, 2023

      • mayhem
        arsh: yes, exactly that. Time to move on to other bits.
      • 2023-07-05 18656, 2023

      • arsh
        ok thanks
      • 2023-07-05 18638, 2023

      • vscode_
        lucifer: I am here, can you please walk me through steps as you mentioned?
      • 2023-07-05 18618, 2023

      • lucifer
        vscode_: hi! so for the music services page mentioned in step 1 of that document, you need to add a section here: https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18649, 2023

      • vscode_
        ok
      • 2023-07-05 18645, 2023

      • lucifer
        2 buttons: connect and disable. when clicking on connect, trigger a request to LB webserver like: https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18630, 2023

      • lucifer
        I will open a PR that automatically generates a new developer token, the endpoint you add should call that.
      • 2023-07-05 18614, 2023

      • lucifer
        Look at the https://github.com/metabrainz/listenbrainz-server… to see how we store tokens in the database
      • 2023-07-05 18649, 2023

      • lucifer
        that automatically generated token has to be user specific and should be stored in the table.
      • 2023-07-05 18630, 2023

      • lucifer
        finally inject the token in global props here: https://github.com/metabrainz/listenbrainz-server…
      • 2023-07-05 18642, 2023

      • lucifer
        you can see how we insert tokens for other services as well.
      • 2023-07-05 18616, 2023

      • lucifer
        let's get this part rolling first and then work on the steps on how to integrate music user token
      • 2023-07-05 18620, 2023

      • lucifer
        does that make sense?
      • 2023-07-05 18653, 2023

      • vscode_
        ok got it
      • 2023-07-05 18647, 2023

      • vscode_
        thank you!
      • 2023-07-05 18634, 2023

      • trolley joined the channel
      • 2023-07-05 18603, 2023

      • pixelpenguin has quit
      • 2023-07-05 18618, 2023

      • pixelpenguin joined the channel
      • 2023-07-05 18632, 2023

      • akshaaatt
        Hi jasje
      • 2023-07-05 18653, 2023

      • akshaaatt
        I have added a review for your search PR
      • 2023-07-05 18655, 2023

      • jasje
        akshaaatt: yo!
      • 2023-07-05 18609, 2023

      • jasje
        i see
      • 2023-07-05 18622, 2023

      • akshaaatt
        And tbh I'm unsure as to why it went too lengthy
      • 2023-07-05 18628, 2023

      • akshaaatt
        We should work on this
      • 2023-07-05 18646, 2023

      • jasje
        ?
      • 2023-07-05 18602, 2023

      • akshaaatt
        There's a lot unpacking in the search PR
      • 2023-07-05 18611, 2023

      • akshaaatt
        Themes changing, code refactoring etc