#metabrainz

jasje: Did you ever see this? https://twitter.com/MetaBrainz/status/167109510... :D

[listenbrainz-server] 14amCap1712 merged pull request #2515 (03master…batch-playlists-timezone): Consider user's timezone while batch generating playlists https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14arsh331 opened pull request #2517 (03master…artist-graph): First commit for artist graph https://github.com/metabrainz/listenbrainz-serv...

aerozol: "But if you want to take a shot at something in particular let me know"

ok sounds good.

aerozol: haha yess my like’s there ;)

mayhem: good luck reviewing arsh's pr

akshaaatt: see i ain't that harsh on you <3

uh oh, I haven't looked yet. coffee just hitting veins.

+1 on the coffee part

jasje if you ever wanna compare, compare yourself with those above you :) checkout how monkey submits PRs for example

akshaaatt: just kidding and no way arsh is below me

He’s on the same level as

he def better

You

XD jasje already feeling superior

alright i read that wrong

but the boomer(admit it) lecture is there xD

🤣🤣

Haha, no shame for my monster PRs

monkey, lucifer : could one of you two please look at LB#2517 and have a look at the javascript/reactness of the code? I've commented on the general nature and calculation side of things. (see review)

First commit for artist graph: https://github.com/metabrainz/listenbrainz-serv...

Sure thing

keeping in mind that this isn't intended to be merged, but mostly for review.

Actually I'll do that now. Had a quick peek already this morning

thanks, monkey !

lucifer: one request on the tag data query -- can you please sort recordings by tag_count?

sure

mayhem: remove random ordering and order by tag_count?

the random ordering is important for the selection process that your query does. but for the results, they should be ordered by tag_count. does that make sense?

or first randomize results and then order by tag count

that

👍

this project was so simple in my mind. but really, its been a bear -- there are so many things to think of. oy.

mayhem: check now.

also you don't need to specify a condition if passing one tag now.

great, thanks!

all the perfectn values are 1 currently -- thats not intended, is it?

*percent

hmm seems like a bug somewhere

will fix

thx, not urgent.

monkey: did export to spotify on prod break again?

Getting a 500 back from the server:

ah, that would have lucifer 's fingerprints all over it. :)

mayhem: labs api returning BAD GATEWAY errors it seems, cascading 500s

is the original error from spotify?

nope

try again

still barfs

okay i see the correct error now.

mayhem: it fails because there is a standalone recording in the playlist which are not considered when generating canonical data.

a 500 is not ideal ofc.

I guess it should just skip that recording and try to move on?

yeah i was thinking about that but we might be relying that the list of items is ordered

and there won't be gaps etc so have to review other uses of this query

[listenbrainz-server] 14amCap1712 merged pull request #2516 (03master…apple-music-key): Lay foundations for generating and storing apple music tokens https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release 03v-2023-07-06.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

monkey: lucifer : I'm using the metadata viewer and it shows this:

Double electronic?

the tag electronic is shown twice. however, I can't see that tag applied to ac/dc at all: https://musicbrainz.org/artist/66c662b6-6e2f-49...

yes, but where does that come from??

Hrm. Might be related to some Issues I was working on yesterday with the metadata viewer

I'd say park it for now because I might resolve it with LB#2475

Listening now: allow users to vote on and add tags: https://github.com/metabrainz/listenbrainz-serv...

ok.

Was the previous listen of an electronic band?

yes.

That's probably it then. Although I'm not seeign electronic on Tame Impala: https://musicbrainz.org/artist/63aa26c3-d59b-4d...

for some reason it didn't update for the tame impala track. but boozoo bajou before it is likely tagged with electronic.

Nope

indeed not.

Rhye is though

So, probably just accumulating tags from previous listens…

Which isn't ideal, let's face it

ok, thanks for taking a look.

Well, it is my poopy code after all

thanks for the js review on arsh's PR. much appreciated.

It's lookign pretty good to be honest. Lots of small details but no big issue that I could see

agreed.

an interesting thought: https://uselessdevblog.wordpress.com/2023/07/03...

[bookbrainz-site] 14the-good-boy opened pull request #1000 (03administration-system…middlewareTS): feat(Admin System): Change files to .ts to increase type validation https://github.com/metabrainz/bookbrainz-site/p...

who deployed wikidata-bot on zappa? It seems to have an issue

python run.py processes seem to get stuck https://www.irccloud.com/pastebin/3Gr5QkQd/

BB is now 1000 PRs old 🎉

Hey ! Congrats on the 1000th PR !

😃

I noticed yesterday we hit 999 :p

lol had I noticed it earlier, I would've made that PR yesterday itself ;)

Hey riksucks and lucifer: I updated the PR as we according to our chat yesterday. because i dont have the keys which are required for the generate developer token method I had stubbed it with static token which was shared with me earlier for the purpose of testing the rest of the implementation.

Congrats ShivamAwasthi, I had briefly considered to create a PR just to get number 1000 myself ;)

PR sniping, wow. :)

vscode_: cool, for the next part you need to send over the music user token to the backend. it needs to be stored in the backend but we dont have an appropriate column for it, i think just store it in the refresh token column.

let me look into it and share more details on how'd go about it.

monkey: I added the page it looks like this. From where should I start correcting it?

AbhinavOhri[m]: I would say the best would be to create a draft PR on the main website so I can run it and review it with better answers that on the fly here

From there I can look at the css and see how best to go about it

lucifer: I wonder if some code disappeared in smoke somewhere. I'm getting 404s hitting /beta.listenbrainz.org/profile/music-services/musicbrainz/refresh/

Maybe related to leftover code https://github.com/metabrainz/listenbrainz-serv... ?

Could you please help me out when you have the time and see what I'm missing?

monkey: okay.

(currently deployed the tags PR to beta at https://beta.listenbrainz.org/listening-now/ )

AbhinavOhri[m]: It's nice to start seeing it in situ on the website :)

bitmap: floyd is running a high load. do you happen to have any idea why?

monkey: hi

mayhem: I'll take a look

Hi jasje

Waddup?

monkey: lets say we have a user search result in which we just show basic data and a follow button associated with the user.

How would you manage the state of the follow button?

Given we have the initial state of the follow buttons status

lucifer: update: logged out, logged back in and now i have an up-to-date token. But how would I refresh it?

jasje: not sure what you're asking exactly. Is this about the FollowButton component? https://github.com/metabrainz/listenbrainz-serv...

nope just general reactive Ui question

I hope the thing im working on and React are same in funtioning

I'd look at the state management we do in that component ^

My hand is tight in js

really tight

non existent to be exact

Heh :p

So ill put forward two approaches

monkey: Is there any ticket which I can link to this page?

monkey: checking it

1) Have a state for each of the follow button

2) Make a list that is processed by latest data and any changes the user might do

Downsides: 1) makes alot of state variables and 2) requires processing

2) seems less heavy to me right now

jasje: https://medium.com/mobile-app-development-publi...

AbhinavOhri[m]: I can't find a ticket for it.Perhaps you can link the the figma page?

i think you are looking for something like this

lucifer: paid content