#metabrainz

I didn’t nothing and let spotify play the track for me

Did*

yeah spotify is the first preference.

i would suggest disabling spotify or changing to it only record listens before testing apple integration.

also note that this is kind of the first full test on prod, so there will likely be many issues to be uncovered.

monkey: hi! lmk when you are around for a quick discussion about the apple music auth workflow?

Shoot

ah cool, so currently when we click the play on listenbrainz button here: https://test.listenbrainz.org/profile/music-ser...

we don't actually link the user's apple account with LB because that needs us to load the apple music player script.

there is no proper oauth api to do that.

i was wondering if on clicking this button, we could load the music player dynamically

and then have it perform the oauth, save the token back to LB via an api call.

Yes, loading the library dynamically shouldn't be an issue

currently, this happens when the user tries to play songs on LB frontend with the apple music player.

i think the workflow outlined above is better, thoughts?

Yes, definitely a better idea IMO to try to do as much setup in one go when the user enables the feature

cool, makes sense. one more question.

when the linking expires because of the tokens expiring, we'll probably get some 403s. to have the user relink it we just send the user back to that settings page?

and ask them to relink?

Was that the issue that the token expires really quickly?

i think in the best case it will last 6 months.

Can we detect this specific case (organic expiration of token)? If so we should maybe try to handle it in BrainzPlayer when we encounter a 403. But as a first version, I think it'll be simpler to link to the settings page for the user to reauth

makes sense

thanks!

Of course

pixelpenguin: hey!

Generally, I've had a few ideas brewing for improving how we manage third-party music playing settings.

I think a new BrainzPlayer settings page will be necessary, and will likely replace the current music service page

monkey: yup indeed, that would make sense.

Do you reckon we could save separate tokens for reading data and for playing music? For example for Spotify we could allow users to link their account to read history, and separately have another token for BrainzPlayer.

Would probably simplify some of the scopes mess we have to deal with

that might be possible but I am unsure. i think it would vary service to service.

Right.

one possibility could be to create multiple oauth apps, one for BP and one for LB main.

Right, I guess that makes sense

PossiblyNot sure it would be necessary though. I'll keep brainstorming.

yup sure

Oh, lucifer, one more thing if you've never done it: to load a script dynamically, you can write some JS to inject a resource into the page (like you would with HTML) and it will load the library

monkey: yes makes sense, i did see the utils functions to do it with react.

on this page, might need to write more JS from scratch because its not react-ified yet.

Yep

That's why I was coming here to point it out

-> some solutions here https://stackoverflow.com/questions/21294/dynam...

i see, thanks!

atj_: not yet, just so I could measure how each config change affects things, but planning on it today

bitmap: do you use `wal_sync_method = 'fdatasync'` by default?

yes, it's set to fdatasync

oh, it's the default on Linux

<lucifer> "pixelpenguin: hey!" <- heyy, what's up

akshaaatt: update dev branch?

with my pr

work all good

ship it

atj_: setting full_page_writes=off doesn't seem to affect the benchmark at all, probably because the test doesn't write enough data or run long enough to trigger an automatic checkpoint

were there any other settings I should tweak/? jimmy has the same amount of RAM as pink/floyd right?

bitmap: you can disable wal_init_zero

and wal_recycle

ok

the other tweaks are at the ZFS level so we'll need to arrange a time to collaborate on that

but performance seems reasonable at this stage?

yeah

I could start sending standby traffic to there (currently handled by pink)

best hold off on that for now

basically we need to create a dedicated FS for PG data and WAL

pixelpenguin: Hi! let's discuss about setting up select options in Dataset Hoster UI. so like we currently have input fields for text and datetime, we want to add a field for select input that should be prepoulated with various options. these options can be hardcoded as an enum in the start.

in the final format, we want the options in the enum to be dynamic if possible (for example load from redis or database)

i think that should be possible from the looks of this answer: https://stackoverflow.com/questions/33690064/dy...

but either way you can start implementing the part with static options first and then we can look into dynamic options.

for the partial query ticket, i will have a discussion with mayhem and then you should work on it next.

Thanks for the detailed explanation of the implementation, I agree with it.

I can get started on it

Is there anything else I should look out for?

Or any other task in the current PR which I should work on first?

pixelpenguin: i had looked at the current PR, it lgtm. i have not merged it yet just in case some bug comes up and we need to do a new bugfix release of DSH. the current PR introduces multiple incompatible changes and that would make it harder to do so.

so we should probably merge it all at once.

so no other changes required on the existing work but add the changes for these remaining 2 tickets to that PR as well.

atj: ok, let me know if you create the new FS, I can help move the data over. though I'm not sure how well I can measure the impact of those changes with pgbench alone. I don't see any disk ops stats for jimmy in grafana

lucifer: Okay, I will add the new changes

to the same PR

I didn’t know spotify was founded in 2006. Damn

[musicbrainz-server] 14yvanzo opened pull request #2990 (03master…some-more-diagrams): Add three more diagrams for database schema docs https://github.com/metabrainz/musicbrainz-serve...

bitmap: am I OK to stop the PG container wherever?

s/wherever/whenever/

atj: can you run sudo -u postgres stop_postgres.sh inside the container first? (not at my pc rn)

otherwise yes, I’m just not sure if docker stop alone does a clean shutdown of the process

[listenbrainz-ios] 14gauravbhardwaj7 opened pull request #7 (03main…match-custom-audio): Match Custom Audio https://github.com/metabrainz/listenbrainz-ios/...

[listenbrainz-server] 14amCap1712 merged pull request #2529 (03master…remove-similar-candidate-sets): Remove candidate set recommendations https://github.com/metabrainz/listenbrainz-serv...